From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 1D2E2A0471 for ; Mon, 17 Jun 2019 12:22:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 02CEB1BEC6; Mon, 17 Jun 2019 12:22:49 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 4A6F61BE16 for ; Mon, 17 Jun 2019 12:22:48 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x5HAGSEG028609; Mon, 17 Jun 2019 03:22:47 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=/c81NmWRq0jsuodGqz/4kUQuHm/x6XUixUTfQccFcyk=; b=ln2xxqVkRguTBoz4hmP0EphVFwTo8sBnJ/sgolIBdW5U89F8yk8DVh2w4wz7bK884tf5 +GiHi/ImLrXx3XfMEe8Em3keVlwea6+Og21/IA6Y9PyGxkG9uvLwnrHkuH8GjbrLwWkM dHUYIZQCMVEtwLUP9ThAgkCnH3/sY885H8OSTcTgbBkkg28KM91QBPlg6+BLEYtwvYJR zja59FixV+Hh413z7nYHSRu0/dMj5IS8/328kScSO1unFnMqS7wltoXxJqWiT5hsA74c odtviK4oYpaNZckSIOkQD3MskNH4WzLw21B3xLEPsMOhD+s9JD7/VgleTIw9+SDX4WFx DA== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0b-0016f401.pphosted.com with ESMTP id 2t506hx6kw-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 17 Jun 2019 03:22:47 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 17 Jun 2019 03:22:43 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.50) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Mon, 17 Jun 2019 03:22:43 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/c81NmWRq0jsuodGqz/4kUQuHm/x6XUixUTfQccFcyk=; b=uJgn3ooaIaqjByHyrcLVuTSBKcCshsyiUIHN+qYyxoOYbR7DGNXtWfKRkSh9u5Th31GcmB0vKIrOyD/ECIaX96s1E0b1B2ud/e5HRXg9Gw4nnZY+A96IgLH1ZOmkqxgNW+FAuJtLGc2NPgGs5aBaOWo/C71LDHs87ZbbqrKVXNs= Received: from MN2PR18MB2877.namprd18.prod.outlook.com (20.179.20.218) by MN2PR18MB2701.namprd18.prod.outlook.com (20.179.22.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1987.12; Mon, 17 Jun 2019 10:22:41 +0000 Received: from MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::3d9b:ed4b:b155:9bad]) by MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::3d9b:ed4b:b155:9bad%3]) with mapi id 15.20.1987.014; Mon, 17 Jun 2019 10:22:41 +0000 From: Anoob Joseph To: Jerin Jacob Kollanukkaran , Nikhil Rao , Erik Gabriel Carrillo , Abhinandan Gujjar , Bruce Richardson , Pablo de Lara CC: Narayana Prasad Raju Athreya , "dev@dpdk.org" , Lukas Bartosik , "Pavan Nikhilesh Bhagavatula" , Hemant Agrawal , Nipun Gupta , Harry van Haaren , =?iso-8859-1?Q?Mattias_R=F6nnblom?= , Liang Ma Thread-Topic: [PATCH 19/39] eventdev: add common initialize routine for eventmode devs Thread-Index: AQHVGjLLi3ewaLA/hEiuttUYor1XK6aUuMWAgAr996A= Date: Mon, 17 Jun 2019 10:22:41 +0000 Message-ID: References: <1559583160-13944-1-git-send-email-anoobj@marvell.com> <1559583160-13944-20-git-send-email-anoobj@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fb71ebf3-51c9-4b7a-32ea-08d6f30dbb0b x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:MN2PR18MB2701; x-ms-traffictypediagnostic: MN2PR18MB2701: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0071BFA85B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39850400004)(136003)(376002)(346002)(396003)(366004)(13464003)(189003)(199004)(6506007)(86362001)(81156014)(52536014)(53936002)(6436002)(25786009)(33656002)(81166006)(55236004)(5660300002)(110136005)(53546011)(2906002)(102836004)(7416002)(8676002)(54906003)(66574012)(4326008)(99286004)(8936002)(74316002)(6246003)(7696005)(55016002)(76176011)(229853002)(305945005)(316002)(76116006)(14444005)(486006)(73956011)(66446008)(7736002)(66946007)(66476007)(66556008)(64756008)(9686003)(14454004)(26005)(478600001)(71200400001)(446003)(6116002)(476003)(3846002)(256004)(68736007)(11346002)(66066001)(186003)(71190400001); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB2701; H:MN2PR18MB2877.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: pFIMrL6gS7hh8tfb1BbSSLfHAFCj5FZ4OomfzEOCX6+60buQUC1EHKPyAm3B00pMKC2GWtAEzf+Nc6VBetazPFbwl0OdVjiPyrD4VeqsFRyB37bfp0Ob8MXD70ennluBnUYqRJN70GFzB9HDpHNhuNlA06fB25isoP7E8Zz4Bj1FzTSdTuoBJEIAFYurP5zISLk1PJF9r19rec6oSBUps0Db9pz7qUPuJt/HURItgMfIehrK7cCzH0PcwvS+VJvlPLRHAgnuuZTLf0dzdKo8eMS6Tms1HtYnPgI+eL85hZbcIntZ5wCK9xlqxdi/r9lh36LjJmEg/mAFQjRpkGKncY5faoyExl4LoZLCO1o1nT65HP2tfqBUDv2+B/md15hLOKovZ3DhhDqVkm7YFr7BvTnMf8vjSPdeKtikgEy4GhY= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: fb71ebf3-51c9-4b7a-32ea-08d6f30dbb0b X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jun 2019 10:22:41.5672 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: anoobj@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2701 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-06-17_05:, , signatures=0 Subject: Re: [dpdk-dev] [PATCH 19/39] eventdev: add common initialize routine for eventmode devs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Jerin, Please see inline. Thanks, Anoob > -----Original Message----- > From: Jerin Jacob Kollanukkaran > Sent: Monday, June 10, 2019 3:54 PM > To: Anoob Joseph ; Nikhil Rao > ; Erik Gabriel Carrillo = ; > Abhinandan Gujjar ; Bruce Richardson > ; Pablo de Lara > > Cc: Anoob Joseph ; Narayana Prasad Raju Athreya > ; dev@dpdk.org; Lukas Bartosik > ; Pavan Nikhilesh Bhagavatula > ; Hemant Agrawal > ; Nipun Gupta ; Harry > van Haaren ; Mattias R=F6nnblom > ; Liang Ma > Subject: RE: [PATCH 19/39] eventdev: add common initialize routine for > eventmode devs >=20 > > -----Original Message----- > > From: Anoob Joseph > > Sent: Monday, June 3, 2019 11:02 PM > > To: Jerin Jacob Kollanukkaran ; Nikhil Rao > > ; Erik Gabriel Carrillo > > ; Abhinandan Gujjar > > ; Bruce Richardson > > ; Pablo de Lara > > > > Cc: Anoob Joseph ; Narayana Prasad Raju Athreya > > ; dev@dpdk.org; Lukas Bartosik > > ; Pavan Nikhilesh Bhagavatula > > ; Hemant Agrawal > ; > > Nipun Gupta ; Harry van Haaren > > ; Mattias R=F6nnblom > > ; Liang Ma > > Subject: [PATCH 19/39] eventdev: add common initialize routine for > > eventmode devs > > > > Adding framework for common initialization routine for event mode. > > Event mode would involve initialization of multiple devices, like > > eventdev, ethdev etc and this routine would be the placeholder for all > > initialization to come in. > > > > Signed-off-by: Anoob Joseph > > Signed-off-by: Lukasz Bartosik > > --- > > > > +/* Helper functions for initialization, & launching workers */ > > + > > +/** > > + * Initialize event mode devices > > + * > > + * Application could call this function to get the event device, eth > > +device > > + * and eth rx adapter initialized according to the conf populated > > +using the > > + * command line args. > > + * > > + * Application is expected to initialize the eth device and then the > > +eventmode > > + * helper subsystem will stop & start eth device according to it's > > requirement. > > + * So call to this function should be done after the eth device is > > +successfully > > + * initialized. > > + * > > + * @param mode_conf > > + * Configuration of the mode in which app is doing packet handling > > + * @return > > + * - 0 on success. > > + * - (<0) on failure. > > + */ > > +int32_t __rte_experimental > > +rte_eventmode_helper_initialize_devs( > > + struct rte_eventmode_helper_conf *mode_conf); > > + >=20 > # Prefer to change to rte_event_helper_init() and introduce the counter p= art [Anoob] This routine is doing init of devs (not the helper library). So are= you okay with renaming it to rte_event_helper_devs_init() and rte_event_he= lper_devs_uninit(), and retain the functionality as before? > for the same(rte_event_helper_uninit() or rte_event_helper_fini()) # > introduce params structure taking another paraments input instead of new > APIs. > # let library return rte_event_helper_conf* object for further operations= . [Anoob] Parse args will parse the command line arguments and return the con= f. Based on the conf we setup the required devices (eventdev, Rx adapter & = Tx adapter, can be expanded to handle ethdev also).=20 >=20 >=20 > > #ifdef __cplusplus > > } > > #endif > > -- > > 2.7.4