From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 68695A056B; Thu, 12 Mar 2020 12:01:00 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 338E41C010; Thu, 12 Mar 2020 12:01:00 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 646D21C001 for ; Thu, 12 Mar 2020 12:00:58 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 02CB0OHK018802; Thu, 12 Mar 2020 04:00:57 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=eAyLb6l0YHHWXu48O99kaztvIXkUkNMLGVWBKajnG6A=; b=CrIig08pCT5oGtX8Cfu3tMKiINLwhDaGFJkfMSJ5Uaj2JEnAAj1gNULmGEKITok8kJu9 cV9TXryzK7vAAecq1xvI5X0EmnaRmqsUyXKDZwuvdnLiR0Wqn+yKWAsM9uIX4X21o52O QA0puhCjmYG7LxkWcEjoU/nY5jAR8bdntFnJVYvEwqZr3HNzCAu65bU+JFW/R9Gq7PH/ 9MVc+8c0B4RMPNq6GXBKJzRy3rpxaP6b3WKB/lHUjY8gZbUd/qWOoaTiu/ys26efdz6X 5QE4KtDUutRqyEaTLWCdLw2RXxvt4mbd050nriOLuzJHoMYuE44rrjgD6XofyV08sFd1 5A== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0a-0016f401.pphosted.com with ESMTP id 2yqfwugxs3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 12 Mar 2020 04:00:56 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 12 Mar 2020 04:00:55 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.176) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Thu, 12 Mar 2020 04:00:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dTN26eFgL9H5W8TREJQQVqCUkf55atMac6SCKKBnSuraaPvcUxivVXW0jnvZYc+1+KDcpFR/cWoob766l0EZdEnR2hZkbNU/ZAWxyBQYe3UBpNLwSYtswyFoCbAeLIyWEkrKyvYFHDZ3z1L7BUHgsoOOPTPe4Gp4zcb5jENwZHpYCRVSNYV8265l7F4nyFmr1HtoIGJ4akLUTAe1VbajYEOuLsqgabUYTny5sL3oTx5RoteMjSko/2ORb1Mu+5iF74tvNgBfUsLPN2XT3tNMNQGVO6LLm3iNYrXT4Bop8+IVX8nIa1T6SCrgSWEFeFzWFBgSXlTaBGdX4dyOxbRTfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eAyLb6l0YHHWXu48O99kaztvIXkUkNMLGVWBKajnG6A=; b=ectPa+LEh7U+RXcQ/YtohZQsS78bZeLzFS/ctEqnStQh4LnA5kUqYYxr3ngwc0Hhbl103Zxsebp/q3HVKhiZp6hUvDqOSzVmjK5hbKraHvH4h0PGYIaR0T/sv7wfHzvFqvbAm7r1M+TVNMmw9tEZiklgOOmRPI+D6Y06ShvKodEbs4ulQWoKcP7UyjxukNK+EAhqKWUSbgJEWdhaRPYrtPlo56Z9pLD74hW7PdjOExMv0JV9xZ2FGGBhPSFjfhX6vOMg5VwuG2ecMfM8KRrKPlHr6O5Z0wg+vnoa6YyM36PZ/OACM/uabnJmbmK9dBwie4KxmKqFRr1DPqSXNsY1Ew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eAyLb6l0YHHWXu48O99kaztvIXkUkNMLGVWBKajnG6A=; b=fiIygXYWzEqQVwQeRScSSOIPDYGyTgHsib/cGcDgYpOv+IVCWPYatiuwOXbWRKo8b+grlPmqXrP90meb2/SPePZA4EnCfKPZ83YkJKNPkLY/gi9ejYMTF2xku7IOd9wvlKt6/ncZkLRy6kjJZHG+7z2ed0yrZgWJRfcDL9fry9k= Received: from MN2PR18MB2877.namprd18.prod.outlook.com (2603:10b6:208:3b::26) by MN2PR18MB3576.namprd18.prod.outlook.com (2603:10b6:208:266::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2814.13; Thu, 12 Mar 2020 11:00:54 +0000 Received: from MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::648f:e7fa:f95e:191b]) by MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::648f:e7fa:f95e:191b%2]) with mapi id 15.20.2793.018; Thu, 12 Mar 2020 11:00:54 +0000 From: Anoob Joseph To: Praveen Shetty , "dev@dpdk.org" , "declan.doherty@intel.com" , "bernard.iremonger@intel.com" , "konstantin.ananyev@intel.com" Thread-Topic: [dpdk-dev] [PATCH v1] examples/ipsec-secgw: support flow director feature Thread-Index: AQHV97UkgwJYR7cP/UqfOBI8Z/3jmKhExRVg Date: Thu, 12 Mar 2020 11:00:53 +0000 Message-ID: References: <20200311145529.40221-1-praveen.shetty@intel.com> In-Reply-To: <20200311145529.40221-1-praveen.shetty@intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [27.34.244.205] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 29044d08-908f-482f-3516-08d7c674a27d x-ms-traffictypediagnostic: MN2PR18MB3576: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 0340850FCD x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(376002)(366004)(136003)(346002)(39860400002)(199004)(478600001)(71200400001)(186003)(5660300002)(52536014)(7696005)(81166006)(6506007)(66446008)(76116006)(66946007)(26005)(9686003)(66476007)(33656002)(81156014)(53546011)(64756008)(66556008)(8936002)(55016002)(30864003)(110136005)(316002)(2906002)(86362001); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB3576; H:MN2PR18MB2877.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ptKCx1QTHXhnQLAY8k2rRKoriE4ZgOSbNvIQdQ2INVc4+udOGDMzDmYjB2CrJt0qUpi7cGjMCaDsqdiQfx0tntmXxhmVyW3Q3e1iggfS34QJo9iIP+CHhuEApg1ZhT2WuPaTmqqjQ4xqo+RWOegNItWX8zT3CTHdZxzg9a9KIz4/BfRlg+tmfU709HYV7wn35BxWpQUVyX+sGlNXNTAhJz3teGMScfPxIXEBRFu4dddhG7yNEM4Atr3QCCMrarhWJ0khajqy+bF/EXnorKM+0VXoEGkRPxMUAeHu713vrXpKx+0XXvbfxwYQHyu530ceBNyOdH90VzfRLgpXwJACkPNMsVOtm7UVR4B6xfzeXmezXUW0KXwW57IQdDDttHQW8DkxBneCiwsL94iXMgFRPlzzJaJSs8TGll3wSf89m5QFiFXtrzaQRwNStdJxJni0 x-ms-exchange-antispam-messagedata: FYlARXuEy9q5YAFpTkO9P/tqXvgFvGuE0KsPQs+ldoqvw+vWeMNMqQdE4s9P/WQFKXd6t2XWqHZ9l3CpxGbRGsrbfPJCz9nMK6hk6eWsdtZdE5gErLKWum2+fS/a7itnsX7lnkQHkp9F7jgeZrYgYg== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 29044d08-908f-482f-3516-08d7c674a27d X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Mar 2020 11:00:53.8536 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FNRRm3wU4ltIALEfptJzwCjXUzD4M5OGzdOnQ3RuCEWjC97brK/p0XreloMcAMF8vU0pnEfvA37adhkj5yjEIw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB3576 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.572 definitions=2020-03-12_02:2020-03-11, 2020-03-12 signatures=0 Subject: Re: [dpdk-dev] [PATCH v1] examples/ipsec-secgw: support flow director feature X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Praveen, I do have some review comments on the code. Before that, can you give a bri= ef overview of what is being targeted? My understanding is that the primary= objective is to use rte_flow (or flow director) to redirect a specific flo= w(/SA) to a specific queue. Can you confirm? Couple of questions, 1. I would assume the new option of "flow-direction" is optional and is det= ermined per SA. In that case, can I assume that RSS would be active for the= other flows (or SAs). Let's say, I just want to add a SA for which I would= like to enable "flow-direction" but leave the rest as is. How is that hand= led? 2. I see that the changes are only applicable for LOOKASIDE_PROTOCOL. The s= ame feature would be useful for other modes as well, right? 3. I'm not sure "flow-direction" is the right wording for the option. This = is just specifying the "rx-queue" per SA. @Akhil, Konstantin, comments? Thanks, Anoob > -----Original Message----- > From: dev On Behalf Of Praveen Shetty > Sent: Wednesday, March 11, 2020 8:25 PM > To: dev@dpdk.org; declan.doherty@intel.com; bernard.iremonger@intel.com; > konstantin.ananyev@intel.com > Subject: [dpdk-dev] [PATCH v1] examples/ipsec-secgw: support flow directo= r > feature >=20 > Modified Secuirty gateway application to support configuration of flow di= rector > rule to direct inbound IPsec SA to a specified queue. >=20 > Signed-off-by: Praveen Shetty > --- > examples/ipsec-secgw/ep0.cfg | 11 +++++ > examples/ipsec-secgw/ipsec-secgw.c | 56 ++++++++++++++++++++++++- > examples/ipsec-secgw/ipsec.c | 67 ++++++++++++++++++++++++++++++ > examples/ipsec-secgw/ipsec.h | 11 +++++ > examples/ipsec-secgw/sa.c | 50 +++++++++++++++++++++- > 5 files changed, 192 insertions(+), 3 deletions(-) >=20 > diff --git a/examples/ipsec-secgw/ep0.cfg b/examples/ipsec-secgw/ep0.cfg > index dfd4aca7d..c9f80e81b 100644 > --- a/examples/ipsec-secgw/ep0.cfg > +++ b/examples/ipsec-secgw/ep0.cfg > @@ -29,6 +29,7 @@ sp ipv4 in esp protect 111 pri 1 dst 192.168.186.0/24 s= port > 0:65535 dport 0:6553 sp ipv4 in esp protect 115 pri 1 dst 192.168.210.0/= 24 sport > 0:65535 dport 0:65535 sp ipv4 in esp protect 116 pri 1 dst 192.168.211.0= /24 > sport 0:65535 dport 0:65535 sp ipv4 in esp protect 115 pri 1 dst > 192.168.210.0/24 sport 0:65535 dport 0:65535 > +sp ipv4 in esp protect 117 pri 1 dst 192.168.212.0/24 sport 0:65535 > +dport 0:65535 > sp ipv4 in esp protect 125 pri 1 dst 192.168.65.0/24 sport 0:65535 dport= 0:65535 > sp ipv4 in esp protect 125 pri 1 dst 192.168.65.0/24 sport 0:65535 dport = 0:65535 > sp ipv4 in esp protect 126 pri 1 dst 192.168.66.0/24 sport 0:65535 dport = 0:65535 > @@ -61,6 +62,8 @@ sp ipv6 in esp protect 125 pri 1 dst > ffff:0000:0000:0000:aaaa:aaaa:0000:0000/96 > sport 0:65535 dport 0:65535 > sp ipv6 in esp protect 126 pri 1 dst > ffff:0000:0000:0000:bbbb:bbbb:0000:0000/96 \ sport 0:65535 dport 0:65535 > +sp ipv6 in esp protect 127 pri 1 dst > +ffff:0000:0000:0000:cccc:dddd:0000:0000/96 \ sport 0:65535 dport > +0:65535 >=20 > #SA rules > sa out 5 cipher_algo aes-128-cbc cipher_key 0:0:0:0:0:0:0:0:0:0:0:0:0:0:= 0:0 \ > @@ -118,6 +121,9 @@ dst 172.16.1.5 >=20 > sa in 116 cipher_algo null auth_algo null mode ipv4-tunnel src 172.16.2.= 6 dst > 172.16.1.6 >=20 > +sa in 117 cipher_algo null auth_algo null mode ipv4-tunnel src > +172.16.2.7 \ dst 172.16.1.7 flow-direction 0 2 port_id 0 type > +lookaside-protocol-offload > + > sa in 125 cipher_algo aes-128-cbc cipher_key c3:c3:c3:c3:c3:c3:c3:c3:c3:= c3:c3:\ > c3:c3:c3:c3:c3 auth_algo sha1-hmac auth_key > c3:c3:c3:c3:c3:c3:c3:c3:c3:c3:c3:\ > c3:c3:c3:c3:c3:c3:c3:c3:c3 mode ipv6-tunnel \ @@ -130,6 +136,11 @@ sa in > 126 cipher_algo aes-128-cbc cipher_key 4d:4d:4d:4d:4d:4d:4d:4d:4d:4d:4d:\ > src 2222:2222:2222:2222:2222:2222:2222:6666 \ dst > 1111:1111:1111:1111:1111:1111:1111:6666 >=20 > +sa in 127 cipher_algo null auth_algo null mode ipv6-tunnel \ src > +2222:2222:2222:2222:2222:2222:2222:7777 \ dst > +1111:1111:1111:1111:1111:1111:1111:7777 \ flow-direction 0 3 port_id 0 > +type lookaside-protocol-offload > + > #Routing rules > rt ipv4 dst 172.16.2.5/32 port 0 > rt ipv4 dst 172.16.2.6/32 port 1 > diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec- > secgw/ipsec-secgw.c > index 4799bc90c..132484422 100644 > --- a/examples/ipsec-secgw/ipsec-secgw.c > +++ b/examples/ipsec-secgw/ipsec-secgw.c > @@ -166,7 +166,6 @@ static const struct option lgopts[] =3D { > {CMD_LINE_OPT_FRAG_TTL, 1, 0, CMD_LINE_OPT_FRAG_TTL_NUM}, > {NULL, 0, 0, 0} > }; > - > /* mask of enabled ports */ > static uint32_t enabled_port_mask; > static uint64_t enabled_cryptodev_mask =3D UINT64_MAX; @@ -259,6 +258,30 > @@ static struct rte_eth_conf port_conf =3D { > .txmode =3D { > .mq_mode =3D ETH_MQ_TX_NONE, > }, > + .fdir_conf =3D { > + .mode =3D RTE_FDIR_MODE_NONE, > + .pballoc =3D RTE_FDIR_PBALLOC_64K, > + .status =3D RTE_FDIR_REPORT_STATUS, > + .mask =3D { > + .vlan_tci_mask =3D 0xFFEF, > + .ipv4_mask =3D { > + .src_ip =3D 0xFFFFFFFF, > + .dst_ip =3D 0xFFFFFFFF, > + }, > + .ipv6_mask =3D { > + .src_ip =3D {0xFFFFFFFF, 0xFFFFFFFF, 0xFFFFFFFF, > + 0xFFFFFFFF}, > + .dst_ip =3D {0xFFFFFFFF, 0xFFFFFFFF, 0xFFFFFFFF, > + 0xFFFFFFFF}, > + }, > + .src_port_mask =3D 0xFFFF, > + .dst_port_mask =3D 0xFFFF, > + .mac_addr_byte_mask =3D 0xFF, > + .tunnel_type_mask =3D 1, > + .tunnel_id_mask =3D 0xFFFFFFFF, > + }, > + .drop_queue =3D 127, > + } > }; >=20 > static struct socket_ctx socket_ctx[NB_SOCKETS]; @@ -1184,7 +1207,6 @@ > main_loop(__attribute__((unused)) void *dummy) >=20 > if (nb_rx > 0) > process_pkts(qconf, pkts, nb_rx, portid); > - > /* dequeue and process completed crypto-ops */ > if (UNPROTECTED_PORT(portid)) > drain_inbound_crypto_queues(qconf, > @@ -1196,6 +1218,27 @@ main_loop(__attribute__((unused)) void *dummy) > } > } >=20 > +int check_flow_params(uint16_t fdir_portid, uint8_t fdir_qid) { > + uint16_t i; > + uint16_t portid; > + uint8_t queueid; > + > + for (i =3D 0; i < nb_lcore_params; ++i) { > + portid =3D lcore_params_array[i].port_id; > + if (portid =3D=3D fdir_portid) { > + queueid =3D lcore_params_array[i].queue_id; > + if (queueid =3D=3D fdir_qid) > + break; > + } > + > + if (i =3D=3D nb_lcore_params - 1) > + return -1; > + } > + > + return 1; > +} > + > static int32_t > check_params(void) > { > @@ -2503,6 +2546,15 @@ main(int32_t argc, char **argv) > continue; >=20 > sa_check_offloads(portid, &req_rx_offloads, > &req_tx_offloads); > + /* check if FDIR is configured on the port */ > + if (check_fdir_configured(portid)) { > + /* Enable FDIR */ > + port_conf.fdir_conf.mode =3D > RTE_FDIR_MODE_PERFECT; > + /* Disable RSS */ > + port_conf.rxmode.mq_mode =3D ETH_MQ_RX_NONE; > + port_conf.rx_adv_conf.rss_conf.rss_hf =3D 0; > + port_conf.rx_adv_conf.rss_conf.rss_key =3D NULL; > + } > port_init(portid, req_rx_offloads, req_tx_offloads); > } >=20 > diff --git a/examples/ipsec-secgw/ipsec.c b/examples/ipsec-secgw/ipsec.c = index > 6e8120702..363809cfd 100644 > --- a/examples/ipsec-secgw/ipsec.c > +++ b/examples/ipsec-secgw/ipsec.c > @@ -415,6 +415,73 @@ create_inline_session(struct socket_ctx *skt_ctx, > struct ipsec_sa *sa, > return 0; > } >=20 > +int > +create_ipsec_esp_flow(struct ipsec_sa *sa) { > + int ret =3D 0; > + struct rte_flow_error err; > + if (sa->direction =3D=3D RTE_SECURITY_IPSEC_SA_DIR_EGRESS) > + return 0; /* No Flow director rules for Egress traffic */ > + if (sa->flags =3D=3D TRANSPORT) { > + RTE_LOG(ERR, IPSEC, > + "No Flow director rule for transport mode:"); > + return -1; > + } > + sa->action[0].type =3D RTE_FLOW_ACTION_TYPE_QUEUE; > + sa->pattern[0].type =3D RTE_FLOW_ITEM_TYPE_ETH; > + sa->action[0].conf =3D > + &(struct rte_flow_action_queue){ > + .index =3D sa->fdir_qid, > + }; > + sa->attr.egress =3D 0; > + sa->attr.ingress =3D 1; > + if (IS_IP6(sa->flags)) { > + sa->pattern[1].mask =3D &rte_flow_item_ipv6_mask; > + sa->pattern[1].type =3D RTE_FLOW_ITEM_TYPE_IPV6; > + sa->pattern[1].spec =3D &sa->ipv6_spec; > + memcpy(sa->ipv6_spec.hdr.dst_addr, > + sa->dst.ip.ip6.ip6_b, IPV6_ADDR_LEN); > + memcpy(sa->ipv6_spec.hdr.src_addr, > + sa->src.ip.ip6.ip6_b, IPV6_ADDR_LEN); > + sa->pattern[2].type =3D RTE_FLOW_ITEM_TYPE_ESP; > + sa->pattern[2].spec =3D &sa->esp_spec; > + sa->pattern[2].mask =3D &rte_flow_item_esp_mask; > + sa->esp_spec.hdr.spi =3D rte_cpu_to_be_32(sa->spi); > + sa->pattern[3].type =3D RTE_FLOW_ITEM_TYPE_END; > + } else if (IS_IP4(sa->flags)) { > + sa->pattern[1].mask =3D &rte_flow_item_ipv4_mask; > + sa->pattern[1].type =3D RTE_FLOW_ITEM_TYPE_IPV4; > + sa->pattern[1].spec =3D &sa->ipv4_spec; > + sa->ipv4_spec.hdr.dst_addr =3D sa->dst.ip.ip4; > + sa->ipv4_spec.hdr.src_addr =3D sa->src.ip.ip4; > + sa->pattern[2].type =3D RTE_FLOW_ITEM_TYPE_ESP; > + sa->pattern[2].spec =3D &sa->esp_spec; > + sa->pattern[2].mask =3D &rte_flow_item_esp_mask; > + sa->esp_spec.hdr.spi =3D rte_cpu_to_be_32(sa->spi); > + sa->pattern[3].type =3D RTE_FLOW_ITEM_TYPE_END; > + } > + sa->action[1].type =3D RTE_FLOW_ACTION_TYPE_END; > + > + ret =3D rte_flow_validate(sa->fdir_portid, &sa->attr, > + sa->pattern, sa->action, > + &err); > + if (ret < 0) { > + RTE_LOG(ERR, IPSEC, > + "Flow Validation failed\n"); > + return ret; > + } > + sa->flow =3D rte_flow_create(sa->fdir_portid, > + &sa->attr, sa->pattern, sa->action, > + &err); > + if (!sa->flow) { > + RTE_LOG(ERR, IPSEC, > + "Flow Creation failed\n"); > + return -1; > + } > + > + return 0; > +} > + > /* > * queue crypto-ops into PMD queue. > */ > diff --git a/examples/ipsec-secgw/ipsec.h b/examples/ipsec-secgw/ipsec.h > index 4f2fd6184..00147895a 100644 > --- a/examples/ipsec-secgw/ipsec.h > +++ b/examples/ipsec-secgw/ipsec.h > @@ -46,6 +46,8 @@ >=20 > #define IP6_VERSION (6) >=20 > +#define IPV6_ADDR_LEN 16 > + > struct rte_crypto_xform; > struct ipsec_xform; > struct rte_mbuf; > @@ -138,6 +140,9 @@ struct ipsec_sa { > }; > enum rte_security_ipsec_sa_direction direction; > uint16_t portid; > + uint16_t fdir_portid; > + uint8_t fdir_qid; > + uint8_t fdir_flag; >=20 > #define MAX_RTE_FLOW_PATTERN (4) > #define MAX_RTE_FLOW_ACTIONS (3) > @@ -383,5 +388,11 @@ create_lookaside_session(struct ipsec_ctx *ipsec_ctx= , > struct ipsec_sa *sa, int create_inline_session(struct socket_ctx *skt_c= tx, struct > ipsec_sa *sa, > struct rte_ipsec_session *ips); > +int > +check_flow_params(uint16_t fdir_portid, uint8_t fdir_qid); > + > +int > +create_ipsec_esp_flow(struct ipsec_sa *sa); >=20 > +int check_fdir_configured(uint16_t portid); > #endif /* __IPSEC_H__ */ > diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c index > 4822d6bda..9955dfcbe 100644 > --- a/examples/ipsec-secgw/sa.c > +++ b/examples/ipsec-secgw/sa.c > @@ -20,6 +20,9 @@ > #include > #include > #include > +#include > +#include > +#include >=20 > #include "ipsec.h" > #include "esp.h" > @@ -271,6 +274,7 @@ parse_sa_tokens(char **tokens, uint32_t n_tokens, > uint32_t type_p =3D 0; > uint32_t portid_p =3D 0; > uint32_t fallback_p =3D 0; > + int16_t status_p =3D 0; >=20 > if (strcmp(tokens[0], "in") =3D=3D 0) { > ri =3D &nb_sa_in; > @@ -681,6 +685,25 @@ parse_sa_tokens(char **tokens, uint32_t n_tokens, > fallback_p =3D 1; > continue; > } > + if (strcmp(tokens[ti], "flow-direction") =3D=3D 0) { > + rule->fdir_flag =3D 1; > + INCREMENT_TOKEN_INDEX(ti, n_tokens, status); > + if (status->status < 0) > + return; > + rule->fdir_portid =3D atoi(tokens[ti]); > + INCREMENT_TOKEN_INDEX(ti, n_tokens, status); > + if (status->status < 0) > + return; > + rule->fdir_qid =3D atoi(tokens[ti]); > + /* validating portid and queueid */ > + status_p =3D check_flow_params(rule->fdir_portid, > + rule->fdir_qid); > + if (status_p < 0) { > + printf("port id %u / queue id %u is not valid\n", > + rule->fdir_portid, rule->fdir_qid); > + } > + continue; > + } >=20 > /* unrecognizeable input */ > APP_CHECK(0, status, "unrecognized input \"%s\"", @@ -823,6 > +846,9 @@ print_one_sa_rule(const struct ipsec_sa *sa, int inbound) > break; > } > } > + if (sa->fdir_flag =3D=3D 1) > + printf("flow-direction %d %d", sa->fdir_portid, sa->fdir_qid); > + > printf("\n"); > } >=20 > @@ -1153,7 +1179,15 @@ sa_add_rules(struct sa_ctx *sa_ctx, const struct > ipsec_sa entries[], > return -EINVAL; > } > } > - > + if (sa->fdir_flag && > + ips->type =3D=3D > + RTE_SECURITY_ACTION_TYPE_LOOKASIDE_PROTOCOL > && > + inbound) { > + rc =3D create_ipsec_esp_flow(sa); > + if (rc !=3D 0) > + RTE_LOG(ERR, IPSEC_ESP, > + "create_ipsec_esp flow failed\n"); > + } > print_one_sa_rule(sa, inbound); > } >=20 > @@ -1256,6 +1290,20 @@ fill_ipsec_session(struct rte_ipsec_session *ss, s= truct > rte_ipsec_sa *sa) > return rc; > } >=20 > +int > +check_fdir_configured(uint16_t portid) > +{ > + struct ipsec_sa *sa =3D NULL; > + uint32_t idx_sa =3D 0; > + > + for (idx_sa =3D 0; idx_sa < nb_sa_in; idx_sa++) { > + sa =3D &sa_in[idx_sa]; > + if (sa->fdir_portid =3D=3D portid) > + return sa->fdir_flag; > + } > + return 0; > +} > + > /* > * Initialise related rte_ipsec_sa object. > */ > -- > 2.17.1