From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E30EA0567; Fri, 13 Mar 2020 11:51:40 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5013F1BFA5; Fri, 13 Mar 2020 11:51:39 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id BD2561BF97 for ; Fri, 13 Mar 2020 11:51:37 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 02DAjP6k004309; Fri, 13 Mar 2020 03:51:36 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=cqcchIyYzFtSWLqnuo7KDyxHvhSTa1t3nhP7eeWQo58=; b=PizqVvLwZ3JXtqQ7Sa8AMzT5/Pd7xjBJpFA/pHEqsrdziy9YKPXtNvkR5WeeBuiNXFdh 4T4XDK1Ww691LNnPQDCmpRiXtLwJHlR81/NuZJ39SL8JlKg8PPDndKpO+Z4CYWh2unzw 4i8CRkaA6vPssFxx+0/oqbSJHEs9U+Ze+L+zTNV49sF81QjKgMgp2sbD3BKw19NTe9HN g+u/H5acJd/9tXEDkIJRL9Mlcyuimf+/G2jrZbCATCyetgE5ziySgqadeolJQjm7nwY4 MJasNVOr+B2Ehbpl1VHTzn9/D/yKYH3BWR5L9MJ3i9IpVs+u2IxkQWe4Lcet6DdHGfCk lA== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0a-0016f401.pphosted.com with ESMTP id 2yqt7t3fht-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Fri, 13 Mar 2020 03:51:36 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 13 Mar 2020 03:51:35 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 13 Mar 2020 03:51:34 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.46) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Fri, 13 Mar 2020 03:51:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MGhznVBbWLNGhRV09ud6KuX6fMPZdf7T0h4CwaNTewHDMZsIeJt8gLxLRix6iBFF/leJmstijHvgHmCONZ3MmyN2u/3nfLBi1cJLGzglY3hTHrylu3PYWPYx5h9Gqs3rsbYZGLq6nHIm63UWp4bdTY1Un9q6PpA3E7P/emDHsZobHsyF2CHivconzq1JDsv6CN81dtPxDMel/e3uUk45Vma1WWtCvtPH8AGEkYSGcaEIDTl88GEUT6QWZP5vgifTnoIUWTEGmYfii+dn7XiR+4xgFnhf4bYLyIPcNhW+03MQC4aaxAM5w9O+CXNLaXJ0PSyOVFpoVVGqUI1/REy/Lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cqcchIyYzFtSWLqnuo7KDyxHvhSTa1t3nhP7eeWQo58=; b=Y4iR/HhzvAHMb4+YjTxzST08DT35jSDxRvp8aKZJkLIF0gjUysuRENV8PMfEeoYkLy9sH1jV/4OE5bx3GEviDY8rbf5Der8YS+4ItO0K21zO1K/gJTkRDoUyA912ZE3CNxaWbeUXQs48fYiUk04OwakScwx22R+Q1oK2j8pFO39EzXZFInzYAkY3AeDKkXcAxblpaTqsENp/iF8j5pqPHRktLvS1ixMCgwBgQLFxhHYTa4vjUT2cFrlDiXC5sPKedfQ+RZ2MlMWmnLza/3NyoNxJLj/KjrN/gWMEXziKv0lpGiqAoA68D38J39II+dBxHIIJhgAnXfT/LztWkLilgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cqcchIyYzFtSWLqnuo7KDyxHvhSTa1t3nhP7eeWQo58=; b=bJmp0ZfoHHqu/cHjiuKuWEN3j3K+pCHMu9dkSSmcmYpx94MM5M1vf/luNWQmuR09C/fYJdPZIT9xSBl5ggXmsRofIx88Hxr81R1Sax/iqenZaCze2/KRjz1tt1fJjHQtuONqsaXUKxI/d9Ezk9FtHUnqb2dx9I9te1t4NHI7eOY= Received: from MN2PR18MB2877.namprd18.prod.outlook.com (2603:10b6:208:3b::26) by MN2PR18MB2527.namprd18.prod.outlook.com (2603:10b6:208:103::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2814.18; Fri, 13 Mar 2020 10:51:32 +0000 Received: from MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::648f:e7fa:f95e:191b]) by MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::648f:e7fa:f95e:191b%2]) with mapi id 15.20.2793.021; Fri, 13 Mar 2020 10:51:32 +0000 From: Anoob Joseph To: "Shetty, Praveen" , "Doherty, Declan" , "Ananyev, Konstantin" , "Iremonger, Bernard" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v1] examples/ipsec-secgw: support flow director feature Thread-Index: AQHV97UkgwJYR7cP/UqfOBI8Z/3jmKhEy5SAgAAuy4CAACWAkIAAID0QgADS81CAAEdtEA== Date: Fri, 13 Mar 2020 10:51:32 +0000 Message-ID: References: <20200311145529.40221-1-praveen.shetty@intel.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [111.125.192.37] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b7a8e131-f798-4213-822e-08d7c73c7e11 x-ms-traffictypediagnostic: MN2PR18MB2527: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 034119E4F6 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(376002)(39860400002)(136003)(346002)(366004)(199004)(8936002)(7696005)(316002)(81156014)(81166006)(110136005)(55236004)(6506007)(478600001)(33656002)(52536014)(55016002)(5660300002)(2906002)(9686003)(86362001)(26005)(76116006)(71200400001)(30864003)(66446008)(66946007)(66556008)(66476007)(64756008)(186003)(53546011); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB2527; H:MN2PR18MB2877.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7+eG2vDXzxNANAhPGU50g6dZw2ZnKB76+EBFqjo9LTaFDpwUAc6NOlRVhRv5isbvY86ncegUloCrvKDH3enbiBqvEA8Qu2QlItPg98ojgjIIwKTKyQou3+PV01bVzq7Mrkf8QTRRZEqaB2CboIwR/UgSLBTMdThlRPW/rc6jw9I98obyhDdAk5WwixnuMBMX6Fvq71xNuHgoaYkz/8Ts8xlfVjZQRoNTWcLEAS3hAokji94imU4qFJl+5PXV0TpYF5Jwbd2K70OT7pY3f39/cJ679StO16VxxkjrAH757/EgHzrcHEH6PcIO+LBgJS8nyKLvEauhdMqYjfKBmhiVUpoAcsxNYSVjGLE3vO2V8hSim+HWZYdNTEquVE4mnBEaxPyKiznyNUQgU4S8exib0Ineqz3d8LvA7h5lYybHhlI5CvY5Fbd4+1H1eK9KAvyr x-ms-exchange-antispam-messagedata: /4eh2yKeT+aaKYmY54Avle3JTVSC8rflcfSRzTivmA+7u6dvLGVYqlBp5omHB/vyawstfNeRDysTz1vOHAkOHYzVI+t2hnUrfLdKLH4EvIwC3glBwMYrmnnH0CpypCF8Tjq8xFStC0qamzcNWHmyaQ== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: b7a8e131-f798-4213-822e-08d7c73c7e11 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Mar 2020 10:51:32.1577 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: odP9yAVElmE77PugAb3DaOvnk2plq6NN+2p2LY4CnPi9p1KydMDkiNGpFUP3M+FuH9rAmtTEEnP9n8UkMg0aPw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2527 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.572 definitions=2020-03-13_04:2020-03-12, 2020-03-13 signatures=0 Subject: Re: [dpdk-dev] [PATCH v1] examples/ipsec-secgw: support flow director feature X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Praveen, Please see inline. Thanks, Anoob > -----Original Message----- > From: Shetty, Praveen > Sent: Friday, March 13, 2020 12:36 PM > To: Anoob Joseph ; Doherty, Declan > ; Ananyev, Konstantin > ; Iremonger, Bernard > ; dev@dpdk.org > Subject: [EXT] RE: [dpdk-dev] [PATCH v1] examples/ipsec-secgw: support fl= ow > director feature >=20 > External Email >=20 > ---------------------------------------------------------------------- > Hi Anoob, >=20 > Thank you. >=20 > Please see my answers below. >=20 > Regards, > Praveen >=20 > -----Original Message----- > From: Anoob Joseph > Sent: Thursday, March 12, 2020 4:31 PM > To: Shetty, Praveen ; dev@dpdk.org; Doherty, > Declan ; Iremonger, Bernard > ; Ananyev, Konstantin > > Subject: RE: [dpdk-dev] [PATCH v1] examples/ipsec-secgw: support flow dir= ector > feature >=20 > Hi Praveen, >=20 > I do have some review comments on the code. Before that, can you give a b= rief > overview of what is being targeted? My understanding is that the primary > objective is to use rte_flow (or flow director) to redirect a specific fl= ow(/SA) to a > specific queue. Can you confirm? >=20 > >>>> Yes, your understanding is correct, the main objective is to support= load > distribution in ipsec-secgw application. > >>>> flow director and RSS features are used achieve the load distributio= n. > >>>> flow director is used to redirect the specified inbound ipsec flow t= o a > specified queue. [Anoob] May be update the commit description with some more such details. A= nd I think it's better to use 'rte_flow' rather than flow director. I see t= hat i40e PMD talks about flow director, but overall the feature is usage of= rte_flow. =20 >=20 > Couple of questions, > 1. I would assume the new option of "flow-direction" is optional and is > determined per SA. In that case, can I assume that RSS would be active fo= r the > other flows (or SAs). Let's say, I just want to add a SA for which I woul= d like to > enable "flow-direction" but leave the rest as is. How is that handled? >=20 > [Praveen] >=20 > >>>> We are using fdir_flag to differentiate the mix of SA's(SA's with an= d > without flow-direction). > >>>> fdir_flag will be "set" for the SA which has configured with flow-di= rection > option(SA rule syntax is extended to add new options > ). > >>>> flow creation is called only for the SA's with fdir_flag is set. [Anoob] I've few questions on this. I'll send this along with my code revie= w. =20 >=20 > 2. I see that the changes are only applicable for LOOKASIDE_PROTOCOL. The > same feature would be useful for other modes as well, right? >=20 > [Praveen] > >>>> We are adding this feature for i40e NIC and the i40e NIC doesn't s= upport > either encryption or decryption, that's why we used only > LOOKASIDE_PROTOCOL in this case. [Anoob] I meant LOOKASIDE_NONE (LOOKASIDE_CRYPTO) case. I would assume that= can be early supported. >=20 > 3. I'm not sure "flow-direction" is the right wording for the option. Thi= s is just > specifying the "rx-queue" per SA. @Akhil, Konstantin, comments? >=20 > >>>> @Declan, @Konstantin , @Bernard, @Akhil Could you please suggest = a > name on which we can all agree upon? >=20 > Thanks, > Anoob >=20 > > -----Original Message----- > > From: dev On Behalf Of Praveen Shetty > > Sent: Wednesday, March 11, 2020 8:25 PM > > To: dev@dpdk.org; declan.doherty@intel.com; > > bernard.iremonger@intel.com; konstantin.ananyev@intel.com > > Subject: [dpdk-dev] [PATCH v1] examples/ipsec-secgw: support flow > > director feature > > > > Modified Secuirty gateway application to support configuration of flow > > director rule to direct inbound IPsec SA to a specified queue. > > > > Signed-off-by: Praveen Shetty > > --- > > examples/ipsec-secgw/ep0.cfg | 11 +++++ > > examples/ipsec-secgw/ipsec-secgw.c | 56 ++++++++++++++++++++++++- > > examples/ipsec-secgw/ipsec.c | 67 ++++++++++++++++++++++++++++++ > > examples/ipsec-secgw/ipsec.h | 11 +++++ > > examples/ipsec-secgw/sa.c | 50 +++++++++++++++++++++- > > 5 files changed, 192 insertions(+), 3 deletions(-) > > > > diff --git a/examples/ipsec-secgw/ep0.cfg > > b/examples/ipsec-secgw/ep0.cfg index dfd4aca7d..c9f80e81b 100644 > > --- a/examples/ipsec-secgw/ep0.cfg > > +++ b/examples/ipsec-secgw/ep0.cfg > > @@ -29,6 +29,7 @@ sp ipv4 in esp protect 111 pri 1 dst > > 192.168.186.0/24 sport > > 0:65535 dport 0:6553 sp ipv4 in esp protect 115 pri 1 dst > > 192.168.210.0/24 sport > > 0:65535 dport 0:65535 sp ipv4 in esp protect 116 pri 1 dst > > 192.168.211.0/24 sport 0:65535 dport 0:65535 sp ipv4 in esp protect > > 115 pri 1 dst > > 192.168.210.0/24 sport 0:65535 dport 0:65535 > > +sp ipv4 in esp protect 117 pri 1 dst 192.168.212.0/24 sport 0:65535 > > +dport 0:65535 > > sp ipv4 in esp protect 125 pri 1 dst 192.168.65.0/24 sport 0:65535 > > dport 0:65535 sp ipv4 in esp protect 125 pri 1 dst 192.168.65.0/24 > > sport 0:65535 dport 0:65535 sp ipv4 in esp protect 126 pri 1 dst > > 192.168.66.0/24 sport 0:65535 dport 0:65535 @@ -61,6 +62,8 @@ sp ipv6 > > in esp protect 125 pri 1 dst > > ffff:0000:0000:0000:aaaa:aaaa:0000:0000/96 > > sport 0:65535 dport 0:65535 > > sp ipv6 in esp protect 126 pri 1 dst > > ffff:0000:0000:0000:bbbb:bbbb:0000:0000/96 \ sport 0:65535 dport > > 0:65535 > > +sp ipv6 in esp protect 127 pri 1 dst > > +ffff:0000:0000:0000:cccc:dddd:0000:0000/96 \ sport 0:65535 dport > > +0:65535 > > > > #SA rules > > sa out 5 cipher_algo aes-128-cbc cipher_key > > 0:0:0:0:0:0:0:0:0:0:0:0:0:0:0:0 \ @@ -118,6 +121,9 @@ dst 172.16.1.5 > > > > sa in 116 cipher_algo null auth_algo null mode ipv4-tunnel src > > 172.16.2.6 dst > > 172.16.1.6 > > > > +sa in 117 cipher_algo null auth_algo null mode ipv4-tunnel src > > +172.16.2.7 \ dst 172.16.1.7 flow-direction 0 2 port_id 0 type > > +lookaside-protocol-offload > > + > > sa in 125 cipher_algo aes-128-cbc cipher_key > > c3:c3:c3:c3:c3:c3:c3:c3:c3:c3:c3:\ > > c3:c3:c3:c3:c3 auth_algo sha1-hmac auth_key > > c3:c3:c3:c3:c3:c3:c3:c3:c3:c3:c3:\ > > c3:c3:c3:c3:c3:c3:c3:c3:c3 mode ipv6-tunnel \ @@ -130,6 +136,11 @@ sa > > in > > 126 cipher_algo aes-128-cbc cipher_key > > 4d:4d:4d:4d:4d:4d:4d:4d:4d:4d:4d:\ > > src 2222:2222:2222:2222:2222:2222:2222:6666 \ dst > > 1111:1111:1111:1111:1111:1111:1111:6666 > > > > +sa in 127 cipher_algo null auth_algo null mode ipv6-tunnel \ src > > +2222:2222:2222:2222:2222:2222:2222:7777 \ dst > > +1111:1111:1111:1111:1111:1111:1111:7777 \ flow-direction 0 3 port_id > > +0 type lookaside-protocol-offload > > + > > #Routing rules > > rt ipv4 dst 172.16.2.5/32 port 0 > > rt ipv4 dst 172.16.2.6/32 port 1 > > diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec- > > secgw/ipsec-secgw.c index 4799bc90c..132484422 100644 > > --- a/examples/ipsec-secgw/ipsec-secgw.c > > +++ b/examples/ipsec-secgw/ipsec-secgw.c > > @@ -166,7 +166,6 @@ static const struct option lgopts[] =3D { > > {CMD_LINE_OPT_FRAG_TTL, 1, 0, CMD_LINE_OPT_FRAG_TTL_NUM}, > > {NULL, 0, 0, 0} > > }; > > - > > /* mask of enabled ports */ > > static uint32_t enabled_port_mask; > > static uint64_t enabled_cryptodev_mask =3D UINT64_MAX; @@ -259,6 > > +258,30 @@ static struct rte_eth_conf port_conf =3D { > > .txmode =3D { > > .mq_mode =3D ETH_MQ_TX_NONE, > > }, > > + .fdir_conf =3D { > > + .mode =3D RTE_FDIR_MODE_NONE, > > + .pballoc =3D RTE_FDIR_PBALLOC_64K, > > + .status =3D RTE_FDIR_REPORT_STATUS, > > + .mask =3D { > > + .vlan_tci_mask =3D 0xFFEF, > > + .ipv4_mask =3D { > > + .src_ip =3D 0xFFFFFFFF, > > + .dst_ip =3D 0xFFFFFFFF, > > + }, > > + .ipv6_mask =3D { > > + .src_ip =3D {0xFFFFFFFF, 0xFFFFFFFF, 0xFFFFFFFF, > > + 0xFFFFFFFF}, > > + .dst_ip =3D {0xFFFFFFFF, 0xFFFFFFFF, 0xFFFFFFFF, > > + 0xFFFFFFFF}, > > + }, > > + .src_port_mask =3D 0xFFFF, > > + .dst_port_mask =3D 0xFFFF, > > + .mac_addr_byte_mask =3D 0xFF, > > + .tunnel_type_mask =3D 1, > > + .tunnel_id_mask =3D 0xFFFFFFFF, > > + }, > > + .drop_queue =3D 127, > > + } > > }; > > > > static struct socket_ctx socket_ctx[NB_SOCKETS]; @@ -1184,7 +1207,6 > > @@ > > main_loop(__attribute__((unused)) void *dummy) > > > > if (nb_rx > 0) > > process_pkts(qconf, pkts, nb_rx, portid); > > - > > /* dequeue and process completed crypto-ops */ > > if (UNPROTECTED_PORT(portid)) > > drain_inbound_crypto_queues(qconf, > > @@ -1196,6 +1218,27 @@ main_loop(__attribute__((unused)) void *dummy) > > } > > } > > > > +int check_flow_params(uint16_t fdir_portid, uint8_t fdir_qid) { > > + uint16_t i; > > + uint16_t portid; > > + uint8_t queueid; > > + > > + for (i =3D 0; i < nb_lcore_params; ++i) { > > + portid =3D lcore_params_array[i].port_id; > > + if (portid =3D=3D fdir_portid) { > > + queueid =3D lcore_params_array[i].queue_id; > > + if (queueid =3D=3D fdir_qid) > > + break; > > + } > > + > > + if (i =3D=3D nb_lcore_params - 1) > > + return -1; > > + } > > + > > + return 1; > > +} > > + > > static int32_t > > check_params(void) > > { > > @@ -2503,6 +2546,15 @@ main(int32_t argc, char **argv) > > continue; > > > > sa_check_offloads(portid, &req_rx_offloads, > &req_tx_offloads); > > + /* check if FDIR is configured on the port */ > > + if (check_fdir_configured(portid)) { > > + /* Enable FDIR */ > > + port_conf.fdir_conf.mode =3D > > RTE_FDIR_MODE_PERFECT; > > + /* Disable RSS */ > > + port_conf.rxmode.mq_mode =3D ETH_MQ_RX_NONE; > > + port_conf.rx_adv_conf.rss_conf.rss_hf =3D 0; > > + port_conf.rx_adv_conf.rss_conf.rss_key =3D NULL; > > + } > > port_init(portid, req_rx_offloads, req_tx_offloads); > > } > > > > diff --git a/examples/ipsec-secgw/ipsec.c > > b/examples/ipsec-secgw/ipsec.c index 6e8120702..363809cfd 100644 > > --- a/examples/ipsec-secgw/ipsec.c > > +++ b/examples/ipsec-secgw/ipsec.c > > @@ -415,6 +415,73 @@ create_inline_session(struct socket_ctx *skt_ctx, > > struct ipsec_sa *sa, > > return 0; > > } > > > > +int > > +create_ipsec_esp_flow(struct ipsec_sa *sa) { > > + int ret =3D 0; > > + struct rte_flow_error err; > > + if (sa->direction =3D=3D RTE_SECURITY_IPSEC_SA_DIR_EGRESS) > > + return 0; /* No Flow director rules for Egress traffic */ > > + if (sa->flags =3D=3D TRANSPORT) { > > + RTE_LOG(ERR, IPSEC, > > + "No Flow director rule for transport mode:"); > > + return -1; > > + } > > + sa->action[0].type =3D RTE_FLOW_ACTION_TYPE_QUEUE; > > + sa->pattern[0].type =3D RTE_FLOW_ITEM_TYPE_ETH; > > + sa->action[0].conf =3D > > + &(struct rte_flow_action_queue){ > > + .index =3D sa->fdir_qid, > > + }; > > + sa->attr.egress =3D 0; > > + sa->attr.ingress =3D 1; > > + if (IS_IP6(sa->flags)) { > > + sa->pattern[1].mask =3D &rte_flow_item_ipv6_mask; > > + sa->pattern[1].type =3D RTE_FLOW_ITEM_TYPE_IPV6; > > + sa->pattern[1].spec =3D &sa->ipv6_spec; > > + memcpy(sa->ipv6_spec.hdr.dst_addr, > > + sa->dst.ip.ip6.ip6_b, IPV6_ADDR_LEN); > > + memcpy(sa->ipv6_spec.hdr.src_addr, > > + sa->src.ip.ip6.ip6_b, IPV6_ADDR_LEN); > > + sa->pattern[2].type =3D RTE_FLOW_ITEM_TYPE_ESP; > > + sa->pattern[2].spec =3D &sa->esp_spec; > > + sa->pattern[2].mask =3D &rte_flow_item_esp_mask; > > + sa->esp_spec.hdr.spi =3D rte_cpu_to_be_32(sa->spi); > > + sa->pattern[3].type =3D RTE_FLOW_ITEM_TYPE_END; > > + } else if (IS_IP4(sa->flags)) { > > + sa->pattern[1].mask =3D &rte_flow_item_ipv4_mask; > > + sa->pattern[1].type =3D RTE_FLOW_ITEM_TYPE_IPV4; > > + sa->pattern[1].spec =3D &sa->ipv4_spec; > > + sa->ipv4_spec.hdr.dst_addr =3D sa->dst.ip.ip4; > > + sa->ipv4_spec.hdr.src_addr =3D sa->src.ip.ip4; > > + sa->pattern[2].type =3D RTE_FLOW_ITEM_TYPE_ESP; > > + sa->pattern[2].spec =3D &sa->esp_spec; > > + sa->pattern[2].mask =3D &rte_flow_item_esp_mask; > > + sa->esp_spec.hdr.spi =3D rte_cpu_to_be_32(sa->spi); > > + sa->pattern[3].type =3D RTE_FLOW_ITEM_TYPE_END; > > + } > > + sa->action[1].type =3D RTE_FLOW_ACTION_TYPE_END; > > + > > + ret =3D rte_flow_validate(sa->fdir_portid, &sa->attr, > > + sa->pattern, sa->action, > > + &err); > > + if (ret < 0) { > > + RTE_LOG(ERR, IPSEC, > > + "Flow Validation failed\n"); > > + return ret; > > + } > > + sa->flow =3D rte_flow_create(sa->fdir_portid, > > + &sa->attr, sa->pattern, sa->action, > > + &err); > > + if (!sa->flow) { > > + RTE_LOG(ERR, IPSEC, > > + "Flow Creation failed\n"); > > + return -1; > > + } > > + > > + return 0; > > +} > > + > > /* > > * queue crypto-ops into PMD queue. > > */ > > diff --git a/examples/ipsec-secgw/ipsec.h > > b/examples/ipsec-secgw/ipsec.h index 4f2fd6184..00147895a 100644 > > --- a/examples/ipsec-secgw/ipsec.h > > +++ b/examples/ipsec-secgw/ipsec.h > > @@ -46,6 +46,8 @@ > > > > #define IP6_VERSION (6) > > > > +#define IPV6_ADDR_LEN 16 > > + > > struct rte_crypto_xform; > > struct ipsec_xform; > > struct rte_mbuf; > > @@ -138,6 +140,9 @@ struct ipsec_sa { > > }; > > enum rte_security_ipsec_sa_direction direction; > > uint16_t portid; > > + uint16_t fdir_portid; > > + uint8_t fdir_qid; > > + uint8_t fdir_flag; > > > > #define MAX_RTE_FLOW_PATTERN (4) > > #define MAX_RTE_FLOW_ACTIONS (3) > > @@ -383,5 +388,11 @@ create_lookaside_session(struct ipsec_ctx > > *ipsec_ctx, struct ipsec_sa *sa, int create_inline_session(struct > > socket_ctx *skt_ctx, struct ipsec_sa *sa, > > struct rte_ipsec_session *ips); > > +int > > +check_flow_params(uint16_t fdir_portid, uint8_t fdir_qid); > > + > > +int > > +create_ipsec_esp_flow(struct ipsec_sa *sa); > > > > +int check_fdir_configured(uint16_t portid); > > #endif /* __IPSEC_H__ */ > > diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c > > index 4822d6bda..9955dfcbe 100644 > > --- a/examples/ipsec-secgw/sa.c > > +++ b/examples/ipsec-secgw/sa.c > > @@ -20,6 +20,9 @@ > > #include > > #include > > #include > > +#include > > +#include > > +#include > > > > #include "ipsec.h" > > #include "esp.h" > > @@ -271,6 +274,7 @@ parse_sa_tokens(char **tokens, uint32_t n_tokens, > > uint32_t type_p =3D 0; > > uint32_t portid_p =3D 0; > > uint32_t fallback_p =3D 0; > > + int16_t status_p =3D 0; > > > > if (strcmp(tokens[0], "in") =3D=3D 0) { > > ri =3D &nb_sa_in; > > @@ -681,6 +685,25 @@ parse_sa_tokens(char **tokens, uint32_t n_tokens, > > fallback_p =3D 1; > > continue; > > } > > + if (strcmp(tokens[ti], "flow-direction") =3D=3D 0) { > > + rule->fdir_flag =3D 1; > > + INCREMENT_TOKEN_INDEX(ti, n_tokens, status); > > + if (status->status < 0) > > + return; > > + rule->fdir_portid =3D atoi(tokens[ti]); > > + INCREMENT_TOKEN_INDEX(ti, n_tokens, status); > > + if (status->status < 0) > > + return; > > + rule->fdir_qid =3D atoi(tokens[ti]); > > + /* validating portid and queueid */ > > + status_p =3D check_flow_params(rule->fdir_portid, > > + rule->fdir_qid); > > + if (status_p < 0) { > > + printf("port id %u / queue id %u is not valid\n", > > + rule->fdir_portid, rule->fdir_qid); > > + } > > + continue; > > + } > > > > /* unrecognizeable input */ > > APP_CHECK(0, status, "unrecognized input \"%s\"", @@ -823,6 > > +846,9 @@ print_one_sa_rule(const struct ipsec_sa *sa, int inbound) > > break; > > } > > } > > + if (sa->fdir_flag =3D=3D 1) > > + printf("flow-direction %d %d", sa->fdir_portid, sa->fdir_qid); > > + > > printf("\n"); > > } > > > > @@ -1153,7 +1179,15 @@ sa_add_rules(struct sa_ctx *sa_ctx, const > > struct ipsec_sa entries[], > > return -EINVAL; > > } > > } > > - > > + if (sa->fdir_flag && > > + ips->type =3D=3D > > + RTE_SECURITY_ACTION_TYPE_LOOKASIDE_PROTOCOL > > && > > + inbound) { > > + rc =3D create_ipsec_esp_flow(sa); > > + if (rc !=3D 0) > > + RTE_LOG(ERR, IPSEC_ESP, > > + "create_ipsec_esp flow failed\n"); > > + } > > print_one_sa_rule(sa, inbound); > > } > > > > @@ -1256,6 +1290,20 @@ fill_ipsec_session(struct rte_ipsec_session > > *ss, struct rte_ipsec_sa *sa) > > return rc; > > } > > > > +int > > +check_fdir_configured(uint16_t portid) { > > + struct ipsec_sa *sa =3D NULL; > > + uint32_t idx_sa =3D 0; > > + > > + for (idx_sa =3D 0; idx_sa < nb_sa_in; idx_sa++) { > > + sa =3D &sa_in[idx_sa]; > > + if (sa->fdir_portid =3D=3D portid) > > + return sa->fdir_flag; > > + } > > + return 0; > > +} > > + > > /* > > * Initialise related rte_ipsec_sa object. > > */ > > -- > > 2.17.1