From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7DF35A046B for ; Fri, 28 Jun 2019 13:34:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0DC652BA5; Fri, 28 Jun 2019 13:34:36 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id EF21DF04; Fri, 28 Jun 2019 13:34:33 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x5SBUO3I017383; Fri, 28 Jun 2019 04:34:32 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=K8YPTaLfRBw11AIYkXXC+/Q7KJTUp6a5PuZffkWHCFM=; b=RwcjSyT+oTufI0TAKUZyla0NZmaSXM7+tNHbMJP3XP4xcmo5O1un/E8u2QWFGfNczv1C w51CvTn40TXx00X32BZWiJpdHDPXM+JhFywqt6d4ZxpRV7GuMQKOkgi231q3UaUK6sTK xjbZRbNjKfyNI5LMH5XogGRvwJqHAxFO4F0LdxgduxsKqeLeqRJgPJMOJEpp0tHw5Yll KjzqODlvqqw1cehocpzu0VfXxKP34FRt+BZgK6fJY/cNSDqBuS72LDIgBJhS+JI7eZG8 1CGHjnWOvAx3iQ0sUlNH/Uw3TqOBHBM9HCqNaly1xxfbm+zRKCbcS4bnrXhmCyGy2aJY 9Q== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0a-0016f401.pphosted.com with ESMTP id 2tdd7790rk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Fri, 28 Jun 2019 04:34:32 -0700 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Fri, 28 Jun 2019 04:34:31 -0700 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.55) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Fri, 28 Jun 2019 04:34:31 -0700 ARC-Seal: i=1; a=rsa-sha256; s=testarcselector01; d=microsoft.com; cv=none; b=PpWh9XmGEzHvz42YhMPL59PYDKnigh/usx5dsxTrfm2qXU93GeEbIUVP0DZ509+6Uv8KvF+GkLHKWrA9FcYLe7u96lgMPt4vshu78NDKsNYlZ39XMjeEiHgYxphgvC/8jVMPYAG8xjeIbTKoxRFSJ3oYOUJJRRybDLA45behYDY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=testarcselector01; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K8YPTaLfRBw11AIYkXXC+/Q7KJTUp6a5PuZffkWHCFM=; b=w8D2p5AU1amds+GqW7iJ7pUMRe5I6AAD1tFh407njLDvGF8Pi+rQ10RLeUd06FdUUzl0RkMNoQC5FCUGic0BRpNzbjb1339DzuPtGT8AXqixkrfkvMunJTNRjTCZUJ2DvjVPFZptCm1wpGN98k9/Pj0ylU9wtRX6muSkYNXqgQE= ARC-Authentication-Results: i=1; test.office365.com 1;spf=none;dmarc=none;dkim=none;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K8YPTaLfRBw11AIYkXXC+/Q7KJTUp6a5PuZffkWHCFM=; b=THAEV0YXtd83AyR8UWFGCP+vHru1qEqR7KB+SyJ7RRwzqSUW0NDcwzOLammpJdss8SR5mg9v9MqxT5GLX3DOEGT3Lz8eKmiJDk1HnorGVJ4igNBOJiKKrsV7wRiDaTKhc+g4riDC28wa4QQFBbpQANlBAZb/UEr+yATVbgxfG3g= Received: from MN2PR18MB2877.namprd18.prod.outlook.com (20.179.20.218) by MN2PR18MB2559.namprd18.prod.outlook.com (20.179.84.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2008.16; Fri, 28 Jun 2019 11:34:30 +0000 Received: from MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::595e:3b6c:3d12:7285]) by MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::595e:3b6c:3d12:7285%7]) with mapi id 15.20.2008.018; Fri, 28 Jun 2019 11:34:30 +0000 From: Anoob Joseph To: Thomas Monjalon , Jerin Jacob Kollanukkaran CC: "dev@dpdk.org" , =?iso-8859-1?Q?Mattias_R=F6nnblom?= , Nikhil Rao , "Erik Gabriel Carrillo" , Abhinandan Gujjar , Bruce Richardson , Pablo de Lara , Narayana Prasad Raju Athreya , Lukas Bartosik , "Pavan Nikhilesh Bhagavatula" , Hemant Agrawal , Nipun Gupta , Harry van Haaren , Liang Ma , "techboard@dpdk.org" Thread-Topic: [EXT] Re: [dpdk-dev] [PATCH 00/39] adding eventmode helper library Thread-Index: AQHVLY0kqrMRpyEGyUiXLRuegHF0Yaawx6Ow Date: Fri, 28 Jun 2019 11:34:29 +0000 Message-ID: References: <2775383.qy1u6QUkDx@xps> In-Reply-To: <2775383.qy1u6QUkDx@xps> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2d592e01-5ef6-48c3-9084-08d6fbbc959e x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:MN2PR18MB2559; x-ms-traffictypediagnostic: MN2PR18MB2559: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 00826B6158 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(376002)(136003)(39850400004)(366004)(346002)(189003)(199004)(13464003)(316002)(26005)(5660300002)(73956011)(66556008)(64756008)(66476007)(66946007)(66446008)(6246003)(52536014)(9686003)(7416002)(14454004)(76116006)(68736007)(7696005)(55016002)(6116002)(186003)(76176011)(54906003)(110136005)(256004)(6636002)(66066001)(486006)(446003)(11346002)(476003)(305945005)(4326008)(102836004)(3846002)(6436002)(33656002)(55236004)(99286004)(7736002)(8676002)(71200400001)(71190400001)(478600001)(6506007)(86362001)(561944003)(53546011)(8936002)(53936002)(229853002)(74316002)(25786009)(81166006)(2906002)(81156014); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB2559; H:MN2PR18MB2877.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: fqOtJs0XSyy50NRnHxnmZAwE0LDCKTRe88veJczSSQ4VKm+MVuOzRrt0BIp9YRRh7k7ADuBC+k43TObzz9+lzB05KA7THvDHHNbbYxNUnkEvZlsYUozgyq4gam3hsfG/hXRNWIgbZVnNCd8/UvlNpZr6U1VDTRAS4bzULm0JvKtWLhVyfsxHJMK4/SJJflwME60Qv9ePWTMUAeqrkApsrIE+h37KuLAOkAen8J6fZhHRQ6aacU10/kc5ElzUhpE8DwU3t6t9RtaAKyBAqGypwOKE8haom4dkwnacOJ65If3hh4vnlIla3O9vny1te7SRqYJdQ/AjFh6ZpM8x3AaJkQD9S6rD1gY6X6Qmc2LSIdefA3wVDIhKDtzi9bUFPozU7osa0KOhmy/z6TAtNcHluRpGGMyOeG3Jc5e3lX5D6C8= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 2d592e01-5ef6-48c3-9084-08d6fbbc959e X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jun 2019 11:34:30.0265 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: anoobj@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2559 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-06-28_04:, , signatures=0 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH 00/39] adding eventmode helper library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, Jerin, > -----Original Message----- > From: dev On Behalf Of Thomas Monjalon > Sent: Friday, June 28, 2019 2:10 PM > To: Jerin Jacob Kollanukkaran ; Anoob Joseph > > Cc: dev@dpdk.org; Mattias R=F6nnblom ; > Nikhil Rao ; Erik Gabriel Carrillo > ; Abhinandan Gujjar > ; Bruce Richardson > ; Pablo de Lara > ; Narayana Prasad Raju Athreya > ; Lukas Bartosik ; Pavan > Nikhilesh Bhagavatula ; Hemant Agrawal > ; Nipun Gupta ; Harry > van Haaren ; Liang Ma > ; techboard@dpdk.org > Subject: [EXT] Re: [dpdk-dev] [PATCH 00/39] adding eventmode helper > library >=20 > External Email >=20 > ---------------------------------------------------------------------- > 28/06/2019 05:37, Jerin Jacob Kollanukkaran: > > From: Anoob Joseph > > > From: Jerin Jacob Kollanukkaran > > > > From: Anoob Joseph > > > > > The helper library will be experimental while we add event-mode > > > > > support for other applications like l3fwd & ipsec-secgw. I > > > > > expect the helper library to be complete over the course of > > > > > those applications also using the helper library. >=20 > You are doing a copy of l2fwd example to add event mode. > It was the decision from the techboard to not complicate the original l2f= wd. > But it makes me nervous to see some code duplicated, especially if you pl= an > to do the same for l3fwd and ipsec-secgw. > We are not going to duplicate every examples. We should re-consider. >=20 [Anoob] For l3fwd & ipsec-secgw, the plan is to add eventmode in the origin= al application itself. If you have concerns about code duplication in l2fwd= -event, the changes can be added to l2fwd itself. Please advise on how to p= roceed. =20 > > > > I have only concern about moving this as library inside eventdev > > > > that till we have mature version of helper library the eventdev > > > > library ABI will not stable(i.e .so file version needs to be > > > > incremented as when a change needed). Which align with Mattias > > > > thoughts for some other reason:. How about moving this code to > > > > 1) example/common or > > > > 2) to specific application itself, once at least two applications > > > > starts using it then move to Eventdev library. > > > > > > > > Thoughts? > > > > > > [Anoob] Either location is not a problem if there is a consensus. > > > Earlier the suggestion was to move it to library (when the patch was > > > submitted with changes added in app). >=20 > If there is only one user, making it grow in the application looks to be = the > best thing to do. > Should we use it in more applications before it is more mature? > If not, we could move the code in eventdev library when we will use it in > more examples. >=20 [Anoob] The proposal with l2fwd-event was to present an easy enough example= so that the APIs can be decided before moving onto complex examples. Addit= ions to l3fwd & ipsec-secgw is in the pipeline. > > If there NO objections then lets move to example/common. >=20 > If we really want to have this library standalone in examples, I suggest = to give > it a name and not use a "common" directory. >=20 [Anoob] I would suggest to add the eventmode code in 'examples/utils'. What is being added here can be treated as a utility library. Almost all ex= amples have duplicated code for the entire conf parsing, ethdev init etc. A= nyone who would attempt a new application will have to duplicate lot of cod= e. So a similar exercise with regular poll mode is also possible.=20 As for build, we will have the following options, 1. From the examples//Makefile, build *helper*.o files ( '../utils= /eventmode_helper.o') and prepare the binary. So each application will buil= d its own version of *helper*.c +SRCS-y +=3D ../utils/eventmode_helper.c 2. Make 'examples/utils' a separate library. This way, all applications can= directly link without having to build separately. Please do suggest on which would be a good way to execute. Thanks, Anoob