From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 62379A0524; Fri, 31 Jan 2020 16:05:49 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 052FF1C0CF; Fri, 31 Jan 2020 16:05:49 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 0AE131C0CC for ; Fri, 31 Jan 2020 16:05:47 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 00VEuC3u021910; Fri, 31 Jan 2020 07:05:47 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=iEsAztL3mMGZO4BjWu+mC5k1YY+Un1yS5uqeZFAc7zk=; b=eV+eHfQXeNyWj7inTcGiSqsgj4A5SjudybhsWkr55DGc+R/bhjX9SgcAkdiJNjq2MsQM K9DN9nh33ku/q2TY5W9APKImy5/Gx/MQweLVqaYxFuDGPaTZHYGLaurU52iuf6wGiXfT TNCnuTYDGQqM3XHIA2LDvRcK1jnovV4L6z8Zi9UP9ij4MIAn79rR75vkhSUQm5xzmf4z 6f0WiU5cwN1n+jvVyxqAxqORSw0w7Mz8/fk+Eu3Sw0ANN5Zf6gcLeEKeECkEh7vWx7aX KKtzBBBynQQr/Ht5wKtNqePwcAxM4K1JtxpVXWpYc5a22WHW2AVV4VAXhYL4qMcQx8Nw DQ== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0b-0016f401.pphosted.com with ESMTP id 2xrp2tm2kr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Fri, 31 Jan 2020 07:05:47 -0800 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 31 Jan 2020 07:05:44 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Fri, 31 Jan 2020 07:05:44 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Tjzaal/A1t7n9opIt1IwoGhvJ5s5tSmSdIOtZB7HhFQ8PnRm4fBLbTEwsPWZpXB159NKuCg6hymjM3rx8bqut0k5zsvWK0YpsIhqJkXN39CS493xWCc+q433ZPoUTtATfrwcsnTj4PZYj1RuvzyGEdBBY8hoySXZDEwJMjpCKK381GfAfyXT/PGZ6WtN2y/qMyfCi/5hUUDkZ/wGJmNZN/LWpks/gGeeV+PndNiepGanQkFY0ILtgSirjVWt4RJEWOTX+JDnFSr621XpLwiBlsUwoZZR57hH+FJ/Eyreb1Hnnx1FleTaWC2S5/0N0hNxNHT4dmxjKA5fpPaLT7H1lQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iEsAztL3mMGZO4BjWu+mC5k1YY+Un1yS5uqeZFAc7zk=; b=KBQkp1b7EF4PVNgCvOzQmIBLbfd5RSYaqGAID3UrKHY7eicqStGaQeQjOaJGzp1Kb9Vz8u3PJ+B3kdJwQOue9/gtKoJEvLBe6WNc+Jb/AzXU4+Md8Go4twzCvLIez9I2Kb9QCRSiXJfW13DQKXe1vGwKctEBiwuRRWOIAQUJU0ujPXGZTBTFW+Kt99jw264LJcNfN/e1AMcCKZL9cMMZfPZ88EQN78F2qm0JuSLtCsaPOb7HwRW+RNsndjYLp68AxkQhBIe+nE0MF5lhcJ0PRRiIB8Pqjg7RRzGbsXJ6hhD1OhYPTyIT5IehOHLuz5ZpIRw5TzJ8BmvXUsi7/Q11zA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iEsAztL3mMGZO4BjWu+mC5k1YY+Un1yS5uqeZFAc7zk=; b=gKlyOnBtmC7zyuvcYNut/tHvKrUvZk89l8ePYfYRbWQM8bCLCJHZ6iZD3emyoSeMbvAPnfn9MVWMGrMAqQUz9Pny76Fyx/f2yIpHEsGLuR1uqLqbk2DcXwCVkxAw9PAxVekPW2JLWK0jqlAYUxpdemt/sCB/vjJd7XYA/92gJG4= Received: from MN2PR18MB2877.namprd18.prod.outlook.com (20.179.20.218) by MN2PR18MB2415.namprd18.prod.outlook.com (20.179.81.205) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2686.26; Fri, 31 Jan 2020 15:05:43 +0000 Received: from MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::e48d:494:fc46:3572]) by MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::e48d:494:fc46:3572%7]) with mapi id 15.20.2686.028; Fri, 31 Jan 2020 15:05:43 +0000 From: Anoob Joseph To: Akhil Goyal , Declan Doherty , Thomas Monjalon CC: Tejasree Kondoj , Jerin Jacob Kollanukkaran , Narayana Prasad Raju Athreya , Kiran Kumar Kokkilagadda , Nithin Kumar Dabilpuram , Pavan Nikhilesh Bhagavatula , Ankur Dwivedi , "Archana Muniganti" , Vamsi Krishna Attunuru , Lukas Bartosik , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 11/15] net/octeontx2: add inline ipsec Rx path changes Thread-Index: AQHV2DvWO++2GxKmr0C4Pc0Qml25cKgE3gCw Date: Fri, 31 Jan 2020 15:05:42 +0000 Message-ID: References: <1579344553-11428-1-git-send-email-anoobj@marvell.com> <1580465035-30455-1-git-send-email-anoobj@marvell.com> <1580465035-30455-12-git-send-email-anoobj@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [27.34.250.227] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d3263fe7-8613-4aef-6958-08d7a65f0ad5 x-ms-traffictypediagnostic: MN2PR18MB2415: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 029976C540 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(346002)(136003)(396003)(376002)(366004)(199004)(189003)(9686003)(2906002)(64756008)(5660300002)(33656002)(316002)(26005)(66556008)(66476007)(66446008)(52536014)(110136005)(54906003)(7696005)(4326008)(53546011)(66946007)(55016002)(186003)(6506007)(8936002)(71200400001)(76116006)(86362001)(81166006)(478600001)(81156014); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB2415; H:MN2PR18MB2877.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: plJ4GSW/D+IBQjNCkVpa742fq+CzGELGHes+l8cU9NpV/i+8nWaQQiGaYF4YXlb73AVPClHZi9OeGEb0YfRhz9kq2EJeOrZKJwDfxgvjo2Th7OI26lJz3b8me1olykaMFZqdqhf5X8DQYc1e9uY9As+S+SNpNAA5vicQfRpIR42bR7NiWUDZfz36ffi+IdbFkg8xKuqdKXjUm/TtA6h4OZnukHb/sHDeTHJYn4Oq8657mF9EnTypczBBTtw0PgWPgtM/lNtg+PfkAiYGpdxuSCtgYtI+OpZ2lBdewswf5mKXEzuYyLOkHeVKZE9fledmPAlqJqaMKlnY6ujowtoCFUcBhOXjWr0gcHlDgajAmAAZaeFVxhvHNdDXQniqEV5pMXhPfw7dnkwvO+Kumd3myBW04a1s4eZP4eOGV06SkXmHoy5VfDCMobLO0y0pEEeW x-ms-exchange-antispam-messagedata: wr01ovBNPpdbbcAakZLa4Ep/Azq61MXMo4PcqU0YlqwMZxuUJAymbW4XnAKWEZ7v1LQkm3W/Nf3Q5upd6HiGjy0tSzdwqs3GeO2nYXxNO+WnFA+6ENNuSDj0Ng7nY2ek59f7ZoOssBiq6b+FvrdP8Q== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: d3263fe7-8613-4aef-6958-08d7a65f0ad5 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jan 2020 15:05:42.8717 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QYvk1wr4Kbl9WKnkfsgEgUlOc1DkSu0BJua2avq5rEyRwJXAh7wBbvpC1kE6b2Cr69Rqs7m4pFAAtKzLv64W7A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2415 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.572 definitions=2020-01-31_03:2020-01-31, 2020-01-31 signatures=0 Subject: Re: [dpdk-dev] [PATCH v3 11/15] net/octeontx2: add inline ipsec Rx path changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, Please see inline. Thanks, Anoob > -----Original Message----- > From: dev On Behalf Of Akhil Goyal > Sent: Friday, January 31, 2020 7:09 PM > To: Anoob Joseph ; Declan Doherty > ; Thomas Monjalon > Cc: Tejasree Kondoj ; Jerin Jacob Kollanukkaran > ; Narayana Prasad Raju Athreya > ; Kiran Kumar Kokkilagadda > ; Nithin Kumar Dabilpuram > ; Pavan Nikhilesh Bhagavatula > ; Ankur Dwivedi ; > Archana Muniganti ; Vamsi Krishna Attunuru > ; Lukas Bartosik ; > dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 11/15] net/octeontx2: add inline ipsec = Rx > path changes >=20 > Hi Anoob, > > > > From: Tejasree Kondoj > > > > Adding post-processing required for inline IPsec inbound packets. > > > > Signed-off-by: Ankur Dwivedi > > Signed-off-by: Anoob Joseph > > Signed-off-by: Archana Muniganti > > Signed-off-by: Tejasree Kondoj > > Signed-off-by: Vamsi Attunuru > > --- > > drivers/crypto/octeontx2/Makefile | 3 +- > > drivers/crypto/octeontx2/meson.build | 2 + > > drivers/event/octeontx2/Makefile | 1 + > > drivers/event/octeontx2/meson.build | 2 + > > drivers/net/octeontx2/otx2_rx.h | 73 > > ++++++++++++++++++++++++++++++++++++ > > 5 files changed, 80 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/crypto/octeontx2/Makefile > > b/drivers/crypto/octeontx2/Makefile > > index 3ba67ed..1458e2b 100644 > > --- a/drivers/crypto/octeontx2/Makefile > > +++ b/drivers/crypto/octeontx2/Makefile > > @@ -11,7 +11,7 @@ LIB =3D librte_pmd_octeontx2_crypto.a CFLAGS +=3D > > $(WERROR_FLAGS) > > > > LDLIBS +=3D -lrte_eal -lrte_ethdev -lrte_mbuf -lrte_mempool -lrte_ring > > -LDLIBS +=3D -lrte_cryptodev > > +LDLIBS +=3D -lrte_cryptodev -lrte_security > > LDLIBS +=3D -lrte_pci -lrte_bus_pci > > LDLIBS +=3D -lrte_common_cpt -lrte_common_octeontx2 > > > > @@ -20,6 +20,7 @@ VPATH +=3D $(RTE_SDK)/drivers/crypto/octeontx2 > > CFLAGS +=3D -O3 > > CFLAGS +=3D -I$(RTE_SDK)/drivers/common/cpt CFLAGS +=3D > > -I$(RTE_SDK)/drivers/common/octeontx2 > > +CFLAGS +=3D -I$(RTE_SDK)/drivers/crypto/octeontx2 >=20 > Why do you need to include self path for the driver? [Anoob] Well this is interesting. I cannot explain this but when I'm buildi= ng otx2_cryptodev*.c files which include otx2_ethdev_sec.h, it's throwing a= n error that otx2_ipsec_fp.h is not found (in case of shared build and meso= n, I guess). The file otx2_ethdev_sec.h is in net/octeontx2 and it includes= otx2_ipsec_fp.h which is in crypto/octeontx2. I'll cross check and let you know if it's needed in both Makefile & meson. =20 >=20 > > CFLAGS +=3D -I$(RTE_SDK)/drivers/mempool/octeontx2 > > CFLAGS +=3D -I$(RTE_SDK)/drivers/net/octeontx2 > > CFLAGS +=3D -DALLOW_EXPERIMENTAL_API > > diff --git a/drivers/crypto/octeontx2/meson.build > > b/drivers/crypto/octeontx2/meson.build > > index 67deca3..a531799 100644 > > --- a/drivers/crypto/octeontx2/meson.build > > +++ b/drivers/crypto/octeontx2/meson.build > > @@ -9,6 +9,7 @@ deps +=3D ['bus_pci'] > > deps +=3D ['common_cpt'] > > deps +=3D ['common_octeontx2'] > > deps +=3D ['ethdev'] > > +deps +=3D ['security'] > > name =3D 'octeontx2_crypto' > > > > allow_experimental_apis =3D true > > @@ -32,5 +33,6 @@ endforeach > > > > includes +=3D include_directories('../../common/cpt') > > includes +=3D include_directories('../../common/octeontx2') > > +includes +=3D include_directories('../../crypto/octeontx2') >=20 > Same here. >=20 > > includes +=3D include_directories('../../mempool/octeontx2') > > includes +=3D include_directories('../../net/octeontx2') > > diff --git a/drivers/event/octeontx2/Makefile > > b/drivers/event/octeontx2/Makefile > > index 6dab69c..bcd22ee 100644 > > --- a/drivers/event/octeontx2/Makefile > > +++ b/drivers/event/octeontx2/Makefile > > @@ -11,6 +11,7 @@ LIB =3D librte_pmd_octeontx2_event.a > > > > CFLAGS +=3D $(WERROR_FLAGS) > > CFLAGS +=3D -I$(RTE_SDK)/drivers/common/octeontx2 > > +CFLAGS +=3D -I$(RTE_SDK)/drivers/crypto/octeontx2 > > CFLAGS +=3D -I$(RTE_SDK)/drivers/mempool/octeontx2 > > CFLAGS +=3D -I$(RTE_SDK)/drivers/event/octeontx2 > > CFLAGS +=3D -I$(RTE_SDK)/drivers/net/octeontx2 > > diff --git a/drivers/event/octeontx2/meson.build > > b/drivers/event/octeontx2/meson.build > > index 807818b..56febb8 100644 > > --- a/drivers/event/octeontx2/meson.build > > +++ b/drivers/event/octeontx2/meson.build > > @@ -32,3 +32,5 @@ foreach flag: extra_flags endforeach > > > > deps +=3D ['bus_pci', 'common_octeontx2', 'mempool_octeontx2', > > 'pmd_octeontx2'] > > + > > +includes +=3D include_directories('../../crypto/octeontx2')