From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id E14E0A0471 for ; Mon, 17 Jun 2019 07:27:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2A7291BDD0; Mon, 17 Jun 2019 07:27:34 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id CCA241BD6E for ; Mon, 17 Jun 2019 07:27:30 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x5H5RH4n021360; Sun, 16 Jun 2019 22:27:30 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=/LdqUCsmMKJK6GSawywifZc1zs5QN0DVmKzHZ+8JbK0=; b=CdG3IsZC0q9zG/cTLi+xmz6d7lU7Ow03Q6xg22NGmuO/Wz341y4CDzrva/jl47l9v0um aragcjX4zp7MHnZA4yd5ynUWZbchd33UfE9G8gwL0/DbYynnLAJ+33azzzOhdAqTyz8K H8qRUPmALFijDvtdRjDdlWV6/u3f9xxHhfNO98+7twwds3NiQLr3RG30xm5gX8ZPNf2F NUoQ0ggQgivy2fJvtSmIE/1rU3fIRHF4i/8T+cghWPFM0h6S5m5Focp2QWzs0WW9p0St pvMvxVdrysF+fCXyE8nvc68PPD85FzMXjT6vkJVx/sIY15QRrtHNrKQRfuqcHs+iD2Zd EA== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0b-0016f401.pphosted.com with ESMTP id 2t506hwcvc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Sun, 16 Jun 2019 22:27:29 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Sun, 16 Jun 2019 22:27:28 -0700 Received: from NAM05-DM3-obe.outbound.protection.outlook.com (104.47.49.57) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Sun, 16 Jun 2019 22:27:28 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/LdqUCsmMKJK6GSawywifZc1zs5QN0DVmKzHZ+8JbK0=; b=J/wclIGgn/t/UOIpRTJS+tiXR4BswoXz9wx8BhMAMB3Vux0OmpykwdPri+29mgm+H6YKMCJaB3EK4+FkEKKs6YuDs3QsxbLmlngF94DJ8HQiBfC6/w/2IWwMw17/tK4wAXjAWXAEV44wzdqbY4n67qwZwFJKLdITSs0y3lpfU6Y= Received: from MN2PR18MB2877.namprd18.prod.outlook.com (20.179.20.218) by MN2PR18MB3040.namprd18.prod.outlook.com (20.179.84.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1987.11; Mon, 17 Jun 2019 05:27:26 +0000 Received: from MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::3d9b:ed4b:b155:9bad]) by MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::3d9b:ed4b:b155:9bad%3]) with mapi id 15.20.1987.014; Mon, 17 Jun 2019 05:27:26 +0000 From: Anoob Joseph To: Neil Horman , "dev@dpdk.org" CC: Jerin Jacob Kollanukkaran , Bruce Richardson , Thomas Monjalon Thread-Topic: [EXT] [PATCH v1 7/9] cpt: mark internal functions with __rte_internal Thread-Index: AQHVIV79K2j743Ud6kSO4A1JBCDDtaafVlbQ Date: Mon, 17 Jun 2019 05:27:26 +0000 Message-ID: References: <20190525184346.27932-1-nhorman@tuxdriver.com> <20190612203903.16565-1-nhorman@tuxdriver.com> <20190612203903.16565-8-nhorman@tuxdriver.com> In-Reply-To: <20190612203903.16565-8-nhorman@tuxdriver.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bc9b88d8-cd3f-48a1-7ea7-08d6f2e47c26 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:MN2PR18MB3040; x-ms-traffictypediagnostic: MN2PR18MB3040: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:337; x-forefront-prvs: 0071BFA85B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(136003)(376002)(366004)(346002)(39840400004)(189003)(199004)(13464003)(186003)(4326008)(33656002)(256004)(52536014)(66946007)(8936002)(7696005)(5660300002)(66476007)(99286004)(54906003)(66556008)(64756008)(66446008)(68736007)(76116006)(476003)(102836004)(316002)(110136005)(486006)(11346002)(6436002)(446003)(6506007)(53546011)(14454004)(478600001)(3846002)(6116002)(55236004)(71190400001)(25786009)(73956011)(7736002)(71200400001)(66066001)(74316002)(229853002)(26005)(9686003)(53936002)(86362001)(8676002)(2501003)(305945005)(6246003)(81166006)(81156014)(76176011)(2906002)(55016002); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB3040; H:MN2PR18MB2877.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: BEdkHUf59qCYQJffWmASVqUNetlONrRdbY/s2juc9g/0DJnwe2ewdwjE02a0brsQx2JJLKfQrbzymLbxNb3EKS81rDqGQnx1GCiHsv0DFlAHka4dQjgG7YJzQjwgUxJ5NP0WiKJjchv5WfNidLNSe/EsS5DlCuAty5JtroaCJIcW4OcbO1wZ7Tn8cOuEtmpNUM5idCkVFpy0sZ+PT//5i8RJexW8Cj/8/dY/cH6z7tD/GCctX1njq+lXBzNW51s5IQ9AFe6RCN46fRT5Mu5PJMR3IVFz6Hbow1a+e5q3VAP5dMXtMmHfCdDh7dCndQDObt3kyvAKoDdXmpXW2oANq+0mEn5QYruc9wnX0C79/L7u9mHraiy9unI7wZF6cEH/9fqkqi4E7TxSy1oIMLQjeWgcqkwfrjNwXkt0MY14o9I= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: bc9b88d8-cd3f-48a1-7ea7-08d6f2e47c26 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jun 2019 05:27:26.6927 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: anoobj@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB3040 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-06-17_03:, , signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH v1 7/9] cpt: mark internal functions with __rte_internal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Neil Horman > Sent: Thursday, June 13, 2019 2:09 AM > To: dev@dpdk.org > Cc: Neil Horman ; Jerin Jacob Kollanukkaran > ; Bruce Richardson ; > Thomas Monjalon ; Anoob Joseph > > Subject: [EXT] [PATCH v1 7/9] cpt: mark internal functions with > __rte_internal >=20 > External Email >=20 > ---------------------------------------------------------------------- > Identify functions in the cpt driver which are internal (based on their n= ot > having an rte_ prefix) and tag them with __rte_internal >=20 > Signed-off-by: Neil Horman > CC: Jerin Jacob Kollanukkaran > CC: Bruce Richardson > CC: Thomas Monjalon > CC: Anoob Joseph > --- > drivers/common/cpt/cpt_pmd_ops_helper.c | 4 ++-- > drivers/common/cpt/cpt_pmd_ops_helper.h | 4 ++-- > drivers/common/cpt/rte_common_cpt_version.map | 6 +++++- > 3 files changed, 9 insertions(+), 5 deletions(-) >=20 > diff --git a/drivers/common/cpt/cpt_pmd_ops_helper.c > b/drivers/common/cpt/cpt_pmd_ops_helper.c > index 1c18180f8..d8c7add66 100644 > --- a/drivers/common/cpt/cpt_pmd_ops_helper.c > +++ b/drivers/common/cpt/cpt_pmd_ops_helper.c > @@ -13,7 +13,7 @@ > #define CPT_OFFSET_CONTROL_BYTES 8 >=20 > int32_t > -cpt_pmd_ops_helper_get_mlen_direct_mode(void) > +__rte_internal cpt_pmd_ops_helper_get_mlen_direct_mode(void) > { > uint32_t len =3D 0; >=20 > @@ -27,7 +27,7 @@ cpt_pmd_ops_helper_get_mlen_direct_mode(void) > } >=20 > int > -cpt_pmd_ops_helper_get_mlen_sg_mode(void) > +__rte_internal cpt_pmd_ops_helper_get_mlen_sg_mode(void) > { > uint32_t len =3D 0; >=20 > diff --git a/drivers/common/cpt/cpt_pmd_ops_helper.h > b/drivers/common/cpt/cpt_pmd_ops_helper.h > index dd32f9a40..314e3871b 100644 > --- a/drivers/common/cpt/cpt_pmd_ops_helper.h > +++ b/drivers/common/cpt/cpt_pmd_ops_helper.h > @@ -20,7 +20,7 @@ > */ >=20 > int32_t > -cpt_pmd_ops_helper_get_mlen_direct_mode(void); > +__rte_internal cpt_pmd_ops_helper_get_mlen_direct_mode(void); >=20 > /* > * Get size of contiguous meta buffer to be allocated when working in > scatter @@ -30,5 +30,5 @@ > cpt_pmd_ops_helper_get_mlen_direct_mode(void); > * - length > */ > int > -cpt_pmd_ops_helper_get_mlen_sg_mode(void); > +__rte_internal cpt_pmd_ops_helper_get_mlen_sg_mode(void); > #endif /* _CPT_PMD_OPS_HELPER_H_ */ > diff --git a/drivers/common/cpt/rte_common_cpt_version.map > b/drivers/common/cpt/rte_common_cpt_version.map > index dec614f0d..7459d551b 100644 > --- a/drivers/common/cpt/rte_common_cpt_version.map > +++ b/drivers/common/cpt/rte_common_cpt_version.map > @@ -1,6 +1,10 @@ > -DPDK_18.11 { > +INTERNAL { > global: >=20 > cpt_pmd_ops_helper_get_mlen_direct_mode; > cpt_pmd_ops_helper_get_mlen_sg_mode; > }; > + > +DPDK_18.11 { > + local: *; > +}; > -- > 2.20.1 Acked-by: Anoob Joseph