From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 892B6A0597; Wed, 8 Apr 2020 16:44:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DD9E11C1BD; Wed, 8 Apr 2020 16:44:17 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 13B9E1C18F; Wed, 8 Apr 2020 16:44:15 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 038EQO6c016632; Wed, 8 Apr 2020 07:44:15 -0700 Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-0016f401.pphosted.com with ESMTP id 3091me3k5d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 08 Apr 2020 07:44:15 -0700 Received: from m0045851.ppops.net (m0045851.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 038EiEpl000719; Wed, 8 Apr 2020 07:44:14 -0700 Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0b-0016f401.pphosted.com with ESMTP id 3091me3k5a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 08 Apr 2020 07:44:14 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 8 Apr 2020 07:44:12 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.107) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Wed, 8 Apr 2020 07:44:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lTyTnCKj8/mrKhVCXrdrWskPrpmBHeD5d18pGFBDTuZzXl4cfmexA0WW8xRM3g58GOwoxa5Ttb1NpAAr/QHWlq9Xgy8f8Qrbo9lWPFt5A4JHQ4MTfc4zgtfTSCefRMFRdk2BFn7nqr4HdwBNcUxFWGiNZWr6qlyOkyxO6pU0xmBnzUVI3CqnUJknczrltwgutAm9jIaU6fGqy7Fv1oCfJQ010+w+Nb90egzVq7NVrlPeN8EB3VQW0wP9i0DvrNz0H2vJFCbz2VH9dxl2xfawEDLQ/C4JVYO+W8bODzhddevCbUTm5DtmtZRvvZaqvzG3iO/iuAyFPvFhZEkC2BQnUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h2IF8xnCe1Mkyyb3nrDpZPVKFkM2j/zSHg2IrAPeG2M=; b=mRqWoF05/Ri2tCHsf4EULJtYC8QF1z4Eof/dmzjebY/r1Zw569fAyav9lrF08pyr33Frycrwy+owVsc6KZaSWWwEmVeRuT8Bp9LjDtIW5BdV0kpQ8fcMWKJt6xTEl7HEUf9uniwkOQfkT0Ra7nmlFx56wDCCZDlCJfpilVkkmiV7wtU2O+9cm2WkWAehIQmqoyIGlSinLou0XjZVeDhU3psPuwIVdNXlWmqJ1KdMfOfXbTfYhxIDJ00S/8Vf3Tmo8WG2eZvNdawssqeeQkpYzC4swX9RTHzkO1I9DfZJGyhSzTSdWmgadaoMF6X/UtwxtLTYByhqtJoyNxT6JRNMVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h2IF8xnCe1Mkyyb3nrDpZPVKFkM2j/zSHg2IrAPeG2M=; b=OHkTMWr1Y3iepEUV0FyklJt1XFzFYoD8xYrNgCH1zbXINdYERKt0NYQ6+KN1oGqzc88oxkdvyL2Whr8Mf3vEZhDp6EMnwvqajMlKk2oJfu+4alVQUINjHpI2yRMUxY6Q10gjnqGwg4h4QRJ4F71BjkKghb+v9OEIlLSSQ8lFnXY= Received: from MN2PR18MB2877.namprd18.prod.outlook.com (2603:10b6:208:3b::26) by MN2PR18MB3637.namprd18.prod.outlook.com (2603:10b6:208:24e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.20; Wed, 8 Apr 2020 14:44:11 +0000 Received: from MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::648f:e7fa:f95e:191b]) by MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::648f:e7fa:f95e:191b%2]) with mapi id 15.20.2878.022; Wed, 8 Apr 2020 14:44:11 +0000 From: Anoob Joseph <anoobj@marvell.com> To: Thomas Monjalon <thomas@monjalon.net>, Lukasz Wojciechowski <l.wojciechow@partner.samsung.com> CC: Akhil Goyal <akhil.goyal@nxp.com>, Declan Doherty <declan.doherty@intel.com>, Aviad Yehezkel <aviadye@mellanox.com>, "Boris Pismenny" <borisp@mellanox.com>, Radu Nicolau <radu.nicolau@intel.com>, Anoob Joseph <anoob.joseph@caviumnetworks.com>, "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org> Thread-Topic: [EXT] Re: [dpdk-dev] [PATCH v2 01/13] security: fix verification of parameters Thread-Index: AQHWDaldfaVwulFPXEGlKDBrrrHfiahvS0RA Date: Wed, 8 Apr 2020 14:44:10 +0000 Message-ID: <MN2PR18MB2877F5455CF2C6C51B0AAE4BDFC00@MN2PR18MB2877.namprd18.prod.outlook.com> References: <20200312151654.7218-1-l.wojciechow@partner.samsung.com> <1875710.PYKUYFuaPT@thomas> <MN2PR18MB28771B123F21BDFF4CFA6331DFC00@MN2PR18MB2877.namprd18.prod.outlook.com> <8635541.CDJkKcVGEf@thomas> In-Reply-To: <8635541.CDJkKcVGEf@thomas> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [27.34.244.203] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 36f1ad22-ab58-49b1-2f15-08d7dbcb4ce0 x-ms-traffictypediagnostic: MN2PR18MB3637: x-microsoft-antispam-prvs: <MN2PR18MB363771874B11E3902665D565DFC00@MN2PR18MB3637.namprd18.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 0367A50BB1 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR18MB2877.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(136003)(39860400002)(366004)(396003)(346002)(376002)(8936002)(15650500001)(66556008)(7696005)(5660300002)(52536014)(4326008)(33656002)(9686003)(966005)(81166007)(86362001)(2906002)(55016002)(478600001)(186003)(71200400001)(66446008)(6506007)(66946007)(19627235002)(54906003)(76116006)(316002)(110136005)(66476007)(7416002)(81156014)(64756008)(26005)(8676002); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: e9P95DVt/W4FTk7C+sYDqUZw1Lh3nQxq3OLXKVcgQtfsb9nlzrixiaJpiqtYglJJ6nrFAsQmGsrycEfXTJFlGtYK74otQTA2nfdd12xQ/M/3t5cMb55vcI0h4LMw9SXlaBunxwrTKHesbZignYfCKNRr5yDyIAzGptLf+Z8+0u9L42+ANqOi4MAAXrn0bjLJP3l8bFS2WkaTpQA0/a22peAvFdd88FO9rfzSkpoCqGgtHU8NDS2I+gfcKZpxbBR/CteFuIR0XR3qXCL0wb6CZP/onhs9TePT5aUBMdrK9u+IzjzGyDsgDpF1SAcVY1/ilRaz/1EjUu/fIFeNYx7UmUDtB1Ngy7UxwDkxKSm4RcfE5wR/GTp4TsHDP0SE+r74P/ZqJj9b/wqj/Vn5cOdj9J+QWmrBbM4AYCBlJx0Xmwp6XrfvI6Z0kUuEttJGd5P9B4PWZeA0oP8VO+MlxgGMTPX+3kqZxLIn9JLBBHaokeb6ijDb3hVmVC1XjP4yldb1d7xGJHMDJfK5sRS9tthTUA== x-ms-exchange-antispam-messagedata: 5Es7HesMvFK0Mkb5NwAPQ/naGMPxrJt4Q76x6b/ZGOiTldLzWhqTiXr8G1UyCOwuQehQlkxHKrg8E+EJ92HcQ1HZVwpNjf3PYXDJ7aQzc8qxV2T3RApS1WfwfXMI+MoVWMFCZT0XhZcpxL1/Qh0ouw== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 36f1ad22-ab58-49b1-2f15-08d7dbcb4ce0 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2020 14:44:10.9639 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3a8cUh0u0uEXnvh7fSGxf6tyLfEIdGuJ1W3YQoTvzPv3uIpnGAyIy/Ou3NRvygmZ0WukEtqUzZCywrrOhaHlVg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB3637 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676 definitions=2020-04-07_10:2020-04-07, 2020-04-07 signatures=0 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v2 01/13] security: fix verification of parameters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Hi Thomas, >=20 > ---------------------------------------------------------------------- > 08/04/2020 15:02, Anoob Joseph: > > Hi Thomas, > > > > > 08/04/2020 05:13, Lukasz Wojciechowski: > > > > This patch adds verification of the parameters to the ret_security > > > > API functions. All required parameters are checked if they are not = NULL. > > > [...] > > > > --- a/config/common_base > > > > +++ b/config/common_base > > > > CONFIG_RTE_LIBRTE_SECURITY=3Dy > > > > +CONFIG_RTE_LIBRTE_SECURITY_DEBUG=3Dn > > > > > > Is it a leftover? > > > > > > > [Anoob] It is similar to 'RTE_LIBRTE_ETHDEV_DEBUG' for usage in > > datapath. Like in, > > https://urldefense.proofpoint.com/v2/url?u=3Dhttp-3A__code.dpdk.org_dpd= k > > _latest_source_lib_librte-5Fethdev_rte-5Fethdev.h-23L4378&d=3DDwICAg&c= =3Dn > > KjWec2b6R0mOyPaz7xtfQ&r=3DjPfB8rwwviRSxyLWs2n6B- > WYLn1v9SyTMrT5EQqh2TU&m=3D > > > STCBgRhcnCb9M6MWQL9CUszLwy2r0NJ_3m93_D5UX3g&s=3DHVsD0LKZ2Q6UCW > BSRvbw9beD > > 7OtuQyWPrRrx9eofnz8&e=3D >=20 > 1/ I don't see it used in this patch [Anoob] Following snippet uses. +#ifdef RTE_LIBRTE_SECURITY_DEBUG + RTE_PTR_CHAIN3_OR_ERR_RET(instance, ops, set_pkt_metadata, -EINVAL, + -ENOTSUP); + RTE_PTR_OR_ERR_RET(sess, -EINVAL); +#endif > 2/ Adding makefile-only option is weird > 3/ Adding new compile-time options is discouraged [Anoob] This is only introduced for data path APIs. And the same approach i= s followed in eth dev as well. Thanks, Anoob