Re: [dpdk-dev] [PATCH v2 07/12] crypto/octeontx2: add enqueue/dequeue ops

[Anoob Joseph <anoobj@marvell.com>]

Hi Gavin,

Thanks for your review and suggestion. I agree with your suggestion and would be taking up the rework. But since we are close to RC1, I would like to defer this to the next release cycle. This change would touch all features supported and hence, will require an extensive QA internally.

Thanks,
Anoob

> -----Original Message-----
> From: Gavin Hu (Arm Technology China) <Gavin.Hu@arm.com>
> Sent: Tuesday, October 15, 2019 4:50 PM
> To: Anoob Joseph <anoobj@marvell.com>; Akhil.goyal@nxp.com; Pablo de
> Lara <pablo.de.lara.guarch@intel.com>
> Cc: Fiona Trahe <fiona.trahe@intel.com>; Jerin Jacob Kollanukkaran
> <jerinj@marvell.com>; Narayana Prasad Raju Athreya
> <pathreya@marvell.com>; Shally Verma <shallyv@marvell.com>; Ankur
> Dwivedi <adwivedi@marvell.com>; Kanaka Durga Kotamarthy
> <kkotamarthy@marvell.com>; Sunila Sahu <ssahu@marvell.com>; Tejasree
> Kondoj <ktejasree@marvell.com>; dev@dpdk.org; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; nd <nd@arm.com>; nd <nd@arm.com>
> Subject: [EXT] RE: [dpdk-dev] [PATCH v2 07/12] crypto/octeontx2: add
> enqueue/dequeue ops
> 
> External Email
> 
> ----------------------------------------------------------------------
> Hi Anoob,
> 
> This is a typical producer-consumer case, enqueue and dequeue operations
> must be conducted in a synchronized way, otherwise stale or earlier-than-
> arrival data will be got.
> Out-of-synchronization issues are more prone to happen on weak memory
> ordered platforms, like arm and PPC, if execution in the program order is
> assumed.
> I see in this patch MOD_INC() and other reads/writes of the indexes might
> get reordered with regard to real enqueue and deque operations, this may
> cause synchronization errors.
> I have a fix for rte ring using C11 to keep synchronized operations, please
> refer to: https://urldefense.proofpoint.com/v2/url?u=http-
> 3A__patches.dpdk.org_patch_47733_&d=DwIFAg&c=nKjWec2b6R0mOyPaz7
> xtfQ&r=jPfB8rwwviRSxyLWs2n6B-WYLn1v9SyTMrT5EQqh2TU&m=-
> CQNFLhmDggI38cEto5lpU668oUfOgbIO8Akw7ViaVM&s=c5-
> AH2gQk6Kqi_AKdacCs0k-w42Qrisy4Ev9SF3fG6w&e=
> /Gavin
> 
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Anoob Joseph
> > Sent: Sunday, October 13, 2019 8:40 PM
> > To: Akhil.goyal@nxp.com; Pablo de Lara
> > <pablo.de.lara.guarch@intel.com>
> > Cc: Anoob Joseph <anoobj@marvell.com>; Fiona Trahe
> > <fiona.trahe@intel.com>; jerinj@marvell.com; Narayana Prasad
> > <pathreya@marvell.com>; Shally Verma <shallyv@marvell.com>; Ankur
> > Dwivedi <adwivedi@marvell.com>; Kanaka Durga Kotamarthy
> > <kkotamarthy@marvell.com>; Sunila Sahu <ssahu@marvell.com>;
> Tejasree
> > Kondoj <ktejasree@marvell.com>; dev@dpdk.org
> > Subject: [dpdk-dev] [PATCH v2 07/12] crypto/octeontx2: add
> > enqueue/dequeue ops
> >
> > This patch adds the enqueue burst and dequeue burst callbacks for the
> > OCTEON TX2 crypto driver.
> 
> <snip>