RE: [PATCH v6] pci: read amd iommu virtual address width

[Michael Piszczek <mpiszczek@ddn.com>]

Hi David,

Sorry I do not have a solution for this. Can you close the patch?

Michael Piszczek

-----Original Message-----
From: David Marchand <david.marchand@redhat.com> 
Sent: Tuesday, August 8, 2023 3:31 AM
To: Michael Piszczek <mpiszczek@ddn.com>
Cc: dev@dpdk.org; Ferruh Yigit <ferruh.yigit@amd.com>
Subject: Re: [PATCH v6] pci: read amd iommu virtual address width

On Tue, Oct 25, 2022 at 1:54 PM David Marchand <david.marchand@redhat.com> wrote:
>
> On Mon, Oct 24, 2022 at 5:35 PM Michael Piszczek <mpiszczek@ddn.com> wrote:
> >
> > Add code to read the virtual address width for AMD processors.
> > Updated pci_device_iommu_support_va() to use glob to find iommu 
> > capability files.
> >
> > Signed-off-by: Michael Piszczek <mpiszczek@ddn.com>
>
> Please have a look at the ci.
>
> Unit tests are failing with this patch because the default is changed 
> from VA to PA.
> A quick way to reproduce is to run vdev unit tests as a normal user in 
> no huge mode.
>
> Before change:
> $ DPDK_TEST=vdev_autotest ./build-gcc/app/test/dpdk-test --no-huge -m
> 2048 --log-level=*:debug
> ...
> EAL: Bus vdev wants IOVA as 'DC'
> EAL: Bus pci wants IOVA as 'DC'
> EAL: Buses did not request a specific IOVA mode.
> EAL: Physical addresses are unavailable, selecting IOVA as VA mode.
> EAL: Selected IOVA mode 'VA'
>
> After change:
> $ DPDK_TEST=vdev_autotest ./build-gcc/app/test/dpdk-test --no-huge -m
> 2048 --log-level=*:debug
> ...
> EAL: Bus vdev wants IOVA as 'DC'
> EAL: Bus pci wants IOVA as 'PA'
> EAL: FATAL: Cannot use IOVA as 'PA' since physical addresses are not 
> available
> EAL: Cannot use IOVA as 'PA' since physical addresses are not 
> available

I got no reply since a few months, marking as "Changes requested" in patchwork.
If you think this is still worth pursuing, please provide a new revision that does not break IOVA default mode (and the CI).

Cc: Ferruh, for info

--
David Marchand