Hello Julien,
On Mon, Aug 7, 2023 at 8:19 AM Julien Hascoet <jhascoet@kalrayinc.com> wrote:
> from my understanding after debugging, in test_refcnt_iter the return value of rte_ring_enqueue is not checked; leading to lack of expected mbufs at the end checks.
>
> Here is some fix proposal that seems to work after running endurance tests for several days:
>
> diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c
> index b4f436b5e2..8a5d26e4f6 100644
> --- a/app/test/test_mbuf.c
> +++ b/app/test/test_mbuf.c
> @@ -1033,12 +1033,17 @@ test_refcnt_iter(unsigned int lcore, unsigned int iter,
> tref += ref;
> if ((ref & 1) != 0) {
> rte_pktmbuf_refcnt_update(m, ref);
> - while (ref-- != 0)
> - rte_ring_enqueue(refcnt_mbuf_ring, m);
> + while (ref-- != 0) {
> + /* retry in case of failure */
> + while (rte_ring_enqueue(refcnt_mbuf_ring, m) != 0)
> + ;
> + }
> } else {
> while (ref-- != 0) {
> rte_pktmbuf_refcnt_update(m, 1);
> - rte_ring_enqueue(refcnt_mbuf_ring, m);
> + /* retry in case of failure */
> + while (rte_ring_enqueue(refcnt_mbuf_ring, m) != 0)
> + ;
> }
> }
> rte_pktmbuf_free(m);
>
> Can you confirm ?
This analysis looks correct (though failing to enqueue in this unit
test seems strange to me).
Could you send a fix with a Fixes: line in the commitlog, and copying
the maintainer?
Thanks.
--
David Marchand