From: Matan Azrad <matan@nvidia.com>
To: "Benoit Ganne (bganne)" <bganne@cisco.com>,
NBU-Contact-Thomas Monjalon <thomas@monjalon.net>,
Matan Azrad <matan@mellanox.com>, Asaf Penso <asafp@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix link state update
Date: Thu, 19 Nov 2020 08:30:20 +0000 [thread overview]
Message-ID: <MW2PR12MB24920E56F2C10AD7765491F2DFE00@MW2PR12MB2492.namprd12.prod.outlook.com> (raw)
In-Reply-To: <CH2PR11MB43270EC572863B7C1B14CA47C1C30@CH2PR11MB4327.namprd11.prod.outlook.com>
+@Asaf Penso
From: Benoit Ganne
> >> 2. To change documentation of ethdev API to say that only link status
> >> is mandatory report. (all others "nice to have" or "best effort"):
> >> This is for you - I suggest to send prior patch to ethdev
> >> for this and let the community to decide.
> > Matan, Benoit, I guess nobody tried to update ethdev API doc yet?
> > I can do it if you prefer.
>
> My understanding was that this [1] was basically saying 'returning UNKNOWN
> is ok'. But if this is not what you had in mind, I'll be glad you can take care of it
> 😊
>
> [1]
> https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmails.dpdk
> .org%2Farchives%2Fdev%2F2020-
> April%2Fthread.html%23161538&data=02%7C01%7Cmatan%40mellanox.c
> om%7Cee2c8eebc00d4ea3106b08d7daf97473%7Ca652971c7d2e4d9ba6a4d149
> 256f461b%7C0%7C0%7C637218637252717747&sdata=JSFaHkmSzE1tWB7
> DqEaqVI5B1pIZuIdDrfw0SFyUE8s%3D&reserved=0
>
> Best
> ben
Hi
Now, when the API is updated that the speed value is best effort using ETH_SPEED_NUM_UNKNOWN new value,
You can go for your approach:
In case the link is up and speed is invalid by kernel we can return link up and ETH_SPEED_NUM_UNKNOWN.
In case applications wants a valid speed they should call the API again.
Need to update it in mlx5 release notes section.
The original patch should be rebased and updated.
Matan
next prev parent reply other threads:[~2020-11-19 8:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 17:24 Benoît Ganne
2020-03-29 7:00 ` Matan Azrad
2020-03-30 9:55 ` Benoit Ganne (bganne)
2020-03-30 10:12 ` Matan Azrad
2020-03-30 12:03 ` Benoit Ganne (bganne)
2020-03-30 13:44 ` Matan Azrad
2020-03-30 13:53 ` Benoit Ganne (bganne)
2020-03-30 16:13 ` Matan Azrad
2020-04-01 10:17 ` Benoit Ganne (bganne)
2020-04-01 12:46 ` Matan Azrad
2020-04-07 12:54 ` Thomas Monjalon
2020-04-07 13:41 ` Benoit Ganne (bganne)
2020-11-19 8:30 ` Matan Azrad [this message]
2020-11-19 14:20 ` [dpdk-dev] [PATCH v2] " Raslan Darawsheh
2020-11-19 16:27 ` Raslan Darawsheh
2020-11-19 17:48 ` Ferruh Yigit
2020-11-19 18:42 ` Thomas Monjalon
2020-11-20 10:51 ` Ferruh Yigit
2020-11-20 13:50 ` Thomas Monjalon
2020-11-20 14:21 ` Ferruh Yigit
2020-11-22 10:03 ` Raslan Darawsheh
2020-11-22 10:04 ` [dpdk-dev] [PATCH v3] net/mlx5: allow unknown link speed Raslan Darawsheh
2020-11-22 12:58 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW2PR12MB24920E56F2C10AD7765491F2DFE00@MW2PR12MB2492.namprd12.prod.outlook.com \
--to=matan@nvidia.com \
--cc=asafp@nvidia.com \
--cc=bganne@cisco.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).