From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0940BA0561; Thu, 18 Mar 2021 11:13:34 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BF032140E45; Thu, 18 Mar 2021 11:13:33 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2072.outbound.protection.outlook.com [40.107.220.72]) by mails.dpdk.org (Postfix) with ESMTP id C8114140E6A for ; Thu, 18 Mar 2021 11:13:31 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZSlA08rVoRXl+V/Ft0op/gMukZ/unTxE66DmqW6sN+wVf6DdYnOXCWKoZVQhC9PogRLL2Rgr5x6Y9va0eMnlQQpbpD9asAY0vBoeKBecAeAQUsRZH++Fqef3NcuS+CTe6iBwK8ybJA2RUn9ZqfXwXLmM4myH4DSLJava8sBXgLX+CqL9pZ9dwAkxtClicmdDOhbo8EP/nhU0H5c14BBX1xpb19sSFNHKYFTB9Aks0KqS6W3Wn8/E5If8Xa/o84naQdiMJRnd/2+RywPxsXRHD7OaXvpZL0lDaSn6tdaJmV9qjmLNYQpZQMpFkYSfEPD2Ay+bYAYcgOwHezEdlsSvAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C4xtnWdnYfGb5fl7BNQFsJBchoXXmUk/11FfzlrQt8I=; b=EmexCIDfPJu/hJLn12SLiL96S6RxXOr51KSyNVv4XNemg/Gov0I64sJz0BAlQOKJqmGrFww+sDaryJ5n1k4g7RIMXznA5vVm7fiOPWozsR4mKKFLOhiyLRyvJjGB3ZkTWLmfRQ7g1gVJ/ppPpdJ4yhnBvVwlzFQfv9FV+kbLYntVreROrmjuajaU/aoVOBf1oNwoIr6JYclJ2d1VC+ojpQypMK8Wya1C5r4dMOLMglfZ0Bva4iq5pTf82QQjqNWspKdNQA+65XYkVgjfGIEFxMMi5htEKY1IJqN9eVvvmuMQwSy/0c7SAghwZtzic50UMHnLM/anfOiJguBUxsgFcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C4xtnWdnYfGb5fl7BNQFsJBchoXXmUk/11FfzlrQt8I=; b=qn2iQXaYlb50lRtK/xztUuDP+wHsGEf/JiWHJLmJatGlty6AtXMRhkB5Xe4C5vrcm3VOERX4Sik8oJMQpd3rKwmMqr3/Jdg7tj9kD4sVTS6Nk33cJUXWsu9ZsqV/y0sIOCzM8JlcCry/dpDvuKYc1z6j/AOYOmJcY4B/BS6H+2h2OmrECAFd8Dpmfwmv4vFDfS3z1LKPJGLwtxJ75DzmM22bTpdo1C8I9cfsNO4y4lwsCv75dlJOsIuMQ9ux+s9FTp2yIpa1OmyWfOuxN4KQDXBWCZ5eQKWTx1QRd1soMENuVN8YM4VKhPKdSqXiFffRbmnaMM4mC5TmB3WFzkvW/g== Received: from MW2PR12MB2492.namprd12.prod.outlook.com (2603:10b6:907:8::19) by MWHPR12MB1776.namprd12.prod.outlook.com (2603:10b6:300:113::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Thu, 18 Mar 2021 10:13:30 +0000 Received: from MW2PR12MB2492.namprd12.prod.outlook.com ([fe80::99f2:8567:2f9e:c351]) by MW2PR12MB2492.namprd12.prod.outlook.com ([fe80::99f2:8567:2f9e:c351%4]) with mapi id 15.20.3890.038; Thu, 18 Mar 2021 10:13:30 +0000 From: Matan Azrad To: NBU-Contact-Thomas Monjalon , "dev@dpdk.org" , Ferruh Yigit , Slava Ovsiienko CC: Shahaf Shuler Thread-Topic: [dpdk-dev] [PATCH v2 2/4] common/mlx5: enable debug logs dynamically Thread-Index: AQHXFMl1d1YwQCj53ESpIoOFzCOYRKqIf16AgAACogCAARK/EA== Date: Thu, 18 Mar 2021 10:13:30 +0000 Message-ID: References: <20210308222855.823670-1-thomas@monjalon.net> <20210309094836.988763-3-thomas@monjalon.net> <51a1b4b9-946d-95f4-632d-791a3553b281@intel.com> <3194774.rGTt1S1Lk1@thomas> In-Reply-To: <3194774.rGTt1S1Lk1@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [216.228.117.191] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 804e773b-cc33-4cc1-eb8b-08d8e9f67aab x-ms-traffictypediagnostic: MWHPR12MB1776: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VCrrbrXhU8MZFSEPQyq0SP8cauzC/70j269mAkkrS1VPh0AEgybEzjr7lyfn/QTOeIHglLbtQXNSby7qDFwrX89OcTugN7JmGnMXes1omCFIHx7qWnp56pgrihd5MUR8qbexn6PhRI2CZ21r68tXKySb3KjgQ8gLGNDSbUQVWhMiKJn2XKQ0kgukuGlmxqYFCLlIdKzC6lwzSPKsS5YIO5JCH17wMMlaiuwE2f9Hsf9IVTmZIBiSvWHKLdS+Ok3V44/B5YnBjlvHH/ahw2ZY/VBiUfjbb0PLWiWci60W9nK/ReJIKbCRJqxCgcJel6Bow5AedLUdkCTiO9o2jmZJVB/O7/SidlH4XE/1bJkte5Ic8FBEfM/54mi2ncrLpXNF6EFYVv2HhkqQ9Gu22OzJLRl7rOX/sJm2G+oxXFZUiBb27Y3aNZ10tw3xxI7xBHoiuZQs2ImK5u0W9qpse4CxS+Ef3u5ITeJwi4eVYH0pfbDfmbSsfyaY5BSrfng0kxr7s1WA79zR7qVvU6vfZpDFDEonCNgNar9vvUjIoMtjOL+eKFEDrK1KZSRmbDqDpotcW7PENkBCLgiKNXQ5idBNxxMskAvjXgXZIqNtbjZMblxVgqCu9XoKq93YRCMmBgp5400ynNxEodfBJyytwOX+vXNWRl0uB3XS1BIN9qgigVyiyeW4Zm+/QDT9s6FfoDQS/hIa1uQYNq89Xd3Uo22F+g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR12MB2492.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(346002)(366004)(376002)(396003)(136003)(66946007)(76116006)(7696005)(66476007)(5660300002)(66446008)(64756008)(8676002)(66556008)(26005)(316002)(478600001)(2906002)(53546011)(6636002)(186003)(38100700001)(966005)(52536014)(86362001)(6506007)(71200400001)(107886003)(55016002)(9686003)(8936002)(33656002)(110136005)(4326008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?h5+csTsWN4ceFr8j1M8OfzvuxszUxiQTbZhLWNXzXQVmtvWRzFWF3S6ZmNJy?= =?us-ascii?Q?pSI9RXxdvR2PcaAVYzsLto6F5Yr6RMFdEvUbRcSW+g7BOdkuh7B/ccWhariQ?= =?us-ascii?Q?6GYZ3tc1H9+08B6UQaPu4F/0xfVIrFp7rejobxiahm74QyHuq56/T3ngVOOc?= =?us-ascii?Q?QcMvsnXcyzSZMyzvpAqUY7OZkmRpOI36yIPn2v0+AFegMg0bzgGZIk3qwWAE?= =?us-ascii?Q?0BYE7Ngn3VfxAc2OOUNe7AYOg3PduV0PQZ1loShIuJN8Pbk6tMsHwy65RfH0?= =?us-ascii?Q?7yHUJH3rgChyyj+QP5Pk68AL14Q57l4J2jr270tXPOMMXt4FhjPscmdvyzgX?= =?us-ascii?Q?MU/IuV6dB/nSvBNhItBEfRLDhrIzAJxRyBVVoIAd8biv1ndZcNzOcKJQZZjY?= =?us-ascii?Q?ld4OdiMNI9EfqOPMY+RDF+TzxnVTHDdPaiu/TIR5MqbSERONAalp8AGhvWdL?= =?us-ascii?Q?rR/wdYcYwVvNsoGv5D3QHT0s71HAqGWRkfP4HI5wWVEcS/hyPl/4hRnTipKY?= =?us-ascii?Q?kkzVQY3icO4swDhtiGArFCLo+2+QgMQYAjZRcoesJ5p7cjL6GR0wTojp1Ubz?= =?us-ascii?Q?hdf2QBbYPhn4A1y+8itFL0dMK/9iK42zBixXpQeoNFiwgQsE+eOSzOxMjTFJ?= =?us-ascii?Q?zD4hzCAJjA8kKEjexqGcSKWjKyr97KhDVL2nphXc4GsDSoZDumjsT6cwxJ0S?= =?us-ascii?Q?CX14n/JzbYEn4pItORt36kqO3MeFn3OG3ZNCSTuWZFjjkZg6ucKBrMotcL+Q?= =?us-ascii?Q?vTSbKqdTwoDRFQwdtFRrvNpwgwNAqOtuNpL4xuXLCIsiYCEtMZRgnegG4uz4?= =?us-ascii?Q?lhk89vUAmq7j99fDm2QzNJAwHBJqC9eQn2hsNBg9turcAOzaGjk5gm9UfX6A?= =?us-ascii?Q?pqRxkgsUtZqPRnFBGd4v1sdCqBtOhObYxGQIqlaLH6CoHw5YJBt2hg9/wThq?= =?us-ascii?Q?ndrSnpvdbzo30rAqOOrvhS0DLiMcnsA6zPFaCmEBdyiqUya0twbSxHJsgNuM?= =?us-ascii?Q?2aEF5UKgL04NPHOmnRZVHIsR2yYRQfaWVfAEJEKBuoPXJ8fG0nkp73Ebj2yw?= =?us-ascii?Q?orDd2ylysvXzvGfL7Q3EnAPi1OyTuk5XjmyJCrISwcZ6sNoeOz4zRecMvvL0?= =?us-ascii?Q?55hsXjQPsLxMP9z2CjzZSHXMT88nhWg0tHGfeDht5EIdvZnHkE6mjSbDFvod?= =?us-ascii?Q?pc2iVH7lZHzuiuO4Of3g9zlQ+b2rnTfQU4q53Zr7Lk7LiaPzV0s4dT6XrDvE?= =?us-ascii?Q?K56z742Zzf3l62Ukv29wolLlhWi52h3XJdowZVNzvevBTEJ03UgUuVWtpSss?= =?us-ascii?Q?VPi38A7mNQQUxgppnPow6EvB?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB2492.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 804e773b-cc33-4cc1-eb8b-08d8e9f67aab X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Mar 2021 10:13:30.0310 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DvXi2t/FJk/HrbbRPcgw0B91Zp1AmmvKVXplvVmNPitPIBkBFrjvG9S3qEcRecbLnvJ4KETh9c/+48+An3WMdg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1776 Subject: Re: [dpdk-dev] [PATCH v2 2/4] common/mlx5: enable debug logs dynamically X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Thomas Monjalon > 17/03/2021 18:39, Ferruh Yigit: > > On 3/9/2021 9:48 AM, Thomas Monjalon wrote: > > > Most debug logs are using DRV_LOG(DEBUG,) but some were using > > > DEBUG(). > > > The macro DEBUG is doing nothing if not compiled with > > > RTE_LIBRTE_MLX5_DEBUG. > > > > > > As it is not used in the data path, the macro DEBUG can be replaced > > > with DRV_LOG. > > > Then all debug logs can be enabled at runtime with: > > > --log-level pmd.net.mlx5:debug > > > > > > Signed-off-by: Thomas Monjalon > > > > Similar comment for the mlx4 one, copying here: > > > > Why 'RTE_LIBRTE_MLX5_DEBUG' exists at first place? > > > > It seems is is used both for data and control path, can you extend the = patch > for: > > 1- Remove #ifdef from control path > > 2- Replace with 'RTE_ETHDEV_DEBUG_RX' & 'RTE_ETHDEV_DEBUG_TX' for > data path, > > please see: > > https://patches.dpdk.org/project/dpdk/list/?series=3D15738 > > 3- Remove 'RTE_LIBRTE_MLX5_DEBUG' completely, if not removed > document it in the > > driver documentation as supported config file > > > > Both for 'mlx4' and 'mlx5', I will continue with existing patch, but > > can it be possible to make additional patches to address above issues? >=20 > Same answer as for mlx4 :) > To me using ETHDEV config macro in PMDs is new, and I think it is out of = scope > for this patch. > But yes I agree it would be a nice improvement. > Matan, Slave, please could you do this change during next month? Yes, good suggestion, will add to our tasks. Thanks Thomas\Ferruh. Matan