DPDK patches and discussions
 help / color / mirror / Atom feed
From: Matan Azrad <matan@nvidia.com>
To: Slava Ovsiienko <viacheslavo@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Raslan Darawsheh <rasland@nvidia.com>, Ori Kam <orika@nvidia.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/mlx4: fix RSS action hash key null pointer
Date: Thu, 8 Apr 2021 09:36:44 +0000	[thread overview]
Message-ID: <MW2PR12MB249299B5D28859BEB6F979B6DF749@MW2PR12MB2492.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20210407153015.32035-1-viacheslavo@nvidia.com>



From: Viacheslav Ovsiienko 
> If RSS action contains non zero hash key length and NULL key buffer pointer the
> default hash key should be used.
> The check for the NULL pointer this was missing in the mlx4 PMD causing
> crash, for example, in testpmd with command:
> 
> flow validate 0 ingress group 0
>   pattern eth / ipv4 / end
>   actions rss queues 0 end key_len 40 / end
> 
> Fixes: ac8d22de2394 ("ethdev: flatten RSS configuration in flow API")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>

  reply	other threads:[~2021-04-08  9:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-07 15:30 Viacheslav Ovsiienko
2021-04-08  9:36 ` Matan Azrad [this message]
2021-04-11 12:35 ` Raslan Darawsheh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MW2PR12MB249299B5D28859BEB6F979B6DF749@MW2PR12MB2492.namprd12.prod.outlook.com \
    --to=matan@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=orika@nvidia.com \
    --cc=rasland@nvidia.com \
    --cc=stable@dpdk.org \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).