From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id ED8D0A04DD; Thu, 26 Nov 2020 19:31:10 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4664FCA4D; Thu, 26 Nov 2020 19:31:09 +0100 (CET) Received: from hqnvemgate24.nvidia.com (hqnvemgate24.nvidia.com [216.228.121.143]) by dpdk.org (Postfix) with ESMTP id C51B6CA48 for ; Thu, 26 Nov 2020 19:31:06 +0100 (CET) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Thu, 26 Nov 2020 10:31:12 -0800 Received: from HQMAIL101.nvidia.com (172.20.187.10) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 26 Nov 2020 18:30:58 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Thu, 26 Nov 2020 18:30:58 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hoggZPxlBVyL5EYFYGF78DPRXDWd0ejAv0C35qNVFY51/5KaHIEGID2BjFdxhFTK3OWkVA+jvEukGxkqkyIS7IiQk3AXPg7L8l885uEs0eDprEd3iQVIJ8B8QIn8HSR6Cvcg9dLVurcloo9kWvASW9sj72w8qGYfIdMUXp6QzcJYY1/uRZ3R6sWJr3TlCWLgC379Akkss+DGNwrceVlUEBjfTtISWxuohKcVKqNOWktA2gF/dKeuMBYN7ON5m1s5LvrCl3SMfzzUieHw7C6PsQQ4miNRZlhGyB7ljh5RGZveZ+B08nXZNr2P6IWoln3VP+cFZ9+HBJwy/Qg0KwEmQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2VKLCOdEfAuyFt5UoYuYk8qwAy51/ELbCaOdk0e9FaE=; b=l7XEAriHL4cskKOZW0nu5qtid/QUDrO+sKcexo6kVfyq47RLQJPu4/JhmSDpXSCz6g6yLp3lKsjgy5DpF68cKaaAgtzFcF0b12cqwIyvIguXwqDFrvrAGZnsXEP5LOfmDfZ+t+54iaEZteyUlvTwG8d32wlETynF+87UynQA6AdW3387CseZ2m65vJjSKlmfHo4tyQqDAIkm7t6mXHYSXeyn2yZbtiuHhAuQexsxSyxv1BDeW0hnPFghs3gwN3wZYuc0LYhPBGDux0h149rhNbLjC48GdV/cEX5V31k/x8tVrgr6fQTK59j/43X1pDch/epgTdr06t6NVhQxCgmZkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from MW2PR12MB2492.namprd12.prod.outlook.com (2603:10b6:907:8::19) by MWHPR1201MB0080.namprd12.prod.outlook.com (2603:10b6:301:54::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3611.22; Thu, 26 Nov 2020 18:30:57 +0000 Received: from MW2PR12MB2492.namprd12.prod.outlook.com ([fe80::2c59:3e5e:2b21:d20e]) by MW2PR12MB2492.namprd12.prod.outlook.com ([fe80::2c59:3e5e:2b21:d20e%7]) with mapi id 15.20.3589.030; Thu, 26 Nov 2020 18:30:57 +0000 From: Matan Azrad To: Ferruh Yigit , Ray Kinsella , "Neil Horman" CC: "dev@dpdk.org" , Konstantin Ananyev , NBU-Contact-Thomas Monjalon , Andrew Rybchenko , "Olivier Matz" , Jerin Jacob Thread-Topic: [RFC v2] doc: announce max Rx packet len field deprecation Thread-Index: AQHWwohkpPMocSXsGECsUmSmbAoE3qnavKFA Date: Thu, 26 Nov 2020 18:30:56 +0000 Message-ID: References: <20201020120305.1516513-1-ferruh.yigit@intel.com> <20201124173628.1057348-1-ferruh.yigit@intel.com> In-Reply-To: <20201124173628.1057348-1-ferruh.yigit@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [77.126.110.58] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4d475139-9293-472f-00b2-08d892396a96 x-ms-traffictypediagnostic: MWHPR1201MB0080: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WGbQScU7YmQq7N5GzEXsM+bcFK4Wo65e1T2ypn8c/q4GOuH8/E+0qS3/FwQM94a3Hsq0jjtzoOwV31zl2pxJxtYA70BtY/5GH7Av1BaQ4GUqItbmKEoR4eXnPWDpBqxv67oi24HsUZrPzrvCyYJug2ZvBL/C3SrsiJ2LtOdpRHu/z3TTbZeyfvMdeQeYPs4jsV1REBmx5Y8dHW3CZQzMQFyWLnvDXeNJXcmBmSNJh2lNGR7LGjvcdU3flUW5p+PvdsulXIES46Aq4NQI23kUAfuax6or6PgPd7HygRFow4jgO9JcEoyRw0zbM3DKJjSVj7DjoarF9iKnflPrTimtaSjeVz7Hy2T4Jn16f4F6GPOjw7EcEnCsE8q/ZJ4tZpjI x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR12MB2492.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(39860400002)(376002)(396003)(366004)(136003)(86362001)(5660300002)(76116006)(55016002)(33656002)(66476007)(66446008)(186003)(66556008)(64756008)(7696005)(66946007)(9686003)(26005)(316002)(110136005)(54906003)(8676002)(2906002)(4326008)(83380400001)(8936002)(71200400001)(478600001)(52536014)(6506007)(87944003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?vBJcOUPv9DE/gutKEj/8mHiLDzb9Z7Ilt26M24mDfQCpJmasXwyw7SfeoI46?= =?us-ascii?Q?sKLaAx/iqmMBQwrD3TMIirn7DBILr6et3QnY4xywvQCaNyQDP9RSOrWyH1pm?= =?us-ascii?Q?zjqZydMkJSLWzZpOoOwebAbXSmf48bvhezO7eZ26Xgc6vbe7QRdb7mEEaL88?= =?us-ascii?Q?EsFh301koKPeB/Z/wzPxmMxyCFaMelK6FrrhiV6sdaM/TPuzA+zbI20Sx0G0?= =?us-ascii?Q?vkHQMmAcwdbj6xDat7x9ITSx2iaTOSLPHbnTxQ8IF7lr+nWOOeVOz6Io1STL?= =?us-ascii?Q?utFCGFZAmyyTJm8Hm/gamqSE8wkwqn6xvujDReUJvpk6hydsvmdlW83IdTzx?= =?us-ascii?Q?oKSoxfv30anvzwdnGJtgcFE4upo9+sTv3NYG6W06XhkXu4BMgB6s5Deu1adM?= =?us-ascii?Q?hrRuKT44vHI3PR3v0Fe2141QvUmXyufc916VorF8IB37Xvh5gIr1U4PP3zHT?= =?us-ascii?Q?c0LJiECejBRPaBJfuYZEPw1+4t2WpcglzBBJHioPAwnwNw+i+Cmq2JQNmVce?= =?us-ascii?Q?KSwkoWlTIB13gbB7QwSi6wjwZgSvSgLu/puyKBQu9bQRn193Z628GEz4elt7?= =?us-ascii?Q?iR2L3Pf9cGjR9wMJn7i3k5UQikSPIOIh+r6exAQheaO/+Le9+X1tfuKd/Ryg?= =?us-ascii?Q?0IvPvVEl16sJN0rQa7ByHS9nxCzd9O/acWGVxHzYe4Tp0mJvdAMQFLlcssMP?= =?us-ascii?Q?uc19tfeqIVzw/+QHgZpzFSJunTw4Urks8iBJ+mKxAQFBLCQbjD3QHTyOM55F?= =?us-ascii?Q?ZC1E9Ka+TXVTyHzzOfEBcp4mtI75TxDbO0AKRj2MdqSZC59FhQMIKOjSXKjF?= =?us-ascii?Q?hKi7fI+3zHOxbEkC1jriWFx8i+Q8Jx+dnGKSRd3C/ipeYw45rhFiIhy2MuIk?= =?us-ascii?Q?lD81HsdMB75bI8N0O+d1sZ8qX3ThMrTXaboJLXB9ox/JERTy4oIyOp/FPU7V?= =?us-ascii?Q?recDd058x2SwLtVeO234vfop8SDsJhxu0GC+7a0agYU=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB2492.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4d475139-9293-472f-00b2-08d892396a96 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Nov 2020 18:30:56.8074 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: D7NGi5xB0M0P31g5W1kVnCNc6h+TZXw7mIXVytNgs/3WviZBC7xjH4kVP6ORDSRt5UCwjGCfMX6+zRJsTQXUyQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1201MB0080 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1606415472; bh=2VKLCOdEfAuyFt5UoYuYk8qwAy51/ELbCaOdk0e9FaE=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ld-processed: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:x-ms-exchange-transport-forked: Content-Type:Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=B9nbbaIZr359rJe6BTHFdTNMlf7LR1VR4EnBvgJ2HzPzafLp9or+1b69eSi2SwZwZ JIXqNkMlpibQ6V4n7I2KPfSfixxr3ecaTfaxCaqccvaeIq+R4f3ZxRmp2EuCq5sVpk q78kZnrNtSl9JzZIt0T4cEhl9A9xHjQ8CA5W42FPf8z+IzGMJQsIsznx8FYFJ4UTTj uGQ4QtcB+3/PK5z0jbn+10XllWV9Ej15xpKEHYn7LWlgYvvYNsa8Xk3aMEd7uUpNGU jUHvmzuPKRTltSOVTHuEQXg3o60gXoplWEHc6IgYOCneNqxOCCpNSZYJPpqX3vhd2J 7DlxIe2ZAwVJg== Subject: Re: [dpdk-dev] [RFC v2] doc: announce max Rx packet len field deprecation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Looks very good direction - it will do some order here. Will be also good to define what is MTU exactly: Maximum Rx packet size \ Maximum Tx packet size \ both? Is it include L2\L3 headers? Vlan? How is it going together with ``uint32_t max_lro_pkt_size``? Also when should the user configure DEV_RX_OFFLOAD_SCATTER? Matan From: Ferruh Yigit > Signed-off-by: Ferruh Yigit > Acked-by: Konstantin Ananyev > --- > Cc: Thomas Monjalon > Cc: Andrew Rybchenko > Cc: Konstantin Ananyev > Cc: Matan Azrad > Cc: Olivier Matz > Cc: Jerin Jacob >=20 > v2: > * ``uint32_t mtu`` moved to ``struct rte_eth_conf`` > * The "Driver is responsible from updating ``(struct > rte_eth_dev)->data->mtu``" updated because ethdev layer also can do > this. The intention there was both APIs should update the variable. >=20 > Another open question is from Andrew, if we can remove the ``uint32_t > max_rx_pkt_len`` completely from the ``rte_eth_dev_configure()``. > This may force applications to have one more additional > ``rte_eth_dev_set_mtu()`` call for device initialization, but if applicat= ions are > OK with the default values most of times, agree that removing is easier > solution, please comment. > --- > doc/guides/rel_notes/deprecation.rst | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) >=20 > diff --git a/doc/guides/rel_notes/deprecation.rst > b/doc/guides/rel_notes/deprecation.rst > index 96986fabd598..73e43581d615 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -88,6 +88,31 @@ Deprecation Notices > will be limited to maximum 256 queues. > Also compile time flag ``RTE_ETHDEV_QUEUE_STAT_CNTRS`` will be > removed. >=20 > +* ethdev: ``uint32_t max_rx_pkt_len`` field of ``struct > +rte_eth_rxmode``, will be > + replaced by a new ``uint32_t mtu`` field of ``struct rte_eth_conf`` in= v21.11. > + The new ``mtu`` field will be used to configure the initial device > +MTU via > + ``rte_eth_dev_configure()`` API. > + Later MTU can be changed by ``rte_eth_dev_set_mtu()`` API as done now. > + The existing ``(struct rte_eth_dev)->data->mtu`` variable will be > +used to store > + the configured ``mtu`` value, > + and this new ``(struct rte_eth_dev)->data->dev_conf.mtu`` variable > +will > + be used to store the user configuration request. > + Unlike ``max_rx_pkt_len``, which was valid only when ``JUMBO_FRAME`` > +enabled, > + ``mtu`` field will be always valid. > + When ``mtu`` config is not provided by the application, default > +``RTE_ETHER_MTU`` > + value will be used. > + ``(struct rte_eth_dev)->data->mtu`` should be updated after MTU set > +successfully, > + either by ``rte_eth_dev_configure()`` or ``rte_eth_dev_set_mtu()``. > + > + An application may need to configure device for a specific Rx packet > + size, like for cases ``DEV_RX_OFFLOAD_SCATTER`` is not supported and > + device received packet size can't be bigger than Rx buffer size. > + To cover these cases an application needs to know the device packet > + overhead to be able to calculate the ``mtu`` corresponding to a Rx > + buffer size, for this ``(struct rte_eth_dev_info).max_rx_pktlen`` > + will be kept, the device packet overhead can be calculated as: > + ``(struct rte_eth_dev_info).max_rx_pktlen - (struct > + rte_eth_dev_info).max_mtu`` > + > * sched: To allow more traffic classes, flexible mapping of pipe queues = to > traffic classes, and subport level configuration of pipes and queues > changes will be made to macros, data structures and API functions defi= ned > -- > 2.26.2