From: Matan Azrad <matan@nvidia.com>
To: Shiri Kuzin <shirik@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "declan.doherty@intel.com" <declan.doherty@intel.com>
Subject: Re: [dpdk-dev] [PATCH] examples/l2fwd-crypto: remove key size validation
Date: Thu, 8 Apr 2021 09:25:03 +0000 [thread overview]
Message-ID: <MW2PR12MB24929D128838CC2328D0DF40DF749@MW2PR12MB2492.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20210408084958.4443-1-shirik@nvidia.com>
From: Shiri Kuzin
> In the example application the key can be provided by the user or generated
> randomly by the example application.
>
> Then a validation is done in order to check if the key size is supported in the
> algorithm capabilities.
>
> As a result of patch [1] application should support the case where a user
> supplies a wrapped key.
>
> In order to align with this patch and be able to use the app with wrapped keys,
> app should remove the validation of key size in the application and rely on a
> PMD key size validation.
>
> The validation is removed in case the key is provided by by user, and kept in
> case the key should be generated by the application.
>
> [1] https://www.mail-archive.com/dev@dpdk.org/msg201281.html
>
> Signed-off-by: Shiri Kuzin <shirik@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
> ---
> examples/l2fwd-crypto/main.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c
> index a96cb94cc4..5ae2569065 100644
> --- a/examples/l2fwd-crypto/main.c
> +++ b/examples/l2fwd-crypto/main.c
> @@ -2111,13 +2111,11 @@ check_capabilities(struct l2fwd_crypto_options
> *options, uint8_t cdev_id)
> cap->sym.cipher.key_size.min,
> cap->sym.cipher.key_size.max,
> cap->sym.cipher.key_size.increment)
> - != 0) {
> + != 0)
> RTE_LOG(DEBUG, USER1,
> - "Device %u does not support cipher "
> - "key length\n",
> + "Key length does not match the device
> "
> + "%u capability\n",
> cdev_id);
> - return -1;
> - }
> /*
> * Check if length of the cipher key to be randomly generated
> * is supported by the algorithm chosen.
> --
> 2.21.0
next prev parent reply other threads:[~2021-04-08 9:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 8:49 Shiri Kuzin
2021-04-08 9:25 ` Matan Azrad [this message]
2021-04-13 9:52 ` [dpdk-dev] [EXT] " Akhil Goyal
2021-04-13 16:24 ` [dpdk-dev] [PATCH v2] " Shiri Kuzin
2021-04-16 10:38 ` [dpdk-dev] [EXT] " Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW2PR12MB24929D128838CC2328D0DF40DF749@MW2PR12MB2492.namprd12.prod.outlook.com \
--to=matan@nvidia.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=shirik@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).