From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C1682A0579; Thu, 8 Apr 2021 11:25:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 92A5340698; Thu, 8 Apr 2021 11:25:07 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2085.outbound.protection.outlook.com [40.107.92.85]) by mails.dpdk.org (Postfix) with ESMTP id 7549840138 for ; Thu, 8 Apr 2021 11:25:06 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ULzJfzpbhGJh5MDPTRxmU5mDzh1syqWtwJ8Xoj1ooEuYMonul0C6NEHjUkao/a+guV5HCqt4B4dNg1GleyPngkOcuJhmycKQq+Yuq2NkY17Y1S0SgQinspV3OQXtr7YuvrRhehF3lhbM1pM7E4eQRSz9KD7Dt7aB0tBcTpd8qXZORqlT9/5SWvibVQHPBd1jMCtxBp9EOjTOVX6dm+By/RZLGw2eWhWWVlS/ZBdIIn89trjGDefg1ofDBOsPIvOgbWIbRZsQPG0c/lvJMxSDLa4vtGbnLsG+rVQTESaOaZyw1zXy+JwANcTySnvRoG5hdx081TBn5Z2cgkEMz6F8BQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cB70mMXF8nwhnBQQVgjW7sY7KijhoQlyRLKgQTktepQ=; b=et5E94vTPpICO/DvcT++L6nV1qJUZOVf4uDz8cjdXUf7fTKLsNcZwfCNDFb7mf+ScAcQPS8bxWFdHdI22LbEtCUax+jFMRJu6+XHelaRbZxOuld3HAQm2xJ7ip8MeIY74OqsEwKL3xCnlUZebw9g9BRbevPPa7wGrLiQPCGkaqKeFAQCXkL47ZlgUja67wwXs/Dap8O+yfPx/jhnSNRodUWDB4ONdq6R2yfwEe6+EVPL+8jC+twKqlWYfTyX6Kn1r8aU2HTJM2zQ2njy6ePzFcF9hb+veaAJCV4SaeLbNI4bkcK8ZwHkv0CMXAv2UeAYSl4fY2babW7lNnMsrT7Wrw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cB70mMXF8nwhnBQQVgjW7sY7KijhoQlyRLKgQTktepQ=; b=P2YlwOhjtQaCxpksEbNnB5gVYdeSiU3v1+GqB4RmxMcrG6RPYKGRQEfjmpeNhETBKeE7w8MOjgLFWjWC+NlTQ64VfcMGbJLXDFjEe/p7q714iN5miXPvyGhauQaBmXhglEn/XWiGICxweBbeDHgvjS0w+/FGAb01+TLAuLBisre+TpQgKDXNGlu+/NceblJ5bHKlIt/aughcjCBCgdVDW3Vt/1YoYpz4Qelh75RFNMW7IcDJ2tocuLD96u2wymx6hTp19RScNwcxoVF7tmPfCyy0nQFG/IqPmcAQTn7aKQJBfhSpuQkUvkkKKGgTwyaLNc1WHsd1bl2djmiTy/Rtdg== Received: from MW2PR12MB2492.namprd12.prod.outlook.com (2603:10b6:907:8::19) by MWHPR1201MB0109.namprd12.prod.outlook.com (2603:10b6:301:52::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.18; Thu, 8 Apr 2021 09:25:04 +0000 Received: from MW2PR12MB2492.namprd12.prod.outlook.com ([fe80::997d:63f4:b22c:8d90]) by MW2PR12MB2492.namprd12.prod.outlook.com ([fe80::997d:63f4:b22c:8d90%7]) with mapi id 15.20.3999.032; Thu, 8 Apr 2021 09:25:04 +0000 From: Matan Azrad To: Shiri Kuzin , "dev@dpdk.org" CC: "declan.doherty@intel.com" Thread-Topic: [PATCH] examples/l2fwd-crypto: remove key size validation Thread-Index: AQHXLFQzFlXBBIlHckC+GMhaFFTcP6qqWVog Date: Thu, 8 Apr 2021 09:25:03 +0000 Message-ID: References: <20210408084958.4443-1-shirik@nvidia.com> In-Reply-To: <20210408084958.4443-1-shirik@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [216.228.117.191] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 61bf23a5-d0a3-45b9-c001-08d8fa703130 x-ms-traffictypediagnostic: MWHPR1201MB0109: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8WTIShj3pmhkKwtPsWsAJsZsI+gnWJPMd573VTuaDz5cZn4DrASJv/i+61h1jNXvyYjUT8I3i5bf0klxiaYkNW848/oxG0eRb1k9ZNuP14biaV5lF69zpgxDYH3LDQreZfdvcZqzoxdTP90OYwKObW0NUah0xKFg9mh9GUDyyQ56k+m8d8vWZ5EI+/KiXPx11zpbB6sYiniRoGRDYG9DaVy/zcXmx+Gr6YFQcEPv9wzTyvUSxUs4sMQiYif/34AhlV9/wZs6yCvK0U3UAOx4Tl3VyyL9I+zTqBdG6DTQmCgQk3PkjVstVBz6l4sGtFEnVYGw/jDxeTwQqyAkxLS6ETHaXStql4mCf6a6P4oIHdloIK9/2lP5CpdIsWkiTJtme0gHV918Rk93mCUGAFhCMLqF6L+8HoQc588b2B20IHI6J62RM20dY3GLm+rDOuCHtooiAIxjlSosV8BBAd3oPoPat8uM1ywAS29Q9rK6GcwurJ4gpD1zMce1qCR/oHwe5hDR6C7EZTeL310CyBQzXWxTY/vC9JDXuYtthtu9tpSXLC63ZBDU895TmsoHikSXnnIiEAhhvtasdpPQoMIP1vB1+KtZj5t1BfzzsQjcO7ybmrMietHn8lNXUkUUO8/tW3vJiCX2qhL+g3z1A5uUnOVWnSUbu9bfAJQ9KeGHQ0TFMAaPp+hvqeCVcU9QlJec4p5xRJSiFatmTSTO8NoM5P8xX+MoUwqtg2oGwzGRlBWXy2yvA7HmVLVrdmgJG4Vl x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR12MB2492.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(366004)(346002)(136003)(396003)(39860400002)(9686003)(2906002)(71200400001)(52536014)(66476007)(55016002)(66946007)(38100700001)(7696005)(66446008)(64756008)(5660300002)(4326008)(478600001)(33656002)(76116006)(966005)(8676002)(66556008)(8936002)(83380400001)(316002)(110136005)(186003)(86362001)(6506007)(26005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?7STQNh0F6uqox0p81spbZrMRVEILinn4WMeY6l3TvyvRN5tkRxdXaW0Es+fh?= =?us-ascii?Q?tARwVsGyAnSQqHJTJn33XcmRV9ydHwC7vRz1eCwdnlr3C4fxcCx9JORwNUie?= =?us-ascii?Q?p3XMdQcFlM9EB7noUyAxw5FMw3ZoaskX33QAXJlFuvD4HXuyFvj6HluhDa3U?= =?us-ascii?Q?5uGacBkp8Cu0p2prCBk+irNPIw3rmo58w068FpHJgNpM1d8dU9qpB6PqwaGL?= =?us-ascii?Q?tlWrqrL6VOusnt2YhO+5jQfG/tm1thzwHHwhbimifU/KxwIl4dk8f6Py7nNy?= =?us-ascii?Q?2D708WdSHvlkcJjykC4zh4V8joECv6XMMJN17NHdaIWwvMv4bQb67DK9zQTV?= =?us-ascii?Q?HKO++T8zog20dHO7YAjF5j15q3vqW8BHRolPagLeSbpmqES+CCCE0zURnxp6?= =?us-ascii?Q?/9qvn5y0DWHe+zPDwwb3xgIusah35GyL9dgrfhyG5CcnlbVEKwv4/N5hl4vz?= =?us-ascii?Q?yk/c5I30PodR/+qDh5GYn6aXr6j7ifFCI0ol50rv/6RfkgCkj4XCB+yuf24G?= =?us-ascii?Q?rUAc9W1Vm/WShCw/P831CKkwAXZp/KPDUk8j17ya/Flxq6+FtYHLT94YjO2N?= =?us-ascii?Q?28yx5w91XuupOBZmxsRPP2i1l69mOy1JkU1lqidRy0BSEVKKAlflvJ7As3Fa?= =?us-ascii?Q?3IKHSSLwgbh5t94Y4S751hk+mbv19IggqMlTY+MVe+X3CYFJG7dqrG/FsVnF?= =?us-ascii?Q?4oyY5Bt77/qHIdYKwtaaSA5gVRfOBt3S4SVvTe40KvVhj97QxztI1rsrm0zi?= =?us-ascii?Q?qyhUI/EPJ/1BD6T7t96VssbuE9GkYButfjpBTFcobnNftTBN5V59f7UwuZ76?= =?us-ascii?Q?OxeEhjttNu44e3gCRIsbf9ebhvNO6gNWz5VqaIEQYOsnP7a3dSXWGsC0Nlgb?= =?us-ascii?Q?6W+8y/ujTHJqhpn+UaQFiBNAnv2vocvCA1fMIlwC8gsSaXy6+9Hgo/52BoXd?= =?us-ascii?Q?8FMEQOmc9ZL++WaOh1hYKol6khX3f93TsnbSGJsCClhjbeTq8Z+TFCop7Hv0?= =?us-ascii?Q?TxH5Zxg/ql2Kfet3Ss5FxMQG1mQddBAugDeOaZ92g01d3jUBKLHhy6Fo3bM4?= =?us-ascii?Q?2pVDb8XdpN4cPz8Orz0siHFVtdQw3NrGf9M7O7fQ9awTiaPKTXujcKFDCJky?= =?us-ascii?Q?ZOb9KsI8+61EjZBcu5FM59JmWLsJcmYOxtKALGpwPYV7RE3Vs/G5G/VshXYl?= =?us-ascii?Q?fTTcvT8wCMXWwlYXY2Gpw7WWy4/xeZmTFefo2mHZZwvHWT3RdgKpAeYgLpmA?= =?us-ascii?Q?A+IRnBDmR+Q393JMxnjP37NTmt2m6UQlOOcEGiKs/1fOrUmJfyfHw89w6Mjo?= =?us-ascii?Q?zmmXFRHpdSL3xFH4muLlI2Fk?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB2492.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 61bf23a5-d0a3-45b9-c001-08d8fa703130 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2021 09:25:03.9775 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TJJn06v3Jx/5F3JUlsZMc/QMrUv+pyB0K4Mo8eDwwL/Tm2mDuINtGSs99EgLmsO+HcMENS+iZ2+Wx9K5MMvP0A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1201MB0109 Subject: Re: [dpdk-dev] [PATCH] examples/l2fwd-crypto: remove key size validation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Shiri Kuzin > In the example application the key can be provided by the user or generat= ed > randomly by the example application. >=20 > Then a validation is done in order to check if the key size is supported = in the > algorithm capabilities. >=20 > As a result of patch [1] application should support the case where a user > supplies a wrapped key. >=20 > In order to align with this patch and be able to use the app with wrapped= keys, > app should remove the validation of key size in the application and rely = on a > PMD key size validation. >=20 > The validation is removed in case the key is provided by by user, and kep= t in > case the key should be generated by the application. >=20 > [1] https://www.mail-archive.com/dev@dpdk.org/msg201281.html >=20 > Signed-off-by: Shiri Kuzin Acked-by: Matan Azrad > --- > examples/l2fwd-crypto/main.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) >=20 > diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c > index a96cb94cc4..5ae2569065 100644 > --- a/examples/l2fwd-crypto/main.c > +++ b/examples/l2fwd-crypto/main.c > @@ -2111,13 +2111,11 @@ check_capabilities(struct l2fwd_crypto_options > *options, uint8_t cdev_id) > cap->sym.cipher.key_size.min, > cap->sym.cipher.key_size.max, > cap->sym.cipher.key_size.increment) > - !=3D 0) { > + !=3D 0) > RTE_LOG(DEBUG, USER1, > - "Device %u does not support cipher " > - "key length\n", > + "Key length does not match the device > " > + "%u capability\n", > cdev_id); > - return -1; > - } > /* > * Check if length of the cipher key to be randomly generated > * is supported by the algorithm chosen. > -- > 2.21.0