From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4394AA04B5; Mon, 26 Oct 2020 08:15:10 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2FC9C2BDB; Mon, 26 Oct 2020 08:15:09 +0100 (CET) Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) by dpdk.org (Postfix) with ESMTP id 85B472BB8; Mon, 26 Oct 2020 08:15:06 +0100 (CET) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Mon, 26 Oct 2020 00:14:43 -0700 Received: from HQMAIL111.nvidia.com (172.20.187.18) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 26 Oct 2020 07:15:01 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.104) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Mon, 26 Oct 2020 07:15:01 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UbCjuTgtNcUDmbOJpwcBq2dFGwKdu1Bh32aLlDiqzsKKQ54cH2dCeRUaq/2VQEXkWcXDC2Wr+JCWpHgizm6OwrhSDLtTqywnFggENZeFPB4H6oPY1ABZnEkX7oxLM7ue3Da5qxdBtGQAm51HPaOhuyOk66BFwNdnqp0cKql3Fu+QdNiwZtcUfyt6VTtgUasbACYq5TCPm1wQWXtcXQ7N9pKx2jSE9IrllZWjsj9aIW2vM/09gfvSQA3Dw2hMfhmywgaR3vaIrNwucEUdRknGYMAf238MPdCWFCMYIKYvxKUJSI20j0Dp5sf/XeuLVytrJC1PpArZNhcSFPhQeU9vtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3+R3hN0qrZomIGxpVkBG3kXQ9Q/cXv3+qTuyRYumQSc=; b=Bk++1+O8PrwmrgY7X6pqsO/NCnPT8mRl8XNB9GpCWGw79YO264ggGyl60lPLBpt5G+egwy6gTTFPevUfSlIkimKXydAhr37uwNBHDTbqWYYtCc75HM6u54KIN4bK6MZ2AMX+Lxa6Nzu7FkXhOJxNlrvCtkIJQ6ZfLy6x6bAd/S0eMQQ54Ku2xQ6FLNegs4UnzZfLexgQSHhrOmzI0oTuH9FHa2Ip0kwqbGH0TqR2lZP/2v8/Mfni/BLO8/3kFrGdEYEmpK5dqG0IHmXP9CXv5WNiY4GkJX2y/TJrj3ZDdJOr6SFHkyaxQeo0sLV97YJ8QLTA7Nl7RJHJMvFNWOL0+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from MW2PR12MB2492.namprd12.prod.outlook.com (2603:10b6:907:8::19) by MWHPR12MB1152.namprd12.prod.outlook.com (2603:10b6:300:7::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.25; Mon, 26 Oct 2020 07:15:00 +0000 Received: from MW2PR12MB2492.namprd12.prod.outlook.com ([fe80::39f3:2b4b:6018:4b88]) by MW2PR12MB2492.namprd12.prod.outlook.com ([fe80::39f3:2b4b:6018:4b88%7]) with mapi id 15.20.3477.029; Mon, 26 Oct 2020 07:14:59 +0000 From: Matan Azrad To: Long Li , Matan Azrad CC: "dev@dpdk.org" , NBU-Contact-longli , "stable@dpdk.org" Thread-Topic: [Patch v2] net/vdev_netvsc: prevent alarm loss on failed device probe Thread-Index: AQHWqEsAqOW5BW/oBEup1vDuHPgNb6mpfJWw Date: Mon, 26 Oct 2020 07:14:59 +0000 Message-ID: References: <1603354294-16610-1-git-send-email-longli@linuxonhyperv.com> In-Reply-To: <1603354294-16610-1-git-send-email-longli@linuxonhyperv.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: linuxonhyperv.com; dkim=none (message not signed) header.d=none;linuxonhyperv.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [77.126.110.58] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 23873260-66b1-4c65-7b13-08d8797ed9c1 x-ms-traffictypediagnostic: MWHPR12MB1152: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-transport-forked: True x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3HIxIDuXzoUbxXeTtPEhmSlGywYBlEIkzBiMZEzd1rJlYD1ig2EududJLeuqyX/fWDJyFgNfLVXcvF4gIKrBrSuuISV910rWcmhDW+5asQljyOgqtddqAggCeiJhgqNNHODm+PtxC1V0VHy5yIdt76XYfD+VuZujrlX1N4e08MPJGBU8BiUImJqTgVg+mOc5HcYru7g7u1C7DqMuSZ8lhhC6RIjbihCESLie7ELgGe4mPd9QE1CKL8p77RPvvZ5NvjEvz/4SBgMhrLrF/iFEAH6249VrlVtv2UbofuNOclIQ13r/z2SMFimWgBYHulHF x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR12MB2492.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(376002)(136003)(346002)(396003)(39860400002)(33656002)(71200400001)(7696005)(478600001)(66946007)(55016002)(76116006)(9686003)(52536014)(5660300002)(66476007)(4326008)(66446008)(66556008)(2906002)(86362001)(64756008)(4744005)(316002)(8676002)(186003)(54906003)(8936002)(6506007)(83380400001)(110136005)(26005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: Sndx6tbAZPcOg+vIQef3P/2dn3+EiqXUuBv+m5WX86hqctMgKHJrXR6u9b3Hd8IFipnslaQCuTBHHeztMRoAgrnPe2qoId1BDLWnbX6dPSrIuw6POdKmks+bjWOlbavJVBk3DlFUgs/M1iB8t1x5p9YRuEGa0YAVay1aAO35jpLmQYFOzoZpeHHjNiKW3HaAvJWa5ftKSValLcOmfwzdPMPvPDLwRMzvBa7zjEq3BBKsel84bDdR4AorlWBYmDy7mp1oy18A00fy8CnIWzT2yATgHg8+z+JF9LpRMc6nLwQ0UxIvTm7CblatT0dB8oI0g2S7rnw1VUjj2VAaFtlR8lLY/qe+ZSoIOlkgRDDKjzOomAz2oyDz1IAx5KOd8rIFlMTSYl3dleuc2vG9oBj1Pb/atht0D7H0Xg3ebmapp1XT9l0m8tO9O9CDrC4vfmak7vGF6kFPrBSZ/XBQl/5GGV4X+56nQsgmMxd75uU7Cf5EOmL8GfuEgt57wG6L5lC0VLkrQmmatCrZBqhLznHri18FQkKLN0SWWOVy7up+Q3dz3mjg60bs+yLZ8EWC985PJg0lnECeKiZ201Jwk7oH5sgVDMqiQmh/+MREc3o1TL7CSZ5dZbLKhDSsVXxvkvc76GO6/jBIQliAUTnlV4M6Dg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB2492.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 23873260-66b1-4c65-7b13-08d8797ed9c1 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2020 07:14:59.8501 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: r3unqyAQSA52YJUmnxeHNZLDf3q+osfdMGxHbQ+adFhG+WY1dvEjK/gO7JrFPlfYNNEM1Th5Hqz/+58LVuCd4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1152 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1603696483; bh=3+R3hN0qrZomIGxpVkBG3kXQ9Q/cXv3+qTuyRYumQSc=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ld-processed: x-microsoft-antispam-prvs:x-ms-exchange-transport-forked: x-ms-oob-tlc-oobclassifiers:x-ms-exchange-senderadcheck: x-microsoft-antispam:x-microsoft-antispam-message-info: x-forefront-antispam-report:x-ms-exchange-antispam-messagedata: Content-Type:Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=qawqr7tWBK4ybD5xyhiAgIjQjvHRRD3cWTY9v95n/HVeEEYF/3bELFqDI0whY56FS IV/FAb1+v2Vhf29A63DRHXUqvPGlCDImI/pUddV4A1xelVQt4sE70NMW/9o96fAo7y 9ZtDuOoI/wiKfew7kQr+2scaKN6RLhr2WRU2RUoGtCMnsAbnsaR338JEvr9+0FecVU kdtCei2acwLnnl662v12XMBVZD1FG/f0yZv1rhF4W/lVRpF47N5xKSirEefLgAkq3S 9zzzSAfmSjOA/q0pHtgRjRAmfs+fVfBMTaocw6F69+VPiXAJyaLyDNvVJgSgKWC64B 3QDnRsYVj5MaA== Subject: Re: [dpdk-dev] [Patch v2] net/vdev_netvsc: prevent alarm loss on failed device probe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Long From: Long Li > If a device probe fails, the alarm is canceled and will no longer work fo= r > previously probed devices. >=20 > Fix this by checking if alarm is necessary at the end of each device prob= e. > Reset the alarm if there are vdev_netvsc_ctx created. >=20 > Change log: > v2: removed lock and flags, use counter to decide if alarm should be rese= t >=20 > Cc: stable@dpdk.org > Signed-off-by: Long Li I suggest the next title: net/vdev_netvsc: fix device probing error flow and the next fixes line: Fixes: e7dc5d7becc5 ("net/vdev_netvsc: implement core functionality") Acked-by: Matan Azrad