From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE5F0A04B1; Tue, 24 Nov 2020 11:15:56 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3A0FDC904; Tue, 24 Nov 2020 11:15:54 +0100 (CET) Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) by dpdk.org (Postfix) with ESMTP id 3B541C902 for ; Tue, 24 Nov 2020 11:15:51 +0100 (CET) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Tue, 24 Nov 2020 02:15:52 -0800 Received: from HQMAIL111.nvidia.com (172.20.187.18) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 24 Nov 2020 10:15:49 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Tue, 24 Nov 2020 10:15:49 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MQJJdUX2j6Owrg+RGf5SZaKzjqEqQ4aVK2xHtr/gRWc31tEfbahOgWY76wzTIhB01TeviNMaFfPDiOfTXjChQBnBKwxlTO0KbuMCOW2OVY0Z+wqnsRIwtCbHK9hurvMZfdVnI+yh7mD5IgzpNhzLdWQ4quNlnnwX6TAifR0xXD9LELL4Jek22AA3L6QowUGIJrZUP5+pPKe0GuHkQR6Cu17v/RGao2X8HPguSVNcW5SZbYIRq85Yu2qE6yg1vWgMegzMT/ea7yv17amIUmMh13vj+moLn2EHYIAkGnJwKRJ2cWH3WmnsOuYgKkQi40bfuJOdXgB59ZNRW7tNENZ91Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TXNsiYsSSCjMruP+sRh64Sr+jJ0CTXsjmj/ilsk1hZ8=; b=MGpMg6xy+Fq0pFE+mNS8eGNXIvkKtTo/cfnzLSWyTdeGHionCZi7Gq7Q42x4rYSZ79cJZGNgPflhzj4VGkWmC5WUVjK9ueYgqQ76Xe7AwrTX9GCZ96ceVNLV7+ADY7bf45VadHTEfglPdBDdvIJPR3y06Ir46HM+GmP84Xy5QBVWlzqGNXaUPWQauuL5TzUx8DRI2IThpT8RS2l3X6F5C8ABaFOA1QryaClTN8Sxj+2Fu51woysH14AvDT0sgfu2IDTm56MyKp1VkOSDR0EeF4DKA96avJfsgSDLUug7QYCsRp8lqj+DPHs8kSDc7KCcqolwf1yQYPMs/4x7wfScog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from MW2PR12MB2492.namprd12.prod.outlook.com (2603:10b6:907:8::19) by MW2PR12MB2554.namprd12.prod.outlook.com (2603:10b6:907:3::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.22; Tue, 24 Nov 2020 10:15:47 +0000 Received: from MW2PR12MB2492.namprd12.prod.outlook.com ([fe80::2c59:3e5e:2b21:d20e]) by MW2PR12MB2492.namprd12.prod.outlook.com ([fe80::2c59:3e5e:2b21:d20e%7]) with mapi id 15.20.3589.030; Tue, 24 Nov 2020 10:15:47 +0000 From: Matan Azrad To: Gregory Etelson , "dev@dpdk.org" CC: Raslan Darawsheh , NBU-Contact-Thomas Monjalon , Slava Ovsiienko , "Shahaf Shuler" , Michael Baum Thread-Topic: [PATCH] net/mlx5: fix DevX resources memory management. Thread-Index: AQHWwjlLTGu6PGdBeUCWjQfeGw5s/KnXEQEA Date: Tue, 24 Nov 2020 10:15:47 +0000 Message-ID: References: <20201124081013.1912-1-getelson@nvidia.com> In-Reply-To: <20201124081013.1912-1-getelson@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [77.126.110.58] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: feacaa77-bb6d-4b9a-987b-08d89061e97c x-ms-traffictypediagnostic: MW2PR12MB2554: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3631; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Sglc8y/GWh36seA601qWJMiTK+L/4U3PTk/T4/oHk/uVGmSRvNHz3IVF6UlFlL3NNi1p6H1APVEDRqz1nEr7TCAzUHupBE1kMmBqXTa2BGOjT5wRH8r9AS0b3g8ibgzYI06dRIkTCFJ7zBBfYgFGo429gWSm5/BIy0trpcE4n3NKM5ENWiRUaSEVEhjknca8O/kytEjHAbCd4BxyQVuHqZuaNFQWBWxl2FAf3M2G9+O86MCbY6UmiE7PPCfY1AIDar8vq88NOCTdktuhq+YUEoB43SgziiOzGRax1iGUy9MBYdo+d6otpbG/XvOlfpJ7 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR12MB2492.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(346002)(376002)(39860400002)(366004)(396003)(66556008)(64756008)(7696005)(66446008)(76116006)(4326008)(107886003)(5660300002)(55016002)(66476007)(86362001)(66946007)(9686003)(478600001)(4744005)(54906003)(2906002)(83380400001)(71200400001)(8676002)(316002)(26005)(6506007)(110136005)(8936002)(52536014)(33656002)(186003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?OAXPASZ+CO7KnqSHy0pmzHrSisAws8QTCBsXbPuqAOAhTfnPNAzQseTPXtuB?= =?us-ascii?Q?bPnWHwVMPEqxHZEHOznS/WUxdT5BSx4udI55aZGAI0nP0991h3eO96Gq7kYf?= =?us-ascii?Q?TJ6bdCNCL06FIhkvNhLY4L5NckEj0QayxMcVTOv0eZbY7B89RgS0BJSkKY60?= =?us-ascii?Q?AmyBk6FBZ++5ACvHYq/Y1UbluDVR5mAwVZGtQdMWeskY8u1DPVJy8j/Cu3jb?= =?us-ascii?Q?0FkUGesB02N2OASQxd47h3NehZ08NpBzonoNqNJHqpqhcHwhYWCA/9ic4TNR?= =?us-ascii?Q?/ApdtPIWNqe49Zf7bqIkUxR5YBD8OCLGMGZnhU7mEKBQnojKk807xm01OjFK?= =?us-ascii?Q?ER1w+5rL1WDZhsA+mbSBjpCO3/UMJub5Ztxh5h8jSQX4sDiuV3ydxbwtgLGo?= =?us-ascii?Q?RMJpsXS8BVYfcoogN7fJ/mv0cPDe5mVZQAnlJ2NWpZoUIjp4YUbrhh1k/GJ3?= =?us-ascii?Q?pCIXQlIEvHtqtHxpbB+vrEo7w/1qt3PCxu/s+3VNr0CNb/fVqlr2/bljLKdD?= =?us-ascii?Q?0B7Pkv9C8sWHDQ7SZXEkYYbXBdFp/KJYEkxv5i+4exG2wCWatH6TZyKrSasS?= =?us-ascii?Q?xsOI2i+f5E5wxqH9a9x3x6ehT7mK2XxtGgCAjni+GuT4VgYrgePSPhcxDu/k?= =?us-ascii?Q?ui9l7VmeCc4cFEAYL8u8axsQb3l5TE6YCOS8YbWNZFLA/+XvhUz2q1/07Gmu?= =?us-ascii?Q?4sK/tOMLK03IF/F0tg6VDTbEhoh+ggr9Ir7ifKXfnRJAOIFU5zqHviG4MaOS?= =?us-ascii?Q?WlPFYbMzmTw5pyg68XL6/nJC6cRR8fRQtx8J5axt5Bo0STPxlKL9npELXlOU?= =?us-ascii?Q?fdNvl7En81/zKRo/4gyA9hb70u598kceBYiufeinZrhaplUOQH98v4KDc9mB?= =?us-ascii?Q?c0wWsBYkH1rSLlYOm9B87pdhWLivzVZTTERx089CmqSQfstog5ieNB4ixkJG?= =?us-ascii?Q?U3lPdZrWgdZ4RNNvw04rDaq4f19H/La7asvDwkDAT0A=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB2492.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: feacaa77-bb6d-4b9a-987b-08d89061e97c X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Nov 2020 10:15:47.5020 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GwqK0AhJ1UmG7XR80RzKEnreZm6FTRLLZmeXhr6zO6Gk88OdFaykoi9Qwm7pG7eA0uPKa53Jk7O52QiS6y6haA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR12MB2554 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1606212952; bh=TXNsiYsSSCjMruP+sRh64Sr+jJ0CTXsjmj/ilsk1hZ8=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ld-processed: x-ms-exchange-transport-forked:x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers:x-ms-exchange-senderadcheck: x-microsoft-antispam:x-microsoft-antispam-message-info: x-forefront-antispam-report:x-ms-exchange-antispam-messagedata: Content-Type:Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=V99PpDVTUZMH602H5vNckeyshW/JnMic/UeK2Q6Vqtl31/w5qs4NoSSLqPfRTaaNU s8DlZcJOSIfROl/l7UO4LMVY5K/pmITIb8etgPLXtl3I8+dVsRmYbjoGkZjVwyvsrp K6s6ysuLf3dzusU9wuWLoLrmbd0zDP70GnpvqWeOviX02hf6JM+ZheZRgJ32KSQl9z kP5nvM/onVIqyxh92OpV7+uIn0EITyXsXTkOBh1NZ4x84ZfTZuenwu9SOz8GnirfjT og47nQsQq7PYhX8QlsArWc2iXWYfjnEw4AzXn4NM3pM1hUmEvmcrUwvZqrcKjkm2ZX FTFYdGIEtFOEA== Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix DevX resources memory management. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Gregory Etelson > Invalid memory release order of DevX resources caused PMD crash. >=20 > 1. SQ and CQ memory must be unregistered with DevX before it is freed. > 2. SQ objects reference to a CQ ones. Hence, SQ should be destroyed in > advance of CQ it references to. >=20 > Fixes: 6deb19e1b2d2 ("net/mlx5: separate Rx queue object creations") > Fixes: 88f2e3f18cc7 ("net/mlx5: rearrange SQ and CQ creation in DevX > module") >=20 > Signed-off-by: Gregory Etelson > Acked-by: Viacheslav Ovsiienko Acked-by: Matan Azrad