From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7FE85A04AC; Tue, 1 Sep 2020 17:34:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C44291C0AD; Tue, 1 Sep 2020 17:34:14 +0200 (CEST) Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) by dpdk.org (Postfix) with ESMTP id BC2101C07D for ; Tue, 1 Sep 2020 17:34:12 +0200 (CEST) Received: from hkpgpgate102.nvidia.com (Not Verified[10.18.92.100]) by nat-hk.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Tue, 01 Sep 2020 23:34:11 +0800 Received: from HKMAIL102.nvidia.com ([10.18.16.11]) by hkpgpgate102.nvidia.com (PGP Universal service); Tue, 01 Sep 2020 08:34:11 -0700 X-PGP-Universal: processed; by hkpgpgate102.nvidia.com on Tue, 01 Sep 2020 08:34:11 -0700 Received: from HKMAIL103.nvidia.com (10.18.16.12) by HKMAIL102.nvidia.com (10.18.16.11) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 1 Sep 2020 15:34:03 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.170) by HKMAIL103.nvidia.com (10.18.16.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Tue, 1 Sep 2020 15:34:00 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HTMSBu0sYbQvyQhrTjfmMK98gd75ObgI7AA9GQK6moLNEfxU0A+CxEH1rFmbdRlv3S3hipHWUSN0kYb66YD3M/hIYsRVCtV98ko3t5QasljKjqtTaHj8TSJYvydIuaDEUpkxMaaOs8kQCBAg5DAk9rmJRBhK73IjCFHAOoVnMqIRpgHRlONO8TFn22oKLr9fbOW01YeB3Dcc216qIeDWEP62iKD2tmFsk9Qg5NLw9n3sqL5ow6Ahqb5dgisnFc7QOOdFTKqlrNntmAyEArNzKoGYBQxDULVVzSf9Z/AjJ/gIBCRKjczr32Wqz7nK4L8HcozUzVuW7AQcE8nSc1WAaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PAx1EAWelxpH+4QjSLX3hpnBMDo6gHFmWksfH4Xq+ng=; b=WB1/vMrJcN6VkoY1t5rkaQEK+T2+io+Y3yb8xZfuEPFkuXy+VTRkTE1xHWiD+FmCtdzyu/CiGcplWfjXk7WE+xq+fWnV3rc/sYJN3//aYU1YxltIWG/YamNMCwiFJ/JoBQmgTDT5xBFifpmFlRkZLBklAoKn5Yk30dKMAxPefKUeKbCqiIXP4MjdggcZD96f9V3PWpZrp0kpKlzOPKROX9FAJGVlrI78ONp9EVRMWJI6Jl1hlx3sO/w/ZSX0eBErbfBQaVcw2Ryn7TVSI1f8mCz/QuW45cLcCjhOR12qZvVDClxEixrrYfchappzMyuYYAMC8UYKz33xyPLpb560eg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from MW2PR12MB2492.namprd12.prod.outlook.com (2603:10b6:907:8::19) by MWHPR12MB1615.namprd12.prod.outlook.com (2603:10b6:301:10::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3305.25; Tue, 1 Sep 2020 15:33:58 +0000 Received: from MW2PR12MB2492.namprd12.prod.outlook.com ([fe80::693f:4ec4:caa9:ac9c]) by MW2PR12MB2492.namprd12.prod.outlook.com ([fe80::693f:4ec4:caa9:ac9c%5]) with mapi id 15.20.3326.025; Tue, 1 Sep 2020 15:33:58 +0000 From: Matan Azrad To: Chengchang Tang , "dev@dpdk.org" CC: "linuxarm@huawei.com" , NBU-Contact-Thomas Monjalon , "arybchenko@solarflare.com" , "ferruh.yigit@intel.com" , "wenzhuo.lu@intel.com" , "maryam.tahhan@intel.com" Thread-Topic: [dpdk-dev] [PATCH v3 1/4] ethdev: add a field for rxq info structure Thread-Index: AQHWfdRddMw/ykWHNkeaRKxv9sXGxqlT7Aaw Date: Tue, 1 Sep 2020 15:33:58 +0000 Message-ID: References: <1592483709-7076-1-git-send-email-tangchengchang@huawei.com> <1598685199-1630-1-git-send-email-tangchengchang@huawei.com> <1598685199-1630-2-git-send-email-tangchengchang@huawei.com> In-Reply-To: <1598685199-1630-2-git-send-email-tangchengchang@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [77.126.81.41] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 479c474e-7e31-48ed-15b6-08d84e8c71d0 x-ms-traffictypediagnostic: MWHPR12MB1615: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UGl2dMih8ao+azkZnzYSLlSwC3srE16k+QyZsVQlt8CQz33q1WIDkTnipVCUu4gSDBewm1qbUJLp2d1ALo9rghvjizZPFyS0NANAnQPCqmvKRMrEVGquSNtXzcmGhfR3Jf5rKZw3+GOW41Um4kMGj30FSuD/JbHNjFptCjo+H/mhaDZ+vsG3kQp98k5VyZ+xFiTqCmCcWU9NJBMQGYJBLwA/PHGxi8LXVXeCJ3WdJ9ztARZ/orBY5HwJlzpwi3DiaWoIisMTWZcT/1khy1P7KMx6b99Ae/Vvqrjllm9AGyb4jHYk5+6W+0kxQFGTeh9aHqw54KA5cO3p6y5rZFRBBg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR12MB2492.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(346002)(376002)(366004)(396003)(39860400002)(8936002)(6506007)(8676002)(9686003)(66946007)(55016002)(64756008)(71200400001)(26005)(478600001)(66446008)(66476007)(86362001)(66556008)(76116006)(52536014)(5660300002)(83380400001)(33656002)(186003)(110136005)(2906002)(4326008)(7696005)(54906003)(316002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: 9CVBayRo4cbztlY7GBxvA136WC7erLN66v2ckHc9+kPRQApYshSCFosZ8bHY5NKDP5G6wdG2VNZye5PMbKnIXvuf8yEME+8JD2lfHdWzZZ70AZ0VmIgmCf5VgFw5tIOuDcEy6+Sl+iuNa5y6TIwc4lHdwdBQSqxkv+9WeGoiqxMj6tafQJwzX6SgX2yxQCRyBJERlIRL6iMbY8RFelnx1b2DXoW4BnsJIMc4Phc2CQyS9M77AyCFQSSNS0VGim+vWE03xYBYuTvCUWa0LK2cukoMpA//EDlK4uAcOK5Eu3E46YV1sI8LChDwZ4BPnIptAceoegvdliiqWgsikMjF6dbJAoNddqOUsKjPPxrwPbrxeMGjMzlbf/jhlWLpHXzHJHkcbG/MM4YYczV+Vn24Xeg9G6bklfACplDCDvhR9XVdXMn4E3GLhHywF69ctOf0g2DH9WYuZ97Yngq3OaNilKP+2wbFSdUGMgRo8wTxFXSMuD+M6IvNshP30hRiH5UBcoqBXXrS7xhyaZTTc0Si1GFTDi7oPcwkWOOVIEI0jzwH+47Z3+ngT8MQn0g4f8rFj0nU7Gu7lldjVFnvgtYVQhUdPo0IxaJDXtAwwa6wbYvyOnR7pWPVDwQuG1ufKVFv4qCTF0YfRBNchlliciRXdQ== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB2492.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 479c474e-7e31-48ed-15b6-08d84e8c71d0 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Sep 2020 15:33:58.3456 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1Kas6ZQ+fxsCuYzyfvKNbF9hIhgOk6P5lUYn/M+J3Srry+zPmPkoXAz/NYX4iERcW3jOVUdLaP5h0TduOg69vQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1615 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1598974451; bh=PAx1EAWelxpH+4QjSLX3hpnBMDo6gHFmWksfH4Xq+ng=; h=X-PGP-Universal:ARC-Seal:ARC-Message-Signature: ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic: Thread-Index:Date:Message-ID:References:In-Reply-To: Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ld-processed: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:x-ms-exchange-transport-forked: Content-Type:Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=lsp3pVvDQCegne8G+zxL2qO7b9YsNRlbKyWOQfWljk9lgDDW8bu1n2WLlGu9RRU40 OrkB9ok5ggNkOHaLyralxmzcb7pACMe+tZ0JQN8C5DNuvdZBOQFZBf/uwR0n4wtfkH /8nFmFh3aSfezoH/8ogjkFH6m+MLbHqjeEGkZA9WceswJO8S6vt7xj1+jfJhi30clE Zg/1jWqhpGjrlHFYKi/GrI419UI+B1g7FJmTJQlVzpEHKPVjaqLJ3m3VEethQ0nqX3 7aoMfxhNi+Zxq4lSTpuTd80uY1ooECKvO+UtTyftGAKn17Bh0TcKNuWmfklJ94PYbA IPV5uJivAx7Pw== Subject: Re: [dpdk-dev] [PATCH v3 1/4] ethdev: add a field for rxq info structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Chengchang Please see some question below. From: Chengchang Tang > Add a field named rx_buf_size in rte_eth_rxq_info to indicate the buffer = size > used in receiving packets for HW. >=20 > In this way, upper-layer users can get this information by calling > rte_eth_rx_queue_info_get. >=20 > Signed-off-by: Chengchang Tang > Reviewed-by: Wei Hu (Xavier) > Acked-by: Andrew Rybchenko > --- > lib/librte_ethdev/rte_ethdev.h | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethde= v.h > index 70295d7..9fed5cb 100644 > --- a/lib/librte_ethdev/rte_ethdev.h > +++ b/lib/librte_ethdev/rte_ethdev.h > @@ -1420,6 +1420,8 @@ struct rte_eth_rxq_info { > struct rte_eth_rxconf conf; /**< queue config parameters. */ > uint8_t scattered_rx; /**< scattered packets RX supported. = */ > uint16_t nb_desc; /**< configured number of RXDs. */ > + /**< buffer size used for hardware when receive packets. */ > + uint16_t rx_buf_size; Is it the maximum supported Rx buffer by the HW? If yes, maybe max_rx_buf_size is better name? Maybe document that 0 means - no limitation by HW? Must application read it in order to know if its datapath should handle mul= ti-segment buffers? Maybe it will be good to force application to configure scatter when this f= ield is valid and smaller than max_rx_pkt_len\max_lro.. (<=3D room size)... > } __rte_cache_min_aligned; >=20 > /** > -- > 2.7.4