From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91F9CA04A6; Thu, 27 Jan 2022 14:39:32 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2423C427A4; Thu, 27 Jan 2022 14:39:32 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2073.outbound.protection.outlook.com [40.107.92.73]) by mails.dpdk.org (Postfix) with ESMTP id 5B8304067C for ; Thu, 27 Jan 2022 14:39:30 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d3+AQQ26YuzdWwZsUtWCf8WZYR5xPkeEzGP4VlGdhoAQnxayT3nBjdOpgpfUiSkk71BUGxBnh+AiBVlKexzeWiqTv1X3fuBw7Wff9KZqXBJDxgLhNeg8nbToM9yo5SSgQfpw1jRvP2DSLSiqthwv6jqNwXFvA5SIrNDuZpa/E4NYtQbvDmufhd9bQT9KW9Y6JxA1hDl8yOS8Ib4JbngBCgyeszQ/7TKtFHC5Pa1YHNIA6gRs2Du6AlgQHlRZ9IcAWbioZvUIUx3lhFh3FjlV3xtnfJ7I/LZGxNScO6BNjDRz5lZ2UT4PMXvt7NS9fFU8pV5/+r9JOJ+tavrrfnWWZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DypuqRlYpq4+7pq0FWHWCgKd0u4goH0SOuTKvGmae0U=; b=GX+roqBl8i+JnN6ExNmHVRQOT6J//ZNrBro+T2lPKZOF0crYziC7f7s5sYH1pDqmmDdiLgQ04825llyD9Zl+b7PrPUjE6rk20hCtL/8wTWxWv+QUFAhs42CqcLR7V/+28Gj4ra5gmKmWKOuAfw5GhK+v6UXjffGNemcGfEpOCjVv8wBfExqlcjJCOYBmRrXa67TeBCW69nr++TpFBkSIvmNVoCj/dZFecmROkQ1PG4f5YoSzFo83RnP5ZTRXtXA0yOPUDnZg4lV5atiT//JIMq/0mcNgAr6GsVtlewpg5CVh9cTUyqwptR6y4R3utGdOHhbxpPI8obTpKjPH58ws0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DypuqRlYpq4+7pq0FWHWCgKd0u4goH0SOuTKvGmae0U=; b=5Oabmaxf1TB5le8mzmPSHCtcOZGMmipF6yXrrd8IjARwETH3fxk9JPuM76zF2HpCSjLrXx+Jf0hKrXj8r8WVcpE4XMKl4836uXqZPqlBkdI5iG563FrbkXm3IUg9rHjlAyxkDBOc+u1P5XedvDe6WV0iatdPY43/o4i1Snlm+lI= Received: from MW2PR12MB2538.namprd12.prod.outlook.com (2603:10b6:907:5::14) by PH7PR12MB5687.namprd12.prod.outlook.com (2603:10b6:510:13e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.13; Thu, 27 Jan 2022 13:39:28 +0000 Received: from MW2PR12MB2538.namprd12.prod.outlook.com ([fe80::ad98:6ba4:7d63:fd6a]) by MW2PR12MB2538.namprd12.prod.outlook.com ([fe80::ad98:6ba4:7d63:fd6a%4]) with mapi id 15.20.4930.017; Thu, 27 Jan 2022 13:39:28 +0000 From: "Namburu, Chandu-babu" To: "Sebastian, Selwin" , "dev@dpdk.org" Subject: RE: [PATCH v2 5/6] net/axgbe: add support for new port mode Thread-Topic: [PATCH v2 5/6] net/axgbe: add support for new port mode Thread-Index: AQHYEeXinpjs2QQKhEmkfURU4tA60Kx24sNg Date: Thu, 27 Jan 2022 13:39:28 +0000 Message-ID: References: <20220125121747.344631-1-ssebasti@amd.com> <20220125121747.344631-6-ssebasti@amd.com> In-Reply-To: <20220125121747.344631-6-ssebasti@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Enabled=true; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SetDate=2022-01-27T13:39:22Z; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Method=Privileged; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Name=Public-AIP 2.0; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ActionId=dcd7f645-67f8-4023-a211-05fc3b29e189; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ContentBits=1 msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_enabled: true msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_setdate: 2022-01-27T13:39:25Z msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_method: Privileged msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_name: Public-AIP 2.0 msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_siteid: 3dd8961f-e488-4e60-8e11-a82d994e183d msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_actionid: 5aa46b6e-c2e1-4cad-95ba-37bdaefeacee msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_contentbits: 0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 41067231-9f3f-4714-f9ab-08d9e19a70e8 x-ms-traffictypediagnostic: PH7PR12MB5687:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1468; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GdpHFZGTCqlE1GxCPWvgeOosgrRw/VPMHi2JV1W5wkCyRKLT04EtgGxQ/PNBANyacwjDHzv0QBMY1UNrXZQ13BwsCOw9a+2PuKTey50oITFcuRascSkRTEZ3mEsBEXrIt3/LS1WJPnKFtsJiGYy+RdAaWrJI03duO5YqI7CjVc/A+W6hI/y/WqM3FmzoFlI/RKc9svqS9LRIvR/dEPI7YMP1UNshs3bF5gZzR9aaC/eQOLu9Dg/cURbWJakJMYxqMgAxMoCcs8zss+Ewy/Z40COEmYhfdJ8p9C2shkO4YY5iBcbqr2mzQBGjBpSK30ZD15oHYRGolY+OU7ZAXon02I4frC9Vvqj4Ys6wHEzXbwb4zcVL4xE2iU2gR4MbA8fjqvjWtVBXsWJ4J3TKnrmV6JlZB2+LXs6fIo8K/WBxx0b/qU6t5CDy9Zt7StAWXxEnYhWEh5hlMt7iSEUzV3dCTNvB1XT9QSp5MyFeZNe0jzikLT7khHXoCfD7QOqV4OvpauMapHRRNmNpDrvTOFUslcaY8FmodpkKsuX/bJApAYP/bFlB4Xlxlp/QBq+0aN7b0I1WNTHYrs1aYH3ZvGku8SKkPF8xCh7f252dysWkMpFmND6CQQlUN8aLyzjDE3gfkAZ8I+B1hdJxKxcfjjhOY+6IFb49jvoyEBkPXXibG7+Xc68I+ut9gj3GOmOHd5J//OpmkY16Hwx8gtxvCHmfKQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR12MB2538.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(66946007)(186003)(508600001)(26005)(52536014)(5660300002)(38070700005)(86362001)(8676002)(53546011)(76116006)(83380400001)(7696005)(110136005)(55016003)(122000001)(8936002)(6506007)(33656002)(64756008)(9686003)(38100700002)(316002)(66446008)(66476007)(71200400001)(66556008)(2906002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2xYXWTgmjdO6t3hNW1HvnDBIHVVtSq2VZGytFMMRmsgnjQv7brT6L2NlcaBV?= =?us-ascii?Q?HvpGMzsxO3I8byoUx14uOctYrXz+/T/eN9UH2KsosR8jI0D43NQc8dFd6yVf?= =?us-ascii?Q?WSORJblT1bzEjBsSeBrjMODdWUCY1V6PYGsykAvrJom4N8jOExnOByVdbx2v?= =?us-ascii?Q?6HMX7lcfj/Q6x7jB50e/oC4QpFp+3d3a8lg7wHnVgSTDbIj2K+HI6kdZ0Fc/?= =?us-ascii?Q?n8uBzUEtF0R7bAinnnfz1Ml/RdEudKn0wgJSxu+rZ32wdroU1es1GdR3szk1?= =?us-ascii?Q?Esc2vtF3BPh9Ee1Qe5Srs931hu68dqdQjDEn+j9P5gBDndx0X+FeSPxpzc2E?= =?us-ascii?Q?BzOfbehj0fc08duf0XZ54rPbZ9Ez/AHSKoHwj9xB13iZBHO/h0sqOeD8CYxg?= =?us-ascii?Q?B26EZig+xRcofNTOFnbfaqht5eOa92QdGPrr5su9gPmpSwHkKtfuCTXUYHqq?= =?us-ascii?Q?z2wYDr5mjqf9RZlTcTy78WIs60lGhsR4LyVZ+SPumH6ZDogPH1oPU60eXNC/?= =?us-ascii?Q?LKNz0LFIQSdT0etOX/2KFIixR1X4cwO/iDdNvzW2rkZr99qbvvA6ePhsluyz?= =?us-ascii?Q?lJoZd//5TvyjOdpM596kXrd88ihL1D6J3XYBEBkYG6Vd+uEm7FWGVGYQBtJh?= =?us-ascii?Q?Zw+l5lMK7V36/obANzO+7cQJOCO1GnO8lwvcC2XE/USHhtK6G64XXlpn6T8o?= =?us-ascii?Q?8rKijKKPFhZY3QYvMJiHfZLoBHaRaT24p5uhWpw6DKPQrBimo+xcIVf8TXNI?= =?us-ascii?Q?ouAWgRRoyG3VYXOpWqzK3KvPa42vIfbibI69llGFj/mHL/FWHmOsFd0cbRqD?= =?us-ascii?Q?YxjvFtRy3yH7TtAaDcRExsAoV5fPg8tnSCAuddg9ZhWQOMLv0m1aoScLlu5h?= =?us-ascii?Q?6ILiB122FovRuCUKQtCTuT/pneV8HPYd/SYYGdG5yB4p1+N/CnVgmr3uj0i+?= =?us-ascii?Q?z2qRaeGY/I8o9RJnKKMncirsMmGFq9cOHO43ZurkSVgoqIGRyL1tHeTrXnRd?= =?us-ascii?Q?gVY+mcVkkhIoguQJGWBL1j0RVUSJw2ePkMkxqOg1ropOH1DCue3VMCuqP6aJ?= =?us-ascii?Q?NBFSXrRPuqP3iRgm3MWlkBKRV86aqw4y+tFLV8Y3yPTy8Ge+S7Ho3a+0DK1Y?= =?us-ascii?Q?Bo8lDgETMkooUYPOEOnArDNAcelB2qkEj0WHtTrCJm6lNrb+mGN4RfE4KyNW?= =?us-ascii?Q?XCsQTm7JTufR+CeOIsWW5PtHWve8pLOmlb9f6azxOCDDIVhz73mzSWALhklw?= =?us-ascii?Q?tMByQEF7GT56pyfU0ASQ8XZsRo03/hKGV4Ml2UyKRwlXJMO49PfT6LKZWOgS?= =?us-ascii?Q?UbnRZPSIo81oJbGZzlegwnNfc3JXEwvVNr/OPBLwCsA09/L2uZL0kpJbb10G?= =?us-ascii?Q?CM98zmUcz16ku2ZF75Y8FwM/a+uGNRMEleVYUaNbPG0UjxhM+jI6cKR/cclf?= =?us-ascii?Q?3HhvEDcrMcI03p/163uRWSq6qj9JKqKxnqSw8SWWD0yY++/N6BAbpq4msCi+?= =?us-ascii?Q?sq5E3c88oKVgoxVvMvJ6rZbwp9zoGeTnOkuX32ZQ6V9/B+uRPYXmOKx/BfBq?= =?us-ascii?Q?83mktsKQvYHIZ/gPFoGDjOTUtxLGpuhuoIfvDarBXkSUCmf0LnE5ijZFDmVY?= =?us-ascii?Q?czUH+bcR7t/nz/8amxWN8FE=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB2538.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 41067231-9f3f-4714-f9ab-08d9e19a70e8 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jan 2022 13:39:28.3915 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 59PwE7odWFw7KNJhXWByMJ2Wi3RYBTxE9C4hTYkWsqDxGUi1M4u58CIjLpiUvqn9iS3u7NJJDZeKU0QBggYHRQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5687 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org [Public] Acked-by: Chandubabu Namburu -----Original Message----- From: ssebasti@amd.com =20 Sent: Tuesday, January 25, 2022 5:48 PM To: dev@dpdk.org Subject: [PATCH v2 5/6] net/axgbe: add support for new port mode From: Selwin Sebastian Add support for a new port mode that is a backplane connection without supp= ort for auto negotiation. Signed-off-by: Selwin Sebastian --- drivers/net/axgbe/axgbe_phy_impl.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/net/axgbe/axgbe_phy_impl.c b/drivers/net/axgbe/axgbe_p= hy_impl.c index eefb03e94e..b0e1c267b1 100644 --- a/drivers/net/axgbe/axgbe_phy_impl.c +++ b/drivers/net/axgbe/axgbe_phy_impl.c @@ -46,6 +46,7 @@ enum axgbe_port_mode { AXGBE_PORT_MODE_10GBASE_T, AXGBE_PORT_MODE_10GBASE_R, AXGBE_PORT_MODE_SFP, + AXGBE_PORT_MODE_BACKPLANE_NO_AUTONEG, AXGBE_PORT_MODE_MAX, }; =20 @@ -885,6 +886,7 @@ static enum axgbe_mode axgbe_phy_an73_redrv_outcome(str= uct axgbe_port *pdata) if (ad_reg & 0x80) { switch (phy_data->port_mode) { case AXGBE_PORT_MODE_BACKPLANE: + case AXGBE_PORT_MODE_BACKPLANE_NO_AUTONEG: mode =3D AXGBE_MODE_KR; break; default: @@ -894,6 +896,7 @@ static enum axgbe_mode axgbe_phy_an73_redrv_outcome(str= uct axgbe_port *pdata) } else if (ad_reg & 0x20) { switch (phy_data->port_mode) { case AXGBE_PORT_MODE_BACKPLANE: + case AXGBE_PORT_MODE_BACKPLANE_NO_AUTONEG: mode =3D AXGBE_MODE_KX_1000; break; case AXGBE_PORT_MODE_1000BASE_X: @@ -1052,6 +1055,7 @@ static unsigned int axgbe_phy_an_advertising(struct a= xgbe_port *pdata) =20 switch (phy_data->port_mode) { case AXGBE_PORT_MODE_BACKPLANE: + case AXGBE_PORT_MODE_BACKPLANE_NO_AUTONEG: advertising |=3D ADVERTISED_10000baseKR_Full; break; case AXGBE_PORT_MODE_BACKPLANE_2500: @@ -1122,6 +1126,7 @@ static enum axgbe_an_mode axgbe_phy_an_mode(struct ax= gbe_port *pdata) switch (phy_data->port_mode) { case AXGBE_PORT_MODE_BACKPLANE: return AXGBE_AN_MODE_CL73; + case AXGBE_PORT_MODE_BACKPLANE_NO_AUTONEG: case AXGBE_PORT_MODE_BACKPLANE_2500: return AXGBE_AN_MODE_NONE; case AXGBE_PORT_MODE_1000BASE_T: @@ -1400,6 +1405,7 @@ static enum axgbe_mode axgbe_phy_switch_mode(struct a= xgbe_port *pdata) =20 switch (phy_data->port_mode) { case AXGBE_PORT_MODE_BACKPLANE: + case AXGBE_PORT_MODE_BACKPLANE_NO_AUTONEG: return axgbe_phy_switch_bp_mode(pdata); case AXGBE_PORT_MODE_BACKPLANE_2500: return axgbe_phy_switch_bp_2500_mode(pdata); @@ -1495,6 +1501,7 @@ static enum axgbe_mode axgbe_phy_get_mode(struct axgb= e_port *pdata, =20 switch (phy_data->port_mode) { case AXGBE_PORT_MODE_BACKPLANE: + case AXGBE_PORT_MODE_BACKPLANE_NO_AUTONEG: return axgbe_phy_get_bp_mode(speed); case AXGBE_PORT_MODE_BACKPLANE_2500: return axgbe_phy_get_bp_2500_mode(speed); @@ -1644,6 +1651,7 @@ static bool axgbe_phy_use_mode(struct axgbe_port *pda= ta, enum axgbe_mode mode) =20 switch (phy_data->port_mode) { case AXGBE_PORT_MODE_BACKPLANE: + case AXGBE_PORT_MODE_BACKPLANE_NO_AUTONEG: return axgbe_phy_use_bp_mode(pdata, mode); case AXGBE_PORT_MODE_BACKPLANE_2500: return axgbe_phy_use_bp_2500_mode(pdata, mode); @@ -1806,6 +1814,7 @@ st= atic bool axgbe_phy_port_mode_mismatch(struct axgbe_port *pdata) =20 switch (phy_data->port_mode) { case AXGBE_PORT_MODE_BACKPLANE: + case AXGBE_PORT_MODE_BACKPLANE_NO_AUTONEG: if ((phy_data->port_speeds & AXGBE_PHY_PORT_SPEED_1000) || (phy_data->port_speeds & AXGBE_PHY_PORT_SPEED_10000)) return false; @@ -1858,6 +1867,7 @@ static bool axgbe_phy_conn_type_mismatch(struct axgbe= _port *pdata) =20 switch (phy_data->port_mode) { case AXGBE_PORT_MODE_BACKPLANE: + case AXGBE_PORT_MODE_BACKPLANE_NO_AUTONEG: case AXGBE_PORT_MODE_BACKPLANE_2500: if (phy_data->conn_type =3D=3D AXGBE_CONN_TYPE_BACKPLANE) return false; @@ -2122,6 +2132,8 @@ static int axgbe_phy_init(struct axgbe_port *pdata) /* Backplane support */ case AXGBE_PORT_MODE_BACKPLANE: pdata->phy.supported |=3D SUPPORTED_Autoneg; + /* Fallthrough */ + case AXGBE_PORT_MODE_BACKPLANE_NO_AUTONEG: pdata->phy.supported |=3D SUPPORTED_Pause | SUPPORTED_Asym_Pause; pdata->phy.supported |=3D SUPPORTED_Backplane; if (phy_data->port_speeds & AXGBE_PHY_PORT_SPEED_1000) { -- 2.25.1