From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B2D47A0093; Thu, 8 Sep 2022 15:57:13 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A1795427F7; Thu, 8 Sep 2022 15:57:13 +0200 (CEST) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2071.outbound.protection.outlook.com [40.107.100.71]) by mails.dpdk.org (Postfix) with ESMTP id D4FCE4021F; Thu, 8 Sep 2022 15:57:12 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HEBjniwcM4Wj5FSC+jSnqnfIpBhxPvu3l8N3dEbjuIHUKfJye1AnfBl/AzTRE/LCRSkSdJpG5AORXoyBAUPczjoq68tEGB1nf01jhWFHNDR/xqgYTt86/neJ4hUHEdZ8UAHeXk9MPGfWHjjkR4n9TuSORsmj2YqVZJsZsKPLSRL/exuerJsFsKxAPs/6+T9KqvwQ36yWGKGBiDiISECUZ8EME6WCVijZDbLbf+y64dt8vd5npT/5URMONzkEA+h8PKaMEWFr5AkNgtbDGfJW7fAmBNiN1wdMA/bCFt7Z91+Cm8zQOeVa31+9wAzgxC6qdjYkGg6KVqBRWw2EpVzNOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9ZRr1Oqb5IPVVGI8VTacapIPgp8xJwl584Na1olGO3M=; b=hQHW7MHF6azW6xM1bQlya33Ws5CZbzO9gYul9qBw+eagCXosUyYmOVBVzRF751iyK45X8joV4OqqSqeAWKGeEjsPW5/DQq8hkcI5qZBexMq5z+/W3BUi6W0GTqcDiui+1PFDKn4lbWFP96/IcBxBdSq/2JhkfklDFGRr2AfDN6EwpuwKbpGFCqFiJ9ZSI3TawEcIv9EtYtCy13kN/wHI6CWQU/K3I+5WvEtI/2TID3MyV4hyP1L8RMmE3Y8elVC35YZinlnzwXDrjcTVfnFpGIFmlbhXM4VkSACxfvQy/GfEzwLZVc3uxzRuZSukA00yyUsaUxd4dSSgQixitpENMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9ZRr1Oqb5IPVVGI8VTacapIPgp8xJwl584Na1olGO3M=; b=qFqupazOFIeBQsjcl3oYxa7H8vHV4/6sGM7w8IkMYbu4SZuODoBw87nPXTcJoehzjG21eSv5oZ9DBqCnYWjVb6/m5+9ttlLhsK93GZ3bIQa1zXk7BJzttnhUuZG8IioLoK8H6C2GsjW/E718UOrZbwlmTN2N+a+mleRvL49CUXE= Received: from MW2PR12MB2538.namprd12.prod.outlook.com (2603:10b6:907:5::14) by PH8PR12MB6820.namprd12.prod.outlook.com (2603:10b6:510:1cb::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.17; Thu, 8 Sep 2022 13:57:11 +0000 Received: from MW2PR12MB2538.namprd12.prod.outlook.com ([fe80::c57e:5ef8:1335:e1f4]) by MW2PR12MB2538.namprd12.prod.outlook.com ([fe80::c57e:5ef8:1335:e1f4%6]) with mapi id 15.20.5588.018; Thu, 8 Sep 2022 13:57:11 +0000 From: "Namburu, Chandu-babu" To: "Modali, Bhagyada" , "Yigit, Ferruh" CC: "dev@dpdk.org" , "stable@dpdk.org" Subject: RE: [PATCH] net/axgbe: remove freeing buffer in scattered rx Thread-Topic: [PATCH] net/axgbe: remove freeing buffer in scattered rx Thread-Index: AQHYw4B6H10Pl217NUK1Ofg56Eb/oa3VjrBw Date: Thu, 8 Sep 2022 13:57:11 +0000 Message-ID: References: <20220908124215.2976-1-bhagyada.modali@amd.com> In-Reply-To: <20220908124215.2976-1-bhagyada.modali@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Enabled=true; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SetDate=2022-09-08T13:56:58Z; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Method=Privileged; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Name=Public-AIP 2.0; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ActionId=5cb32cb0-b0d2-4e60-bf8e-e21fcf39c3eb; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ContentBits=1 msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_enabled: true msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_setdate: 2022-09-08T13:57:09Z msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_method: Privileged msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_name: Public-AIP 2.0 msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_siteid: 3dd8961f-e488-4e60-8e11-a82d994e183d msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_actionid: ab0a9a04-1fed-4524-9b70-277dd8376b79 msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_contentbits: 0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fc33a08f-a640-4efd-83b4-08da91a206d6 x-ms-traffictypediagnostic: PH8PR12MB6820:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UVEi9B8/ICg/2pnFA25/Fjs/2adRyLCkQRN5sHm/S1GWybM/ObUGoJ1GdZSPcDk4rPtNsl66RAM/ZzsDYSyzY/Cf/rRLceaPsFEjpZ3n77jit0pjZ60RyXHvPi6aSf+psYYLjfSqPoJhKEV1vtEgDRqdit0ZG8midaFnXANLiHxeExsV0DQEpxFHZwjbyh59ejYQm35FSjg1t5yF/Bun5uF21MGToKtpMJ+wj3gY62QSGA9T6+ZoOSJfIgw6v8aRJOg311rlcM8KsXYHxCS8Ffi2Ja01FSrphq/xqibYALEZZu1IXXcpgZdtp/0KlrU2VaJIgyKNsJgTwxPZ3aunpMt8GJekKFUqUshXzirIQl69X7nC3jJP1PgxpDA4r5jVqgravlsq0Htv7hdjWceUf2s/U0HOfnd3fG6e2tg6PBdzSmKn0jWrfniEqK98fQEV1/ie0sBnGBOqbpM+SvN9IXFYkMyEqHwlgof/oOd0pu6fYtW4C45DISoYT3g53/BkzPDt9FWzH0wBSPtYrRymUhaLpCMhirilnGl3B/DXcfX1AclYHeZHIYWpuJyEEEIjgl7iLhQoNpkkqoeaJYG6nVkhrB+28+0UE05874pEM0lwXwqC/yqowzvVLkUDB52NAKJ9JLucvp52WqXgP8bykHuDHSbXwl0cBTrs+6pISC0dKUnRB0FMTlSoXTmPkb594aE3D1ttooHNe4Fz+Ia7/074/+zVMiqryl4TnGSRLm9WH1tycGLNB1Mfoomivqn4DAjNXSJh5JTcv9SMowFLmmokfghhacdXgTxsiFZj6jo= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR12MB2538.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(346002)(396003)(39860400002)(376002)(136003)(366004)(186003)(55016003)(52536014)(7696005)(5660300002)(53546011)(6506007)(26005)(33656002)(41300700001)(9686003)(71200400001)(478600001)(316002)(38100700002)(38070700005)(83380400001)(122000001)(2906002)(6636002)(66476007)(54906003)(86362001)(66446008)(64756008)(8676002)(110136005)(450100002)(8936002)(66556008)(66946007)(4326008)(76116006)(83323001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mpqycaJjLK/Kddh9ap8agn50Mu+WEzEVh05EpkFpdXAGppUyQl25O00aFZAs?= =?us-ascii?Q?1WytExyFReT34XNjgfDxwvBH3WKvDzpc32ZeGHw+BLv1YPgjwusOmvIL4q4Q?= =?us-ascii?Q?r+TO2JdHSZWoBnEwoHkKmFe9eRkli9AYMtAZZNK6/UoAhSwiAi/AYXfsWnO5?= =?us-ascii?Q?sImEK/+wRl8NcmxRpVvQiBTyCuEQR3WXrREpotXLjGIRZkdKCW0G55ac1rwo?= =?us-ascii?Q?67ub4VGmAw11+GvemowgQWfAJRR1vzmmzR56e/uB6hkDzrYLdOCamMzDSOeX?= =?us-ascii?Q?MgCvIDw5MQG/zsz9htVomH9CIN7iEHwb5E2U3Nb2X4uEkNdL9aiaE9ZSSDQs?= =?us-ascii?Q?Shujl7S0gN3K4nsvPCT46kPYu6KpraDW03epflZZUFvhROWsu092yZ5gEVXE?= =?us-ascii?Q?etIB94uru7pcQF6PdAjPUhcgjFbVZzZrNnTKJnW6sLbrRjlZF1VpnWSegJvI?= =?us-ascii?Q?Hk8q2tTOYofAU+kKPNXjr9pNIPyG9nfh8hM/nS6giQiJcuF6eHSu+9szDmwz?= =?us-ascii?Q?SUkFEsrA1kJHDMauzkO0nToxgH1nWZ+/w27x4NHLPhQ0kIrWzY1mvRdJ7V1K?= =?us-ascii?Q?+hv0QbYagkPpX0LDXq8Gm6zR3nKdJihLD7PnODgUe91RXvQozDDqnv0PkzC1?= =?us-ascii?Q?czd/DiuXJEuWteGF6Pm9nzmLYWfnh5m9XuEX8yBAhVetWifdt6U0Aq2+7QT0?= =?us-ascii?Q?B/8FkLZu3YnJ1aZOcVZt+24ruNex3pfK35NIPQRFPHfQ6uSu1AYuhRHNBhSd?= =?us-ascii?Q?VrAMMOwrYRFgQp+Jx/t51po7iLUC+jC2rfcFP9hGYbPcCNotcXXL2sDcgL+8?= =?us-ascii?Q?hfCZ3CyfbXdweztCCkPj5Mz+375z8dKHNFwyT543INnU3mP15xnaaOarRKPG?= =?us-ascii?Q?3xVvGg7sIyz3OCT6ugg/wnjVAfki1KrZxJR5v3p2tSs0OuvFshIX32L6rUGP?= =?us-ascii?Q?fkhtH0FwE53HdWe9gVnzbb2lONjsYtXzS6MO8QC3dnD/NC+mv79pJaNcoRiQ?= =?us-ascii?Q?qJmjfuVhHjWGPZwldJe9rFI1ytmoBD5qZADx/v6YYa5/z+cHxvpOmqM/PtiS?= =?us-ascii?Q?88wDEpLPqRLrPanTFLEiMYmPd/B2BVnW85Gf6ZFr27IhHezbbFhnmSUm/2vU?= =?us-ascii?Q?MmSxUkZZz9JZbG1sdiJ+aJYH2eC5bvGGbuFGj3uXgKMXmgeCa/b5qStLcY9M?= =?us-ascii?Q?q2oc5j9Qjevqtr6La3MUOjV7CKE9iSiD2X7+GDapOA4jnzMcluXWHtUkW5ES?= =?us-ascii?Q?B2yUdo/z5GWAtyJPYwgLUwqDW7cOHqlAAKzbNtCtU1Yh4Pw7+x7sTB3QpD+J?= =?us-ascii?Q?v1dWvWPBZWxazbiJ11bLFCKPwvKqv2Z3ZyRIuo2lNBjUOKlYALW9mOiIiGRy?= =?us-ascii?Q?/6lPG3cZy8Mk1M2VJ75ks6MI37/0U2jzeJpKErnoUkOGVlA9oi6oPFDVj/M4?= =?us-ascii?Q?9UiCwd64olXv/ja6hzq/kp2Z7C1bE1CCqZAcSDrFkYCmZ5Qgk36GoBeXMWRk?= =?us-ascii?Q?P4/yvqYqrN/KW6T8VPeqwvn3uVsGSTlkSHDQ9tGG4PHNhCbZuFTBrxAXVNTG?= =?us-ascii?Q?OGKAOfnEMKWsEvoduns=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB2538.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fc33a08f-a640-4efd-83b4-08da91a206d6 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Sep 2022 13:57:11.1172 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: S7pn6zGce2Vbq2ob7/Hgkmnjoc82t1/KV+7m+zE/NX/fIV/z1hU/aeB7CMIV2KbYJ9HS/VKS5U3UVvLTYxr5tg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6820 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org [Public] Acked-by: Chandubabu Namburu -----Original Message----- From: Modali, Bhagyada =20 Sent: Thursday, September 8, 2022 6:12 PM To: Namburu, Chandu-babu ; Yigit, Ferruh Cc: dev@dpdk.org; stable@dpdk.org; Modali, Bhagyada Subject: [PATCH] net/axgbe: remove freeing buffer in scattered rx Removed freeing of mbuf in scattered Rx as it should not be freed in rx. Fixes: 965b3127d425 ("net/axgbe: support scattered Rx") Cc: stable@dpdk.org Signed-off-by: Bhagyada Modali --- drivers/net/axgbe/axgbe_rxtx.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/axgbe/axgbe_rxtx.c b/drivers/net/axgbe/axgbe_rxtx.= c index 8b43e8160b..d4224992ee 100644 --- a/drivers/net/axgbe/axgbe_rxtx.c +++ b/drivers/net/axgbe/axgbe_rxtx.c @@ -458,14 +458,11 @@ uint16_t eth_axgbe_recv_scattered_pkts(void *rx_queue= , memset((void *)(&desc->read.desc2), 0, 8); AXGMAC_SET_BITS_LE(desc->read.desc3, RX_NORMAL_DESC3, OWN, 1); =20 - if (!eop) { - rte_pktmbuf_free(mbuf); + if (!eop) goto next_desc; - } =20 first_seg->pkt_len =3D pkt_len; rxq->bytes +=3D pkt_len; - mbuf->next =3D NULL; =20 first_seg->port =3D rxq->port_id; if (rxq->pdata->rx_csum_enable) { -- 2.25.1