From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 753ACA04AB; Mon, 24 Jan 2022 17:40:14 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6958641160; Mon, 24 Jan 2022 17:40:14 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2072.outbound.protection.outlook.com [40.107.244.72]) by mails.dpdk.org (Postfix) with ESMTP id 0A58740040 for ; Mon, 24 Jan 2022 17:40:13 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bQHL4gUbRhKaiu23jVqj7jVW6IWmonqUBubmdA0c4+9JtzQkdFnJF+owuG5f6JQKLh3FzRr1pqopVGY3nDizE8ubIBVn/kNcazpzmHcowpMa+5OF0U+CXnEkf4TXAsXMVXMea38oXlP7vCB7A+TZqfk/ro/Ri9o6DpykmUuzI+WwLMaz3QMuVcPz2BUpqmhDeJ8WO9NaTIT8PfsYR0RW3zUKtwsUp8gTgmXeGNH2GdNQ2BVm8dK/A+Kt/GueqFDKDentYsiqiVjF6KEbW7x703/ox6a4qRXOWpTbJfQbYkMKa5dOQV5gW2/wmAyF9/3Y7Bbh02vjuuc4a6oho5a4Hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dVT8BRvBIoBzc6z0Ww43IrzxdC2m9kI2TKqX9XXSiYE=; b=PtDDYtyyl2QXfT6nruD79QNniVucAr6HQasw/hIjQxwxPngOH3lWsW4hNn53xFQz18Pijeztb1g5XbGRYufPY+f7gJIXYred+mncCuX7+LtJkcfst0Mupp5unRqoDWxjwbxsaXgPnsdmCyxkxppicyW6LTzmhqFhnZOIG932ONc3P4K9sN6XMkWMz6vKM//F6kYFQeWxHmbV3WNAm9CDQNWvlglA7UQWV1EBmF9wAw4tK3zNbPTge9/+M4cZT5e2UwoeBAiHzkZkpFKcTEZmxTyqEczSOEGCQXbp2JM2bdpP/RnKkM+f31p9FHX0gxXR3UoBn97TuvXGIyDo9tJn/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dVT8BRvBIoBzc6z0Ww43IrzxdC2m9kI2TKqX9XXSiYE=; b=gsDkdmmIqvyKO2H+y1KEscJJzKuYBp8XwfOzNyeRHteA/rJ37KxrwMDRSkvlGMtyYP4xdNU5Xp/384y0iCRFKjuaDir8wAGcNiTMCvqxmA4CAqOPWadoG8yBvjnznRym8x5coGvNqYk5mSiK7vbLN7THginR24GZwc1SjWiS3Ls= Received: from MW2PR12MB2538.namprd12.prod.outlook.com (2603:10b6:907:5::14) by SA0PR12MB4525.namprd12.prod.outlook.com (2603:10b6:806:92::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.8; Mon, 24 Jan 2022 16:40:11 +0000 Received: from MW2PR12MB2538.namprd12.prod.outlook.com ([fe80::ad98:6ba4:7d63:fd6a]) by MW2PR12MB2538.namprd12.prod.outlook.com ([fe80::ad98:6ba4:7d63:fd6a%4]) with mapi id 15.20.4909.017; Mon, 24 Jan 2022 16:40:11 +0000 From: "Namburu, Chandu-babu" To: "Sebastian, Selwin" , "dev@dpdk.org" Subject: RE: [PATCH v1 6/6] net/axgbe: alter the port speed bit range Thread-Topic: [PATCH v1 6/6] net/axgbe: alter the port speed bit range Thread-Index: AQHYBhZC72ufzorlHUu8Tp/HoHA086xydd6A Date: Mon, 24 Jan 2022 16:40:11 +0000 Message-ID: References: <20220110113509.553184-1-ssebasti@amd.com> <20220110113509.553184-7-ssebasti@amd.com> In-Reply-To: <20220110113509.553184-7-ssebasti@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Enabled=true; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SetDate=2022-01-24T16:40:01Z; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Method=Privileged; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Name=Public-AIP 2.0; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ActionId=2506d327-c0d4-4747-999f-766b891616bf; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ContentBits=1 msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_enabled: true msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_setdate: 2022-01-24T16:40:08Z msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_method: Privileged msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_name: Public-AIP 2.0 msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_siteid: 3dd8961f-e488-4e60-8e11-a82d994e183d msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_actionid: 853142f7-afac-4180-b009-65706a341b1b msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_contentbits: 0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 56f85c20-6178-4e56-0f52-08d9df583080 x-ms-traffictypediagnostic: SA0PR12MB4525:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2koJr9LNEwLw8xU6eOKP+vfSMe6W1psHBRGzvPo55drnDFhTnKZGDWQg4scGnIKuVZ+3o0mnmHHN3comARKi/JJ2Q7fzdACrr08KOHo3DtmFMITZqoiW/GqJobZDS5VCCwXcQcFFSlG6YbiQtV9IYDxjeHE8HdfkC9tOfyFIWj9XIag5yU2EktCbvaNN23TCcn7lWFOREqdyr1v3AaKHRIbjMiYwumqeYSCXePer6UFKZ9GOljynxFXmZJl4pmVQJcVsSv7ZhuHmgaemp59KCUEYRCZX/zIoxJfcYhChUyKr5qCXRUBXSXEeFCsBLbczdGhAqw0G0e/xOkv5zr9CK1QU88khJAbw6/ILxWMFssHmYTkmsN8xIZouOrqZe+KEZCkaMlrzb2c+xOHCkYZW+HR2zDVkYK9QXnX8A5wUnW/JjuPISC4AWZ9reOa4g6WHBiJJMDJNteR96VxgW1NWvXg7o+6ZzT0GbVapyp+AjpDWA7CO8rqvcwQ0dURqbktWOvsraJh/dzrQZI98xaUpZS4mcFtkG9sVKRtZJ7wQv0wTTUDfrcSOJldVJ8Hl7whs31pDlAP3O6S/oljNoy7xvvOH6QO76LH7ccIRJiu0z72xXvopwoJv7ffmuXimaYUS8ILFzo0/6aiVYXBE6hQKB4N5/7qAgLc2qlnWVTjBds19E7fiqOVZlr69Jx5jLImWir0mmbjK0g9HcRZyKwYKQw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR12MB2538.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(186003)(76116006)(38100700002)(316002)(66946007)(66556008)(26005)(6506007)(53546011)(38070700005)(508600001)(83380400001)(2906002)(66446008)(8676002)(122000001)(55016003)(5660300002)(33656002)(64756008)(71200400001)(86362001)(66476007)(8936002)(52536014)(9686003)(110136005)(7696005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Wcfxy7TuxDY/kthYlYKkHMJFDA/pQdgdotcz3Twu2NTmhB5GSlMP8Fu1yNhm?= =?us-ascii?Q?8UakjiR7Ch/Npuif8t8FFJai9//7cCqEJemOLpb4YhWdO8JCxJDEtlcNoB0g?= =?us-ascii?Q?iO6S8D23gDLQH6Gj+AmGjLQBeVs2euI9XPrAl7mHzGCOyMwD4PM0N9kSkUJE?= =?us-ascii?Q?e/IIkPwjNw6Y7NHz7lZXSouB0DK7hCu4UmdfMsSd299ZpVMNIvnh0dKwZ+2L?= =?us-ascii?Q?JKlx9s+jWNj3h1e7thgoRdTCyZAp/3trsJtpjYdZDE/cG8RzKpJeywZezPGW?= =?us-ascii?Q?9LDy8IhcrDZ5eE+FD44deEv55fM8sCrPNL1ZBL+tnVLgE88JYiBCkOzp4WZE?= =?us-ascii?Q?6MBRB9CFCEqHMEXcqyteobaSFkQKsHdcPlud33bCHQdH4f3eNIk3SvSHa2ih?= =?us-ascii?Q?/oAXwVIOQYJCSnoQspJdq6ZzuXIdSHCQg7CEBICHWgjoJSdvT/ZWbD2OgYSt?= =?us-ascii?Q?E6kvu/cVOUEwPu+2d8FicMiABlPguFxowLrLFKqlNxKdvWW3U3K8ZhzJdsg/?= =?us-ascii?Q?xGHPfq7epxyF6db0IRxLFar7tt/HDV3Yf+XRA8kVWCkvxpgah/YnINL+6i8A?= =?us-ascii?Q?36G2SfieucfEHchVJZJUZVCOUr+Bn5sE8YEia7urKMJimy/GhE/tmwGqAsNS?= =?us-ascii?Q?16dkVQrTe4bDf0xqSbGT0TjZJWEYwzHWErWYE+gCPE1MzqNmqKVc1JEJHDyx?= =?us-ascii?Q?gzRGQlPCY2DGDb4nwcOBcXVEO5jYH4VOroMygKiQXL5uO9wEtQK7LxvzSDsx?= =?us-ascii?Q?ON0A3iJzCHLoUvqpGWhFahtTMXLqbPL0CqyV2K4wNqN6UXNQCxI6Dp2L0fuz?= =?us-ascii?Q?t1IQfcyG4BTwSQ7wClOx22qu39bsQwDCpVIDD/SvIlGf9PeT7qGamSfW9B1b?= =?us-ascii?Q?YSrggOYoWdV5go62sePj/lyYcXgqakfqK107IpZtyosf2JWXKcdhdyv1dcmb?= =?us-ascii?Q?2u5cCzyAd6BcxiwDiC5ufksJOtJoj64cg5deqdH65ZApMs/5IlDr6IbZf/Kd?= =?us-ascii?Q?Cxxpb8jWj/qcKJTxZeZpVmnMh/CUYb+/7cCz80T/NnOLQQnjkIgXvvOLz/n3?= =?us-ascii?Q?5DFhNP58H/Sg+oZM7MFDSO3WSEbgfxVxiqgn1Yk1MloKTlp1+SyWhMc4W2u+?= =?us-ascii?Q?gEZpH1HuPH6xHFKv0XWILjA8i4dG5a6BSWhcj3r2LTNpcnouc3+3w7mYr1E1?= =?us-ascii?Q?qJAB+gXgJfVIPCvlIjXySD9aSuztI5YphVNxffm0HXEVl8s9v2jdHP6jq9gA?= =?us-ascii?Q?dvwhtG4lvXiy0l3STnp4JjqjSgMbCvN8DEVo9ilcabDYYK3QFSsTGbUL4h4p?= =?us-ascii?Q?1qC+tVA1o+q9KrAGbx5U0zFDfISB5ZidIz3EfBmYh3/Ku3Jq+4vyk/tPHQ8B?= =?us-ascii?Q?EoUFMeXmoaogZMPqLusFGsr9g+8HkGAiIdQhOsVslPMyJ+aeifN6Ksq8mZr5?= =?us-ascii?Q?cG3orlNbu0ARNVcCDuiV6nQu08hoG0IR8fWLaHBoXK76Sdh02APjbp+tVcS9?= =?us-ascii?Q?H2ecWxb7i7yMhGnk+YtaqxsC7MVHFlzxKdjLLMQ+oCK5zBLtEtdfG7MYIf0P?= =?us-ascii?Q?x5ah5Fj2qlz7jvXvkT8YAdsqykAriGoJLK8g92PHTT52ww1B53+OZuM9g1i2?= =?us-ascii?Q?JbkDaOeO30WnO7tSpA6kV20=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB2538.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 56f85c20-6178-4e56-0f52-08d9df583080 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jan 2022 16:40:11.1575 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FhOgtTZReJdRGf4xueqsyHiT2DdVQ5aen7B0aUQNHNGH1WVBx3pzdmjqSKzR4PU6Od0ALBkfsDD8X2fhQWk34g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4525 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org [Public] Acked-by: Chandubabu Namburu -----Original Message----- From: ssebasti@amd.com =20 Sent: Monday, January 10, 2022 5:05 PM To: dev@dpdk.org Subject: [PATCH v1 6/6] net/axgbe: alter the port speed bit range From: Selwin Sebastian Newer generation Hardware uses the slightly different port speed bit widths= , so alter the existing port speed bit range to extend support to the newer= generation hardware while maintaining the backward compatibility with olde= r generation hardware. The previously reserved bits are now being used which then requires the adj= ustment to the BIT values, e.g.: Before: PORT_PROPERTY_0[22:21] - Reserved PORT_PROPERTY_0[26:23] - Supported Speeds After: PORT_PROPERTY_0[21] - Reserved PORT_PROPERTY_0[26:22] - Supported Speeds To make this backwards compatible, the existing BIT definitions for the por= t speeds are incremented by one to maintain the original position. Signed-off-by: Selwin Sebastian --- drivers/net/axgbe/axgbe_common.h | 4 ++-- drivers/net/axgbe/axgbe_phy_impl.c | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/axgbe/axgbe_common.h b/drivers/net/axgbe/axgbe_com= mon.h index a5431dd998..5310ac54f5 100644 --- a/drivers/net/axgbe/axgbe_common.h +++ b/drivers/net/axgbe/axgbe_common.h @@ -1032,8 +1032,8 @@ #define XP_PROP_0_PORT_ID_WIDTH 8 #define XP_PROP_0_PORT_MODE_INDEX 8 #define XP_PROP_0_PORT_MODE_WIDTH 4 -#define XP_PROP_0_PORT_SPEEDS_INDEX 23 -#define XP_PROP_0_PORT_SPEEDS_WIDTH 4 +#define XP_PROP_0_PORT_SPEEDS_INDEX 22 +#define XP_PROP_0_PORT_SPEEDS_WIDTH 5 #define XP_PROP_1_MAX_RX_DMA_INDEX 24 #define XP_PROP_1_MAX_RX_DMA_WIDTH 5 #define XP_PROP_1_MAX_RX_QUEUES_INDEX 8 diff --git a/drivers/net/axgbe/axgbe_phy_impl.c b/drivers/net/axgbe/axgbe_p= hy_impl.c index 2aad8babd2..776144696a 100644 --- a/drivers/net/axgbe/axgbe_phy_impl.c +++ b/drivers/net/axgbe/axgbe_phy_impl.c @@ -7,10 +7,10 @@ #include "axgbe_common.h" #include "axgbe_phy.h" =20 -#define AXGBE_PHY_PORT_SPEED_100 BIT(0) -#define AXGBE_PHY_PORT_SPEED_1000 BIT(1) -#define AXGBE_PHY_PORT_SPEED_2500 BIT(2) -#define AXGBE_PHY_PORT_SPEED_10000 BIT(3) +#define AXGBE_PHY_PORT_SPEED_100 BIT(1) +#define AXGBE_PHY_PORT_SPEED_1000 BIT(2) +#define AXGBE_PHY_PORT_SPEED_2500 BIT(3) +#define AXGBE_PHY_PORT_SPEED_10000 BIT(4) =20 #define AXGBE_MUTEX_RELEASE 0x80000000 =20 -- 2.25.1