From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8F893A0350; Mon, 28 Feb 2022 06:35:13 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 63D874068C; Mon, 28 Feb 2022 06:35:13 +0100 (CET) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1anam02on2065.outbound.protection.outlook.com [40.107.96.65]) by mails.dpdk.org (Postfix) with ESMTP id 404554068A for ; Mon, 28 Feb 2022 06:35:12 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MCSXHcq4tchGB3WhYzPrGD2568SzxMgg1hVpLCpmdq/nHTfKhCLYUzztyh2n/SWd4VRdaUWYRqVI7WSP7QzbYmi6iMmYmzqdd5FVUB2WAwhIZI0WAzjPgL8EkdBHpGAP7i7OWEbDCwHIyVl7mQfMKVt37CDUFZwu+o04AOEbYSI9nZ5Dg8syf2Hmn0lptBqzAMAQxjY024+yJumPTtZF110y2IvxldDjUQJzrt3g6dqJf9us4EtaQhFhzOA6ms/cC1Eh6JDo8MLCcmSDKK3SPMSmjhN38v2MmhAFp6NUo8V/tV1ye2Gt3e+9RY9pW/9HqLGYj/CQYCD6UB45puk55g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3Zi1zNrauG6/KPZR8+DcbFPo1GRFZYZlmhFZ8UcMfDo=; b=my95KQKn5VC6uYOjxHXqlAj5ZU14QHg8lVvyvXml4/95GbsqIuQM6/1OoN6wxTuXyDt7FP+2eob5odWRBcL0dSn55JfRlSnd9ZgFMzn1jzPM2mmwUUzSMnrjKcMb1wcZRR7YPLOUHrakYdI9bSxPCqGU2qvU0eF60TOgiLmsagMKAA9NC8XmgaMXdOykgalfQSAV1hlGJCrhyK4QXvWGl6ZgA/5jR8SErVtG37kofQ3BMwuNCbh0ZLrkDl+GZqga5dNpMToqH+eTIj4DDH62Lk9Epc07G5MAat0tzmXTYYY49//nIaScNSba+XQ4YG7o4SZ/kCDyiiKtHd/iXlNeFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3Zi1zNrauG6/KPZR8+DcbFPo1GRFZYZlmhFZ8UcMfDo=; b=PAFdkYpIIJ8d89TZFKy6QTOpKPOJVvrDegxy6O5ZR6IVoM6AA7vA8Wsy8mcDNg8LHmYyT86zvqLIm7epv1jr/XEJ/KQ2XTYaLVxyRoiUh/9dYAF5yy9rAcjdBmCo/ff3GutgWt8J6ThsUXelzi4iLpU0Pq6AtoYsPRWmBP8PwR0= Received: from MW2PR12MB2538.namprd12.prod.outlook.com (2603:10b6:907:5::14) by BL1PR12MB5899.namprd12.prod.outlook.com (2603:10b6:208:397::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Mon, 28 Feb 2022 05:35:09 +0000 Received: from MW2PR12MB2538.namprd12.prod.outlook.com ([fe80::f040:8152:9dbf:8e9b]) by MW2PR12MB2538.namprd12.prod.outlook.com ([fe80::f040:8152:9dbf:8e9b%6]) with mapi id 15.20.5017.026; Mon, 28 Feb 2022 05:35:09 +0000 From: "Namburu, Chandu-babu" To: "Zhang, Roy Fan" , Akhil Goyal , "Ji, Kai" , "dev@dpdk.org" CC: "Sebastian, Selwin" Subject: RE: [EXT] [dpdk-dev v5] crypto/openssl: openssl 3.0 support on sym crypto routine Thread-Topic: [EXT] [dpdk-dev v5] crypto/openssl: openssl 3.0 support on sym crypto routine Thread-Index: AQHYJL3g3B4zPCAEx0WoGMq+lQFteqyjGKsAgABGG4CAAE7eAIAAazkAgAAFqYCAADV7AIAEK1Eg Date: Mon, 28 Feb 2022 05:35:09 +0000 Message-ID: References: <20220218094408.49290-1-kai.ji@intel.com> <20220218115124.57745-1-kai.ji@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Enabled=true; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SetDate=2022-02-28T05:31:47Z; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Method=Privileged; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Name=Public-AIP 2.0; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ActionId=f0c876b4-00ce-4913-9e0c-adb71b24d369; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ContentBits=1 msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_enabled: true msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_setdate: 2022-02-28T05:35:06Z msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_method: Privileged msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_name: Public-AIP 2.0 msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_siteid: 3dd8961f-e488-4e60-8e11-a82d994e183d msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_actionid: d1aae416-3071-4791-80ca-3fa0f669cd38 msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_contentbits: 0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f5c9ab5f-39c4-42e8-71fd-08d9fa7c15c5 x-ms-traffictypediagnostic: BL1PR12MB5899:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: V+6P0VU3tdS87DdLSW1wC0vi1YUqLh6jPhegtcey+Exd81y72RVwFVwE0hfm64QhaChPBtKaiCVHBYuEH4yUXctHQeOuV08wvqhFSiUv9Q8zjQxtfxB+8vJTrTV8Auhk8XxxtdnIghGbLmxoD0ziMt025VaUFmP0MrPVcodL3kffs0cEOqXFG2Qv4PCOm31taacu0ImgradlfP1JMVKhI9hVQIdc+8XB6JJuNnrWN7gckzzQJPpe+6UJJFFf65Ok3aKQGxm5kazbQD48sH70I8DDTgL1TjSM1FiEhJULwU4Jzj8jY/IzhIROrAW6vr4MpxUDO5L0OB8OIfnu/8bScHvsXsmU5IWMQNAyI8Af97srWxGgN2j1pvZgLf0TDyeH8pnySOT8pXYoaC/uYgDrj8xNYO70bGbm82tTGYWJKW7R/5pOv6aRZnmORiKCDgVeFN6eJSyFOs/C87T1zxvsoPGMcagQOE9gvJORNWRxswYJtj2ww61bBx1KzQGM5F5cZ7W8NdOVbgtDe9thc4y0W6+/MpGgF65cUNcHFf1KM/pDx2OoTpUfaaADTidAUJXQYl89wXqCLdEc3WtAuC/TqFNpIu3Q5z0Y65knJCtFrs4cYYVCs3xL4M9uH0CMJJ283vgA4AlM30FiWiBsZl/f5l2mVM8I5wp/Y2aAMMOfLCntMT/eAviXh9wqZB84QaJPzjSEoAp/2mIjgDpeMZU+vw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR12MB2538.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(9686003)(7696005)(316002)(53546011)(4326008)(33656002)(83380400001)(71200400001)(6506007)(508600001)(186003)(26005)(2906002)(38070700005)(122000001)(8936002)(55016003)(5660300002)(52536014)(110136005)(66946007)(76116006)(64756008)(66446008)(66476007)(66556008)(86362001)(8676002)(38100700002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?eCX3wwU20t9ix+7mGo43Nw7DgPckrh0gupat/NXQuU+FO+k6VWPmFwYYuM5j?= =?us-ascii?Q?e0XdGymI9ItJDUwsX/Awfq/FyF3ZbhZ35vmwMYVpvUwvS88sEjkEfwi8sWfa?= =?us-ascii?Q?hJtCMCuAaibh5770Oc6z6Yt8S2DlhnZpi7jrB/vX0RzMf+kME8FYB7aulQB5?= =?us-ascii?Q?IGLHD07PPUuvwKyb3zu15X/0CC2j1BowBjTHKGZVuucLBbJ3qarKBE/vJCo1?= =?us-ascii?Q?eTjdLqAvyY4XFWDNlfJ/GYJCQ5XYW6YtHSdNgomHFJ+YKuLrG7Y83i1iGO2t?= =?us-ascii?Q?xih0XxwaUNZa2DbbX5LhVDttKmQPwYEiCCGBV8g4vq0X+D8crcA4mGdv9InD?= =?us-ascii?Q?Ainp/rKjVYpHX4iSrYBziUZ9M7yeuQmFeWmWpA8vH4cmSBcijz4qmHjd6gYl?= =?us-ascii?Q?AMX+CmrUtO2O9j8HuCdCyTWqAAD/Cl2lr+yP6LYQnle51gV7GBg8rJulcP3y?= =?us-ascii?Q?GEK/UheaKzfmbDSKdfbSbqvm2nusn2H+whhrt/jHkPvhbZCuTQBrq5lDL267?= =?us-ascii?Q?EDr0YvZllSqwmvgvf/uJwqd7RWBa8x5V5Ym34EfEQoXgncXCz/xJvkrIrpqE?= =?us-ascii?Q?M7gmMVqw72H395togTC5Bv6MZCr5xHRmt9McoMdzTwUIImiowJntBEV1evV7?= =?us-ascii?Q?yBUzvICN4SD/K2fdf3PQeMI8dz7BujuzAMzyrRFHiNbTHf5P+p0H4D2C1iBq?= =?us-ascii?Q?uDDebsmXiqHPisoSbQB9RqOMyut4fyyTR/VfaXpZm20DA3CnTc3GHSZyhPSV?= =?us-ascii?Q?Ygghs5UZ5e+Nj27AMai6uxZh5GxComqMfmc188jaBsNYdZxTiQvCCL1EUSy/?= =?us-ascii?Q?qt2iluaNy1tuJsAneohTQbPArM1g+ng+HSrqXzO+G0zIFejr+4F+riJqDRiW?= =?us-ascii?Q?j4qYNObEsIBzv3+dyDpogsuTWcVX0y2sUNgajYn8CBaOAecQah9y7eltWfD3?= =?us-ascii?Q?ryuw26guLATgJgR+JA5B/dcc0zmWnRGqaScGwABY4L7BCCkR8O4vsTxbunyz?= =?us-ascii?Q?4tJRVSIFE/+Jdj/+cEJYFKYlmHwCZ7ANj6eh/cSakR4t5EK5PiMhb6SyKeIa?= =?us-ascii?Q?YjZn9swvdexpUd6khsdooxuxirvfNUP1QewHjJTAJ2+n9O1pGYgdxKjsKtLp?= =?us-ascii?Q?Pi9Uqs9EpqOmzj50U5Q2HZjoRPGJlF5j4WypoDk3+HJgtNgDta/1iXXJdRZG?= =?us-ascii?Q?ORRo5rRiydjiVGKLwzCn9YIzCt5bXhcEHNoWFA9/PD7ToTRT1tVXmhKW7fiP?= =?us-ascii?Q?1BxL0Sfmznurrdz50rmuA61jFLjs3I8eWcA/ghnOwFySBzN644swrHCfIWrI?= =?us-ascii?Q?DKD00mJe/xXPqYFmnPdeqymmaH1Q5Lt9SCU9BbK8WfW28rlQxa65427ggBGn?= =?us-ascii?Q?Yl3DfqiQo9LA4CIIx+Djp6ZmXAQK542priYaCmqukvinPXewffOwUpacnuKD?= =?us-ascii?Q?pkHz3fucB3WYnjDKkBx6WvlEWTrAtdxN6GdpY05QxxIhkBpQooR11mo1QFWh?= =?us-ascii?Q?Ykm6fYtZ6Kg/JPQL08atxEhm5nDm7dV8a/DLbcKKvhFDCTQLUhmBoWCwvSiY?= =?us-ascii?Q?qY70jqpYSqKSYIKZGZLM+Fc/D7M2QqCD7yzc5DlTKdOPp3XKW25Mo+NBvC7s?= =?us-ascii?Q?/B4Fl5D8RY+cS+DmSoHQE1o=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB2538.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f5c9ab5f-39c4-42e8-71fd-08d9fa7c15c5 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Feb 2022 05:35:09.6223 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3GZkX0HRg7eGLym8e6irhZrGTM829PJA4dbB68xy00ZymgFluKkxvnNnwdVwk10S8HrrMLC0FIDeFErT1NV5Pg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5899 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org [Public] Hi Roy Fan, -----Original Message----- From: Zhang, Roy Fan =20 Sent: Friday, February 25, 2022 7:21 PM To: Akhil Goyal ; Ji, Kai ; dev@dpdk.= org Cc: Namburu, Chandu-babu Subject: RE: [EXT] [dpdk-dev v5] crypto/openssl: openssl 3.0 support on sym= crypto routine Hi Akhil, > -----Original Message----- > From: Akhil Goyal > Sent: Friday, February 25, 2022 10:40 AM > To: Ji, Kai ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [dpdk-dev v5] crypto/openssl: openssl 3.0 support=20 > on sym crypto routine >=20 > Hi Kai, > > > > The warning messages are deprecated APIs warnings from openssl , not=20 > > compiler warnings from gcc, the integrity of DPDK remain the same. > > Alongside openssl pmd, the ccp and qat pmd also raise the same type=20 > > of warnings once openssl 3.0 installed. > > > > In the current intel roadmap, we will try to support 3.0 API fully=20 > > for openssl > and > > qat pmds by the end of year, so this patch is the first step. > > I think the warning messages are safe to stay, Unfortunately the fix=20 > > ccp > pmd > > driver is out of our reach. > > >=20 > When DPDK is compiled with openssl 3.0. I am seeing these errors in=20 > compilation. > So, compilation is broken and we cannot take this patch as is. > We have few options, > - fix all of these errors, > - add exception in meson.build for ignoring these errors. > - disable/skip compilation of PMDs if openssl version is >3.0 >=20 > Adding only one type of APIs does not make sense, if the driver is not=20 > compiled. >=20 > In file included from ../drivers/crypto/openssl/openssl_pmd_private.h:12, > from ../drivers/crypto/openssl/rte_openssl_pmd.c:16: > /usr/local/include/openssl/dh.h:223:27: note: declared here > 223 | OSSL_DEPRECATEDIN_3_0 int DH_generate_key(DH *dh); > | ^~~~~~~~~~~~~~~ > ../drivers/crypto/openssl/rte_openssl_pmd.c: In function > 'process_openssl_rsa_op': > ../drivers/crypto/openssl/rte_openssl_pmd.c:2068:3: error: > 'RSA_public_encrypt' is deprecated: Since OpenSSL 3.0 [-=20 > Werror=3Ddeprecated-declarations] > 2068 | ret =3D RSA_public_encrypt(op->rsa.message.length, You are right. We will defer the change to next release so we can send alon= g with the asym openssl change Kai is working on. But since we have your at= tention I would want to drag Chandubabu's attention too as there are three= PMDs uses deprecated openssl lib APIs: openssl, qat, and ccp. Adding a sup= press flag to meson build file won't resolve the problem - we need to resol= ve them before the APIs are gone for good. Thank you for bringing this to our attention, we will work on CCP changes t= o support 3.0 API's. >=20 > Also, avoid top posting of comments!