From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 94CDEA04AB; Mon, 24 Jan 2022 17:40:34 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7AA92427DE; Mon, 24 Jan 2022 17:40:34 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2078.outbound.protection.outlook.com [40.107.92.78]) by mails.dpdk.org (Postfix) with ESMTP id 4277640040 for ; Mon, 24 Jan 2022 17:40:33 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C3Yjp3HbPOZLgKppOXPAYpqBpqD0Xqz67hWu7HczB8g66DdSwdfKLSsJeFLL0LFLOMVce5f6qtNyaSoUXK7jlLAqKaoHO5hoLzVh6aOoBbx2IoYQx4uDlBhECv/zzSzjIKlLdZfIO/lqBacLgLA3i1Bo2w41bl8YwN3Z7dB9STHD3K3em39RrdITtetW2HohFaoyJ41Cgivag5Ljl+Y6bsam/p6Uts6KfqLjL28BI8Hvp5oShy1UTciqXXjxM2pPyrGQ1Ie/0Ua50naowoxkDvCJzJkncjHjFeXSmrpXEHTtSS8gwP8giVMaP2WPtLkga91sysTDwBkY7X2WLN45Pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7+4XHqD0BhZCj47xQ0PKGeAfeFt5RQ9R5c3YuY0JIUM=; b=NcFJVc+icaPtJzTfbB/iTlLtud0DZqxyBfXIcgb2/nd7UeZ4n1iOUttp3QgDoJaMkTpoj0CU50klegTHiBiWdRbVetDzGhxAM7+gmg7h32kwryYZOzk0XRwz4siW4NW+D46g/QsQ75PE3qukvPRtfk8OTaQ5Nefo51cmmYdeRKEss/pUYxjEp2cpe1WlSpaKmMwUK3hEtfmf53Z3d1iNOGB2xndtZyWmmckhqSY1ivZMkvm9+EE/scnuSZ1aN5mtYbQl4xESgWIcROqLnxPG9E+XAr2om08DNhczoXkafswwEXdZ33aUS8Pt5l6qd7BNADzJNemd3dfGZp5hlv5UWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7+4XHqD0BhZCj47xQ0PKGeAfeFt5RQ9R5c3YuY0JIUM=; b=IFjnPs2eej9nagqqpJFBY47N6eJDxaZ6u1dCwYAlXzzCYlSU59LyovL3SYgHc2mtEKwFiFeyNQoqoqOYpP/NAOi4v9oLHSogSDoM5p0O5RE6MRb0ttn/8adeZAQOm9uXF3siZdMkRC37X5E6JclA2s6YuLegD4Li58fWzv7bkWM= Received: from MW2PR12MB2538.namprd12.prod.outlook.com (2603:10b6:907:5::14) by SA0PR12MB4525.namprd12.prod.outlook.com (2603:10b6:806:92::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.8; Mon, 24 Jan 2022 16:40:31 +0000 Received: from MW2PR12MB2538.namprd12.prod.outlook.com ([fe80::ad98:6ba4:7d63:fd6a]) by MW2PR12MB2538.namprd12.prod.outlook.com ([fe80::ad98:6ba4:7d63:fd6a%4]) with mapi id 15.20.4909.017; Mon, 24 Jan 2022 16:40:31 +0000 From: "Namburu, Chandu-babu" To: "Sebastian, Selwin" , "dev@dpdk.org" Subject: RE: [PATCH v1 5/6] net/axgbe: add support for new port mode Thread-Topic: [PATCH v1 5/6] net/axgbe: add support for new port mode Thread-Index: AQHYBhZHg33s1lVs6EGJqf1qw1foTKxydfsg Date: Mon, 24 Jan 2022 16:40:31 +0000 Message-ID: References: <20220110113509.553184-1-ssebasti@amd.com> <20220110113509.553184-6-ssebasti@amd.com> In-Reply-To: <20220110113509.553184-6-ssebasti@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Enabled=true; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SetDate=2022-01-24T16:40:22Z; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Method=Privileged; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Name=Public-AIP 2.0; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ActionId=bb734be9-c149-420a-97c5-f640414e6f39; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ContentBits=1 msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_enabled: true msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_setdate: 2022-01-24T16:40:29Z msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_method: Privileged msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_name: Public-AIP 2.0 msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_siteid: 3dd8961f-e488-4e60-8e11-a82d994e183d msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_actionid: 460a5085-807f-4b24-aa02-24ae5d46a268 msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_contentbits: 0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5be0bd38-3c07-493c-3d3f-08d9df583cc6 x-ms-traffictypediagnostic: SA0PR12MB4525:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1468; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vT5CU+ytUM1foJ0EMtyzeILZ+OB91n7f3jkZ+eM9/yKjmEqZKdm7PzC4+Dqf8XvkaC5tCsv/RkNuhcLyneJ5HKYtXFOQjz8FEOMhAeWjvSC1SHtVJjP3fZJM7Bf2jN+sVAf2aybauokbJNtbuA5aoi50MhEax7U/No4KkaZyrMX+ZzuwarJud41xVnTrn+tLVK79q2NKrDL7YjWJb0Q1ygfEMhQiwAvj3+wwvq9pE3/+cVd1UKHWBRHDITkTk2yjN+swwi3Q0HcRaokzjlWnwiSu7LN77dywJ4I/8D6TpCsgsJDlEtJf0P7arlNCDutLDzFzToBgvR2DRjPSoxMl5MEOGNS0hhvLt5osrLQT4j8GswSlp/m1kGRCBXOKnMcxq0jdP4XruGZgc0HyiPi/BryIl3Kz18fFRijqTRfKLACMx5RO+IifoCCvTRJhktuPMlgo6Bf+IeR4Cksat+srHy6AkGzyLMy4k4nuRHsqJT1Y/vJPEKwQIelUysw8KNlnij37onKG8ZJaSH/IXWzKw5e2SU8teMbNJbwQ8VRXw0eimhqZb8rlJS+2d6W6x75TrUWjPuGKx1Pr04D5jXAQZkh+TYwR8BfJmDLt3CZ0nD+qZpfMeAcNFXBs2so+i+qRHnXmZxhJKlblT3t3jlp4x2J4cyxku4s3jN5Xa1f1YxDnuV0oDSP1DIkmHUM588fwaMNlcOb0fxy6OPjL/3aw3A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR12MB2538.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(186003)(76116006)(38100700002)(316002)(66946007)(66556008)(26005)(6506007)(53546011)(38070700005)(508600001)(83380400001)(2906002)(66446008)(8676002)(122000001)(55016003)(5660300002)(33656002)(64756008)(71200400001)(86362001)(66476007)(8936002)(52536014)(9686003)(110136005)(7696005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?UbjLXc7+EUHF3EX/tYy9FYIOe8kU4PgscPoN8L+efDfEmz1n+m6tHSXYqhGQ?= =?us-ascii?Q?+JnOd6TDh398WPBIixL5Hf47lFmBGOuYJ0loQ9wVOMCT72qrlixlsBfkJyTh?= =?us-ascii?Q?tWek8V71ASWLmX9kb/T9jTg+jv5cuxjwqmLZ8wmbHAmXAa3eo4vC5nT8WgQ/?= =?us-ascii?Q?OqqVTSDs8UO0gZBepT6jlusQOO4QVHUAGi8gsZ55As6mV4j9gs0EibXP0UXa?= =?us-ascii?Q?NBABRsnYeikVH4ShunDpMIznEmKJI5DkmK7+BsD968i+9P2RJfaRHjfxZby8?= =?us-ascii?Q?1l8bQ3bLfya3DCBjsdwYs9hyO0YpJvs2RCMHPr5ImoK3dQ/iNNtk0CyO0NZI?= =?us-ascii?Q?ILdEOKwWjrQvUy8xOCKEhda7g8QlN6p6mBMoSiL2GoyFbo1U1D80jRRkcwhP?= =?us-ascii?Q?hhri4Bgw9tO0OzZ1Lucq/I//JUdxk++onvOhkssDumfQcQOLbuG9PY/Znn9E?= =?us-ascii?Q?AjiyP8BMnd958Z/ZpKwKtoHtOGUt8H9YHn71A3y2mp1xFfRjFSBhFnh1pmt2?= =?us-ascii?Q?WAcENwDNJRoZbX4TTbDTqOlEnYSix4KSSTPc2G2YKo2kvMTS5VSwfAVVAR7k?= =?us-ascii?Q?yGVFWucbZfP33QZ42eYlfZTM55STZIr7YGBxTLuLACyxGnTsQ213JVsN8Vqn?= =?us-ascii?Q?kCs7SkJURSsL8a4Ce+8WylxP2Nfd6BtfoTo3oslfhkRDrJ25rj7E3wFYmb/r?= =?us-ascii?Q?TbWqd4HiorN3OfE+g1/kpQpNFevva980Bdtf48k9flccuwdhBC2M4rEM8HJp?= =?us-ascii?Q?uOOJKO6wiXDsMRSPH6sPCNRQzz5ZhQxvKPJBphq2x9xTD5z7JLPNfBblLYGo?= =?us-ascii?Q?QBZaFqBa5JlbQ1QfeFZ/MDx4QQaLqzL/V5cjeFpoCen0Lbpda9bjDYH8g+eA?= =?us-ascii?Q?sZbSmiUiLzzt9UsC4lun7zWke4D49hEL3P06iQzaS8JndkNMtwz2E6Z8OqfO?= =?us-ascii?Q?WHZIOKb+FkTMhAjVncdVKOCps40hfxSaZOkAP+Wh0pEdBdaBDOAZYKgcOClA?= =?us-ascii?Q?yvg/FY6cAnCqs7Yc2jdTxq8emywSVt7SLiS4RNHkVwhyAEAt2I0VlPGRzmLv?= =?us-ascii?Q?0RobMFeZEhyezm69Q5NAXcLa3FpwSSisPWmawLOMycTSGda1BnsPy8Z/gp6I?= =?us-ascii?Q?6knzWWcAlWNPxaitMLj+He8kcNMlqaGv/hNinYeF5vyT1sgHR0BS9T6aVaof?= =?us-ascii?Q?BeT4MNLKgOt8HZmffR9DuAM7Q9RcqPpLLb6be718Ui1KaRSSrkpYD6KTXThT?= =?us-ascii?Q?dfw0jZwoEJeapPWdatgyKI+VYEk0KOVimYBV+t0J4tPEfUxH040Nx9Pn8B4/?= =?us-ascii?Q?8jjBYiTtM1KaLxH67jpDVb+dx8KLsevktB6yxekPsnGSUNWEX3XQdPqPoM6e?= =?us-ascii?Q?CR+jDqhN/YZWAirI6B3HWjO2ih56O0mZk5QrcaHukubHWsWuqzCK734XV3+h?= =?us-ascii?Q?RGv6fFKW1xKyZBG8fIHVFzhr61VLNq23KMytoQEUBYT+lxZV5fX74Hty/wIz?= =?us-ascii?Q?CfNXtdAxxvPI9zAjLnnt4fMP9ofFsUFsniMXBN3m+L+fr9amEjk/hsMvoJHx?= =?us-ascii?Q?avu8MITvO9u+m/652N0ixJi0mOIFwOYtzSzkbi47FpTvhQxXcpTLpVYzkuLa?= =?us-ascii?Q?aKWuzmwattRfMTJHq/0BFeU=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB2538.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5be0bd38-3c07-493c-3d3f-08d9df583cc6 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jan 2022 16:40:31.7501 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HdCnASv2/RBlPksmbJYaTruAH9ni6Ra2sDrGvUIefzGsFERbELS7jP0+DkOxBaSNXz8n9ia2EIEoW1/RH0fs9w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4525 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org [Public] Acked-by: Chandubabu Namburu -----Original Message----- From: ssebasti@amd.com =20 Sent: Monday, January 10, 2022 5:05 PM To: dev@dpdk.org Subject: [PATCH v1 5/6] net/axgbe: add support for new port mode From: Selwin Sebastian Add support for a new port mode that is abackplane connection without suppo= rt for auto negotiation. Signed-off-by: Selwin Sebastian --- drivers/net/axgbe/axgbe_phy_impl.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/net/axgbe/axgbe_phy_impl.c b/drivers/net/axgbe/axgbe_p= hy_impl.c index e52dbb9585..2aad8babd2 100644 --- a/drivers/net/axgbe/axgbe_phy_impl.c +++ b/drivers/net/axgbe/axgbe_phy_impl.c @@ -46,6 +46,7 @@ enum axgbe_port_mode { AXGBE_PORT_MODE_10GBASE_T, AXGBE_PORT_MODE_10GBASE_R, AXGBE_PORT_MODE_SFP, + AXGBE_PORT_MODE_BACKPLANE_NO_AUTONEG, AXGBE_PORT_MODE_MAX, }; =20 @@ -885,6 +886,7 @@ static enum axgbe_mode axgbe_phy_an73_redrv_outcome(str= uct axgbe_port *pdata) if (ad_reg & 0x80) { switch (phy_data->port_mode) { case AXGBE_PORT_MODE_BACKPLANE: + case AXGBE_PORT_MODE_BACKPLANE_NO_AUTONEG: mode =3D AXGBE_MODE_KR; break; default: @@ -894,6 +896,7 @@ static enum axgbe_mode axgbe_phy_an73_redrv_outcome(str= uct axgbe_port *pdata) } else if (ad_reg & 0x20) { switch (phy_data->port_mode) { case AXGBE_PORT_MODE_BACKPLANE: + case AXGBE_PORT_MODE_BACKPLANE_NO_AUTONEG: mode =3D AXGBE_MODE_KX_1000; break; case AXGBE_PORT_MODE_1000BASE_X: @@ -1052,6 +1055,7 @@ static unsigned int axgbe_phy_an_advertising(struct a= xgbe_port *pdata) =20 switch (phy_data->port_mode) { case AXGBE_PORT_MODE_BACKPLANE: + case AXGBE_PORT_MODE_BACKPLANE_NO_AUTONEG: advertising |=3D ADVERTISED_10000baseKR_Full; break; case AXGBE_PORT_MODE_BACKPLANE_2500: @@ -1122,6 +1126,7 @@ static enum axgbe_an_mode axgbe_phy_an_mode(struct ax= gbe_port *pdata) switch (phy_data->port_mode) { case AXGBE_PORT_MODE_BACKPLANE: return AXGBE_AN_MODE_CL73; + case AXGBE_PORT_MODE_BACKPLANE_NO_AUTONEG: case AXGBE_PORT_MODE_BACKPLANE_2500: return AXGBE_AN_MODE_NONE; case AXGBE_PORT_MODE_1000BASE_T: @@ -1400,6 +1405,7 @@ static enum axgbe_mode axgbe_phy_switch_mode(struct a= xgbe_port *pdata) =20 switch (phy_data->port_mode) { case AXGBE_PORT_MODE_BACKPLANE: + case AXGBE_PORT_MODE_BACKPLANE_NO_AUTONEG: return axgbe_phy_switch_bp_mode(pdata); case AXGBE_PORT_MODE_BACKPLANE_2500: return axgbe_phy_switch_bp_2500_mode(pdata); @@ -1495,6 +1501,7 @@ static enum axgbe_mode axgbe_phy_get_mode(struct axgb= e_port *pdata, =20 switch (phy_data->port_mode) { case AXGBE_PORT_MODE_BACKPLANE: + case AXGBE_PORT_MODE_BACKPLANE_NO_AUTONEG: return axgbe_phy_get_bp_mode(speed); case AXGBE_PORT_MODE_BACKPLANE_2500: return axgbe_phy_get_bp_2500_mode(speed); @@ -1644,6 +1651,7 @@ static bool axgbe_phy_use_mode(struct axgbe_port *pda= ta, enum axgbe_mode mode) =20 switch (phy_data->port_mode) { case AXGBE_PORT_MODE_BACKPLANE: + case AXGBE_PORT_MODE_BACKPLANE_NO_AUTONEG: return axgbe_phy_use_bp_mode(pdata, mode); case AXGBE_PORT_MODE_BACKPLANE_2500: return axgbe_phy_use_bp_2500_mode(pdata, mode); @@ -1806,6 +1814,7 @@ st= atic bool axgbe_phy_port_mode_mismatch(struct axgbe_port *pdata) =20 switch (phy_data->port_mode) { case AXGBE_PORT_MODE_BACKPLANE: + case AXGBE_PORT_MODE_BACKPLANE_NO_AUTONEG: if ((phy_data->port_speeds & AXGBE_PHY_PORT_SPEED_1000) || (phy_data->port_speeds & AXGBE_PHY_PORT_SPEED_10000)) return false; @@ -1858,6 +1867,7 @@ static bool axgbe_phy_conn_type_mismatch(struct axgbe= _port *pdata) =20 switch (phy_data->port_mode) { case AXGBE_PORT_MODE_BACKPLANE: + case AXGBE_PORT_MODE_BACKPLANE_NO_AUTONEG: case AXGBE_PORT_MODE_BACKPLANE_2500: if (phy_data->conn_type =3D=3D AXGBE_CONN_TYPE_BACKPLANE) return false; @@ -2122,6 +2132,8 @@ static int axgbe_phy_init(struct axgbe_port *pdata) /* Backplane support */ case AXGBE_PORT_MODE_BACKPLANE: pdata->phy.supported |=3D SUPPORTED_Autoneg; + /*fallthrough;*/ + case AXGBE_PORT_MODE_BACKPLANE_NO_AUTONEG: pdata->phy.supported |=3D SUPPORTED_Pause | SUPPORTED_Asym_Pause; pdata->phy.supported |=3D SUPPORTED_Backplane; if (phy_data->port_speeds & AXGBE_PHY_PORT_SPEED_1000) { -- 2.25.1