From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B86BBA0525; Sun, 16 Feb 2020 07:49:09 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8E6164C98; Sun, 16 Feb 2020 07:49:09 +0100 (CET) Received: from NAM04-BN3-obe.outbound.protection.outlook.com (mail-eopbgr680040.outbound.protection.outlook.com [40.107.68.40]) by dpdk.org (Postfix) with ESMTP id D710F2C4F for ; Sun, 16 Feb 2020 07:49:07 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B819rhEZf8vPjkIHUCdXwsjofQ+WlChvz9l8PnV4neUFw8ntMhzE4myZod7ZOAo3AzOPIdUiKcTyJ4L5tTV5c2bhRkjR5+cLxtJb0UL0apMm8w/WRMr8lnPMo2+cnpiBr54WqD+itL/Ig4gLXwgLym3HnE195awjsaDecpjhYlHAuNpiTBL5ny/JoQOH7T8sAhqlcxDfhCzhz9NA0iH4+Yvqa6aMMJBd55qfnSF+lDc9KO7eOKQNzKn042yMNv02hb3QPBMWBUVWUsXW+8iV0FDmK8otg5lXNP9ho+VW4ow1s7E+VRur+OsxCGaVpC7qaDwXG/WA2QGAHSj0Vk9m8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SYYOPVDNdFTWE2sc1Rv5Bv+oyotKsUbwG2hKHYkAxpY=; b=Ton4tLK8EEzFFAag9nXVgR9u/YN1uGpV15/RbpSQz8uDtaiwV/Z9+PdIhuUkjnQY6QZGXgSgoEg+K0+Uu6QWYsW9NhWi05SL9c2gODziHDSNSxoFyedxZZ3hsZDip4Rqtt5xCuE0Ya0rCeXjux8r24k8mg8dj1ncVLNMYz4uq/KBOecNhu8mP6Fdb83ppVuh72B9XzrP8C+T11fA9okVKQ26Q7kHD2Bqn3mCI4jJNYon0T7OuMIOzVc8nhxITisxhG49W3jlDPIzHAlYxpbNjQbQ6BX5+2bEf9SimzbH9IeLHChnHb+3RTFs0WyszMLzUULWxEahxWk7Fhim8O/jDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SYYOPVDNdFTWE2sc1Rv5Bv+oyotKsUbwG2hKHYkAxpY=; b=1tzhmKj1hCwy+M58QDAdmmLpGCSbTWJ4uWJhoCql3SX6i3/ISTFCd5iuMlQxBmEg39WwpDmONQm7Ud7KC+rn18Hk7hzW8W0BuoemYGHo1m3katjETfwS/x22V4EzAlOS2Sw6ZvtRqUKYjVjzYJ20pPhNp1Vz8EtDjrrcQ5GgoY0= Received: from MW2PR12MB2570.namprd12.prod.outlook.com (52.132.181.13) by MW2PR12MB2523.namprd12.prod.outlook.com (52.132.184.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2729.25; Sun, 16 Feb 2020 06:49:06 +0000 Received: from MW2PR12MB2570.namprd12.prod.outlook.com ([fe80::ec36:5d88:cc24:c660]) by MW2PR12MB2570.namprd12.prod.outlook.com ([fe80::ec36:5d88:cc24:c660%3]) with mapi id 15.20.2729.031; Sun, 16 Feb 2020 06:49:06 +0000 From: "Kumar, Ravi1" To: "Namburu, Chandu-babu" , "dev@dpdk.org" CC: "Somalapuram, Amaranath" Thread-Topic: [PATCH v1] net/axgbe: add debug logs Thread-Index: AQHV4LQOibIup3aqTUeHDK8ZMG/Rt6gdaTMQ Date: Sun, 16 Feb 2020 06:49:05 +0000 Message-ID: References: <20200211081939.17793-1-cnamburu@amd.com> In-Reply-To: <20200211081939.17793-1-cnamburu@amd.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_Enabled=true; MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_SetDate=2020-02-16T06:50:58Z; MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_Method=Standard; MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_Name=Internal Use Only - Unrestricted; MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_ActionId=fb656d41-e55f-4a86-bd87-000096d99a9f; MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_ContentBits=1 msip_label_76546daa-41b6-470c-bb85-f6f40f044d7f_enabled: true msip_label_76546daa-41b6-470c-bb85-f6f40f044d7f_setdate: 2020-02-16T06:50:58Z msip_label_76546daa-41b6-470c-bb85-f6f40f044d7f_method: Standard msip_label_76546daa-41b6-470c-bb85-f6f40f044d7f_name: Internal Use Only - Unrestricted msip_label_76546daa-41b6-470c-bb85-f6f40f044d7f_siteid: 3dd8961f-e488-4e60-8e11-a82d994e183d msip_label_76546daa-41b6-470c-bb85-f6f40f044d7f_actionid: 62ca86be-fdad-441a-a18d-0000157e9bcd msip_label_76546daa-41b6-470c-bb85-f6f40f044d7f_contentbits: 0 authentication-results: spf=none (sender IP is ) smtp.mailfrom=Ravi1.Kumar@amd.com; x-originating-ip: [117.99.80.68] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 9289e165-661f-4fe8-b6aa-08d7b2ac5131 x-ms-traffictypediagnostic: MW2PR12MB2523:|MW2PR12MB2523: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:206; x-forefront-prvs: 03152A99FF x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(366004)(396003)(376002)(346002)(136003)(189003)(199004)(5660300002)(30864003)(8936002)(2906002)(186003)(4326008)(7696005)(26005)(81166006)(81156014)(8676002)(6506007)(316002)(110136005)(66476007)(86362001)(55016002)(478600001)(64756008)(66556008)(9686003)(66446008)(71200400001)(33656002)(76116006)(52536014)(66946007); DIR:OUT; SFP:1101; SCL:1; SRVR:MW2PR12MB2523; H:MW2PR12MB2570.namprd12.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: amd.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OEr41BUKEyOQdv94/pC+imKBs9GC7Hsmen0xb56EZNctg0ZtVHUkeKwTW+zPts5U/FgeNbEQKsm4EqE6R/ohPgqDjw51NZgWRhSWLp4Z5ujaDw4RKorE+oTyf52IokR406QIG6i73zYtxoV8amefVe274bxNXmmYbUqmHSzBMiC5rs2Fj7Y3Op6t4+Mt2YoVeX98cAz3oJ9M5MpbIFKcOM5Vf0DHrlTT0KihI1kkQeyt+MfasKLtpipX2uNVcZbfB7pRlxFbn0W6fP127gJVbl2gpII8P/YFp9oyUZnnGRREtnCWzSRyvYLGMzk5yXNt8RY7D17sM1YjT6A5gQ61oeqE+oW4xLG3QGZmHJ2zRtQ4Hy2WIcJ4Svw5vzKlKnjGoLYmjJWd5f/8DmgRr7wid1XrpcjC28j4dQ0fExZ7mXd57iG3O444DCJqevPg3kMy x-ms-exchange-antispam-messagedata: hUFu/vOIlwPkVve0DOdzy0ajWAD4Dj7ZatTCPueueQ4bWxj99o40JaIyxJh05SBsQDWFjUCZV/yqHC16uGov/7owMdhte+OCjCHvrZkOpZfTLGNxk3mpm/Imb0GJ5n4t2VnH8yCzZuMfVx42r6rYLQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9289e165-661f-4fe8-b6aa-08d7b2ac5131 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Feb 2020 06:49:06.0127 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: E6arMG5ip0t1H1T2uehxaX0KKlSN/G339PHITrrlyaz8CPy2oS/uef4B4pIr6LLiWTdQ+NTZBUVRSUdmBhhiHA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR12MB2523 Subject: Re: [dpdk-dev] [PATCH v1] net/axgbe: add debug logs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" [AMD Official Use Only - Internal Distribution Only] Acked-by: Ravi Kumar > > >-----Original Message----- >From: Namburu, Chandu-babu =20 >Sent: Tuesday, February 11, 2020 1:50 PM >To: dev@dpdk.org >Cc: Kumar, Ravi1 ; Somalapuram, Amaranath >Subject: [PATCH v1] net/axgbe: add debug logs > >From: Chandu Babu N > >Add debug logs in various modules in axgbe > >Signed-off-by: Chandu Babu N >--- > drivers/net/axgbe/axgbe_dev.c | 17 ++++++++-- > drivers/net/axgbe/axgbe_ethdev.c | 2 ++ > drivers/net/axgbe/axgbe_i2c.c | 10 ++++++ > drivers/net/axgbe/axgbe_mdio.c | 51 +++++++++++++++++++++++++++++- > drivers/net/axgbe/axgbe_phy_impl.c | 43 ++++++++++++++++++++++++- > 5 files changed, 119 insertions(+), 4 deletions(-) > >diff --git a/drivers/net/axgbe/axgbe_dev.c b/drivers/net/axgbe/axgbe_dev.c= index 83089f20d..2e796c0b3 100644 >--- a/drivers/net/axgbe/axgbe_dev.c >+++ b/drivers/net/axgbe/axgbe_dev.c >@@ -260,6 +260,9 @@ static int axgbe_enable_tx_flow_control(struct axgbe_p= ort *pdata) > ehfc =3D 1; >=20 > AXGMAC_MTL_IOWRITE_BITS(pdata, i, MTL_Q_RQOMR, EHFC, ehfc); >+ >+ PMD_DRV_LOG(DEBUG, "flow control %s for RXq%u\n", >+ ehfc ? "enabled" : "disabled", i); > } >=20 > /* Set MAC flow control */ >@@ -915,6 +918,9 @@ static void axgbe_config_rx_fifo_size(struct axgbe_por= t *pdata) > /*Calculate and config Flow control threshold*/ > axgbe_calculate_flow_control_threshold(pdata); > axgbe_config_flow_control_threshold(pdata); >+ >+ PMD_DRV_LOG(DEBUG, "%d Rx hardware queues, %d byte fifo per queue\n", >+ pdata->rx_q_count, q_fifo_size); > } >=20 > static void axgbe_config_tx_fifo_size(struct axgbe_port *pdata) @@ -938,6= +944,9 @@ static void axgbe_config_tx_fifo_size(struct axgbe_port *pdata) >=20 > for (i =3D 0; i < pdata->tx_q_count; i++) > AXGMAC_MTL_IOWRITE_BITS(pdata, i, MTL_Q_TQOMR, TQS, p_fifo); >+ >+ PMD_DRV_LOG(DEBUG, "%d Tx hardware queues, %d byte fifo per queue\n", >+ pdata->tx_q_count, q_fifo_size); > } >=20 > static void axgbe_config_queue_mapping(struct axgbe_port *pdata) @@ -952,= 12 +961,16 @@ static void axgbe_config_queue_mapping(struct axgbe_port *pda= ta) > qptc_extra =3D pdata->tx_q_count % pdata->hw_feat.tc_cnt; >=20 > for (i =3D 0, queue =3D 0; i < pdata->hw_feat.tc_cnt; i++) { >- for (j =3D 0; j < qptc; j++) >+ for (j =3D 0; j < qptc; j++) { >+ PMD_DRV_LOG(DEBUG, "TXq%u mapped to TC%u\n", queue, i); > AXGMAC_MTL_IOWRITE_BITS(pdata, queue, MTL_Q_TQOMR, > Q2TCMAP, i); >- if (i < qptc_extra) >+ } >+ if (i < qptc_extra) { >+ PMD_DRV_LOG(DEBUG, "TXq%u mapped to TC%u\n", queue, i); > AXGMAC_MTL_IOWRITE_BITS(pdata, queue, MTL_Q_TQOMR, > Q2TCMAP, i); >+ } > } >=20 > if (pdata->rss_enable) { >diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_et= hdev.c >index d0b6f091f..7445c544d 100644 >--- a/drivers/net/axgbe/axgbe_ethdev.c >+++ b/drivers/net/axgbe/axgbe_ethdev.c >@@ -201,12 +201,14 @@ axgbe_dev_interrupt_handler(void *param) > pdata->phy_if.an_isr(pdata); > /*DMA related interrupts*/ > dma_isr =3D AXGMAC_IOREAD(pdata, DMA_ISR); >+ PMD_DRV_LOG(DEBUG, "DMA_ISR=3D%#010x\n", dma_isr); > if (dma_isr) { > if (dma_isr & 1) { > dma_ch_isr =3D > AXGMAC_DMA_IOREAD((struct axgbe_rx_queue *) > pdata->rx_queues[0], > DMA_CH_SR); >+ PMD_DRV_LOG(DEBUG, "DMA_CH0_ISR=3D%#010x\n", dma_ch_isr); > AXGMAC_DMA_IOWRITE((struct axgbe_rx_queue *) > pdata->rx_queues[0], > DMA_CH_SR, dma_ch_isr); >diff --git a/drivers/net/axgbe/axgbe_i2c.c b/drivers/net/axgbe/axgbe_i2c.c= index 204ec3679..ab3738a12 100644 >--- a/drivers/net/axgbe/axgbe_i2c.c >+++ b/drivers/net/axgbe/axgbe_i2c.c >@@ -162,9 +162,15 @@ static int axgbe_i2c_isr(struct axgbe_port *pdata) >=20 > isr =3D XI2C_IOREAD(pdata, IC_RAW_INTR_STAT); >=20 >+ PMD_DRV_LOG(DEBUG, "I2C interrupt received: status=3D%#010x\n", isr); >+ > axgbe_i2c_clear_isr_interrupts(pdata, isr); >=20 > if (isr & AXGBE_INTR_TX_ABRT) { >+ PMD_DRV_LOG(DEBUG, >+ "I2C TX_ABRT received (%#010x) for target %#04x\n", >+ state->tx_abort_source, state->op->target); >+ > axgbe_i2c_disable_interrupts(pdata); >=20 > state->ret =3D -EIO; >@@ -285,6 +291,8 @@ static void axgbe_i2c_stop(struct axgbe_port *pdata) > if (!pdata->i2c.started) > return; >=20 >+ PMD_DRV_LOG(DEBUG, "stopping I2C\n"); >+ > pdata->i2c.started =3D 0; > axgbe_i2c_disable_interrupts(pdata); > axgbe_i2c_disable(pdata); >@@ -296,6 +304,8 @@ static int axgbe_i2c_start(struct axgbe_port *pdata) > if (pdata->i2c.started) > return 0; >=20 >+ PMD_DRV_LOG(DEBUG, "starting I2C\n"); >+ > pdata->i2c.started =3D 1; >=20 > return 0; >diff --git a/drivers/net/axgbe/axgbe_mdio.c b/drivers/net/axgbe/axgbe_mdio= .c index 4b280b72d..0f226c3f2 100644 >--- a/drivers/net/axgbe/axgbe_mdio.c >+++ b/drivers/net/axgbe/axgbe_mdio.c >@@ -300,6 +300,8 @@ static void axgbe_an73_restart(struct axgbe_port *pdat= a) { > axgbe_an73_enable_interrupts(pdata); > axgbe_an73_set(pdata, true, true); >+ >+ PMD_DRV_LOG(DEBUG, "CL73 AN enabled/restarted\n"); > } >=20 > static void axgbe_an73_disable(struct axgbe_port *pdata) @@ -307,6 +309,8= @@ static void axgbe_an73_disable(struct axgbe_port *pdata) > axgbe_an73_set(pdata, false, false); > axgbe_an73_disable_interrupts(pdata); > pdata->an_start =3D 0; >+ >+ PMD_DRV_LOG(DEBUG, "CL73 AN disabled\n"); > } >=20 > static void axgbe_an_restart(struct axgbe_port *pdata) @@ -384,6 +388,8 @= @ static enum axgbe_an axgbe_an73_tx_training(struct axgbe_port *pdata, > XMDIO_WRITE(pdata, MDIO_MMD_PMAPMD, MDIO_PMA_10GBR_PMD_CTRL, > reg); >=20 >+ PMD_DRV_LOG(DEBUG, "KR training initiated\n"); >+ > if (pdata->phy_if.phy_impl.kr_training_post) > pdata->phy_if.phy_impl.kr_training_post(pdata); > } >@@ -466,6 +472,9 @@ static enum axgbe_an axgbe_an73_page_received(struct a= xgbe_port *pdata) > pdata->kx_state =3D AXGBE_RX_BPA; >=20 > pdata->an_start =3D rte_get_timer_cycles(); >+ >+ PMD_DRV_LOG(NOTICE, >+ "CL73 AN timed out, resetting state\n"); > } > } >=20 >@@ -515,6 +524,26 @@ static enum axgbe_an axgbe_an73_incompat_link(struct = axgbe_port *pdata) > return AXGBE_AN_INCOMPAT_LINK; > } >=20 >+static const char *axgbe_state_as_string(enum axgbe_an state) { >+ switch (state) { >+ case AXGBE_AN_READY: >+ return "Ready"; >+ case AXGBE_AN_PAGE_RECEIVED: >+ return "Page-Received"; >+ case AXGBE_AN_INCOMPAT_LINK: >+ return "Incompatible-Link"; >+ case AXGBE_AN_COMPLETE: >+ return "Complete"; >+ case AXGBE_AN_NO_LINK: >+ return "No-Link"; >+ case AXGBE_AN_ERROR: >+ return "Error"; >+ default: >+ return "Undefined"; >+ } >+} >+ > static void axgbe_an73_state_machine(struct axgbe_port *pdata) { > enum axgbe_an cur_state =3D pdata->an_state; @@ -536,6 +565,9 @@ static = void axgbe_an73_state_machine(struct axgbe_port *pdata) > pdata->an_state =3D AXGBE_AN_ERROR; > } >=20 >+ PMD_DRV_LOG(DEBUG, "CL73 AN : %s\n", >+ axgbe_state_as_string(pdata->an_state)); >+ > again: > cur_state =3D pdata->an_state; >=20 >@@ -581,6 +613,9 @@ static void axgbe_an73_state_machine(struct axgbe_port= *pdata) > pdata->an_start =3D 0; > if (pdata->phy_if.phy_impl.an_post) > pdata->phy_if.phy_impl.an_post(pdata); >+ >+ PMD_DRV_LOG(DEBUG, "CL73 AN result: %s\n", >+ axgbe_state_as_string(pdata->an_result)); > } >=20 > if (cur_state !=3D pdata->an_state) >@@ -685,6 +720,8 @@ static void axgbe_an37_isr(struct axgbe_port *pdata) >=20 > static void axgbe_an_isr(struct axgbe_port *pdata) { >+ PMD_DRV_LOG(DEBUG, "AN interrupt received\n"); >+ > switch (pdata->an_mode) { > case AXGBE_AN_MODE_CL73: > case AXGBE_AN_MODE_CL73_REDRV: >@@ -792,6 +829,8 @@ static void axgbe_an73_init(struct axgbe_port *pdata) > reg &=3D ~AXGBE_XNP_NP_EXCHANGE; >=20 > XMDIO_WRITE(pdata, MDIO_MMD_AN, MDIO_AN_ADVERTISE, reg); >+ >+ PMD_DRV_LOG(DEBUG, "CL73 AN initialized\n"); > } >=20 > static void axgbe_an_init(struct axgbe_port *pdata) @@ -843,6 +882,8 @@ s= tatic int axgbe_phy_config_fixed(struct axgbe_port *pdata) { > enum axgbe_mode mode; >=20 >+ PMD_DRV_LOG(DEBUG, "fixed PHY configuration\n"); >+ > /* Disable auto-negotiation */ > axgbe_an_disable(pdata); >=20 >@@ -886,6 +927,9 @@ static int __axgbe_phy_config_aneg(struct axgbe_port *= pdata) > ret =3D axgbe_phy_config_fixed(pdata); > if (ret || !pdata->kr_redrv) > return ret; >+ PMD_DRV_LOG(DEBUG, "AN redriver support\n"); >+ } else { >+ PMD_DRV_LOG(DEBUG, "AN PHY configuration\n"); > } >=20 > /* Disable auto-negotiation interrupt */ @@ -959,8 +1003,10 @@ static vo= id axgbe_check_link_timeout(struct axgbe_port *pdata) > link_timeout =3D pdata->link_check + (AXGBE_LINK_TIMEOUT * > 2 * rte_get_timer_hz()); > ticks =3D rte_get_timer_cycles(); >- if (time_after(ticks, link_timeout)) >+ if (time_after(ticks, link_timeout)) { >+ PMD_DRV_LOG(NOTICE, "AN link timeout\n"); > axgbe_phy_config_aneg(pdata); >+ } > } >=20 > static enum axgbe_mode axgbe_phy_status_aneg(struct axgbe_port *pdata) @@= -1088,6 +1134,7 @@ static void axgbe_phy_status(struct axgbe_port *pdata) >=20 > static void axgbe_phy_stop(struct axgbe_port *pdata) { >+ PMD_DRV_LOG(DEBUG, "stopping PHY\n"); > if (!pdata->phy_started) > return; > /* Indicate the PHY is down */ >@@ -1103,6 +1150,8 @@ static int axgbe_phy_start(struct axgbe_port *pdata)= { > int ret; >=20 >+ PMD_DRV_LOG(DEBUG, "starting PHY\n"); >+ > ret =3D pdata->phy_if.phy_impl.start(pdata); > if (ret) > return ret; >diff --git a/drivers/net/axgbe/axgbe_phy_impl.c b/drivers/net/axgbe/axgbe_= phy_impl.c >index a324a2bc9..02236ec19 100644 >--- a/drivers/net/axgbe/axgbe_phy_impl.c >+++ b/drivers/net/axgbe/axgbe_phy_impl.c >@@ -790,6 +790,32 @@ static void axgbe_phy_sfp_reset(struct axgbe_phy_data= *phy_data) > phy_data->sfp_speed =3D AXGBE_SFP_SPEED_UNKNOWN; } >=20 >+static const char *axgbe_base_as_string(enum axgbe_sfp_base sfp_base) { >+ switch (sfp_base) { >+ case AXGBE_SFP_BASE_1000_T: >+ return "1G_T"; >+ case AXGBE_SFP_BASE_1000_SX: >+ return "1G_SX"; >+ case AXGBE_SFP_BASE_1000_LX: >+ return "1G_LX"; >+ case AXGBE_SFP_BASE_1000_CX: >+ return "1G_CX"; >+ case AXGBE_SFP_BASE_10000_SR: >+ return "10G_SR"; >+ case AXGBE_SFP_BASE_10000_LR: >+ return "10G_LR"; >+ case AXGBE_SFP_BASE_10000_LRM: >+ return "10G_LRM"; >+ case AXGBE_SFP_BASE_10000_ER: >+ return "10G_ER"; >+ case AXGBE_SFP_BASE_10000_CR: >+ return "10G_CR"; >+ default: >+ return "Unknown"; >+ } >+} >+ > static void axgbe_phy_sfp_detect(struct axgbe_port *pdata) { > struct axgbe_phy_data *phy_data =3D pdata->phy_data; @@ -820,6 +846,9 @@= static void axgbe_phy_sfp_detect(struct axgbe_port *pdata) > axgbe_phy_sfp_parse_eeprom(pdata); > axgbe_phy_sfp_external_phy(pdata); >=20 >+ PMD_DRV_LOG(DEBUG, "SFP Base: %s\n", >+ axgbe_base_as_string(phy_data->sfp_base)); >+ > put: > axgbe_phy_sfp_phy_settings(pdata); > axgbe_phy_put_comm_ownership(pdata); >@@ -1169,7 +1198,10 @@ static void axgbe_phy_set_redrv_mode(struct axgbe_p= ort *pdata) >=20 > static void axgbe_phy_start_ratechange(struct axgbe_port *pdata) { >- if (!XP_IOREAD_BITS(pdata, XP_DRIVER_INT_RO, STATUS)) >+ /* Log if a previous command did not complete */ >+ if (XP_IOREAD_BITS(pdata, XP_DRIVER_INT_RO, STATUS)) >+ PMD_DRV_LOG(NOTICE, "firmware mailbox not ready for command\n"); >+ else > return; > } >=20 >@@ -1185,6 +1217,7 @@ static void axgbe_phy_complete_ratechange(struct axg= be_port *pdata) >=20 > rte_delay_us(1500); > } >+ PMD_DRV_LOG(NOTICE, "firmware mailbox command did not complete\n"); > } >=20 > static void axgbe_phy_rrc(struct axgbe_port *pdata) @@ -1204,6 +1237,8 @@= static void axgbe_phy_rrc(struct axgbe_port *pdata) > XP_IOWRITE_BITS(pdata, XP_DRIVER_INT_REQ, REQUEST, 1); >=20 > axgbe_phy_complete_ratechange(pdata); >+ >+ PMD_DRV_LOG(DEBUG, "receiver reset complete\n"); > } >=20 > static void axgbe_phy_power_off(struct axgbe_port *pdata) @@ -1218,6 +125= 3,8 @@ static void axgbe_phy_power_off(struct axgbe_port *pdata) > XP_IOWRITE_BITS(pdata, XP_DRIVER_INT_REQ, REQUEST, 1); > axgbe_phy_complete_ratechange(pdata); > phy_data->cur_mode =3D AXGBE_MODE_UNKNOWN; >+ >+ PMD_DRV_LOG(DEBUG, "phy powered off\n"); > } >=20 > static void axgbe_phy_sfi_mode(struct axgbe_port *pdata) @@ -1249,6 +1286= ,8 @@ static void axgbe_phy_sfi_mode(struct axgbe_port *pdata) > XP_IOWRITE_BITS(pdata, XP_DRIVER_INT_REQ, REQUEST, 1); > axgbe_phy_complete_ratechange(pdata); > phy_data->cur_mode =3D AXGBE_MODE_SFI; >+ >+ PMD_DRV_LOG(DEBUG, "10GbE SFI mode set\n"); > } >=20 > static void axgbe_phy_kr_mode(struct axgbe_port *pdata) @@ -1271,6 +1310,= 8 @@ static void axgbe_phy_kr_mode(struct axgbe_port *pdata) > XP_IOWRITE_BITS(pdata, XP_DRIVER_INT_REQ, REQUEST, 1); > axgbe_phy_complete_ratechange(pdata); > phy_data->cur_mode =3D AXGBE_MODE_KR; >+ >+ PMD_DRV_LOG(DEBUG, "10GbE KR mode set\n"); > } >=20 > static void axgbe_phy_kx_2500_mode(struct axgbe_port *pdata) >-- >2.17.1 > >