From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 746C7A0093; Mon, 7 Mar 2022 11:15:09 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D5A1541168; Mon, 7 Mar 2022 11:15:08 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2051.outbound.protection.outlook.com [40.107.244.51]) by mails.dpdk.org (Postfix) with ESMTP id B758440688; Mon, 7 Mar 2022 11:15:07 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cpxMp78A/WIHj2ypLggJntUSbx4RbxRi/sS3jVcB7xO1Bpf3zPO4LdEBQ0q31YPv4MGs2iELSCR+IEPZu75TekfnZ3D+wmonYNMhKReL12Vv6yee85H5HgvCc0UiHUzrRWJ4ozeXLdTDnGSF2PXIXnwtBPeiNGU3q80d3nScQFx6C6Wre+8DgUKCo5pnyHKi0AnZzJJyi3OJIfDHBtEVdaVL+XfRLef90nD4TWF2762yEFTFdSY2hKJatNFBGbUuTXVwBQaNYHx2ETtulkujYYzvq5jje5H4a8JMIgZCkbk37nihMraF0kNwQynbDaR/t8HGD9Rx8huWJ1hOu3qJPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dwFcxOr6QnXADLQl3tdQqiiTFDxsDp0VEeJimKmuSsA=; b=HXJ4mFSpl6JjmX+ARCe+yPIB8d41NlFJK2LjUAvAbW6Rk/6hzfGJkazU+9sQF86aBVypgIefZR/q4P/sAtJ8KR0CUVx+HeA0DJLSpLuRM6e8k7qdPPd/Kuyev1jwvikku1/gNWafCqv+WOnbZnSJw5CA11P+n5bAsYg0YPL53P1W7HgU+JgYpkqYDd6+ysK+tWL5N1SJ07qd0aBJLw6PCiay6TRmO+RqNeI7kNR3krQd0rSfod1qqLA+2X/+lfTkKbHIp0i4CJ5H9nj7SImZc5DqZBOYAjrplu0MxvMpRuQOJDxcGtsDE4pGXnYheVlFxQmRLbtRAdC7xjs8eOv9bQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dwFcxOr6QnXADLQl3tdQqiiTFDxsDp0VEeJimKmuSsA=; b=lRqFVdyxFVco7zFIihrJFWgUsCiA5DHvnZuMiSx2AADOvAWxXk35gUdlZjb1sb8T5dcCsSs6tXVr/GvUDZu4EMD7m/RIN8MT1CBpi7nsBHYPk3CVJ/F+T3UVB/UIU8G6by3lR2q5XQZmQ5ioFKHPtICQB2ZuSUuxMxMS7gR/R+K4Z+tS6RV7W2S8/chQp1fweag0HKKAeFHt0DJGbhx1FQoK/eJwxqW5EXs67w8n7i+5KPWCez0719azmD3WaLknO3zzjY6AxlmbFtb368RifySam073gdXtTKsnAwr3PtvHR5Cdl/UYpJCYb8AYQCH+DvZ/JXthAEKd2m8N3VocJw== Received: from MW2PR12MB4666.namprd12.prod.outlook.com (2603:10b6:302:13::22) by DM5PR12MB1211.namprd12.prod.outlook.com (2603:10b6:3:79::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.23; Mon, 7 Mar 2022 10:15:04 +0000 Received: from MW2PR12MB4666.namprd12.prod.outlook.com ([fe80::9da3:dc28:be54:cd4f]) by MW2PR12MB4666.namprd12.prod.outlook.com ([fe80::9da3:dc28:be54:cd4f%4]) with mapi id 15.20.5038.027; Mon, 7 Mar 2022 10:15:04 +0000 From: Ori Kam To: "NBU-Contact-Thomas Monjalon (EXTERNAL)" , "dev@dpdk.org" CC: "stable@dpdk.org" , Ray Kinsella , Jerin Jacob , Pavan Nikhilesh Subject: RE: [PATCH 1/2] regexdev: fix section attribute of symbols Thread-Topic: [PATCH 1/2] regexdev: fix section attribute of symbols Thread-Index: AQHYMTtwmfHXL4PPfEynoGPYX/bT0qyztceg Date: Mon, 7 Mar 2022 10:15:03 +0000 Message-ID: References: <20220306092023.2461466-1-thomas@monjalon.net> <20220306092023.2461466-2-thomas@monjalon.net> In-Reply-To: <20220306092023.2461466-2-thomas@monjalon.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 96ed1910-a2ff-4cec-905b-08da002358cf x-ms-traffictypediagnostic: DM5PR12MB1211:EE_ x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: eTADqK8epL1rG5Rbwwm6yvKxmqjDDlgZf86rOtpKytYPmKwHbvUUa9Xk2Bxu4I539X8HH0tnOnDC4aEYC+pI4CA8+ngFNY8NCTWVuykImBV0LJ6hRlyEPdMPgbNbAbJymvTnbEMnE20CJfrQ0ZDbKrBKQFm7/zMbTEgAel4O1vCUf9Dat2ar/Z72Vywzsgl2s6KlPe7BJZgcZWiFXfTOALydLWhnAvtdsOv0JmFmsPtaWtWDDvuSkPI+S1vOKJple7+U2B/K1zlbI/akWO8FdfYpjfXDUWnNNwbMjMApRXtlmhsa/4USd3sVpHZtA5PqhBesm0cGTUqtTYLxEPioKX4YZ1IUB1dTcxnXMCMtc1s+3SztXuoYsZrD8jfLCRZuO5mgoDRsC0xUPL7cL/s6T790RkXJwfLCT+Y8/oHRZ3ze1KJ2Mr/jms8hnRlhwovXkhQXbjNFtcyKx0OiRMBfd1F3pgQWq68oYwjwjW4xV+pryW1T90dhbUTJVHdI2IZdqbX7pb1W8pl62gPKXpdp+TETu9G6zbXsqUKpW/rkNNJa6B4ACmAKKvoXOaLI8iNyji1Pq2qmrB0TbfVRbfGYBGCNsSOGtdTNsCzFQDEeO1IZHEbz0UOdFpFeurBed9yxSu7YT7SpwKnDymaAV4F5UgLlbv+H9HBcrH4JD+bN/TV5VuAcjaBtZZSykNhSjrs0rMpsx4y7JsbPbEjkIR8H4Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR12MB4666.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(64756008)(186003)(66946007)(66446008)(4326008)(8676002)(71200400001)(66556008)(54906003)(110136005)(316002)(508600001)(83380400001)(9686003)(5660300002)(66476007)(2906002)(26005)(76116006)(52536014)(7696005)(53546011)(6506007)(8936002)(122000001)(38100700002)(38070700005)(33656002)(55016003)(86362001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vIHMrRPIovKjK9l86g3nrALRFuOqTcb2jxp7QN5T7A8hRoOzrJnwqZJXuymS?= =?us-ascii?Q?RHx0RX7aa5uzc485cmHl4c8OaokajVwGG/cMN+Y6jrNpTDgGNPZ+QZZRypBS?= =?us-ascii?Q?rp9yU2hElPv0ysOmTDzQyIPaUcE03CyQTgNdyiqStkIOTP6S+RfTEalwJwcy?= =?us-ascii?Q?5RC5l778j3asgDI50Sb9IA+RDy21sGTU8gg+AvRT2BIGIqYfGL3uUO95DisI?= =?us-ascii?Q?KeHJ0twK/d5n9J48ZcjAE5AJUwROu+H/nWHfKXx/LTPH9Pp3UgzBvFvp0tJ1?= =?us-ascii?Q?I4W9p5uvtvNRIatdtM+3MFnQKgFeP6ICSVjvlefMvDXa9YyUEhzGExXtNush?= =?us-ascii?Q?ziMI7NW3k+80VvhXKpEOs9Z0RxzK8fl/n38g7p98g7RaX7r8wTZJsMhlo2io?= =?us-ascii?Q?4rxeFYexPfYpymY3eC9gIKt/QRC6H0SorrWvHwd93FQHCAGAEvzt+EErHmma?= =?us-ascii?Q?VurbHzKFai6Nte91gD3a2udzZkd0oFpjeHh0zk6uxPmlwtkZ/3Sfk7Vszs5i?= =?us-ascii?Q?F6bz9H6Ac7z5T6OA3//BTsuZU3Hb9caNElMWz8rdBk5lNscVHuV5BA5mur/1?= =?us-ascii?Q?/fR6m3HwN+sPMAK9MSDg2F5feGIqS3NpcmLbjI1QjcFr4VH+Vave8MImR7bb?= =?us-ascii?Q?Wqbf2exkN6LBKd3R7XuohrKumVlJ4MlrWnwVPO0S8I4E/TuEdvKkvEeQbRnK?= =?us-ascii?Q?fysEvTQMq5dqhycrMsW3QwnOLCaF/eoG2o6AKYI9hOe6DsS3Pow50z0CAzEE?= =?us-ascii?Q?yyGKhmazNgfLPyYw7f2iw2g/EiJeSB+iHjdx5r31Tnt1W6ZdgssNxrVf8Zt9?= =?us-ascii?Q?knEUKTMZYizHT4q5oU7hdN7rnQETK93wv+PR/Afqq+1j0DY1JiqL756fmCbA?= =?us-ascii?Q?RNnL5H8Y5r26kqJ+Z1vfbOy1Nj+w4XBq0KdZkjjb3se/IJvvKwH6A3RWGAkZ?= =?us-ascii?Q?4iYrL+QDkS4CZUquRRwoGyJA7ycPpgZS7Fw3g5PtLimRNPqfhjPXQYqlU8bC?= =?us-ascii?Q?TEbvLPl7pKaMA04VOHUSWC4edQGXrGOyqH9HKlXmIrKZGr1OEKhhMVurPN4A?= =?us-ascii?Q?neNTFe12Mxu4d+Cz/LS/vqJze6jc25fMNQqb3v3AhoKLX7NX9tQ+ZRHvl1Ou?= =?us-ascii?Q?tui4N2UwMZkykhNLA6MKAl5JDST+zN0Q8Xu4mMiEa6Hq5jSBKPsWJRf7btF9?= =?us-ascii?Q?V9INe6FYVqJNw573Rnl6+APtICY7nObt0BEZ13znTwtWFuMDrLk1OfA0+xBf?= =?us-ascii?Q?hHmcEEsvnmMVYAPI7CGsL2zCgX1rTRugGqm6tcbQ3TfqRBH75ZtF0IUw8Sx/?= =?us-ascii?Q?VB7YX212HkAw2k+45WP8YWY/T57AGUCuNuevmNCFMogwqT2hRkmabZnSHH8X?= =?us-ascii?Q?FJzgChOoX8UFL0qs8koIFRpLAEVa27/wcuaeTtbRjo7QApEeQPIKzR/S4T90?= =?us-ascii?Q?n5z3hb0RxHvN92ieOZ/tyn7v9jWoHCjKdHpkp1p529OdkP51E87wElRoigEe?= =?us-ascii?Q?4bgAQeOsxFWurddRH9GfdmCQ5Q9Fuhew4c03pFHJI7h2KP3NIrUA9bxHARhs?= =?us-ascii?Q?mYZYma7jWuHsNk0WutDFfl4SV0I544LfwApIHjLqKfoUW8gNCas+5mqlNhdb?= =?us-ascii?Q?yw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB4666.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 96ed1910-a2ff-4cec-905b-08da002358cf X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Mar 2022 10:15:03.9106 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lx+gcxG7PwagQGkrW/7SMlZUBDPGhG57kgvmA2kUQG38FKENfJQdBuOzvcMn3XlUMWc/A5ZKHWwpN/ZiF2nC7g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1211 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Thomas, > -----Original Message----- > From: Thomas Monjalon > Sent: Sunday, March 6, 2022 11:20 AM > To: dev@dpdk.org > Cc: stable@dpdk.org; Ray Kinsella ; Ori Kam ; Jerin Jacob > ; Pavan Nikhilesh > Subject: [PATCH 1/2] regexdev: fix section attribute of symbols >=20 > The functions used by the drivers must be internal, > while the function and variables used in inline functions > must be experimental. >=20 > These are the changes done in the shared libraries: > - DF .text Base rte_regexdev_get_device_by_name > + DF .text INTERNAL rte_regexdev_get_device_by_name > - DF .text Base rte_regexdev_register > + DF .text INTERNAL rte_regexdev_register > - DF .text Base rte_regexdev_unregister > + DF .text INTERNAL rte_regexdev_unregister > - DF .text Base rte_regexdev_is_valid_dev > + DF .text EXPERIMENTAL rte_regexdev_is_valid_dev > - DO .bss Base rte_regex_devices > + DO .bss EXPERIMENTAL rte_regex_devices > - DO .bss Base rte_regexdev_logtype > + DO .bss EXPERIMENTAL rte_regexdev_logtype >=20 > Because these symbols were exported in the default section in DPDK 21.11, > any change in these functions would be seen as incompatible > by the ABI compatibility check. > An exception rule is added for this experimental library, > so the ABI check will skip it until the next ABI version. >=20 > Fixes: bab9497ef78b ("regexdev: introduce API") > Cc: stable@dpdk.org >=20 > Signed-off-by: Thomas Monjalon > --- =20 Acked-by: Ori Kam Best, Ori