From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 10EBA42499; Fri, 27 Jan 2023 06:02:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A433240143; Fri, 27 Jan 2023 06:02:14 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 7EF40400D7 for ; Fri, 27 Jan 2023 06:02:13 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30QJgmTj007330; Thu, 26 Jan 2023 21:02:11 -0800 Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2044.outbound.protection.outlook.com [104.47.66.44]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3nbn7265fn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 26 Jan 2023 21:02:10 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HlRuh4juJhovGagmHi0uIpxRJVS/CEDQWwCdLlcaK8wB558A6NJa1odhpVyV2/giN8a07grFPoTXWCOXL/Zko86YY0nBGKPEEvhq/y29gcdak3qc6qZga+vSHiiAo59JvbzV6TXfZ7aMaMV1yxGe0E3Ne+Bfk08FVcEiR6O9XbHM+mvi5im6t5jVv7QeZdo3BlqmeeIYxgiO0O5wZgiqpDWDdnE5chvyPQqvmFQqKKsiMVhQRWZ00oZPkpFnpX1jgWKVOyWYRS3cVyMqslG3VbWx8KvqOyUVrlzJRA8WY9Tm6A1p8Xrm2TZYDDnXEqb8KZjvxWidsJQb4m8udF/Z3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yCNfoJQQEtOPjM9k8PDWSwh0zdaiR+/EGxvmWBU20a0=; b=F4i1CUTXYptLyRuSpnkTwfiHunHLYMeAKBSi36AUsF4Kzp3YfWzT3rwe6+Rn8y1RU/D8EamJ/pIGRKJXUEbWvEtti4r4mB8FkI7hHDzpmpOYdLoyAc5gNfJ3LHBSAuRDUvWekAWrZF8uXbctTN8ERXPDFfG/xd+4TIWg0qMfkIx4T4E2ScfhYqaQ26BartjgqNTsRmhnDF2tMzggfRjJPxIa9XweG9XiXDiRLcEVcp3aZ3IN0jeKEYkz4Q37XoYyuKNdjoys4WduTqQeGW3x49GuzX4JTtk1PhT/WibzM+ZTmg0Cch9JBrzlgq5IpW+Sfv1tJhwfXQclpG0N4D06ug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yCNfoJQQEtOPjM9k8PDWSwh0zdaiR+/EGxvmWBU20a0=; b=fr6Odp++MwNs2xNkCYN9yH4Cibi1OUwA3FPqJgpeo/Y49qdm4ZsXRyayfPIEO6RDyPovXnghS9n3eOGEz7EhHOCBuGUXuu8mLi3hPzpKoksoY5iJoBSxTrbmlqgVjbQ5CX3bjpB+x80XTM5ZKjjjlV3XAkRQNXueeEybPcgfXS0= Received: from MW2PR18MB2171.namprd18.prod.outlook.com (2603:10b6:907:7::17) by PH0PR18MB4506.namprd18.prod.outlook.com (2603:10b6:510:ed::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.23; Fri, 27 Jan 2023 05:02:07 +0000 Received: from MW2PR18MB2171.namprd18.prod.outlook.com ([fe80::fd2b:d92c:23a6:e0ce]) by MW2PR18MB2171.namprd18.prod.outlook.com ([fe80::fd2b:d92c:23a6:e0ce%7]) with mapi id 15.20.6002.033; Fri, 27 Jan 2023 05:02:07 +0000 From: Nithin Kumar Dabilpuram To: Thomas Monjalon CC: Aman Singh , Yuying Zhang , Ivan Malov , Andrew Rybchenko , "dev@dpdk.org" , Hanumanth Reddy Pothula , Ferruh Yigit , "viacheslavo@nvidia.com" , Jerin Jacob Kollanukkaran , "david.marchand@redhat.com" Subject: RE: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation Thread-Topic: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation Thread-Index: AQHZFOEF13RJ68GZN0yKdTOQqbTyha6uEtAAgAECroCAADlygIAAEKwAgAABQYCAAAgo0IABWNqAgAEskzA= Date: Fri, 27 Jan 2023 05:02:06 +0000 Message-ID: References: <20221220200250.2413443-1-hpothula@marvell.com> <2252130.NnIJQXNAa5@thomas> <2238537.U75o6juQT5@thomas> In-Reply-To: <2238537.U75o6juQT5@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-dg-rorf: true x-dg-ref: =?us-ascii?Q?PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNcbmRhYmlscHVy?= =?us-ascii?Q?YW1cYXBwZGF0YVxyb2FtaW5nXDA5ZDg0OWI2LTMyZDMtNGE0MC04NWVlLTZi?= =?us-ascii?Q?ODRiYTI5ZTM1Ylxtc2dzXG1zZy1iY2ZkZDg2MS05ZGZmLTExZWQtYWYxNi1i?= =?us-ascii?Q?NDZiZmMzZTQ0YzJcYW1lLXRlc3RcYmNmZGQ4NjMtOWRmZi0xMWVkLWFmMTYt?= =?us-ascii?Q?YjQ2YmZjM2U0NGMyYm9keS50eHQiIHN6PSI2NzYzIiB0PSIxMzMxOTI2OTMy?= =?us-ascii?Q?NDE1Nzg1MzMiIGg9IjJhLzYrMS8xc2RzRUhEMkI2S0VHQk9ma1g2UT0iIGlk?= =?us-ascii?Q?PSIiIGJsPSIwIiBibz0iMSIgY2k9ImNBQUFBRVJIVTFSU1JVRk5DZ1VBQU5n?= =?us-ascii?Q?SEFBQWxoRmQvRERMWkFmc0VueGw2L0dSQyt3U2ZHWHI4WkVJTUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFIQUFBQUJvQndBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFFQUFRQUJBQUFBM1R6RkFBQUFBQUFBQUFBQUFBQUFBSjRBQUFCaEFH?= =?us-ascii?Q?UUFaQUJ5QUdVQWN3QnpBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUVBQUFBQUFBQUFBZ0FBQUFBQW5nQUFBR01BZFFCekFIUUFid0J0QUY4?= =?us-ascii?Q?QWNBQmxBSElBY3dCdkFHNEFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFRQUFBQUFBQUFB?= =?us-ascii?Q?Q0FBQUFBQUNlQUFBQVl3QjFBSE1BZEFCdkFHMEFYd0J3QUdnQWJ3QnVBR1VB?= =?us-ascii?Q?YmdCMUFHMEFZZ0JsQUhJQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFCQUFBQUFBQUFBQUlBQUFBQUFKNEFBQUJq?= =?us-ascii?Q?QUhVQWN3QjBBRzhBYlFCZkFITUFjd0J1QUY4QVpBQmhBSE1BYUFCZkFIWUFN?= =?us-ascii?Q?QUF5QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-refone: =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBRUFBQUFBQUFBQUFnQUFBQUFBbmdB?= =?us-ascii?Q?QUFHTUFkUUJ6QUhRQWJ3QnRBRjhBY3dCekFHNEFYd0JyQUdVQWVRQjNBRzhB?= =?us-ascii?Q?Y2dCa0FITUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQVFBQUFBQUFBQUFDQUFBQUFBQ2VBQUFBWXdCMUFITUFkQUJ2?= =?us-ascii?Q?QUcwQVh3QnpBSE1BYmdCZkFHNEFid0JrQUdVQWJBQnBBRzBBYVFCMEFHVUFj?= =?us-ascii?Q?Z0JmQUhZQU1BQXlBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUJBQUFB?= =?us-ascii?Q?QUFBQUFBSUFBQUFBQUo0QUFBQmpBSFVBY3dCMEFHOEFiUUJmQUhNQWN3QnVB?= =?us-ascii?Q?RjhBY3dCd0FHRUFZd0JsQUY4QWRnQXdBRElBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFFQUFBQUFBQUFBQWdBQUFBQUFu?= =?us-ascii?Q?Z0FBQUdRQWJBQndBRjhBY3dCckFIa0FjQUJsQUY4QVl3Qm9BR0VBZEFCZkFH?= =?us-ascii?Q?MEFaUUJ6QUhNQVlRQm5BR1VBWHdCMkFEQUFNZ0FBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBUUFBQUFBQUFBQUNBQUFBQUFDZUFBQUFaQUJzQUhBQVh3?= =?us-ascii?Q?QnpBR3dBWVFCakFHc0FYd0JqQUdnQVlRQjBBRjhBYlFCbEFITUFjd0JoQUdj?= =?us-ascii?Q?QVpRQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-reftwo: QUFBQUFBQUFBQUFBQUFBQkFBQUFBQUFBQUFJQUFBQUFBSjRBQUFCa0FHd0FjQUJmQUhRQVpRQmhBRzBBY3dCZkFHOEFiZ0JsQUdRQWNnQnBBSFlBWlFCZkFHWUFhUUJzQUdVQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUVBQUFBQUFBQUFBZ0FBQUFBQW5nQUFBR1VBYlFCaEFHa0FiQUJmQUdFQVpBQmtBSElBWlFCekFITUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBRHdBQUFBQUFBQUFBQUFBQUFRQUFBQUFBQUFBQ0FBQUFBQUNlQUFBQWJRQmhBSElBZGdCbEFHd0FiQUJmQUhRQVpRQnlBRzBBYVFCdUFIVUFjd0FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFCQUFBQUFBQUFBQUlBQUFBQUFBPT0iLz48L21ldGE+ x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW2PR18MB2171:EE_|PH0PR18MB4506:EE_ x-ms-office365-filtering-correlation-id: 7fee935a-0be0-484f-323e-08db0023a36c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: C7W7B/k5sXFFfClfpF704xlH+6ci+oHbUSYIvNFt8GmpH9aKr6Sx5zcztYdZyBchylNCDgQsENEkYlJk393YK4Sg++Nz7C/HDmPX523775NlPgLD5RzZYiXRJH36ggoBZwIq40yGjEvWFgJzW3dU9UyAtpHR4y4VJtibIYamgeIWdojI5zm4fYvsgQSC6c6qIPXz3BtsWpDse/mWJrqLuboBNQSRhawsXG+N3NEzPdq6PfLVlir/wLScU19zjKA6SiUhV5+/1SsOj1GuFVC04sQpk4irFOXi5zQvyLyBcyqHU7nnFFanrY3oF8PAgS4eMDDI6k8ZoE9hX7RxHPbAcry8aJvjODXjyfnJqS8ugHoHvfqSRyDamO7nMojPq5YaiiSf2MXmORRE0UFjtraRW3Urb3uTaCYIqiLkDA+QrlcEgx4gWamK7UrbRJDmp7HTknmznSEff71qXVE9zJE2csj1I0mD/G2GuO12l5ehMvnS2KIni6U0ww5FtjCDwlvNI/yltEsBIe+HPgAkVRxHa/oDMIgwHy0QxldIfvqIbmYM3aS8NTvJ100/S71aQnHPece7b6RMcbqhzrEyBcYqnKjXcWMtOcinPY1YU+hpxSQXYuZ6mbhmloGoalACxF+cK1c6VsYPfHqF9g4YAenIc6s1Mk4GOm1XXWqldNMfG4JdQbZVU2C6pU/JoZkNyEHpfbhirfF4cZV2Kp513uXCoA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR18MB2171.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(346002)(376002)(366004)(39860400002)(136003)(396003)(451199018)(38070700005)(122000001)(38100700002)(86362001)(55016003)(186003)(2906002)(6506007)(53546011)(9686003)(26005)(66946007)(54906003)(6916009)(66476007)(8676002)(66556008)(76116006)(64756008)(66446008)(4326008)(7696005)(71200400001)(316002)(5660300002)(478600001)(8936002)(41300700001)(52536014)(83380400001)(33656002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3teB+6JPpI0i083Zp1rUbOMXPMHbdzU/Bk2DLwrihfluD7x5fPQpuxkcg6b5?= =?us-ascii?Q?A9P17a/e4za+2MvngE852nv1xNOZi5MhkUCwFkkZBPyujKbm0KVgDxJ3anyi?= =?us-ascii?Q?x0wOZo3SLFOmNT2SqFv04IWIdteUjt2M441xl8SoPvQh1yLwyhaLlYnPLNhM?= =?us-ascii?Q?JXLlFPxrRSS4lR7waTBgYWBe8y+D3vrjoGefb6+KfYlh1+ONmRQ6RbtF3GpT?= =?us-ascii?Q?s9xAieUAYe5MzJWUmrBKdsWsVMZds7w64qH7ye6iuDlGM7PBLbuBTXblcR4G?= =?us-ascii?Q?3xZGEoeJi9dEqJZOvjbpBPDcGpArXSJ+iQecxUbktpZF+PC4akKRNXWm1rHu?= =?us-ascii?Q?V2k/G3ZnbfYwjSgBlNaCeWTQaXNhsBS4bFz2a1vn+PiNdIrXBL580VSurcf4?= =?us-ascii?Q?KcwvseYSBCSJDWPDG06DH/F8DP5W7FphvO/ZVgtiRK3uqKBzp3E55NkPqApk?= =?us-ascii?Q?swJe0QzYgGNJm/lqT0sL/+05yELf4hBVXFyHETyo/jKoNqO7wVjjwjx4YAzU?= =?us-ascii?Q?VZEcR6TPeTak8aAK2WQEoh47G8B4dQHf0bexboCAZPggQLvaBtNnSTBgpklL?= =?us-ascii?Q?BR8JJCoLCruoJW7j1vUB3806Fo0DiQPwUsUnGhQb5GxMa72L1TEYDFjifMPg?= =?us-ascii?Q?aXKW0ut/2NlLUQ6QeozgAsAYtCm5KcfEhWSjHBkk4BswP0C/PsJaLpb9bpXH?= =?us-ascii?Q?tj76ehk0iygVaDhJNYRjl9OQzBLZDVkP58/7sW4qM6+P1YTmGhBEx5/B9Vxo?= =?us-ascii?Q?HIoPeO9DFmKtIQbZe6io4b/mtFT7A2nuQ6xC1Tp8w3idOaFZVCVmjRTTDlDV?= =?us-ascii?Q?oP4Cr+lDD9QQp+2JzegL66s5hTbsR+iUXZ6+ZN0AP211TuDVYgwRccgbPjvl?= =?us-ascii?Q?ndZDTctQrHfDhVDDHlwlFL60uZ8dSDRZXW2inJhQlxigTIQyYMBerISrPnu1?= =?us-ascii?Q?19L6fI3zDvlaoosXoznbAsRrKoN74H1Qqvow0OH/tccGIj9VGNp9Wm5iu7Yx?= =?us-ascii?Q?1hPHobdUpBXjgwEh1o4J/UJdTEV0Mn3a8qs2tK9h2rzBETtyJn9vVgtJ3KV6?= =?us-ascii?Q?C427UkIH6COPpQMpaK555T/fHlwcKGKIYJUAUH1VDIeSI/z1e0gIVGNMwy9g?= =?us-ascii?Q?6A0YNqVIeB5eN+x1NMjbze6EC5ddJLut8rYeR9piRhjlElqCXYdgNdCnlvTt?= =?us-ascii?Q?F1/pi3rVoM+jigd61f1OMiZ/VIC2xDspPwo7Wqw/qpf1SwnqUbgh9HTgNUgu?= =?us-ascii?Q?rQjjP8I2eiuLSv3RUomflAty4euUwawNuH6eZoD4nTEkM9vOf74jO9GV5PEO?= =?us-ascii?Q?mQy+E+QEL/YKX/R7jVTXp3qEdY+6RyJ/U2nUN957MOvAMSwlsXJBPqgDGPQC?= =?us-ascii?Q?5c/K/0isYEWtTyQG08JRjDrW/s8gCpF8Hx/yem+LXj4rQYmw+G83Csh8EwBB?= =?us-ascii?Q?RV5B85OR1DiVERcH5U3sKoPVUTpYzhPRW3bEem357FQMFRIbPvjgm0opoWjO?= =?us-ascii?Q?eyADkW7rlqIknLGAGR41Z4sTN0i9ofBTHIFukJM2T136IokDatNCADzqD1RF?= =?us-ascii?Q?a2WsO8dM/qTxjf15E5t0WspGMb3LuEXA0L45bT2U?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR18MB2171.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7fee935a-0be0-484f-323e-08db0023a36c X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jan 2023 05:02:06.8220 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gCtQKbsNSjj/c+5Pr5W4z5hHn2C2YhCX04zgBX36IPLclh1ORp+HPrsamhpkHSkSlcecbiCgYo77oj4tHVa1DA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB4506 X-Proofpoint-GUID: jB_H_DYX5Xs9wizh09t669WfDu2Aw6_m X-Proofpoint-ORIG-GUID: jB_H_DYX5Xs9wizh09t669WfDu2Aw6_m X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-27_01,2023-01-27_01,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Please see inline. > -----Original Message----- > From: Thomas Monjalon > Sent: Thursday, January 26, 2023 4:33 PM > To: Nithin Kumar Dabilpuram > Cc: Aman Singh ; Yuying Zhang ; > Ivan Malov ; Andrew Rybchenko > ; dev@dpdk.org; Hanumanth Reddy Pothula > ; Ferruh Yigit ; viacheslavo@= nvidia.com; > Jerin Jacob Kollanukkaran ; david.marchand@redhat.com > Subject: Re: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process= Rx metadata > negotiation >=20 > Please reply inline below instead of doing an incomplete copy > of the replies on top. Ack, was just trying converge threads. >=20 >=20 > 25/01/2023 15:42, Nithin Kumar Dabilpuram: > > > >Will it work to enable them all by default and add capability to dis= able > > > >it in testpmd, which helps to run performance tests also to verify t= he > > > > impact of the API? > > > > The spirit of the negotiating features/Rx/Tx offloads upfront is to hav= e it disabled by > default and enable the feature only when needed. Having the features enab= led by default > is probably against that spirit. > > > > We understand the concerns with drivers that didn't not implement that = API. >=20 > There is no such concern I think. >=20 > > Why not disable it by default(like other offloads) and modify rte_flow = action creation in > testpmd to check for if !ENOSUP and feature disabled and add print to ena= ble. So for the > PMD's that won't support rte_eth_rx_metadata_negotiate(), there won't be = any > difference and for very few PMD's that support this API, they need to ena= ble it before > using RTE_FLOW with MARK/FLAG. > > Behavior change would be seen only with two PMD's(cnxk, sfc). >=20 > I think you missed the whole point. > Ferruh is proposing to have a command "port config ..." > to configure the flags to negotiate. > Are you OK with this approach? >=20 Yes, we are fine to have such command to enable and disable the feature wit= h default being it disabled if supported by PMD. Is default being disabled fine if the feature is supported by a PMD ? > > > Note: I don't understand why we don't have > > > RTE_FLOW_ACTION_TYPE_SET_TAG and RTE_FLOW_ACTION_TYPE_SET_META > > > negotiated in this function. Probably something to add. > > > > The purpose of negotiate is to tell the PMD upfront so that PMD can pre= pare > > HW appropriately. Having these new actions would be very late to infor= m PMD and > > I think won't solve the purpose. >=20 > I am not talking about your problem here. > I am just saying that TAG and META should be negotiated as well > in rte_eth_rx_metadata_negotiate(). >=20 > > From: Thomas Monjalon > > > 25/01/2023 14:55, Ferruh Yigit: > > > > On 1/25/2023 12:55 PM, Thomas Monjalon wrote: > > > > > 25/01/2023 10:30, Hanumanth Reddy Pothula: > > > > >> ++ Ivan Malov and Andrew Rybchenko > > > > >> > > > > >> From: Ferruh Yigit > > > > >>> On 12/21/2022 2:07 AM, Hanumanth Pothula wrote: > > > > >>>> Presently, Rx metadata is sent to PMD by default, leading to a > > > > >>>> performance drop as processing for the same in Rx path takes e= xtra > > > > >>>> cycles. > > > > >>>> > > > > >>>> Hence, add new testpmd command, > > > > >>>> 'enable port nic_to_pmd_rx_metadata' > > > > >>>> > > > > >>>> This command helps in sending Rx metadata to PMD and thereby R= x > > > > >>>> metadata flow command requests are processed. > > > > >>>> > > > > >>>> Signed-off-by: Hanumanth Pothula > > > > >>> > > > > >>> Hi Hanumanth, > > > > >>> > > > > >>> I agree with Thomas for the patch. > > > > >>> > > > > >>> 'eth_rx_metadata_negotiate_mp()' requests all Rx metadata offlo= ads to be > > > > >>> enabled, but at this stage if there is no flow rule for Rx meta= data why it is > > > > >>> consuming extra cycles? > > > > >>> > > > > >>> Can you update driver code to process Rx metadata when it is en= abled by > > > > >>> application (via 'rte_eth_rx_metadata_negotiate()') AND there i= s at least > > > > >>> one flow rule for it? > > > > >> > > > > >> #1 What is the purpose of rte_eth_rx_metadata_negotiate() API if= it is always > called by > > > testpmd. > > > > >> We thought it was added so that when that metadata is not needed= , application > need > > > not call this > > > > >> thereby saving cycles/bandwidth. > > > > > > > > > > testpmd is for testing all features. That's why all is negotiated= . > > > > > Cycles should be saved if you don't enable it until a flow rule r= equires it. > > > > > > > > > > > > > Hi Thomas, > > > > > > > > Not just for saving cycles, but from testing perspective too, do yo= u > > > > think does it work if a way to disable these Rx metadata added by > > > > keeping default behavior as it is? > > > > > > > > And new command can be in a consistent command syntax like: > > > > "port config ..." > > > > > > Yes I agree it would be good to have a way to test different values. > > > And it would allow to completely disable metadata I suppose. > > > > > > Note: I don't understand why we don't have > > > RTE_FLOW_ACTION_TYPE_SET_TAG and RTE_FLOW_ACTION_TYPE_SET_META > > > negotiated in this function. Probably something to add. > > > > > > > > > > >> #2 We use this API similar to Rx/Tx offload flags so that we can= set things up before > > > device is > > > > >> configured. We thought that is the purpose of having this negoti= ate API and avoid > > > depleting offload flags. > > > > > > > > > > It is just a configuration negotiation specific to metadata. > > > > > > > > > >> #3 Generally any new offloads added to DPDK would be in disabled= state in > testpmd > > > and we would have > > > > >> an option to enable it. In this case, testpmd is by default call= ing this negotiation. > > > > > > > > > > Negotiating is not enabling. > > > > > > > > > >> We can update the driver if the purpose of this API is clear. > > > > > > > > > > Please do. > > > > > > > > Is following understanding correct? > > > > > > > > API Flow Rule Result > > > > ----- ------------ -------- > > > > Enable No Rule Feature Disabled > > > > Enable Rule exist Feature Enabled > > > > Disable X Feature Disabled > > > > > > In the API column, you should say "negotiated" instead of "Enable". > > > > > > > > > > >=20 >=20 >=20 >=20