From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8453B42486; Wed, 25 Jan 2023 15:42:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 18B7D42D47; Wed, 25 Jan 2023 15:42:49 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 2B84742D3E for ; Wed, 25 Jan 2023 15:42:47 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30P7tG1H022696; Wed, 25 Jan 2023 06:42:45 -0800 Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2173.outbound.protection.outlook.com [104.47.59.173]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3nb0f69m10-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 25 Jan 2023 06:42:44 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Admb4cL8ykjxc+5BFf2GBt7/86+2HMEDkcyyP67rvjLrT2LRM0ge3sTQ9mM5YCPzrzWrTYQ2NDl87z+j3Zu2aeOplI5xxbeVI2QRqFCCZXKFqVFe7JG8Q8oMNoxxV/LTuyoVVzoiuk33QLPRytdpYf4S3HM1io7OAS+69JAykCZSZ8ajwYG/yuca5ojuPR2ECSUoADwugUNMEa/hyK2OgiEAt34exKAjL6EoChPuPVuI+uZEyvDUmCkkCz+VOjs9oI/An5TOB+PUTJXd6cjtoxoNlf6Giw1ynr0iyjEOE3/8je2z5IY3tlVJHXgFfcMecXqVns6ohkN50NFi0h65aA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fIzHr9EzV7Y5RwEfBwceahatwWx0tXXW2lYujUjZEdo=; b=ELf3CcSnaeMuxSg9C5L7NSmPVbTN3YGBkv85JRQWDzk5nBgMzP8cf3vNED5kPYgDd9XbCBSWVMLFXmrGEOJ1j/R4fUSeQGx9XFMpmsSzRNIJn7kP9T78rJnpWpbBhedPleMS1Y8vt2OjevkLNIN/zmc2Y946yrAkAMCBC/99PWBvBOzTKr8TIodFUx81KSpk74flhtPNIgfoMCdxIWfnzOsX06hnre0jSe/RSvRH80280V+jMFSWLUkNL7uAOVabLOjgjOyHKbn3pXHzo2NdChnDLHCuteBrQSeNXjTOdJy2kKQgVYm+0J0tGK4cUlSh9ag4dDthnFoyN6p3hjQQ/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fIzHr9EzV7Y5RwEfBwceahatwWx0tXXW2lYujUjZEdo=; b=bxjlAEgXlfuTiZWPoOTIjp8nwU6cc6GAfpo2csuyAaSChhMknVqxuaBAlWyr1Zaq9+IA5bhUX5lKHDW5z56DajETUEfRjllnY4nF2ctFcvKCPUsARGwRH57OeSvLG2sxn1qvFOqVwhlgHF7mwb7oBRkYx/3N7tKqpzcrXicHQTw= Received: from MW2PR18MB2171.namprd18.prod.outlook.com (2603:10b6:907:7::17) by SA1PR18MB4646.namprd18.prod.outlook.com (2603:10b6:806:1d5::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.33; Wed, 25 Jan 2023 14:42:42 +0000 Received: from MW2PR18MB2171.namprd18.prod.outlook.com ([fe80::fd2b:d92c:23a6:e0ce]) by MW2PR18MB2171.namprd18.prod.outlook.com ([fe80::fd2b:d92c:23a6:e0ce%7]) with mapi id 15.20.6002.033; Wed, 25 Jan 2023 14:42:41 +0000 From: Nithin Kumar Dabilpuram To: Thomas Monjalon , Aman Singh , Yuying Zhang , Ivan Malov , Andrew Rybchenko , "dev@dpdk.org" , Hanumanth Reddy Pothula , Ferruh Yigit CC: "viacheslavo@nvidia.com" , Jerin Jacob Kollanukkaran , "david.marchand@redhat.com" Subject: RE: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation Thread-Topic: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation Thread-Index: AQHZFOEF13RJ68GZN0yKdTOQqbTyha6uEtAAgAECroCAADlygIAAEKwAgAABQYCAAAgo0A== Date: Wed, 25 Jan 2023 14:42:41 +0000 Message-ID: References: <20221220200250.2413443-1-hpothula@marvell.com> <5290135.upeRZZJTqa@thomas> <2252130.NnIJQXNAa5@thomas> In-Reply-To: <2252130.NnIJQXNAa5@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-dg-rorf: true x-dg-ref: =?us-ascii?Q?PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNcbmRhYmlscHVy?= =?us-ascii?Q?YW1cYXBwZGF0YVxyb2FtaW5nXDA5ZDg0OWI2LTMyZDMtNGE0MC04NWVlLTZi?= =?us-ascii?Q?ODRiYTI5ZTM1Ylxtc2dzXG1zZy04MWVhYjBkMC05Y2JlLTExZWQtYWYxNS1i?= =?us-ascii?Q?NDZiZmMzZTQ0YzJcYW1lLXRlc3RcODFlYWIwZDItOWNiZS0xMWVkLWFmMTUt?= =?us-ascii?Q?YjQ2YmZjM2U0NGMyYm9keS50eHQiIHN6PSI1NDY3IiB0PSIxMzMxOTEzMTM1?= =?us-ascii?Q?NjYwNTI4NTEiIGg9IlNnZXhjSElPcXZqd1ZHMXVVQTBYZnBnR3U0dz0iIGlk?= =?us-ascii?Q?PSIiIGJsPSIwIiBibz0iMSIgY2k9ImNBQUFBRVJIVTFSU1JVRk5DZ1VBQU5n?= =?us-ascii?Q?SEFBRHpzVVZFeXpEWkFhL3huR0tpWFdNTXIvR2NZcUpkWXd3TUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFIQUFBQUJvQndBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFFQUFRQUJBQUFBM1R6RkFBQUFBQUFBQUFBQUFBQUFBSjRBQUFCaEFH?= =?us-ascii?Q?UUFaQUJ5QUdVQWN3QnpBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUVBQUFBQUFBQUFBZ0FBQUFBQW5nQUFBR01BZFFCekFIUUFid0J0QUY4?= =?us-ascii?Q?QWNBQmxBSElBY3dCdkFHNEFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFRQUFBQUFBQUFB?= =?us-ascii?Q?Q0FBQUFBQUNlQUFBQVl3QjFBSE1BZEFCdkFHMEFYd0J3QUdnQWJ3QnVBR1VB?= =?us-ascii?Q?YmdCMUFHMEFZZ0JsQUhJQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFCQUFBQUFBQUFBQUlBQUFBQUFKNEFBQUJq?= =?us-ascii?Q?QUhVQWN3QjBBRzhBYlFCZkFITUFjd0J1QUY4QVpBQmhBSE1BYUFCZkFIWUFN?= =?us-ascii?Q?QUF5QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-refone: =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBRUFBQUFBQUFBQUFnQUFBQUFBbmdB?= =?us-ascii?Q?QUFHTUFkUUJ6QUhRQWJ3QnRBRjhBY3dCekFHNEFYd0JyQUdVQWVRQjNBRzhB?= =?us-ascii?Q?Y2dCa0FITUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQVFBQUFBQUFBQUFDQUFBQUFBQ2VBQUFBWXdCMUFITUFkQUJ2?= =?us-ascii?Q?QUcwQVh3QnpBSE1BYmdCZkFHNEFid0JrQUdVQWJBQnBBRzBBYVFCMEFHVUFj?= =?us-ascii?Q?Z0JmQUhZQU1BQXlBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUJBQUFB?= =?us-ascii?Q?QUFBQUFBSUFBQUFBQUo0QUFBQmpBSFVBY3dCMEFHOEFiUUJmQUhNQWN3QnVB?= =?us-ascii?Q?RjhBY3dCd0FHRUFZd0JsQUY4QWRnQXdBRElBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFFQUFBQUFBQUFBQWdBQUFBQUFu?= =?us-ascii?Q?Z0FBQUdRQWJBQndBRjhBY3dCckFIa0FjQUJsQUY4QVl3Qm9BR0VBZEFCZkFH?= =?us-ascii?Q?MEFaUUJ6QUhNQVlRQm5BR1VBWHdCMkFEQUFNZ0FBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBUUFBQUFBQUFBQUNBQUFBQUFDZUFBQUFaQUJzQUhBQVh3?= =?us-ascii?Q?QnpBR3dBWVFCakFHc0FYd0JqQUdnQVlRQjBBRjhBYlFCbEFITUFjd0JoQUdj?= =?us-ascii?Q?QVpRQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-reftwo: QUFBQUFBQUFBQUFBQUFBQkFBQUFBQUFBQUFJQUFBQUFBSjRBQUFCa0FHd0FjQUJmQUhRQVpRQmhBRzBBY3dCZkFHOEFiZ0JsQUdRQWNnQnBBSFlBWlFCZkFHWUFhUUJzQUdVQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUVBQUFBQUFBQUFBZ0FBQUFBQW5nQUFBR1VBYlFCaEFHa0FiQUJmQUdFQVpBQmtBSElBWlFCekFITUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBRGdBQUFBQUFBQUFBQUFBQUFRQUFBQUFBQUFBQ0FBQUFBQUNlQUFBQWJRQmhBSElBZGdCbEFHd0FiQUJmQUhRQVpRQnlBRzBBYVFCdUFIVUFjd0FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFCQUFBQUFBQUFBQUlBQUFBQUFBPT0iLz48L21ldGE+ x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW2PR18MB2171:EE_|SA1PR18MB4646:EE_ x-ms-office365-filtering-correlation-id: b902947e-06fe-47fa-7f5f-08dafee269d8 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2yalTapng11BeRQTZVnTMfVclFtWAHdXo0LCS7087/0jD9MvNGTmu2tzpy6s/v/mM71k9HxTLph9n03t8JjpIjVjAwAeCEMvBMfp35fr4aj2+3I9hzP2Qg0QhCRhJ3e2x3GejWiG5Nfl+h9GezBQpzWnI1+aQDJ1WgzhD/t6xmmHpIXQ1+gluJ46WgiG5QcIHWcnzXLAjkJPIcjyG52auG8462uz4jQ95OKieCTTa/HRZWHeHb+Quarq2Myy2UCpjSc7o/NOoSpguk3zo36/PjnrGxUCAZosU1A2YARlFU987j8v7V6r6xEW0ckWN/MHYF+Mxi4q8C9EEDNHDU/4n0MEkPFsIl0uPaziox8roO4kLuJi1Oko9roH0HTXG41cjcEJF76nVwAD3chtfZm4MdwZScv9ui8PAessknMPJswwtudXCu8CQg/yKL5eDIShPFI7DxlWZ77+UY2yq2cS4E5UYiqNb46XUYMYaBdj2rnQdOJOGbRJbFVkdKGwCfKYLCeLSs+AFVk76fvt47CxNw6wMqN70e4pJlAMLZH8dtrIetryz7V61S5gU8QrkrarD0hCF0YZDxXqWyd/MwRkAMGBnsrPXyglaydzqDarMSBKUOv/6SEtmaburXO53MLSRspCBuFioNEbGrPwqHtnk+RrD8DzY34k7h0woAfZQKyLUGmzTPRV4vqhDG9qABP3h1KMtvXDBftmyn7IN2LEDA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR18MB2171.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(396003)(376002)(136003)(346002)(366004)(39860400002)(451199018)(6506007)(186003)(9686003)(7696005)(122000001)(38100700002)(478600001)(86362001)(2906002)(53546011)(71200400001)(38070700005)(110136005)(41300700001)(316002)(52536014)(4326008)(54906003)(76116006)(83380400001)(64756008)(8936002)(66946007)(33656002)(8676002)(66476007)(55016003)(66446008)(66556008)(5660300002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qZGas+/ruPXr4J1a5ZIMGM2Cf5r+fNm2r7QLp94GIn6DDgS+raZPvRUo8sUQ?= =?us-ascii?Q?inItgmudY/Xsa2nBSEOZrFGeoKUjLzs/eLCOlARP/64EbKcvtbmIYdybLY2a?= =?us-ascii?Q?vOXIySZXeZ33jnLhLUYHKlDgK3oxuhLEjVuilqTbGgpBlheA8LafUAzGzdIL?= =?us-ascii?Q?z1Ud7gftLzj21rDS3n06pt0kqs/vz4EbX0fOqNAWWhTbZl6RiiF8WFGSb+YR?= =?us-ascii?Q?x9mqVCnpQCmv3mmneHXiZiZfpe5xfavVv9YB6X8PI+8V1BIc0oWhf1cQ3CGx?= =?us-ascii?Q?rUaIr/fO9zcxxNr2/uEBvdFb61yeImswctPjmL1Rb8MJMO1Z72fhXZFgv8L6?= =?us-ascii?Q?pj36GOPxFZ94h6PerVFw9gz6ZjhrQcf0ZFpfMAue2m3XNUMbAQoMh9eQ69Ll?= =?us-ascii?Q?2140cmqHjrBBOjCxHPriaINKrG91kNYnmBI1/2BMZ48kE4h/GKoykWm/sBxf?= =?us-ascii?Q?HNY0L43dacQD0o2ks1hJFNiAQlr5dA+k+AjuLp9qOeDbxUGFPBuwaKHYIsfm?= =?us-ascii?Q?7fRCq9e5bP6fm2aNH8myE4hHTIcqesAJOzvr8pZRy4TpH/RW1e50MuaFZbUj?= =?us-ascii?Q?SEf7tqNTmkXbNp0TQZL4g/mAxksr3MzLRIhH6saBi8J8Lp53GRgyfs8c4Jv4?= =?us-ascii?Q?4W/2PCvLOpd9qpEH7rgF0eqLuVXSyti1KjqitEeyRWU6OtO2+mmFGEQcK3eZ?= =?us-ascii?Q?+bsMeZ6Gg5tJs+fcYVp0A5GoBj1cdE/h/k+P5wLHmIjK7iF24yMlyiSLxS+S?= =?us-ascii?Q?q8WKIFrK7KBjmXVCGqJCaV6ZM7a2RceC7/FkDj97Wna4ZC+SXAza6Jt6AwQt?= =?us-ascii?Q?OWh+h58ihhqwqZwulZV0FisxJyiW74JtsPQ9gFg2jGcSp13/33V15rV0CX4s?= =?us-ascii?Q?sFaslzyCLKrDNORu5zVlYVF7W4+WULgWMv0YktHZF/d+DhnoL084FBStp9YH?= =?us-ascii?Q?avINpqiprqN0w6PsNy+PT7P1Rh9qUxoU1g9xj2T3mZvU5oB8ITHkwYxENaLZ?= =?us-ascii?Q?5rMlWFliLXMgHEsHl6hE38uVtR8cO+ssKZPwYqChXguq4wa7/niYX7ApwQ5j?= =?us-ascii?Q?w03cMPYNjBv3PyZYpXRGZjMFteKZ554tktxhM99s6WHXmJr5MJUN1ygmwsx1?= =?us-ascii?Q?yugY7m3ryXU30KXQwnbiAcOfIK/OzXMmgWmhQrBKZyb+btTV3vPcb9581HXy?= =?us-ascii?Q?JFSCyPcB9GRmNSnIDpQkz7gcadarycWb27iwdnJBUVvacVPNDPNP7XBGUuBK?= =?us-ascii?Q?kg49TU0xysgGARkJjzaHwZnIQCUTEi7r7KMfTG4IxSRz+KZOJIMs+1+aw59b?= =?us-ascii?Q?sc8wA5hGipJ3xA2IIHYxDZs3xRrOhOZauOAz1hUNZrDRYOcyRyIR7wz4vCRS?= =?us-ascii?Q?9CpjKDwQ7g9h7rDWJZyv5QSlc45ROpwYOHvJw9oH8VrTQcBkSCP2k9o+yYwa?= =?us-ascii?Q?SqGj0o1UXfGv5YpedZm3WBl4PMFhGx6TdSVdzuH81u8xc0pnD7V9tTI5mKPg?= =?us-ascii?Q?7hBr3NOct9mmenzBIoW8iYg5H1b4hS1oio69v41eOf9sjvqJRi+iKKqP953K?= =?us-ascii?Q?tHPayJy3KIh6lq8mDRcgV4Si1kvL3P399BmaMAfkh4BO5gGO4m8uo9nicfdV?= =?us-ascii?Q?MKvIXutl8k92jWHt16uKEiHB6C9kPOmf6PqfFRsxFjIp?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR18MB2171.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b902947e-06fe-47fa-7f5f-08dafee269d8 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jan 2023 14:42:41.7894 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dCEfhRm5JHPBrXtA1EmfkrS9V0xOsx6LMoDhiRSKFONeVtvxS0LGzxADB4lhAfWItMilmOva7ginwqN1m7Z4Bw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR18MB4646 X-Proofpoint-GUID: nWJIaaVc6mEGbjh559VnWbkyu7-w1zis X-Proofpoint-ORIG-GUID: nWJIaaVc6mEGbjh559VnWbkyu7-w1zis X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-25_08,2023-01-25_01,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > >Will it work to enable them all by default and add capability to disable > >it in testpmd, which helps to run performance tests also to verify the > > impact of the API? The spirit of the negotiating features/Rx/Tx offloads upfront is to have it= disabled by default and enable the feature only when needed. Having the fe= atures enabled by default is probably against that spirit. We understand the concerns with drivers that didn't not implement that API. Why not disable it by default(like other offloads) and modify rte_flow acti= on creation in testpmd to check for if !ENOSUP and feature disabled and add= print to enable. So for the PMD's that won't support rte_eth_rx_metadata_n= egotiate(), there won't be any difference and for very few PMD's that suppo= rt this API, they need to enable it before using RTE_FLOW with MARK/FLAG. Behavior change would be seen only with two PMD's(cnxk, sfc). > Note: I don't understand why we don't have > RTE_FLOW_ACTION_TYPE_SET_TAG and RTE_FLOW_ACTION_TYPE_SET_META > negotiated in this function. Probably something to add. The purpose of negotiate is to tell the PMD upfront so that PMD can prepare HW appropriately. Having these new actions would be very late to inform PM= D and I think won't solve the purpose. > -----Original Message----- > From: Thomas Monjalon > Sent: Wednesday, January 25, 2023 7:30 PM > To: Aman Singh ; Yuying Zhang ; > Ivan Malov ; Andrew Rybchenko > ; dev@dpdk.org; Hanumanth Reddy Pothula > ; Ferruh Yigit > Cc: viacheslavo@nvidia.com; Jerin Jacob Kollanukkaran ; Nithin Kumar > Dabilpuram ; david.marchand@redhat.com > Subject: Re: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process= Rx metadata > negotiation >=20 > 25/01/2023 14:55, Ferruh Yigit: > > On 1/25/2023 12:55 PM, Thomas Monjalon wrote: > > > 25/01/2023 10:30, Hanumanth Reddy Pothula: > > >> ++ Ivan Malov and Andrew Rybchenko > > >> > > >> From: Ferruh Yigit > > >>> On 12/21/2022 2:07 AM, Hanumanth Pothula wrote: > > >>>> Presently, Rx metadata is sent to PMD by default, leading to a > > >>>> performance drop as processing for the same in Rx path takes extra > > >>>> cycles. > > >>>> > > >>>> Hence, add new testpmd command, > > >>>> 'enable port nic_to_pmd_rx_metadata' > > >>>> > > >>>> This command helps in sending Rx metadata to PMD and thereby Rx > > >>>> metadata flow command requests are processed. > > >>>> > > >>>> Signed-off-by: Hanumanth Pothula > > >>> > > >>> Hi Hanumanth, > > >>> > > >>> I agree with Thomas for the patch. > > >>> > > >>> 'eth_rx_metadata_negotiate_mp()' requests all Rx metadata offloads = to be > > >>> enabled, but at this stage if there is no flow rule for Rx metadata= why it is > > >>> consuming extra cycles? > > >>> > > >>> Can you update driver code to process Rx metadata when it is enable= d by > > >>> application (via 'rte_eth_rx_metadata_negotiate()') AND there is at= least > > >>> one flow rule for it? > > >> > > >> #1 What is the purpose of rte_eth_rx_metadata_negotiate() API if it = is always called by > testpmd. > > >> We thought it was added so that when that metadata is not needed, ap= plication need > not call this > > >> thereby saving cycles/bandwidth. > > > > > > testpmd is for testing all features. That's why all is negotiated. > > > Cycles should be saved if you don't enable it until a flow rule requi= res it. > > > > > > > Hi Thomas, > > > > Not just for saving cycles, but from testing perspective too, do you > > think does it work if a way to disable these Rx metadata added by > > keeping default behavior as it is? > > > > And new command can be in a consistent command syntax like: > > "port config ..." >=20 > Yes I agree it would be good to have a way to test different values. > And it would allow to completely disable metadata I suppose. >=20 > Note: I don't understand why we don't have > RTE_FLOW_ACTION_TYPE_SET_TAG and RTE_FLOW_ACTION_TYPE_SET_META > negotiated in this function. Probably something to add. >=20 >=20 > > >> #2 We use this API similar to Rx/Tx offload flags so that we can set= things up before > device is > > >> configured. We thought that is the purpose of having this negotiate = API and avoid > depleting offload flags. > > > > > > It is just a configuration negotiation specific to metadata. > > > > > >> #3 Generally any new offloads added to DPDK would be in disabled sta= te in testpmd > and we would have > > >> an option to enable it. In this case, testpmd is by default calling = this negotiation. > > > > > > Negotiating is not enabling. > > > > > >> We can update the driver if the purpose of this API is clear. > > > > > > Please do. > > > > Is following understanding correct? > > > > API Flow Rule Result > > ----- ------------ -------- > > Enable No Rule Feature Disabled > > Enable Rule exist Feature Enabled > > Disable X Feature Disabled >=20 > In the API column, you should say "negotiated" instead of "Enable". >=20 >=20