From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 60B0941E86; Mon, 13 Mar 2023 18:29:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EEA8B40E03; Mon, 13 Mar 2023 18:29:31 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 1F27F406BC for ; Mon, 13 Mar 2023 18:29:29 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 32DBcTdE012796; Mon, 13 Mar 2023 10:29:29 -0700 Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2176.outbound.protection.outlook.com [104.47.57.176]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3p9xxmtj3k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 13 Mar 2023 10:29:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RELQo/kIKpTVttEMwm/5+dJRqwhorzL/w/7Kr0gYQOyezfXQ1JGVzYMOXsEpvfiOCAPxCbfBnaT6K8ZeBAUEPrd6bnvlUAaYWox4mHhO9PXTawNqj6E57qV/q6IL8FtVnWsmosorz8wmvsHBPbqIBbqEpzGq1+c55d7yYDx6tZ8PRiStU7rbw4AJAsu6RJaVX6kd1W9vk6+aV/FUI6j8Oqbj6v+aB/lkOuesjkYPvi65LBYL5qRpE0dwPhAcFeoWiJGWJeHVc3bCTC+pbT6oVr5DR60Kx1+z2kFFX9cDdWQrGHiwHp56xC5zQs9TW7BVrJ4gqkqUg8O5yV22CytxKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DHa8UozdcTuOfes4lZSfbrhvkXXQ1arbwcWwGATwAe8=; b=VcrU66J3C1y92WA9Y8/jFIyJPn+HAqnszTbsa6QsSBkQUOaYQL7QC2PIyDTIsgDC+HmF/ARvMlbzGArchOHebdw+z+u8Cj0AvD8jhhSRdtzuTD0AvLY/X1mcEUxzIbuvGpJo6WHquGWgzuC1WdhDw8+XkwJiUoZEazZ/LJz9yKvzmX7kQUYy/EyXNKE4e81EoXwtBvWkZqv4xKXA9oU+5UBU73+D+6NzEgzb1qJRMUkLsm8tnyVipxZ8grQciI1T0muMXzDdAxQ+vg401esEVnq+/hJ8R3TOnVGcqxQr82g4WnZ9Tat0Dc1f8IyBkV2YopT7T+R+OIsUIcVlnan8mg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DHa8UozdcTuOfes4lZSfbrhvkXXQ1arbwcWwGATwAe8=; b=CIKXoKsz4k2baS5P7lQWIlgYveUzjPqyTJM8T2ETp9igVpmQrfc/6Gj7DrvOToHfSRlNoeZFOiFrzFSSTUIySJg4Pd/y1Cw8M7lJ8U5vMc6cnrpme/yWZapMDvYNzVvlSq5bcsWwx9tG7nQhd2rRfM+g3sEHqQiFUSLm7sfaUbI= Received: from MW2PR18MB2282.namprd18.prod.outlook.com (2603:10b6:907:f::19) by BN9PR18MB4202.namprd18.prod.outlook.com (2603:10b6:408:137::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.24; Mon, 13 Mar 2023 17:29:25 +0000 Received: from MW2PR18MB2282.namprd18.prod.outlook.com ([fe80::e0e0:c7fe:674e:ed00]) by MW2PR18MB2282.namprd18.prod.outlook.com ([fe80::e0e0:c7fe:674e:ed00%7]) with mapi id 15.20.6178.024; Mon, 13 Mar 2023 17:29:24 +0000 From: Volodymyr Fialko To: Stephen Hemminger CC: "dev@dpdk.org" , Reshma Pattan , David Marchand , Andrew Rybchenko , Jerin Jacob Kollanukkaran , Anoob Joseph Subject: RE: [EXT] Re: [PATCH] reorder: fix registration of dynamic field in mbuf Thread-Topic: [EXT] Re: [PATCH] reorder: fix registration of dynamic field in mbuf Thread-Index: AQHZVY8WEGmHZX7slE2qVmDd+/IvFq743B6AgAAOKtA= Date: Mon, 13 Mar 2023 17:29:24 +0000 Message-ID: References: <20230313093450.2560058-1-vfialko@marvell.com> <20230313085105.65a0320e@hermes.local> In-Reply-To: <20230313085105.65a0320e@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW2PR18MB2282:EE_|BN9PR18MB4202:EE_ x-ms-office365-filtering-correlation-id: 4c0ba8a7-f4bc-46ef-b7a5-08db23e87d74 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0PPzVZZY8aCab/l3M5WEm3EO0IrK0VBkt08DDlDlCozQixmI4fTtk0siJCTB3vpz6dIYO38wRKyJZSzPDAacg8wKImOeubgHeiPQVTtNroWwgAVidijj4dk51TRrEud19U/g3918eYhEwpX30n6Au9zlHoktcToKXy1UKtK+BT90v4kTa1yZKuTOHvLC3Cw+dxNup9gyRRylw/qUEnPStcc99Q+8dS+tpgAHYpwfA1Q5nEUbUT1eV9vUZYymhLKSTGLOFjDylaogU9e8hXz8kBTXFN6wG6/OGZn/yYh8su2ky11+d5k7lu0QjMAlfbD+XXYq2pH8LroI9+AV2K7mrji7WdKMO/oFPxCjCDrp414dCoVDgUwYvkAo0pUAU9nJJk1DfQ1d+TKywKw86Ryff0F7xYf5H9/w+xg72nUAtnBInq9GccRDZqJvPs5JjmQ4Hqe6BxOwYjG/04/q6cWmYuPcnuSrckBks0s+Anyk68+Ud7JiEG7gkVOumFviO/5aSu0Rg1gcUVG+BjJZlukGvBgrICe1GB0ZloQZwq8UYD5q7sAhiWtNcbCCdyIdORfNwzsXI+SSTRzsnAmmyYrExssp71zqQ2TqfvNaxmoepiaVgZ9V0cUCfnyehgpFD3DeAJadT9EtAS8fw/WbN2qqjzDdzMGmTe5hr/KoIR+auJhHXYflg4xIec+5zeoCgm413vo7oYat0CxZIEjhB3WXeQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR18MB2282.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(136003)(376002)(39860400002)(346002)(396003)(366004)(451199018)(2906002)(122000001)(41300700001)(83380400001)(5660300002)(66946007)(8676002)(64756008)(33656002)(66556008)(52536014)(8936002)(55016003)(6916009)(66476007)(76116006)(4326008)(38070700005)(38100700002)(316002)(54906003)(86362001)(66446008)(478600001)(186003)(9686003)(26005)(53546011)(71200400001)(107886003)(6506007)(7696005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?NvP63+g9OBCazkclt/6WclZoU+gFy8FK+9L/EZRD1d2BmSOQBBp78nQOU8AA?= =?us-ascii?Q?fiRi0zWcJZXMc8Sd82HKrt6OpFo2+JSwZhCXNWg1QxqqjhxYhaQ2vm5WWK2V?= =?us-ascii?Q?b37X5Rq8/xrhEOQxeKvjn5HyDUN2OduDM4bU9ZMfXQ3JAAPc/JiYqu+aMVsI?= =?us-ascii?Q?oCl1G/zxChrZaByVpMnDJLLSlTRFuMqFRfPB3JwMn3kD62E4dxX1cZR3uG79?= =?us-ascii?Q?4fzKyrkgWK/kKojoBJ34O7p9ewidSLqNpK3u08TYMrOUnp4JR1hkSI18kd+A?= =?us-ascii?Q?u4yqXTm8c5Hg2hQxSd/nJZQjyT8hpWEv1RkjUSe8xBRepZxmP41l6KD6rqZT?= =?us-ascii?Q?kXh/5fe/FbSDDKQ9MlfBvIRw9teSOMGnHbZFNSwbjoWdb3Q71FUXaLsXKNGx?= =?us-ascii?Q?5u1RMI1uiyVqnBPcjE0Ep3QiuLzttWQwGC8FSDw7C93UsPerra+8gvZOFCEy?= =?us-ascii?Q?2i+AVnmctEykqAdwS8WgNS2VMwcdBA/VomgdwOf0SKfaK2Z+mgmw/on51CmG?= =?us-ascii?Q?/tgrKHQLSCoDeVNP43cDbQw5KoSy2k7P4H91rtBue1fltvnUoLt1Wflp+3a2?= =?us-ascii?Q?C6SGpJHgYHawoWuqQLSc4gXaCS1eELp5dMjquvmgI8ldWvOMh5d/6eBh5ZON?= =?us-ascii?Q?VS7N0QxL5mOl+QLwpV3tkIa2CUe5rB4GQVm69dkOLJ/FFQI5xf6LnXnVmGN2?= =?us-ascii?Q?2DQVHYXMpAYrczUEbAUtYste8Z8R6MOpEM/bqx4jhjjstImh8u8qJuWTStnv?= =?us-ascii?Q?nhiLNcJmbH5ICgbA99T7+o/wzR5zoqOHj8uGhTNOuOQpDLTjpE7iroGkuJyA?= =?us-ascii?Q?a/Yc6go2dcYU5Hi+4vGiHRrVX9gbXh9FYil1NqCT+EYv1oxxbtBKmbRs9816?= =?us-ascii?Q?e51548/GsTeIxesB2yfad49uvK3q++vq3z2AK+XoB//CcS/sM39STTQyrpf5?= =?us-ascii?Q?tQKTqkWziwTGv6k+hWhPZyM7OR88addkEGPiNuZ+gzblg7yrS78COhHodb0f?= =?us-ascii?Q?BXASCXIwway4fwAzJCeNSMH2O/BNh+GuPTWl4uYAiS/ex1ACLVuZC/Nts6W5?= =?us-ascii?Q?jcQMJjvK2CvsNpv+ZdekZ4WTRAq2Me3p126cKe6QzrLMArTp+suqSqsulVYz?= =?us-ascii?Q?WRay+S8R1yxxe23G257KVO7VO81fmvItw3tYeBj4EBI2CniYGJ1X+w4NAxWo?= =?us-ascii?Q?y4by0vgojWPK//YIcGiDLcOBAB/xZ0iy9tL5eeQuRmOXs/tAVuCtUDZm5Fb0?= =?us-ascii?Q?E+lPoVQ2Bzi+9fCfWICWN07bYO6l1yItz4ugIBYf/gcLze3yLyhdb4hPzGRa?= =?us-ascii?Q?W4b6+yYZFA+Pc/PaxmGaqObmQbwhvbKhVAeDw9HKZz367vFgFIc+sesZ0fkr?= =?us-ascii?Q?iEinFlSlDhGWNb295QzwlXLsNulzjQuvHXL98zBjL4DAYs3wfSgVIEpI8e0v?= =?us-ascii?Q?H1gLeh7Fw7+yZbBMaHyydbupUAG10Mhe5K5yZQ0RsMuvAT8dOGo1WeEMFkrl?= =?us-ascii?Q?hlYNzsLhRSJWpbHw0LflK6R3MFo+hIoSsuX+ZcYjdQ9mv7/4Qm/L+O9DKVqs?= =?us-ascii?Q?sF/p4BZELNkI5FzdN3RAPOdBmxmjL+wo4eiYYBiV?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR18MB2282.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4c0ba8a7-f4bc-46ef-b7a5-08db23e87d74 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Mar 2023 17:29:24.6774 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Lw2+faOC6SBMcC1ZoQ7yySJasRoPf/v5rAATqTz96P6ihqhe8u1zXZAEPISXWRv5u+voe2K3E7cv4QAomTQ3+w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR18MB4202 X-Proofpoint-GUID: GQKDTzeJptm5wML9v9uLmWjEhJw_X2cQ X-Proofpoint-ORIG-GUID: GQKDTzeJptm5wML9v9uLmWjEhJw_X2cQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-13_08,2023-03-13_02,2023-02-09_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Stephen Hemminger > Sent: Monday, March 13, 2023 4:51 PM > To: Volodymyr Fialko > Cc: dev@dpdk.org; Reshma Pattan ; David Marchand > ; Andrew Rybchenko ; Jerin Jacob > Kollanukkaran ; Anoob Joseph > Subject: [EXT] Re: [PATCH] reorder: fix registration of dynamic field in = mbuf >=20 > External Email >=20 > ---------------------------------------------------------------------- > On Mon, 13 Mar 2023 10:34:50 +0100 > Volodymyr Fialko wrote: >=20 > > +rte_reorder_dynf_register(void) > > +{ > > + int ret; > > + > > + static const struct rte_mbuf_dynfield reorder_seqn_dynfield_desc =3D = { > > + .name =3D RTE_REORDER_SEQN_DYNFIELD_NAME, > > + .size =3D sizeof(rte_reorder_seqn_t), > > + .align =3D __alignof__(rte_reorder_seqn_t), > > + }; > > + >=20 > This does not need to be static, can just be on stack variable. I agree, static is unnecessary here since the parameters will be copied to = the internal storage during the register call. So it can be on stack, but static sort of indicates/hints that this is one = time initialization. Also, static is present near every dynfield register in this codebase. In fact, this patch simply moved the dynamic field declaration from create(= ) to init() - static was already present. Therefore, if the maintainers decide to remove static, it should be done in= all other places too, it's not in scope of this patch.