From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F0542A0C42; Wed, 12 May 2021 08:55:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D99944003F; Wed, 12 May 2021 08:55:09 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id AB0A44003E for ; Wed, 12 May 2021 08:55:08 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 14C6k6O1028939; Tue, 11 May 2021 23:55:07 -0700 Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2043.outbound.protection.outlook.com [104.47.66.43]) by mx0b-0016f401.pphosted.com with ESMTP id 38g3eh99y3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 May 2021 23:55:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lOrqJ4N1u2o4Qu3eWtzKkOprSEvqyaz1S0XSL5/B0nLvqYMH9S298toRncyIMv3CEBv5zq7H9p5TG2lWeUo5L9vN6/UnGywFn1mmdci5tbQI65rM+3TwTfzbcjXPtj0PjmRtrgHlpS0CqjReUfuE+IqBvVsqna9VlruRGhVIMobH7jmdIkxmRw+Jpc5QjBZw+NWkygpoFx3ruI4JIVFrHr/y6jE6QiLs4Wa6mT/ZU74JqImxfW+DjaLo9jBJb10s0wAdP8BiLawgq4ZNE+nY87/56yEZHcnhzQWEavo8dS+hwunJBduMnaphmQsSDayd9qCJgsJG55QApfUBxK/XXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eXjUJzmVojDSpxGake/fIAuTGJt691eupGR7tI4uH5E=; b=O5oh1WNngg5Lp3rc51Z5m8+mbv6jK53Bc3scbthO/omr2wQHgp/MIP394iGQNEo+YqQa6A01fygQ00kgi9vVvzPe+Z1WUx46lV1CNkWwxRM9p7+nuRZYxy7LU4ffHRdH28F7/MVf3YZUysGqZ0AbdA6VDZyA/LBVgyldu1pNuihSVBn45g+e8zAapXy3+/RMX+UdIyRsHo3SfMr8PRUUEH8/jrjjmloMtvQ3YX0ycwHdBAM96/iscmWIAhYd58h0IYZ8vmSMDRdvk31IH2RqyeHl53Lyq7TNeayrScJ0CV1diSX+Em5/tEXc36TaiKjBg5vIWVeaPpicnhgXFO7FNA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eXjUJzmVojDSpxGake/fIAuTGJt691eupGR7tI4uH5E=; b=NH+acPgddTmk71P/TdlHmicmE0oT6kJPFoYeLXz5sinjHQLGIjFvmRXySOn1w/k0b1Uy78Qz+YaM2HD4rnvJwYj43k7/q5iBjUykphvqSFR8RYvXG7rqIswe2Tn9wMiPBErBTaWJy8T2pFgI7wlsJpfe77JDw9CZwVyXICHg3Gw= Received: from MW2PR18MB2284.namprd18.prod.outlook.com (2603:10b6:907:10::16) by MWHPR18MB1360.namprd18.prod.outlook.com (2603:10b6:300:cb::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.26; Wed, 12 May 2021 06:55:05 +0000 Received: from MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f]) by MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f%7]) with mapi id 15.20.4129.025; Wed, 12 May 2021 06:55:05 +0000 From: Akhil Goyal To: Matan Azrad , "dev@dpdk.org" , NBU-Contact-Thomas Monjalon CC: Suanming Mou , Shiri Kuzin Thread-Topic: [EXT] [PATCH v3 15/15] crypto/mlx5: set feature flags and capabilities Thread-Index: AQHXQSnWsvz25MKtdkqt23wDGjSfNKrZdQEAgAFodoCAAAPToIAAWQeAgANc4mCAANChgIAAC9EQ Date: Wed, 12 May 2021 06:55:05 +0000 Message-ID: References: <20210429154712.2820159-1-matan@nvidia.com> <20210504210857.3398397-1-matan@nvidia.com> <20210504210857.3398397-16-matan@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [171.48.51.1] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c59812b8-d95d-43c2-2315-08d91512dfc9 x-ms-traffictypediagnostic: MWHPR18MB1360: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fRVR+LwjibVQcQego6BSL6a1+grYjwFPbbxBvMQETHu1eX3a89MfANpShHEJAcA2Qa6lJc1RtPijxflVEyHA3GihjSkEkMIfpK37IOgSvtbP5oJgiYEhVU8fh+kRr3Sa7eea0obEvb2A0T3YSILmt6NU7xvYSgYBhc1ahHpGA08mtwu/4ZJrJvDdlxAYNsJYst93cceY2TiUoyu6iI6urLKUmBcDvAb26cx5ZabGkl1ZYCBt0CrYrwlTDkghwYf7FMoQV+GT5qgc/yY23Iri2lQL5eo5KFCD93YWlrLTosVvQZlXDFFmunmEPzSkTIBMTp3utkPwhyGC5vsr9DUxmdO9TflwCtcVD2mHW1CFpjBqakE+BKQOOveYWAMRji4O8J4m9SkXT/ogL10M5pXgnSmFk+dANG21FDrd2jHP9dM2aHOm02tFz/J1r6AC+YU0jVyIHL+T6OOUZC95vMUCYILNEnPm3WiHbqkDoGdW95E2Luf+bbMpxVIozRHpywSQdoKuJ4rK4PFWSA8Zvb2QUpKPlC8l+dCOBYLlH7XkgVsPL3R4r1aEYm2WhVI2H3izhIiRjraLXtU2co+UIaGR22O+M19d7Ckn/y/UeMt+4Rg= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR18MB2284.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(396003)(39850400004)(346002)(366004)(136003)(26005)(4326008)(76116006)(9686003)(66476007)(64756008)(83380400001)(66446008)(66556008)(38100700002)(6506007)(186003)(66946007)(86362001)(122000001)(478600001)(7696005)(52536014)(2906002)(8936002)(110136005)(5660300002)(54906003)(55016002)(33656002)(316002)(71200400001)(8676002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?fgzWeWWfuonyz9pSRUPP9fu2bSTd523j9oI68uPZR9zmxGcO3rty7XxycO5e?= =?us-ascii?Q?GwfUqXLU+oyft21E0nmxeEMkpbcqke/5ATykUKNWKvx/W0xk17O6lUy+Ol8X?= =?us-ascii?Q?xry9gKebg2XyfNtjI3DSm83Xu7FMkBD4kd/Drr9ulmpeO5dJ8dpjCkWnDq9L?= =?us-ascii?Q?93MuzcdYY7PzeGQlIvvfKApIppCdV0DpSxKUZ/MwNecRooAYmR0ht/ioNJ2J?= =?us-ascii?Q?gBBT60XbcEUxs8kgg9nsFxuiWv2WcQpJ+DeSVnFjr01dWcm74+Wr2b4HFQ1r?= =?us-ascii?Q?Zgw00EvL3Mk+BqPlyPkRa0lnhwHfiqCJBA+aOKVHVbfEMe2rIh+E4PIBESAa?= =?us-ascii?Q?zfBSiJjAIC/ep0f9ixrtXvhlQAl66LlBypR/sAjKFE7LDCxFFvECanvRlzi9?= =?us-ascii?Q?WW4d/S4LkPcqDMGpQglfAe5l6U6rdzi886U+zM97/7UhDQkYUpLSx6PV8Biq?= =?us-ascii?Q?oqP59ihBA3HQdp2C+p/qRw0Lmq8mF8meZLfDchNm9cRKZBkW2K7NS8gD082t?= =?us-ascii?Q?++yKx8iFVZQjx4s0S7hb7IuwPchuHsQmnMlBarfFBjQAaoJwf3VwlAxbGRw9?= =?us-ascii?Q?2eT4xz6MfoSWYKJ1y4e4LytZeBnyD+DIhFn/t6nA+S+iQLX2Zzs5tibGg1gx?= =?us-ascii?Q?hjmYeCIEcJycm96BO6qGRDWRj/ULkfHUK3FTo0EGO+Q4aBzPCFvTifff2pNk?= =?us-ascii?Q?CRnpnCQpET5YOqcvqU8P12144d8MlVdWChpXJfEFLAt45ULuMssAOhnBqC1f?= =?us-ascii?Q?Wyg7LuuadVeRcVtfvpuij+pmPHCeOUZxnNuXGgRwBCGFasXDjjf/MjjH9Erv?= =?us-ascii?Q?jxf8QbKlF2xIz+bH0h99FE41NTEWhNqSdo9w8Y1ppSU5aywUHwKf/RyXyQxY?= =?us-ascii?Q?MUmvKKIu3/RiSS2jV32iUHpg2jQBJkrkuOAPpUQuo2UHkQ6M/gsqOW5wFphw?= =?us-ascii?Q?8Q+T8+LEYwdDXhJEvpQuNNo/JWUvTTMXNYJdsnzMqgzl+rfDhT2++A0TAIVn?= =?us-ascii?Q?hsCiZpzUOWqAu0PU8swWzT5Llmynp5bFOoFO8H4ZM87BREfJBChdCxDOOYtG?= =?us-ascii?Q?k6rBjbD7exzV9DOKtRCQ3tP9uUzv5rb329zNkGK+k4vPst85o3PmOr8DjAqh?= =?us-ascii?Q?B7u4CziBFG4zZjAmryAtvh02xgqjC2mKomQUIXAZdFBymtc1v/fmF6wa/803?= =?us-ascii?Q?TatKsOYpMSgA02GCxGaMnK0cFk9LRIKD+Y9lwFf/RRTli3pzgyImMBqGNWby?= =?us-ascii?Q?Tfl3X0QNc/3aHAgsFOjvVj3ZIRRLZPXiV3GcqqWZYJHQSD4Em4driMCMP3/B?= =?us-ascii?Q?Dh0=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR18MB2284.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c59812b8-d95d-43c2-2315-08d91512dfc9 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 May 2021 06:55:05.6452 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Garu1BebyNnW/GbyBfZ4Rqs/7ab97K+QNLpQQmiT2Rhar+eHUj1uvQTbnAnlIbGhchBgHbO6QdVPRkL+222Etw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR18MB1360 X-Proofpoint-GUID: fw4AH6_J67Q_s1Apd3RRFFW23MVD5kdv X-Proofpoint-ORIG-GUID: fw4AH6_J67Q_s1Apd3RRFFW23MVD5kdv X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-05-12_03:2021-05-11, 2021-05-12 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH v3 15/15] crypto/mlx5: set feature flags and capabilities X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > From: Akhil Goyal > > Hi Matan, > > > > > > > +Prerequisites > > > > > > > +------------- > > > > > > > + > > > > > > > +- Mellanox OFED version: **5.3** > > > > > > > + see :doc:`../../nics/mlx5` guide for more Mellanox OFED de= tails. > > > > > > > > > > > > Since the driver is by default compiled off due to the > > > > > > dependency on external Libraries, I would recommend to add few > > > > > > lines here as well for compilation. > > > > > > Like to compile rdma-core and set PKG_CONFIG_LIBDIR. > > > > > > > > > > Why? all Mellanox drivers has the same external dependencies. > > > > > I added here link for the doc explains it well. > > > > > > > > This is a crypto PMD, not a NIC PMD. Somebody working on crypto > > > > PMDs, > > > do > > > > not really care about the NIC PMDs. > > > > Hence it would be convenient to have compilation information here a= s > > > well. > > > > You can refer to other document for details, but basic info should > > > > be added here as well. > > > > > > The link explains how to install OFED, this is only what the user nee= d > > > to take from the link. > > > The basic is to install OFED. > > > I don't see a reason to duplicate doc section which are exactly the s= ame. > > > > As I compiled the PMD, it was not convenient to read the whole document= . > > And it is not needed to compile linux and everything. > > I just needed rdma-core and set it in PKG_CONFIG_LIBDIR. >=20 > But compilation is not enough to run, you still cannot test if you break = thigs > by compilation. > You need to install also the kernel modules. > That's what we explain in all our drivers. >=20 For a person doing minor changes in the Lib, he cannot test each hardware. He can only do compilation and that is what he is expected to do. >=20 > > The reason I am insisting here is, when somebody do small changes in > Crypto > > library, he may need to do subsequent changes in all PMDs. > > For which compilation steps should be easily accessible in the PMD doc = So > > that the patch can be compiled properly. >=20 > Not enough. >=20 > > Hence I just recommend to have 3-4 lines to enable the compilation In t= he > > PMD doc. >=20 > We are not doing it in others mlx5 drivers. > If you insist, we will do. >=20 > > > > > > And I do not see any updates to the test application for testin= g > > > > > > this > > > driver. > > > > > > > > > > You can see update to l2fwd_crypto, we tested with this example > > > > > for the first stage. > > > > > Everything looks ok there. > > > > > > > > L2fwd-crypto is an app which only test data path with no packet > > validation. > > > > It does not tell if your encryption is correctly done as per standa= rds or > > not. > > > > Did you test interoperability with l2fwd-crypto? > > > > All basic configuration tests are also not done, like cleanup etc o= f the > > PMD. > > > > I haven't seen a driver getting merge without the unit test applica= tion > > run. > > > > Test app helps you comply with the way dpdk drivers are meant to be > > > > written. > > > > > > We adjusted the l2fwd-crypto to the dataunit feature and wrapped keys= . > > > We validated data integrity from the packet returns back from the > > > crypto net port. > > > As I said, encryption\decryption with AES-XTS is working well. > > > > Do you test interoperability here? Encryption by MLX5 and decryption By > > another PMD/stack and vice-versa. >=20 > Compared to open-ssl results. >=20 > > Test app is supposed to have test vectors which will work on any platfo= rm. > > Hence data validation is done properly. >=20 > I think open-ssl is good standard to check too. Yes it is good standard. OK but what about the other basic cases that I listed below. Did you mention any limitation that all these cases are not supported as of= now. >=20 > > > > > > Now, is too late to update the test application to the above features= , > > > the driver code is here for a long time, no one ask about the test > > > adjustment until now. >=20 > I acked as maintainer of this PMD. Is it really enough for the new PMD? >=20 > > Can we defer to next release? I apologize for not asking it earlier. Bu= t this is > > kind of obvious for somebody working in DPDK. > > Please check that none of the PMD is merged without test app in the pas= t 3- > > 4yrs. >=20 > This is not true. >=20 > > > We can add the adjustment to increase validity for the next release t= o > > > all the remaining crypto apps (test\test-crypto-perf). > > > > > > For now, we have one validation with l2fwd-crypto And any user can ru= n > > > it and see how to use mlx5 driver. > > > > The user cannot be sure of the basic things of a crypto PMD are in orde= r or > > not. > > As l2fwd-crypto does not test every basic thing. > > For eg. Session deletion, PMD stop, PMD close, PMD restart, setting up > > multiple sessions(l2fwd support single session). > > > > Running datapath of a single use case is not sufficient for a PMD. > > This is a POC and it need to comply with the environment. >=20 > There are only one\ two cases we need in this version and we tested them. >=20 > > I hope the doubts are clear now and we are OK to defer to next release. >=20 > As I said, we don't agree, it is yours. >=20 As I said, fix the issues, I can still merge today but not after that. Regards, Akhil