From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6D59FA0524; Wed, 14 Apr 2021 10:39:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5211F16181D; Wed, 14 Apr 2021 10:39:36 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 3C35E16181C for ; Wed, 14 Apr 2021 10:39:34 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 13E8ZlOe010330; Wed, 14 Apr 2021 01:39:31 -0700 Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2041.outbound.protection.outlook.com [104.47.66.41]) by mx0b-0016f401.pphosted.com with ESMTP id 37wqtm10c9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 14 Apr 2021 01:39:31 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FNft9V30PxwYhelHG/K/XyxlbxN4Hs936wGrBTseW0TNqPIb/eybyHYB1A6lGs8gt6FUjiOA56mLDqrJ4NH+Lkeu1xN5xtJ/NfcwblFZzExqpqiN6Ar3aj9A2qLmgxN+fK2OgcIv1imTq5WJ+W7SLit9Xd9cRFk+8FpfMc4r7m9sI/1JqS/T9SP4qowmecEvqW1JC71vCDJcvCnpYvTw6EzGvYCAu/5OMzx9oDTtQwu1MJGVKJZXvVXA9u+p5YGBoCQoHpoAZaFtHiujHA1Lg4PYRmYnYL5PwCZUyiQ9wAA9vmEo11Q6xzrXFbk3oQb8dOIxshx2YpNksgY3bRXf9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1SaNPW+bz6qMC4EVOEGxgHe8SlEvvoG/mjswzLMAWTA=; b=RW7Z+f1x+KAI1J8E2JnCK/kF9vTIQe1P6iWVPgwjHSJlUiyxRWqKkhy0YFMoF9nT9ZoIVnyW9MfV+Q94Gm0NLrG00TPsTOj02gUeSqForgHxXcWX726EPtxuo5clg2xFwOHVmGXmSoJnZLCfWzWke86ZqjMIb66gkwQQX+d6oQjULJZ7JhNquaZeXx/BGD+BTmzlmll1LZEfUXN6fwhRPOoqsGqBzFUVJlcXkQP3T9QaInMDIed6HpVohrG0acFT4hiSSQh8V/Z0uxm6ReI0BRqgFJ6m6FtbaBA4yaqvnR/nOn6Dq7+oajPVbNJHDwoLvygAMVQAS/ed4/+kEnjQjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1SaNPW+bz6qMC4EVOEGxgHe8SlEvvoG/mjswzLMAWTA=; b=cqS0e+sPtgblfwmitmEw8YXNsYooBE0xMzgLO0KKhvu2XFPWGzBZPRMwFMFIHb44RSHw8u/SQ2hT6uBlDSWbMF5XmiORFHqtuR5DoCQsdmiBdKK5eb/gBQZufKVQDHxKHEzmQfLiIKz+SzaTBAslp2MqHEYh5s6H+36qdetZWzU= Received: from MW2PR18MB2284.namprd18.prod.outlook.com (2603:10b6:907:10::16) by MW2PR18MB2201.namprd18.prod.outlook.com (2603:10b6:907:e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.16; Wed, 14 Apr 2021 08:39:26 +0000 Received: from MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f]) by MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f%7]) with mapi id 15.20.4042.016; Wed, 14 Apr 2021 08:39:26 +0000 From: Akhil Goyal To: Thomas Monjalon CC: Jerin Jacob Kollanukkaran , "dev@dpdk.org" , Ray Kinsella , David Marchand , "abhinandan.gujjar@intel.com" , "hemant.agrawal@nxp.com" , "nipun.gupta@nxp.com" , "sachin.saxena@oss.nxp.com" , Anoob Joseph , "matan@nvidia.com" , "roy.fan.zhang@intel.com" , "g.singh@nxp.com" , "erik.g.carrillo@intel.com" , "jay.jayatheerthan@intel.com" , Pavan Nikhilesh Bhagavatula , "harry.van.haaren@intel.com" , Shijith Thotton Thread-Topic: [EXT] Re: [PATCH v8 1/3] eventdev: introduce crypto adapter enqueue API Thread-Index: AQHXME/wQthqHceUbkCNS9EClab02aqznsiAgAAGv6CAAAd0AIAAAR7g Date: Wed, 14 Apr 2021 08:39:26 +0000 Message-ID: References: <2815780.tZErNpM5md@thomas> In-Reply-To: <2815780.tZErNpM5md@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=marvell.com; x-originating-ip: [182.69.47.6] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ed6dc470-2aaa-457f-f45c-08d8ff20d01f x-ms-traffictypediagnostic: MW2PR18MB2201: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8LZADEBNjbb++Q7QowFwd3VEICQf1KqETe3bXZQOwMoAqSsvcqs8bEV0Z9J4attSMEL+dGp31hQujQA+poZSAfCKlfKuUMiSkLWpKDDLfBghgDfd8sKvRiLBgDxWLaXcHDgsGERnrYxYKHydRuHKBiFN4hjYBLLxcnvihZzXc5+vIExTmdXFT3CxpZKnSTzAkzTV2onWwTOyl/Jcjx1435lU6AAdkIW9Ui8O/oBYe5OYdouYBfmCGfy8/xSu1RoWEynVy6bFmXL+y+A9Ga/ecPBfEVMC7LiE5HOC06BmKGXJLp5FrZOBJmuiMqicJvgD89bBRU87tbxhkqXh0IUUAvbPNmSbvTVRwuQ0Qs87+MH7KEjNcW8NXsVlHI7gZse0B2N2qaUCuvsuoLsyamXPX3Jd3UP03lQIu5E71rY8ojmUMzaj7Dcq847PIIgfhArRsKW++whglIvPU98cRQG55pjSQG7GttA0XACmf61QsE4jDKP0arlOg0+MALPJ7waCMRPtbDN3NyLhw4D5SiwytF79fSbb26GVhFzZfkU1J94TTy62GbGa1VB/16dCsYRDm+azXT8nczXqNEjVaSoqwEiBh/r5x+gYeim3yVo7haQ= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR18MB2284.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(346002)(366004)(39860400002)(136003)(376002)(107886003)(5660300002)(6506007)(7696005)(26005)(186003)(83380400001)(38100700002)(122000001)(71200400001)(478600001)(4326008)(33656002)(76116006)(8936002)(55016002)(52536014)(8676002)(54906003)(86362001)(64756008)(6916009)(66446008)(316002)(2906002)(66946007)(66556008)(66476007)(9686003)(7416002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?sc24nApROgjNcJaYdCgUArKmCkoN/iSWTR7iE1dygYdIYRkavkm9Rd8oE+zy?= =?us-ascii?Q?7+EjNG04TQ9tRsD8O2ApxyBED99l0GVEmzVCl2iLZCoTbenTfqeC/CKxsmyO?= =?us-ascii?Q?UGTUZw1yVVTCg04sewnqUx9fG9Ew6kSEsHxcsXQIp1YHaK+8JXeHbOO8Gund?= =?us-ascii?Q?4nxc8fhus/82+78P7z8nFvd9bWCYnv6BOr159/pBQ6XN5SuXChzjZwH0nJ/7?= =?us-ascii?Q?SuoW7wG/kthOgh92/c8FAT3KWzGImL85bEuaKvXxXDcaY3kh8/IIjHTVysRq?= =?us-ascii?Q?ruNkWGaaXUThuSnrOOIeRY/eWpPWl3Ed9+ZEqS+6+Zyo6zeRZYQlkmiAbTmr?= =?us-ascii?Q?ms9/InQmS53Ac9uaQVCgYV1LoUdzV4Zc+B3oqx/4WZR63w+skIFBGzJedp8G?= =?us-ascii?Q?ke+/jxxapM7ih27ZG4CePxpOSfjfjLGowbnR+gdxHAGWLs3QDNfP74EM8K8U?= =?us-ascii?Q?9fhXm3C64cGrbZOj+NK+LLmGAKI0mwqoB9ruKHeYzOON4/RGBEtmMjOB2Z1w?= =?us-ascii?Q?mw8ZA7to5qlRSQkOCX3tqRooO9Pxe36I5Ojq5ncNEYJX3CUgJW1gTilBlnQE?= =?us-ascii?Q?L+UK9jUHH9xu9S07huBK+T5NeyE+ercHPYQwiTecOnvNMXKGy2YpA9r3tiMu?= =?us-ascii?Q?VyvMBMJ6S/YBLwXgMSl1NQFitRFPz6R/QOlMIhgGX0SozYHJNOJ+G8K5cgGh?= =?us-ascii?Q?Dbc78nZC1O1CVhDxz4JnxJjoKjjmm7lU5miVZXGIL3QuUzJY4p970uWIpYus?= =?us-ascii?Q?GIYPKjoVFRVxhQRjONvzmHj9SselVX8vTLXJQA8E1LWauNUSScS5fYk1mwhI?= =?us-ascii?Q?uSzVoCo3c8ebX0o90zktE6n5JtWnwvrsW4ze/bAP7Emn64WrTvgiRWOMB0dP?= =?us-ascii?Q?e8Nda6vwjD4jb2FD5sDUB6SNz06r7SJNLESU7mgnnHglJx2KNpMZ80EUeojx?= =?us-ascii?Q?NJqrONyptbhpoKy0jH9L+f0qzem25biD+fbSsKBQJ7LTdsRODLG+WatyRkUH?= =?us-ascii?Q?O5gl6EatnkSDpzDWL82jaE/N83VWS6u8q6ne9PXIRcJ96DIAWmtcm9Vr3vD9?= =?us-ascii?Q?pp0/awyUOaM6SZ0I2+Q+md/9movPN1rdSdrJqDjzjGfYV0WFpcaYIPgtgXlx?= =?us-ascii?Q?lzCzCM2rLllyjwy1XB3lnih0+3fGC3Z11hvbD+0QNLCadfdy7Qs6LohpglRm?= =?us-ascii?Q?ittReNfL3TPfQJajY5BuyyP17NceWb6aSLt84/kV/zxn53M+GneRzGDaO9yW?= =?us-ascii?Q?7EHgw81PNg1G2ST0iO8okgCzztjdBOejRCIa+Pk9oNSoXoEMAuU7jTq67YyD?= =?us-ascii?Q?plg=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR18MB2284.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ed6dc470-2aaa-457f-f45c-08d8ff20d01f X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2021 08:39:26.7217 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tEOBO7CtrD2MFbQre8B6MRdvFmQ6/njDmWa0+t0xthUyZmLO332rHxmx/zF96lzpAj+J6TIPu7pvZ8sEw7KhJQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR18MB2201 X-Proofpoint-ORIG-GUID: nxjB5WEsNJtWYxoCTQKir6-Dv8xiFgm- X-Proofpoint-GUID: nxjB5WEsNJtWYxoCTQKir6-Dv8xiFgm- X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-04-14_03:2021-04-14, 2021-04-14 signatures=0 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v8 1/3] eventdev: introduce crypto adapter enqueue API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, > 14/04/2021 09:58, Akhil Goyal: > > Hi, > > > > + > > > > #define RTE_EVENTDEV_NAME_MAX_LEN (64) > > > > /**< @internal Max length of name of event PMD */ > > > > > > > > @@ -1423,6 +1427,8 @@ struct rte_eventdev { > > > > */ > > > > event_tx_adapter_enqueue txa_enqueue; > > > > /**< Pointer to PMD eth Tx adapter enqueue function. */ > > > > + event_crypto_adapter_enqueue ca_enqueue; > > > > + /**< Pointer to PMD crypto adapter enqueue function. */ > > > > struct rte_eventdev_data *data; > > > > /**< Pointer to device data */ > > > > struct rte_eventdev_ops *dev_ops; > > > > @@ -1435,7 +1441,7 @@ struct rte_eventdev { > > > > /**< Flag indicating the device is attached */ > > > > > > > > uint64_t reserved_64s[4]; /**< Reserved for future fields */ > > > > - void *reserved_ptrs[4]; /**< Reserved for future fields */ > > > > + void *reserved_ptrs[3]; /**< Reserved for future fields */ > > > > } __rte_cache_aligned; > > > > > > > > > This change has following ABI breakage[1]. > > > > > > Could you move ca_enqueue at end of struct to avoid the ABI breakage. > Also, > > > please update depreciation notice to move ca_enqueue to above(to alig= n > > > with function pointers) in 21.11 release. > > > > > > [1] > > > [C]'function rte_eventdev* rte_event_pmd_allocate(const char*, int)= ' at > > > rte_eventdev.c:1467:1 has some indirect sub-type changes: > > > return type changed: > > > in pointed to type 'struct rte_eventdev' at rte_eventdev.h:1411= :1: > > > type size hasn't changed > > > 1 data member insertion: > > > 'event_crypto_adapter_enqueue rte_eventdev::ca_enqueue', at > offset > > > 512 (in bits) at rte_eventdev.h:1430:1 > > > 5 data member changes: > > > 'rte_eventdev_data* rte_eventdev::data' offset changed from = 512 to > > > 576 (in bits) (by +64 bits) > > > 'rte_eventdev_ops* rte_eventdev::dev_ops' offset changed fro= m > 576 to > > > 640 (in bits) (by +64 bits) > > > 'rte_device* rte_eventdev::dev' offset changed from 640 to 7= 04 (in > bits) > > > (by +64 bits) > > > 'uint64_t rte_eventdev::reserved_64s[4]' offset changed from= 768 to > > > 832 (in bits) (by +64 bits) > > > type of 'void* rte_eventdev::reserved_ptrs[4]' changed: > > > type name changed from 'void*[4]' to 'void*[3]' > > > array type size changed from 256 to 192 > > > array type subrange 1 changed length from 4 to 3 > > > and offset changed from 1024 to 1088 (in bits) (by +64 bits) > > > > > > > > Yes my bad, it should be added in the end. > > But abi script will still shout for 'void*[4]' to 'void*[3]' conversion= . > > We may need to add something in the devtools/libabigail.abignore > > So that, CI is not broken when reserved fields are changed. > > Otherwise, it does not make sense to introduce reserve fields. > > Can we have something generic for reserved fields? > > Any suggestions? >=20 > The ABI check is not aware about the reserved fields. > It needs to be added in libabigail.ignore. >=20 Can I add a generic ignore for all reserved fields. +; Ignore changes in reserved fields +[suppress_variable] + name_regexp =3D reserved Regards, Akhil