From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AE0F4A0C42; Sat, 8 May 2021 14:18:32 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 383AC40140; Sat, 8 May 2021 14:18:32 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 532834013F for ; Sat, 8 May 2021 14:18:30 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 148CGIMr019112; Sat, 8 May 2021 05:18:29 -0700 Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2105.outbound.protection.outlook.com [104.47.70.105]) by mx0b-0016f401.pphosted.com with ESMTP id 38dt5rg17h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 08 May 2021 05:18:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ihfqk4u4lQJ/cDJYpGAIRckKERLX5g8XJynICvuatgXe0Dy0l8mwqYjWeStxa4sKNcDOdNVixsTxnAktGPrs74JV/OC/8C2pISC8RuUG25vojqIWTWAquIkm3LliSY5DVzQPH8DUW6dupodjYg1L3oyaDRHpAyh0YieJ4W8ImQjrwMjDqZXVfraWWK0QGn3ZNHuyX/22LZQPLUQbIUv4dbV9pE/yZ6kICyvw2x616PUVBjrFGmweGVBlLfAaYFNenR3X21lCoghwzvMO89nwh/DhBC2Xmge7nKgOzFV4tIX3YCr2Du3jOSX232htg8REzNvKX3aWLQh3LWBUysloIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IyKqLrDSMluiX1EaT0iHnYYM/noy4kAFmcQxYHhRNLw=; b=WOXnTwn3R4Jb8O+d0fZ7Bny1HTgk3Qv+EL3H/qo0VWJjICL3KNhgbK4onq38sy2wy2EmCC5cQZ3jvtWW4fC3CKS6csTQRC8gdwa6RLC80wHzSv7x2ahahDUFhtINGs+UwDFriRgK6HE2XwPmdULCfpHZdpUG1apN7aWsTlXdr6+/LCMRwIw9J0Q8hFPAtHwvWgBjyCQw5xLi0xRhD28BiQXKAWe0zANOMe3NunCJ8ynUoe3rRUj1IA/0e0JX3mO2qnymRKjJ28SBrecsSN8BWCc1yzljf5NsAYKQrLE+mPN3X7HmI8nrpbfs4TWnlT/PHbG8w6vH08JNpHQ7p6txvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IyKqLrDSMluiX1EaT0iHnYYM/noy4kAFmcQxYHhRNLw=; b=Yla3iDSz4RH7goYX8uoOL1Dn5t3NPClBPw+HWIK4k8oEb5pT9AnF8628va9VYvFIsCn1aDT4e4wEKiQMJWvzZP+UCKuhMruRUlqncWAzu5pb1mUgeCQ7b9/BauDVoc/uTSxNpEtQnQiVt+bld5lijjod3KUcVpyxS197W6FBo10= Received: from MW2PR18MB2284.namprd18.prod.outlook.com (2603:10b6:907:10::16) by MW3PR18MB3689.namprd18.prod.outlook.com (2603:10b6:303:5e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25; Sat, 8 May 2021 12:18:24 +0000 Received: from MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f]) by MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f%7]) with mapi id 15.20.4108.030; Sat, 8 May 2021 12:18:24 +0000 From: Akhil Goyal To: Matan Azrad , "dev@dpdk.org" CC: "suanmingm@nvidia.com" , Thomas Monjalon Thread-Topic: [EXT] [PATCH v3 13/15] crypto/mlx5: add enqueue and dequeue operations Thread-Index: AQHXQSnTsbPIXrcMaUG2rZ9/0YRC7KrZhW8Q Date: Sat, 8 May 2021 12:18:24 +0000 Message-ID: References: <20210429154712.2820159-1-matan@nvidia.com> <20210504210857.3398397-1-matan@nvidia.com> <20210504210857.3398397-14-matan@nvidia.com> In-Reply-To: <20210504210857.3398397-14-matan@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [171.48.51.1] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 55fb65d3-6892-4af7-7078-08d9121b60e2 x-ms-traffictypediagnostic: MW3PR18MB3689: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OtUn/W5riUOTY/ixDKVyyVgQjMk4lGorJh0+GhISID2dQvhFuJ1/MMdDpPPXvEQDSRpqyG4mKjaslCeVV/QVwe4y8qM/PMXsdPPqMtano63cePq5R+uc+Duxh+6yNfOAm1G12CTE1qLWkLfkDfzePOZYvcP1HqKy544lGMDBqm5iK3+QFxw8G8D4S+dF+/xMU6uP8GWvN7gLCvXjojn2Rgwb2iYGGjaGP+OEyMM1Q3SsUoMph1WccJiBnuBLeQzxM6cTiiZR5AJc/hxfbvUu1Inil9s1gW64k5B133LAMXxo4J5W0rQEycwjW5SI7lQsB0gFnvDiCmxUxPPMl8F9vHdPxya3HNV2mYSxSE5O+bjpCSWkIDqxOWrh8mgPNg1IK/HBJ4BDvcOjGJNePYS+nwQco+B6FN7D/cmE2iFbFFo+geRlSj/d1xZnQUhJf17dVJCYw/p+3eKyVs2LavFvVENE8aX457strH+tdnzve9DWV8RCZnLZWX14/Py+UgTuDCix1+mytoKGA313maPdNp9acC8RCxOyErSxpBFKinRNLfmky/RUidyw0rI33bqvFDVPE8bQz4nsIung/nqWQDXXHSU5/EgYnDtY2egOtGU= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR18MB2284.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39850400004)(396003)(346002)(366004)(136003)(376002)(26005)(8936002)(55016002)(9686003)(186003)(5660300002)(71200400001)(478600001)(2906002)(8676002)(122000001)(38100700002)(66946007)(76116006)(66446008)(66476007)(86362001)(33656002)(66556008)(64756008)(4326008)(54906003)(316002)(110136005)(7696005)(6506007)(52536014)(83380400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?gShgG1a+usn91TAJ3nmLr7wOOV33iPwP+V+4S5kebOFlHeProD6cA7d+9gEU?= =?us-ascii?Q?1lzF1v74Pt7G6yfVvuvn9TGsYtyeeeJsL6rsuNgIeI4t0icYeXxWgMQ017M/?= =?us-ascii?Q?DYp0SlpSl7SQoOJWBkJSuiSqrj5uAIxl3KGlh6OGwMJe03U6dhJHqCzC0iJL?= =?us-ascii?Q?5KEkxwVeieJ+tAnVfCOpkMPz16lT2Yd1rk1p1t9wu4qQ5sQzbdfqGm6/PCQC?= =?us-ascii?Q?MVCq/QzNhQtapucf11g/rbMzn4I3cOgOTtpVf4+J319EYjz3swAv54nfIBkq?= =?us-ascii?Q?/8T7x8zz2ATs2lxbtX3p1MDVNzI7gZ7fQCH0qx+ap76td8bvaHZnRyxT5KJu?= =?us-ascii?Q?nX/KNqJluWhupwwqYNNLGSiqt9JS95N90HA3b4Q1rf+/vtfPguUCeVjEMS2i?= =?us-ascii?Q?vyHsRLeG7/VVgqZBkTe45LpDlfrgZ5AThlXQf2Uco6qgbGvYH/FBKU5gB2SO?= =?us-ascii?Q?h6rSsKciT2nahOKnK1nsqUXJJCxQJWHndko4qzXKE0ZM2NnioLXz2srIJUcl?= =?us-ascii?Q?cpUAbSpCn1B90Pi2IburaiHzBSCwG3fosaXpP5rwmMWMmAasNTwqYicGEgYd?= =?us-ascii?Q?Roc6uFaI26vWUQ5SqyUoX2e1EFSTWDBLX717iwuXYywKGIZKVnocPtjjUTho?= =?us-ascii?Q?aelRSwQKDBbC2boJxeCiz6kkAtkmRQODXwj58M6ivED4G7H9UX/YuGBJ+m9Q?= =?us-ascii?Q?yruLFliAF3jtRGtNZ+FsLJ6b89YNG7McI38z6inWFUENtvO2cNb7vJAOLRI5?= =?us-ascii?Q?Y1qzQVIfVpsWrDaqBP8Zo8l3lZ5alTlVUYTqq7zKTRWheaxkzwxdAaCc2RVc?= =?us-ascii?Q?IXCP3W1lJPhw88sxrUjwl+EI4fEBGLHuM4MF5rFfKs6iYZy4m67qyekzYcOG?= =?us-ascii?Q?JkI2WnLkiv3hAJvCH6G/efF+snvJPTX1HltewbjjAwUSS4GgQZkPot8LurPC?= =?us-ascii?Q?7DfO3ZhR4S62JG8AqdxqPHcSlb6nKH62A++duFBaKLWJwvLYPfsfxpD0iAuO?= =?us-ascii?Q?YooQKGfouickx35jY8H8E0k/kSE4Djh8LC10quswXk4LyodEG0sk7kC/Lsus?= =?us-ascii?Q?IdVRiU7+9ho1MsNLLENoQ4QQKECfkI3TT7DSga6iczQHmShmIsaItHaDAbnS?= =?us-ascii?Q?pbKNmaRxM8Q7PBg3hHAeBA3itWWeAsxfYTNJ6g894S5SSnEVSUOG7VagniVh?= =?us-ascii?Q?D74Xbn0RGkmlGZSokqKH50z65mBNWw647JtRny2WqDFmoG2g6OQbm/M+D/7V?= =?us-ascii?Q?S0btkrvfIPbrZfIUXTRZTkjwjPN4fGRr4TR8V7Svoxys5iRYOlQLeDm12ni2?= =?us-ascii?Q?jIg=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR18MB2284.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 55fb65d3-6892-4af7-7078-08d9121b60e2 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 May 2021 12:18:24.6616 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: baKkC5nTb3gV54669egglFzR3+2raCrbk3AZqZZwGpEFV/T9IAAaL5E1KIrkfLgpEAFMlwF9jjam++YeuiC9rA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR18MB3689 X-Proofpoint-ORIG-GUID: V0QfVYEYPeOf7vzUBijL41obLAdMvH-Z X-Proofpoint-GUID: V0QfVYEYPeOf7vzUBijL41obLAdMvH-Z X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-05-08_06:2021-05-06, 2021-05-08 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH v3 13/15] crypto/mlx5: add enqueue and dequeue operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > @@ -685,9 +919,8 @@ mlx5_crypto_pci_probe(struct rte_pci_driver > *pci_drv, > DRV_LOG(INFO, > "Crypto device %s was created successfully.", ibv->name); > crypto_dev->dev_ops =3D &mlx5_crypto_ops; > - crypto_dev->dequeue_burst =3D NULL; > - crypto_dev->enqueue_burst =3D NULL; > - crypto_dev->feature_flags =3D > RTE_CRYPTODEV_FF_HW_ACCELERATED; It should be set once in the patchset. I see this getting set in 1/15 and removed here and again set in 15/15. And whenever you are setting it, it should be added in the .ini file as wel= l. > + crypto_dev->dequeue_burst =3D mlx5_crypto_dequeue_burst; > + crypto_dev->enqueue_burst =3D mlx5_crypto_enqueue_burst; > crypto_dev->driver_id =3D mlx5_crypto_driver_id; > priv =3D crypto_dev->data->dev_private; > priv->ctx =3D ctx; > diff --git a/drivers/crypto/mlx5/mlx5_crypto.h > b/drivers/crypto/mlx5/mlx5_crypto.h > index 52fcf5217f..ac4ad1834f 100644 > --- a/drivers/crypto/mlx5/mlx5_crypto.h > +++ b/drivers/crypto/mlx5/mlx5_crypto.h > @@ -37,6 +37,9 @@ struct mlx5_crypto_priv { > uint16_t rdmw_wqe_size; > uint16_t wqe_stride; > uint16_t max_rdmaw_klm_n; > +#ifndef RTE_ARCH_64 > + rte_spinlock_t uar32_sl; > +#endif /* RTE_ARCH_64 */ > }; >=20 > struct mlx5_crypto_qp { > -- > 2.25.1