From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8B687A0548; Sun, 9 May 2021 11:21:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 08CFB406FF; Sun, 9 May 2021 11:21:26 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 096D640140 for ; Sun, 9 May 2021 11:21:23 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 1499GIce015500; Sun, 9 May 2021 02:21:23 -0700 Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2102.outbound.protection.outlook.com [104.47.55.102]) by mx0a-0016f401.pphosted.com with ESMTP id 38dr0qk6kj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 09 May 2021 02:21:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GRrCFPuRztoV45jgVIf+yzFqD5i9Q5uXAFyXUYjiJ/nugvLTDLAKePzazM7pCa2exzJJBOBhJaED1LCrBvi5LTyANh7bdD7xnC2GSydDAFRpfZl9uuTlGRJwf7AiUKROkZuI+mCApzGzruMfQD+Wf2vtGEAGybcUrut8JjVsh3PkY1YVj0CxxbqrPmGi3/E4gyhb5w0FLO5yq61I8Keh/axeqaaUSGjVMrtTv/Dz2n9wmSZG9SnQV9PnwEJ28cidH7H5JfsFfZVMv3ooc25gkHPc6ZsHpuFQ+9hl/RAOtsO/bjeLQAEpI1XigXDR6bzv5VzavHclH6hlvVjSbphZCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+u4LKNvaxzViWPbU5dVj5GK78DjQy08W0CNErKU1yss=; b=PXr46CNN/3OLSZF3lixZcob9W+PIaddsK7ahfzWKfadoGNGTJE2gx/zw+n7cbUyfbrGDxR3QLUxeG5JuI2R6bhoh4PB/a/g8lXY+/Wq1K5ENIvcEBrCG3Y8DmDTXh3hPYG3/8MdaHJ1yB+aV6b4vb2jp30JV0qoehJXJfpAjdftjtRjDHViEhpaCqGjzD/HGVJUbSz/Qb9kaqQhKrv7JNZ7VRvR/5s3ynie73rr82fD6IBspNMyw5WgeCDko4bzx7B2Nazk0x/96FcrDmsYtZpGLrFD4jxbZLB3JL4pbj9S3K0s4HdHuV+hsn+XVX9s7xJuvu/N9U0RoY5GfP/9eVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+u4LKNvaxzViWPbU5dVj5GK78DjQy08W0CNErKU1yss=; b=NFDLa8sJxVpyHFIRYNNyYzv5i6FDlERJxaSL/kZR+HdS4L654+PhcEmfKqCvnTYVeNo2q17G9s7FH4UuknR0OdxsVOyCDgimxkjpYV4HAWml2AKtt2/MVFrkh1Jm9B9RnvjGKlUTZj58xLEVwyU97kDlVF0x7i6QkGuyFIEXxaU= Received: from MW2PR18MB2284.namprd18.prod.outlook.com (2603:10b6:907:10::16) by MWHPR1801MB2030.namprd18.prod.outlook.com (2603:10b6:301:69::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.29; Sun, 9 May 2021 09:21:21 +0000 Received: from MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f]) by MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f%7]) with mapi id 15.20.4108.031; Sun, 9 May 2021 09:21:21 +0000 From: Akhil Goyal To: Matan Azrad , "dev@dpdk.org" CC: Suanming Mou , NBU-Contact-Thomas Monjalon , Shiri Kuzin Thread-Topic: [EXT] [PATCH v3 03/15] crypto/mlx5: support session operations Thread-Index: AQHXQSnJ4KJlusD3MUiFAPGamVq8bKrZjGyggAFE9QCAABU0oA== Date: Sun, 9 May 2021 09:21:21 +0000 Message-ID: References: <20210429154712.2820159-1-matan@nvidia.com> <20210504210857.3398397-1-matan@nvidia.com> <20210504210857.3398397-4-matan@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [171.48.51.1] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b5e46f61-25a9-46ec-fbc4-08d912cbcf8b x-ms-traffictypediagnostic: MWHPR1801MB2030: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qEVcUwgLkGKMOk7EruK2fv0gO5pxEgX1Ip4PsYS0FP3G0XV72WrpLjQPfFLla10CZIZQDHV/8rBGlNlf7BN92NMtTkispi1upT++ejkmA7Z0l8WcXT1/3RDvIpPBnDwIXiPTDf+TuW2Lq5NAw7gJw/NfYM8Wm9RgCp/w4L2jQIeiXbqcrDLTW/mcdvZSP62o/BHNF63lYTyB910BnI05vmssbqmceqQfobIaKNX6k388a8ZF8zHb/9vVvuCNM+KIQuICtqVw4AreLGPR9OLNnWuCDX6Wqzek/dByey6VBoOWDbW18phpMNA204l8YkjRzSrGnkiN3je++9f18aqZoVo+8RLUC5d2AqZVbq6fWoi+wErrZXrjjIolHUakJvpyJTrb72Y6Fw7p4dNfyri9PZgrnVYw10KCnNuftiswlt5532zHiZE7+9lyMNPtrIaDs5UzrtDQRb7DKRQtFCG0O/oJvMdEwh9wSvrHovyIETtY0CqGA8PPK/9W22LLqdCJJ4hHOuKwN20PCVI3KKiyYDXXzZ7zptXxIrNKWspKv2bGECFctdozyxWOnnAOwoQUyFMwrGhq4LSFWQ78HoKYqxnF21TYKouNxUXVfs5TarA= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR18MB2284.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(396003)(366004)(136003)(39850400004)(346002)(4326008)(8936002)(186003)(66476007)(54906003)(110136005)(8676002)(7696005)(9686003)(6506007)(2906002)(66946007)(76116006)(316002)(66446008)(64756008)(66556008)(52536014)(5660300002)(478600001)(55016002)(71200400001)(38100700002)(122000001)(33656002)(86362001)(26005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?gq/qRHyNc0JcJnz5ilcbEgYFwjCvmWlzAJpu6vrl+vg+GQIneC/Msktt3wrL?= =?us-ascii?Q?6jJKE/KSlHBXyXMei7xrLYR7hsSZB9GyxLnSNtXSz1qfB2IubS779xumRMK2?= =?us-ascii?Q?3trEYL43KZGfFRQY5fxetA+Di4hcOBvOmke2vFBCoKSX4AM26Up7J0VkK6xW?= =?us-ascii?Q?o6bi3jEe4yrSA1Ioh8vpzcrKAo/E7jxP4sYKkmS1HSDD+easrJysf9F9Jeut?= =?us-ascii?Q?PHyqnWmIEWbzZbA30rIedgYt+EOrckC3jzyfQtWjAqoM9jq31HvkTio4L3y6?= =?us-ascii?Q?LmY8gv8QfzxvTj3V4/ZoAoczJDmybgJgplWjFDNw/WleXU0EJpR7OhG8tR2V?= =?us-ascii?Q?o2uL0Le94HQv35zva7M5tX4fJp+JcKwlO7wapQecQzk3n0aLKiefAzHk4yGV?= =?us-ascii?Q?zOB6dPGZJbz7Ea7H9tAvsU9BPHzl2zFenxSZbmlMpDbrHLcoOZGZjgSALyO6?= =?us-ascii?Q?amfUXQwe8mNBX16FKM/PXtsV7lIKMpqhiJv/E61ay6yBfHlvvduJWxZ57/eZ?= =?us-ascii?Q?TyU1nXEhcMY9QaDdBqucQSwLjluieOZqKhBOA+fS5lP8NZDS2U8bf+ii2vMf?= =?us-ascii?Q?x3gFrkVAr2VhMXq61cE7efVoY2LRGJLBYQktbv7swjVIRv5tn8jD6WmM/rfN?= =?us-ascii?Q?LmQ5kY5lwdRONvyJv+s9iPgKcpYQjpa5pKGm/9UrovkTosqIkKRS0Kmd4BA9?= =?us-ascii?Q?SFtb2MEHI2dPsuw8JjfztQPDB/fPfqdb9ASmD18abEtS0At93uD9YRyOoYo0?= =?us-ascii?Q?QulCW5S6TLUBRVGEaChCRcbPABsQ6dYQE8KjEGUA0bk0eHTMbDbLJtdz1lP6?= =?us-ascii?Q?l9hsv+VthhDWEsoyvMId9MvKMrVdQor82oX2IH5Lr8NFy3FV73U0iQNNNZRb?= =?us-ascii?Q?MB5Sn/ZUYjh/oKdbDiodQ8K8Y06UN3s1uIGXdwcvEO38AXmhgNnzKV7VT0qV?= =?us-ascii?Q?FwtdFgwApo8Zii3v4YqoM3CZQAV4/lZSQDp1Fp/YZs6H3eN/X6eP3RBF/66a?= =?us-ascii?Q?Z9420JdsorADRVemAzU/AVVka4zfYAc0x+Gl7SdTJw2PyGRCPwyjSxOmaM65?= =?us-ascii?Q?xQLdg00nq8OI1V7qYDNKFks8wCIdj//BV9rCjPoqfzSjz2f1TJ/ccp205Lvc?= =?us-ascii?Q?ODNv2NBVSUasgAzfuGMs7VMRWAdVQpMeew82sgNvTTcdG6gyULndbvYlbaEu?= =?us-ascii?Q?FDfn689XDTOu5s03h4Yg6YcaPbeGgtQiq1jNRc/FWN9ifgliKE7lwYdNs1jY?= =?us-ascii?Q?P9rmL49sHebTQtzP31UD9bY6F30GPsvpKFSlP8OP1lN5vv6nA6t7VRYpTOAR?= =?us-ascii?Q?jyU=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR18MB2284.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b5e46f61-25a9-46ec-fbc4-08d912cbcf8b X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2021 09:21:21.7655 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YwAxi/1Ds9xaDw5PhtPAONuD0rF6sjU8vuYF5kFhV3HsaD8M8k+IzhK9Z3hbc75lbZU8O3Ra+UA8uQGFUmIi9A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1801MB2030 X-Proofpoint-GUID: IKVG2TcyipPyUxutEafc8eDfp6VGVFOu X-Proofpoint-ORIG-GUID: IKVG2TcyipPyUxutEafc8eDfp6VGVFOu X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-05-09_04:2021-05-06, 2021-05-09 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH v3 03/15] crypto/mlx5: support session operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > +static void > > > +mlx5_crypto_sym_session_clear(struct rte_cryptodev *dev, > > > + struct rte_cryptodev_sym_session *sess) { > > > + struct mlx5_crypto_priv *priv =3D dev->data->dev_private; > > > + struct mlx5_crypto_session *sess_private_data =3D > > > + get_sym_session_private_data(sess, > > > +dev->driver_id); > > > + > > > + if (unlikely(sess_private_data =3D=3D NULL)) { > > > + DRV_LOG(ERR, "Failed to get session %p private data.", > > > + sess_private_data); > > > + return; > > > + } > > > + mlx5_crypto_dek_destroy(priv, sess_private_data->dek); > > > + DRV_LOG(DEBUG, "Session %p was cleared.", sess_private_data); } > > > > Memory leakage, mempool is not freed. >=20 > Yes, good catch, this part was missed. >=20 > > IMO, this driver is not properly tested with the unit test app. >=20 > The only app we tested until now is l2fwd_crypto and it works fine! > We can add it to doc. >=20 > > Please add a note in the documentation that it is tested with autotest. >=20 >=20 > The next app we want to test with, is test-crypto-perf. >=20 I would recommend to run the test app first. It will catch most of your basic bugs like the one above.