From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8D891A0C3F; Tue, 11 May 2021 19:38:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1660140140; Tue, 11 May 2021 19:38:37 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id B3EDB4003F for ; Tue, 11 May 2021 19:38:35 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 14BHUHnh024294; Tue, 11 May 2021 10:38:34 -0700 Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2173.outbound.protection.outlook.com [104.47.57.173]) by mx0a-0016f401.pphosted.com with ESMTP id 38fw8y8awk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 May 2021 10:38:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Tv1mIXeS2SPDKRfAu/so8zSO3UOZ0zkvbLdQi4SsvoEKXqlyxFkaHSSzmEqpL2TqutyhrS24WzePwydBtw86SFN/cNwWX//2bNncpn7ZzwbojDKKd8nj8OZsmTFiDI8kgA0d584TnMlvDW8eNDBL3DXDT1bcELc8YkvQZuvx6EMFY1oQmR7LCNx+kA/aVpE/E9f4wx8JZy8w7kyTdKgfFbtGTUWB/TmceLPLtn8kumBu6QvUXa2uzUtF78EEzKsOORwcOl/zQ7lM7HOA5igbhJyB/qkpnB2/oMxH0lCyFVDiW+TscPZjU5RYQsNkGF7bQ8MKK6lw1K76xIEBJuX8pA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MH7JM9cBm/ojVQRmlx0LXm+GbXF40pAodmUtkZOKfbI=; b=CBK4TxoBX5dCrqYUbNzeu1AnREOwmdMaKjRdy6b78TD2oYkP3MpVo1I6t79Xm8IVXAq3dupLkod9L3UdqiDzq+md969x/opSWe2hxHJTD3lu5/h7aMHdbjpMbH4WGqOuyrYCRMxm4L60ZXLdMRdYtLmm7E9MFFpJVOeMOsiNIC/+SoA15tk7Wfv8V6/4h3Q9PM1yHiVDFXKSg9sBkokJBVXoJK9GTdAYVQJO2Zxn4uKWgoaV/tuoEYD3Ek7g0Nn/qmRWER4X5zYl/arajisFVxFmevidIoJoZ4QYOCssEaByF1R5tjaxDH5bupRwrYBTN2uQVY4V3ZjzYG2PBl0Z/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MH7JM9cBm/ojVQRmlx0LXm+GbXF40pAodmUtkZOKfbI=; b=Pj+5eV5UknqQwuN0gaepwqls17ydYb3q8uQItmCpC0jY5FXlsLzuiGgGzw9d3Q4+Jh4r3wO8OM3McI60gBWw5QQ81Wjj2yNypFiHC6S8bIIjV0FVwoXe2+4fxobx+jciJLUyF6L4vP3sVbhZMUQ2Le/Dv1y9TAmY2RH29nD8agk= Received: from MW2PR18MB2284.namprd18.prod.outlook.com (52.132.184.16) by MW2PR18MB2329.namprd18.prod.outlook.com (52.132.180.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.26; Tue, 11 May 2021 17:38:33 +0000 Received: from MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f]) by MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f%7]) with mapi id 15.20.4129.025; Tue, 11 May 2021 17:38:33 +0000 From: Akhil Goyal To: Matan Azrad , "dev@dpdk.org" , NBU-Contact-Thomas Monjalon CC: Suanming Mou Thread-Topic: [EXT] [PATCH v3 10/15] crypto/mlx5: add keytag device argument Thread-Index: AQHXQSnPQf0MD2hMAUqO3HOD7BvLbqrZiTkQgAFP7wCAAAxGoIAAVhMAgANaLQA= Date: Tue, 11 May 2021 17:38:32 +0000 Message-ID: References: <20210429154712.2820159-1-matan@nvidia.com> <20210504210857.3398397-1-matan@nvidia.com> <20210504210857.3398397-11-matan@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [171.48.51.1] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dd762d00-94e6-4415-64a1-08d914a39918 x-ms-traffictypediagnostic: MW2PR18MB2329: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:663; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: EgMicJjbCMKfZdIT6bHd51JZ30cl52vXMEJeTmI+IxJFxWgfIaJwhQFdesOJ2nwiQVeCt9DvPnCbU1jvC+NdOUMwv3aPD8lvrcfF4O9LLzJ9e6zDJSN1f9NdjmNq+BHcboK/4wwLvSJzrlLqybEBCperSTzcGYNdwOR0BVvKRgsp9SdtE43BelhQa6av6fRwbCnqylcNVW1izQESlAr8mucoK19b/ISe4ihpqys1uc7O9gOfBXRD7aOKisikWYM7DrL9/jI/8GWX3ObvDTrwqsd2vXBlXc1n0YhDrgEC0cXlFiiVmrKc1vOOOyKRkJEenga+iNkusOu9zZ+4ewAxU2WW/Aue1J9Mt9x8PeXBgVOkGwk9REHINPqUIrJJO1BHiHykxLPYdEkC4YQGs9MlAPHElsYMF8j/Pf6NecW9bQOswf6NrCz6aY6XQsxVQBLlFCXX0EsMQFlr9Ji9qFvfDAsJtp7tdAhOlxQ9lZsDGP0G90zHNf9BgEQgKtfbPc9gebh4XiOLO53x1EFLa8hXC6E2W66BPgQMYTecV7yIFAa/78T7owhX8iTW8H8hBZsX3ec1j8QpT9BROozfTm1ATLMMz4bOKyyrZZV0SNu3a2s= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR18MB2284.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(136003)(376002)(396003)(346002)(39860400002)(76116006)(86362001)(66946007)(9686003)(38100700002)(478600001)(186003)(52536014)(55016002)(7696005)(4326008)(83380400001)(26005)(66556008)(8936002)(66476007)(2906002)(64756008)(66446008)(8676002)(33656002)(122000001)(110136005)(5660300002)(6506007)(316002)(71200400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?yIDMVvPNiCCf5BY7n1MtgIX8NgjagWve5dJ0I+MM39QEEnQBOkB6rS0Katz7?= =?us-ascii?Q?W2dE5YPHVhCY3PUgiX71dcEhxrorTHj+yX2+oFkhOVFaJcAaRnrgREamXI5y?= =?us-ascii?Q?V3SgD9wZHlZsPMbQTK5r9G1AQzXAzLytqq9IgNWs9+K6BE6QGZUkfeotTGCt?= =?us-ascii?Q?zW1Or4RitE5yJjWofMeamP7i4VwIdlf+9ejfzsjblrYL0/8STSCjGJl+o6Ui?= =?us-ascii?Q?OvS22rWfMcJ6ad4V0sQsquXNwBrpBE0IN6OQEKTuxpawjkDN3trnB9i/pgBO?= =?us-ascii?Q?EDRecinvak+fry7qVteYIOpqCJY5b0G7oAP5meOA1ydveEm+gHP/MELMRGq0?= =?us-ascii?Q?S+ioyiBgwyxbjxxHb1fWgUMHOdJGlI5KXHSPQHPgkN3TPi6Kdm06CEproDI0?= =?us-ascii?Q?nuQwuUZife1GCixePVnNpte7o5HPpXuBLUz9zrGr8atItRKRQTvfkB1BwDQx?= =?us-ascii?Q?0gqGWEMge4G5xu0Vf19zfs2Cv08gkoBaDCE6Vg3Dnk8kD3yKJahoNu1Lzu4i?= =?us-ascii?Q?CBi/h3P34Zh6W+O0WnUTT0/kCqn+T50egS4dj0eqDq/d3XGJLOCnIh559phG?= =?us-ascii?Q?qAYRdTGbfCXJLigfpgbqE6Zz/cAwzL8eR6NwZtuB5LNVBc9md43ftYqenjkA?= =?us-ascii?Q?fDRnuY9C0nHXBmyn4xLxwr7AOYNH2fpDg05b5yzG99BWeZZqmGiGY8GMqKHl?= =?us-ascii?Q?qhKywDeDizQJVDzihoKqrGcG77B1m7wZWOEkyEHz54LZpT+WaXl6/A3Ua3mJ?= =?us-ascii?Q?T4u5GELLY7gcC6hOZ3Y9K6KnF6Wf0Ao/YGrxg1GK4/oFeZ0WvQqyzX8Y493Z?= =?us-ascii?Q?tFfr+wJcayuf+O/cwBSH3Gk1Ofv2AN005F3Rhyr7k3Y+zi38GLFFGEJfznvN?= =?us-ascii?Q?YzoDNt68LpqICrX/tCx4xcFuefJyH7RFaQUImtc+SNLBfbLiWhI4z5EWY/bY?= =?us-ascii?Q?OF9tMIV1w1GvmnMCCo6wb0kUh7xvzpwwhv5eCib9mMGzAulFiAz2O1mmp0Vc?= =?us-ascii?Q?oBkQOfw8DeTuFT7uQiOnoWYxPcU2gsZQ6pp88FwbWWc2Zb60ql3B0Kdzg6y7?= =?us-ascii?Q?kdU3Uhwo7Bhh88YzQQ8NfRI5MgDoEjJ/kaCon2Qk04/2u1URv5N4rlvHkPB0?= =?us-ascii?Q?QuQBKehxixLnzJDfxDXZd5B9v8VHvbaLfbltQGnKhClLAdDOEUqT5CAlU6sC?= =?us-ascii?Q?VAWBj7v3hlk6+55+GbOW93OAXoB4kslsrxEsy9w45teXTQRNjQVbNirlk+vP?= =?us-ascii?Q?Pm7r8xhtm8K15NcZ8cqQhdUs4K/828yp0F7dqRwkAgR+Hx4pdVOu7PYarrB1?= =?us-ascii?Q?a1o=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR18MB2284.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dd762d00-94e6-4415-64a1-08d914a39918 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2021 17:38:32.8644 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rjk3GCG9R1JtMiqFnce3764QACDNv82SjGej+PdrXpEoQZxlvTw//gfSzo4n5/xzMZKve1hZxnK/m21EyfZWKA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR18MB2329 X-Proofpoint-GUID: HrEZyjiXkiv4g10kZ-IR8RpmiMx9Awdr X-Proofpoint-ORIG-GUID: HrEZyjiXkiv4g10kZ-IR8RpmiMx9Awdr X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-05-11_04:2021-05-11, 2021-05-11 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH v3 10/15] crypto/mlx5: add keytag device argument X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > From: Akhil Goyal > > > From: Akhil Goyal > > > > > From: Suanming Mou > > > > > > > > > > A keytag is a piece of data encrypted together with a DEK. > > > > > > > > > > When a DEK is referenced by an MKEY.bsf through its index, the > > > > > keytag is also supplied in the BSF as plaintext. The HW will > > > > > decrypt the DEK (and the attached keytag) and will fail the > > > > > operation if the keytags don't match. > > > > > > > > > > This commit adds the configuration of the keytag with devargs. > > > > > > > > > > Signed-off-by: Suanming Mou > > > > > Signed-off-by: Matan Azrad > > > > > --- > > > > Documentation for devargs should be part of this patch. > > > > Please split the last patch accordingly. > > > > > > > > Title can be shortened to > > > > Crypto/mlx5: add keytag devarg > > > > > > > > Fix other patches of devargs accordingly. > > > > > > As I said before, no devargs is really active before adding datapath > patches. > > > The option to add all the supported features \ documentations in the > > > patch which actually adds the support is correct. > > > > > > The last patch adds the capabilities and docs when all of them are > > > really supported. > > > > > In that case split the patches in such a manner that data path is added > Before > > devargs patch with some dummy values and add the devargs with > > Appropriate documentation update in a later patch. >=20 >=20 > No, data-path must know all the devargs in advance, it cannot work well > without them. The suggestion is to have a sequence like this Crypto/mlx5: add datapath -- (with some dummy values of devargs.) Crypto/mlx5: add keytag devarg -- (replace the dummy values from previous = patch with correct one. Add documentation ) Crypto/mx5: add xyz devarg -- (same as keytag) Regards, Akhil