From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CE72EA0C42; Wed, 12 May 2021 08:49:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BA49A4003F; Wed, 12 May 2021 08:49:18 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id C78974003E for ; Wed, 12 May 2021 08:49:16 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 14C6kWXm031484; Tue, 11 May 2021 23:49:16 -0700 Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2105.outbound.protection.outlook.com [104.47.55.105]) by mx0a-0016f401.pphosted.com with ESMTP id 38fw8yapjh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 May 2021 23:49:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WEslSbJ8PwJsMSDE4TQh53YwxxVE+kgsYAzu7OqqN5e1wm/zCeYKeaFYQ4XxYWLJPR7VPLqlms/ex3MZmWeLG8FF4jQs39aEFcY8FykbLAfe7rmmqxshppKxxpjlILDz/38r1LE92hfabQTHVgUx+cJTrU7xqBcmbocsEKhCBov2nISEpMmnavhkfqLw03BygRII79D16YFzGmt3CiIwDTwMEvhDFbdFalU/GBgERNwBW4Ono7eN/1gBveOP4TIZzW6zb4sP7//cybHA4VQBwvDh1muNqiHMmDuO2WE/KGkmnnQkC+CPpqgZN4E3U/E5o+Jhy/+n9mAe49ofullx1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lWh7SRrxPUI6aDOY/kkJ84RJH+oSo1FtsqHm/NlaYOk=; b=jekNbg3sWlBUgtQ+GC0hflc8ylbJEJx3Jck15BQZNepM2kfM+SSsHlqrDiZndhmF/YPBSJW1/+qU5v1zYdgUOaUIBRmCBYNvVRc9/JPQC8Q0rxQrMXmXrMEZTwNAYONkP2toGYGyUCC/SRu69irS/lN/kxChjv780ULb+bUuEclUK8sREtWCx3dtKsu7KavwZsTrqpUS54mQyoaw9Ukug8lSdt7bfbhMHV0NKP63guoAetTRJiagaVQZ4mU9qc2aPwssM3UK3Cc/Zq8hdGRLoRbasDFYurQDatRPgvW6MnKdgNLKo1Jcm4Em/g5mfkrFTyDVGA0KvhaVjnDOlMiQUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lWh7SRrxPUI6aDOY/kkJ84RJH+oSo1FtsqHm/NlaYOk=; b=Y1DPruz14Zt8Vrmkv1rDUAWY1Pcyz1V6IGVp0C+C8UFD0/+IKr8NOeiEnwSd37jVU5mYmGZG0wHPQCJ72sAkEUyCR7d/0+bU+T36rFLTGicPwMdEqcsqWSrcEZDLxkk4rxuSM+ud5ACS/yaqqyw2dL/2bfCQhyNeZPbyMWm7MYA= Received: from MW2PR18MB2284.namprd18.prod.outlook.com (2603:10b6:907:10::16) by CO6PR18MB3906.namprd18.prod.outlook.com (2603:10b6:5:34c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25; Wed, 12 May 2021 06:49:13 +0000 Received: from MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f]) by MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f%7]) with mapi id 15.20.4129.025; Wed, 12 May 2021 06:49:13 +0000 From: Akhil Goyal To: Matan Azrad , "dev@dpdk.org" CC: Suanming Mou , NBU-Contact-Thomas Monjalon , Shiri Kuzin Thread-Topic: [EXT] [PATCH v3 09/15] crypto/mlx5: adjust to the multiple data unit API Thread-Index: AQHXQSnPWST5nsDOH0Wf5VoieFG/G6rZh6kwgAFKRoCAABRREIAAVWwAgANZLfCAAM8HAIAAD0Vw Date: Wed, 12 May 2021 06:49:13 +0000 Message-ID: References: <20210429154712.2820159-1-matan@nvidia.com> <20210504210857.3398397-1-matan@nvidia.com> <20210504210857.3398397-10-matan@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [171.48.51.1] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: df4e6f82-6d60-487c-4276-08d915120e0c x-ms-traffictypediagnostic: CO6PR18MB3906: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3826; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: g2zBrEXiww2FLK261KZ5gnpa0RmN73Pgt6K9NzjS5gh6Hpw2h0AQYnyGugMaVtG2DjNy4Spt1lp2kSAwbUF3J+KvrzAPzvv1XiZ1nfX/y9Og7Oet/b4ZU7SSoIa22hiS9p5DTV80WJHCiOfzIOCh+Z3A4odoBeSSPKYnguqACQe5HjoiYV2NQEdrPmMGcF1Sd0qye2MGg/KzEZJ/P3kSiNxMV/+iTDWNSeAP/1fhvyw8rnmbxdulb3S8ZUqs4jnzICfrm37CmCNTfZqW8PWFkzZh7N+t5aictvS0ueSzdT8BCKnPQGiKhLQ/wfavK0Lwd6I7hX6hGKLKpLlTkzNxDiOA6ViNIfGkCjehI/ih4TSbl7DcSm4qjzeqID22gw3NLa3EnsD1+bjmFMaVH9+5jV/0x+QJWVK0hdeUlQJr3+BLUdUGwIwu//zuNrmEdYRGjOiz0Ef50kmjJlba7/CgOHPpq3UZLjr/sdaMf8qVjJMMaLNmYQtf/Wgu5mWY+zUFz6f45uKMytnfdn+vlxLTA/k+746281eMwIS7/oAuSVXMLwt2ECcdi/lBXyD5rIXYQvC8P6NFNFkXO2/CYGv6wyiO12PZHRpGydWAwxSNfA4= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR18MB2284.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(39850400004)(346002)(376002)(396003)(136003)(478600001)(122000001)(38100700002)(186003)(316002)(7696005)(9686003)(6506007)(2906002)(33656002)(76116006)(8936002)(110136005)(26005)(8676002)(54906003)(71200400001)(66556008)(66446008)(64756008)(55016002)(52536014)(66476007)(66946007)(86362001)(5660300002)(4326008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?6gTJ05ymD8xhD7HT4XN86lZLn1MzT05C/8AZzON5DTQHcaa1Eh9hXK5ngwS0?= =?us-ascii?Q?I9ctX97j5FZde/kxlaMKZ7xP92LvLwfgHNevjY/601NJaNU8VV6OY0+4gGVR?= =?us-ascii?Q?+4KVlFZTGUpZh8fWFnApw+wRRxvm2F0kPAMpjzRouWDhknnD/NgQ3MiyFO5n?= =?us-ascii?Q?nS9cXXGcsQeBzrOYNSIia1+Ex9Fi3yY4dLmDPIDDwxBOb2UHb1uXZmPbvmVS?= =?us-ascii?Q?G9RJsxkZFN1hIriypltTszsYaK1Kg6UyHiNCPlwTb79Es5FdhItO0FoooGGX?= =?us-ascii?Q?b1KfUdS50MFrMxxH1ntSlqIjRgICt8hx77R76NdTORd97d+rbCh6YJT8qvlj?= =?us-ascii?Q?v19Z3fNSS+3cCDOFOUgee1MGOkQfycJxCZa+0ZXWUsX/opfnkrzTiqGbM3M9?= =?us-ascii?Q?YEfNUKnKrIA06WRRS4S/ELFUgkJ/mVPsWdMdg6eowZtUUekqL3on6oNNzVsD?= =?us-ascii?Q?8eCqZVU+SlIYbKvtp05Rmc0fzkO5cXBvcDmQcs2d1zvCVYQ2w6UiyS9idygY?= =?us-ascii?Q?fbEAgL1Qh91CfUwsvzJpmj1Vuatkz3BaQ/GuG9Mhe3AkJG0x1ft0Ta65yawl?= =?us-ascii?Q?Ipe3a8fIRN2ewClx/gSYbuX6LwlzJXm8JzNHdWXU51TbqTnsWhHyFuEw+3A2?= =?us-ascii?Q?mKRx5PCsi1VDPnrcvurqNyNzv3V9qvX0vsJgkLhcpFXUhH6GRoRkM3wdeZYo?= =?us-ascii?Q?PWIW5UeWyOpcf7uIO2f3vz1mq04qib7wi01djROvziIAu+G8MFOj8jmPnXl9?= =?us-ascii?Q?bQFv3iPpL6hCh/rYNDQgzygj2kT8xj6fu767jFc/u0Lx5aRRMET1wOBZyXHL?= =?us-ascii?Q?udRaBPMHseG9o1Za3yZRc7tOGnYRTYeak9QS00AVEM/UTfmoS55UdUHM/rtz?= =?us-ascii?Q?wu6xghQP1CGZPJSHaGDzGQepo9agIm/23r3jiclzyrwL2nVnFXHHvN/85Kb2?= =?us-ascii?Q?NEKVX9AnwFkeSXEYYLgohMhaN9vw1NC4Jj/5eWPmdwDGR2JjEcDgZC43TR6S?= =?us-ascii?Q?yjmhjT55I195+uqFAptdUG7LrjR7ozfJCdrEpUCzsOnFc6UYjS0R6XiD43jt?= =?us-ascii?Q?Gysiy/JEqdALnVH7ud7o3cT9itsTJf9kEYVgH33XX5SK3aqumS2AEvP40YF4?= =?us-ascii?Q?ng9SBd7FrRyYA3/cihx442KITjl86tnX+y4AEs89qJ9EkDEiJY7T3g0B7ylq?= =?us-ascii?Q?kQe8AdrKsVXaXy24v6jlxwHV+D4l+dwfScjIDCQX7mMS3S4lqTUGLTr8IALX?= =?us-ascii?Q?olDV9/hJXQVp8B+OQHbME8v43UETo/QHQlGh5CNUnxqwhZGQzmBULj6hyQO4?= =?us-ascii?Q?YhY=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR18MB2284.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: df4e6f82-6d60-487c-4276-08d915120e0c X-MS-Exchange-CrossTenant-originalarrivaltime: 12 May 2021 06:49:13.7175 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yohbhi9877RQ8KkrHPtgassheannZQ3CedWEJjdJ6qDan19rDdS9DgASZX1QoruISbAKlP5UF+iZfICvflxStg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR18MB3906 X-Proofpoint-GUID: MiH_dCqmWTqNz09mvmdVIvBbE_BBdYvA X-Proofpoint-ORIG-GUID: MiH_dCqmWTqNz09mvmdVIvBbE_BBdYvA X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-05-12_03:2021-05-11, 2021-05-12 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH v3 09/15] crypto/mlx5: adjust to the multiple data unit API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > From: Akhil Goyal > > > > > > Also set feature flag in the code and the documentation in this > patch. > > > > > > I see that you are setting all of them in a single patch in the= end. > > > > > > This is not correct. It should be added where the feature is > supported. > > > > > > Please fix this for all the feature flags. > > > > > > > > > > No, in this stage no feature is really supported, the actual time > > > > > it will be supported is after the datapath patches and capabiliti= es set. > > > > > > > > > Move the patch after adding data path, but documentation should be > > > > part > > > Of > > > > this patch. > > > > > > I will squash this patch to the session commit. > > > > I am not asking you to squash the patch to the session commit. > > The point is documentation patch should be part of code patch which > > Introduced that feature. This methodology has been discussed in the pas= t > > and is being followed now. Please discuss this in techboard in case of > > deviation. >=20 > Not sure this is mandatory when you add a new PMD. In case of a new PMD also we try to follow this as much as we can. IMO, this can be done here. > For sure you right in general. >=20 > Anyway, the session commit is the better place to this code. >=20 > > Regards, > > Akhil