From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5674AA0562; Wed, 14 Apr 2021 21:43:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3D83E161CCC; Wed, 14 Apr 2021 21:43:36 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 37D40161CC4 for ; Wed, 14 Apr 2021 21:43:34 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 13EJg4Nq001686; Wed, 14 Apr 2021 12:43:30 -0700 Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2107.outbound.protection.outlook.com [104.47.55.107]) by mx0b-0016f401.pphosted.com with ESMTP id 37wqtm328a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 14 Apr 2021 12:43:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TR2fAU9uetD5r6iZNseeRw5UzDeCG22LABtnXgVycjro/bX2p37REOBBbGICZMhi2yEMtFdFMND9Zci7UNtILRjCMNJ1da40Z3rnMLkXrU36AQZmwDuaLJGS8XuItaUqc0sW9+dptiLvWbqSs4qNxUAAZ4hS3PRsM+DnX+yFwO1dQxLMlcO9n8m0mnlWCkMpc2Drk7/J8xeZowaoUWk6Ri0owOY+MKW6chLnOGEPdFx9wlFeO065ut0rz+ZuMwPtHwtyhTCS0qJZkjjpIaWLwOn2hS1hR0sXXOUUvtQKWPxi51pSlLOBxH87FSQPwrTcDWH7K4gHA45uAQ1rxYLIWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zXQHcRKcf+CkuBEvYx8f4AePNn70h16czwbyjINwMj0=; b=nHS3JI8OUUztNvJDPOW1MAFyYL+oXbKYkijJwnfRXDmZKb38hU0dWeTfyJSdjFaBbghBifKnLoveWYaVU884l3+yknO5jyd1lUzbRRrZ93fHHTwiySrvWKmKCfcNvPElI29Ea2Hoprai81BjWB042oA6blXRQqGieG6nsfcORJ7yofq0y9AtNjIdNCbqH9ad6JwT35SjeAHxYOGVLObUJJpBukt83Al7CnaTSWj5MA7UudX4DXWmEGybJlA5+4c0zHCQLQqq2ZrC4DGWKntC70g5OAUVV8Fn9Gn+Aow/6jG4MXkRrLMl5Ij+nGdDoBg/3XAMyAAivn5izScZsgH9Pg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zXQHcRKcf+CkuBEvYx8f4AePNn70h16czwbyjINwMj0=; b=HqCQBSaw/h/COkkUBM8cyGSP1lazaV8QBXglngXNcOXUDdtS5pbsuEgcwh2UGx5oueW8fyuV4ElvSlm9CdD/myvIiFWI934xyvgOY7MbmuQvxNuGkh/VjZMNRp4RGMFmkhKzPuNdMmxXcEvcjjU1rtzQv+WWgj9upoyV0oF7gNw= Received: from MW2PR18MB2284.namprd18.prod.outlook.com (2603:10b6:907:10::16) by MWHPR18MB0991.namprd18.prod.outlook.com (2603:10b6:300:a3::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.16; Wed, 14 Apr 2021 19:43:28 +0000 Received: from MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f]) by MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f%7]) with mapi id 15.20.4042.016; Wed, 14 Apr 2021 19:43:28 +0000 From: Akhil Goyal To: Thomas Monjalon CC: "dev@dpdk.org" , "arkadiuszx.kusztal@intel.com" , Anoob Joseph , Matan Azrad , Ray Kinsella , Neil Horman , Declan Doherty Thread-Topic: [EXT] [dpdk-dev] [PATCH v4] cryptodev: support multiple cipher data-units Thread-Index: AQHXMKWi35DEzMdbP0ygc1kxg4Ofoaq0V1iAgAAS3ICAAADrIA== Date: Wed, 14 Apr 2021 19:43:28 +0000 Message-ID: References: <1612449252-395208-1-git-send-email-matan@nvidia.com> <20210413204250.3989341-1-thomas@monjalon.net> <2068151.q8ePLV6qny@thomas> In-Reply-To: <2068151.q8ePLV6qny@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=marvell.com; x-originating-ip: [182.69.47.6] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 587202f7-163e-42c2-fe9d-08d8ff7d938a x-ms-traffictypediagnostic: MWHPR18MB0991: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: m8u4uSMpth5zMAnXtn2nhwb61+ZdaB8bLwGMy/FwE9/EQyyTQA7OejVo+B2F82qgTkAsOU6mQPysmWalhIGkB4iTbDPpKNIv9/Kia217q3rhZLuRwOfTM9z0oT5ADZIojzxmV1p35aM0aVYmjFh3nWHBZJUmleB8IsTzHGWFzSkW8Mve/UCit56GVGD9bKYQ3DEmg4KCMajzFbEG+8FoCB7WaDLoy2ldvl2f8i87ABDd7y531rTAOLCCxEmnQXWV06cJ0wFvzqym8xBWSJOt3bWyhCShTwJyC4G87bypzlBGpOhYRYASk/YzDoO0rZzxsMWG24zaCz7Wvebw9gIzkdeD6g26xxm5SFdSw0+T1al5MMXHQOyxiM9oTmh9GS0Q1G4ZWWZ8NPMqc48u0ZI/Ye7BzUi3tqttCCAlcrsxTcO2MdXGL8j2+mPa9QSzgvy+h7M7C/sN/gMo9smcz8lKTf9zGbk7fJ5ERoValIP766MmRhEzenPb7y7y0vfsn6iqe3dJ7kglSwIH2w7JBoZyzWrZaoYdD08hI18BCgSXvoJCaWSChmQMnUnHRSwERmjKN9vsVj0Fq3eHA4zZcMahyhNKVAuvjhINyMbNskrJP50= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR18MB2284.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(376002)(366004)(346002)(136003)(39860400002)(5660300002)(186003)(9686003)(71200400001)(478600001)(83380400001)(6916009)(4326008)(55016002)(52536014)(6506007)(26005)(33656002)(76116006)(54906003)(7696005)(86362001)(8936002)(8676002)(38100700002)(122000001)(2906002)(316002)(66946007)(66476007)(64756008)(66556008)(66446008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?XNGc1vLYLWbuSguabsp3yrq5fqaG50LaegJoKglHplgkNAeJvzROJkDF5ftW?= =?us-ascii?Q?fmxr+nmuy9B2iZtoBiiJbU5YiaUXfGz44HzvKWQtfKI8+VCuCCRhfeWwSMB5?= =?us-ascii?Q?jywwbWeFZxroCBsuEiGxxZj1Iq8TkJ+x1i5zxcPQihKKW6nUDCQ5efbjGC/u?= =?us-ascii?Q?c3ruHH9ggj5hSczdhAxb/pzl/fU3+NZc+gTz0/yYNEJz01tnFLzg0czfne3J?= =?us-ascii?Q?9kbj8oxWfiHIUUkTqJzRpaTRJixdBGfRiSsjlH3MEbNpQnm3fdlQ82M6mKNQ?= =?us-ascii?Q?jjpUdPKuqjF4IlpxO//lc8mJCBYOAzBRIj02HT6fW3sPX2PV/PZwmMSLvh5B?= =?us-ascii?Q?DSxp5GB9asDP/249M56aWhk5KnlXVA6VLcUfT052YvpEiso88QwTl5VhFM3/?= =?us-ascii?Q?HsT1lMQAfrTsqUkSWMIJW9oPukdkTVT4l46Z5wT2JW/SmQ2ZfPageHqBTR/V?= =?us-ascii?Q?z4JHU6X72OkfKOcnPJ5yT5S30hcuNeRufCJUttEn52O/9TOmujn+cIwic5RT?= =?us-ascii?Q?53A+SHd3mBwKJHegS6xgu4A0CztwKIx3I4azOv4AVw2JBH5RlcQD4DrdMTzh?= =?us-ascii?Q?JxIgUUOYs6MnQbD7MviI9ktBYezRIaubCYOIAdk3P+aDqUAAEKYxPrtx4BvA?= =?us-ascii?Q?iechIK/gIUfXX0ODzXTLNKn5JNDLVPAG2gkxrTSwRyzOcoAFBHouwZhkJmnP?= =?us-ascii?Q?yO6RAPyDt+v4ouLUZcKbmatiQd4vDglOMzrmnI0Yh77Kq2PyRWjgcdwiN3vI?= =?us-ascii?Q?kGyU9fkBF6Xbv+fsXpoGunA7Z6r1d1Q+f3+eRjDYuk7wRLunhNTKASOt1Lho?= =?us-ascii?Q?27hiX1EkvUzHQGqROJygPryuAuRqnQaU7TQVhCJcwbzQezJoQOOxrLQRCDvQ?= =?us-ascii?Q?Mkpxn3OY0wZkg/SSW8j5OJYwLCfgUcC49nuCcGF6W1b3+0ETqP72rxyBKh0m?= =?us-ascii?Q?mcQ9hQAoke4M/ISYuIx1p/XAhqkSVhAOc3wvuuU0fZWij7CKfTyiY862fzrN?= =?us-ascii?Q?m6f4gTl4xRH/TdafGDNTL/6cQvwFdHs6uECd0IGeqKQlLMWh8dvYeJvzDOcj?= =?us-ascii?Q?yxfEsxEYqjXY1oRDIu7IAzrH/0a6Z12PWxLEe9+N+a9/ZC0P3TswqjpCLFMR?= =?us-ascii?Q?Eu4kFerHHb+1vIy7iVlk2Jpz/vjAmeIBAWwFKTGrz4ZPZYpebuLPnrcEksIc?= =?us-ascii?Q?KzhY+rQtmFYz/X37e4ZS0/ZE7Udhx8HT1/dVa4N3hLWcCntUuvJ+afItaKGI?= =?us-ascii?Q?eREGCM9MTJw/q6wPqDggak51Mw4q7B9gvq7bXtA2BA7JiKu63ki8NyC28x40?= =?us-ascii?Q?D3o=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR18MB2284.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 587202f7-163e-42c2-fe9d-08d8ff7d938a X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2021 19:43:28.2411 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yGuU+kWNWJdbuH9SEMdFTliOu94wKSaaGOsMgtO6xrMiL4D48aqJ7JRYZQ4d0rvb0r85LNCM0XBtHCUy4jN2+g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR18MB0991 X-Proofpoint-ORIG-GUID: sSb5L4wNCHd3wxDYkK_EWLyIhIJkE32z X-Proofpoint-GUID: sSb5L4wNCHd3wxDYkK_EWLyIhIJkE32z X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-04-14_10:2021-04-14, 2021-04-14 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH v4] cryptodev: support multiple cipher data-units X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > 14/04/2021 20:37, Akhil Goyal: > > Hi Thomas, > > > > > + RTE_STD_C11 > > > + union { /* temporary anonymous union for ABI compatibility */ > > > + > > > struct { > > > const uint8_t *data; /**< pointer to key data */ > > > uint16_t length; /**< key length in bytes */ > > > @@ -222,6 +225,27 @@ struct rte_crypto_cipher_xform { > > > * - Each key can be either 128 bits (16 bytes) or 256 bits (32 by= tes). > > > * - Both keys must have the same size. > > > **/ > > > + > > > + RTE_STD_C11 > > > + struct { /* temporary anonymous struct for ABI compatibility */ > > > + const uint8_t *_key_data; /* reserved for key.data union */ > > > + uint16_t _key_length; /* reserved for key.length union */ > > > + /* next field can fill the padding hole */ > > > + > > > + uint16_t dataunit_len; > > > + /**< When RTE_CRYPTODEV_FF_CIPHER_MULTIPLE_DATA_UNITS is > > > enabled, > > > + * this is the data-unit length of the algorithm, > > > + * otherwise or when the value is 0, use the operation length. > > > + * The value should be in the range defined by the dataunit_set fie= ld > > > + * in the cipher capability. > > > + * > > > + * - For AES-XTS it is the size of data-unit, from IEEE Std 1619-20= 07. > > > + * For-each data-unit in the operation, the tweak (IV) value is > > > + * assigned consecutively starting from the operation assigned IV. > > > + */ > > > + > > > + }; }; /* temporary struct nested in union for ABI compatibility */ > > > + > > Can we add a deprecation notice also in this patch to remove these > temporary > > Struct and union, so that we remember to remove them in 21.11 >=20 > I thought about it, but a deprecation notice may involve > new design considerations and requires 3 approvals. > I think it is better to send it separately. In that case you can send it as a separate patch now only. Just wanted to make sure that it is not forgotten. >=20 > > > @@ -127,6 +135,11 @@ struct rte_cryptodev_symmetric_capability { > > > /**< cipher key size range */ > > > struct rte_crypto_param_range iv_size; > > > /**< Initialisation vector data size range */ > > > + uint32_t dataunit_set; > > > + /**< > > > + * A bitmap for a set of the supported data-unit > > > lengths. > > > > Add reference to the newly created macros here > > > > > + * 0 for any length defined in the algorithm standard. > > > + */ >=20 > Yes, I've seen this miss after sending. > I'll reword like this: > * Supported data-unit lengths: > * RTE_CRYPTO_CIPHER_DATA_UNIT_LEN_* bits > * or 0 for lengths defined in the algorithm standard. OK