From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2D7D1A0576; Fri, 13 Mar 2020 18:48:07 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EC79E1BF97; Fri, 13 Mar 2020 18:48:05 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id C94FC1AFF for ; Fri, 13 Mar 2020 18:48:03 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Mar 2020 10:48:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,549,1574150400"; d="scan'208";a="290085663" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by FMSMGA003.fm.intel.com with ESMTP; 13 Mar 2020 10:48:02 -0700 Received: from orsmsx125.amr.corp.intel.com (10.22.240.125) by ORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 13 Mar 2020 10:48:01 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX125.amr.corp.intel.com (10.22.240.125) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 13 Mar 2020 10:48:01 -0700 Received: from NAM04-SN1-obe.outbound.protection.outlook.com (104.47.44.52) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 13 Mar 2020 10:48:00 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L2exiQWY9ZiW353UahbvkVhMqxfd6GcwHpbLIo4PDnulyYjVZZiSru0pjTlF3W5J5xQ0PMH0hLOuYJqul6pmK+PzIUT+xIhcQ9p0rR4PgywqepltPveJX3w3lYCc3m17ZSjopcnhEw9f58tKI/8tQgs9WooAsliVyTmYy+UsUEFrxjEo6pXO9s+KpDJmqVB0xAOUbUY6HseaDCsDQz5hOPnpVis6SnjWmarDGt6E+Ad7BA3Rgl6QF0bWipxKFodwgnUEoFioELroJC9brmOqVT4V7QwnDhxoKcwRcpDIgeeLjSKZlWYWTjW7rjGejnZEp3feAYEs9z8xz0k66NVIRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9ic3Gx9ulyt4lld7mgLDihYI2oY/nJ7wdtsvmd25oW0=; b=PyOsJbYORqdbsX0Rp07qk6xVNyGQnMT1szPzltVy9NjCezCZBWV2JjkCx68Rh7Nr91AICF9z2uUDXdjDVzF6KWcOggO9Jhc9Kp72EaZnMvn1fKeP1uYeQMLO2Tjrwuvfuu8Ty/KAhgVwzJT8+5fM9Y9iLPkp2hayWwbF/xE4C1DxWWlyr16J2xhjI5ZYETyEoTTUsUix12XXnUIf0eeNhmJ25zPZmvuGlLccCWL4+RFHN5jes+yBhJ4wUItNx+sW9BQbR4tYfadg9Ae6bn51wtoCDZcMUcAmc5hH8+UmS/8vIAgpvM1elrp1615W2MQuS2wOy7or5U+PaZSEtrNSvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9ic3Gx9ulyt4lld7mgLDihYI2oY/nJ7wdtsvmd25oW0=; b=Pj0y/pAAmoushUvwCuh1c9Xju3SkH2AiThcC8CCiy8/IIgQOMdNfU4FPcLAGFUIdP7TRmwfxgE8ya+ZqKQRKy9BWq7QlmOXEunaEoz5V0fEjKURP9UyQMy8L1JWYpVvEcvZR8pG3cwaYjxGt9sXt+/4nz64BO/9TCxBHbHmU6jw= Received: from MW3PR11MB4538.namprd11.prod.outlook.com (2603:10b6:303:57::12) by MW3PR11MB4633.namprd11.prod.outlook.com (2603:10b6:303:5b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2793.16; Fri, 13 Mar 2020 17:47:55 +0000 Received: from MW3PR11MB4538.namprd11.prod.outlook.com ([fe80::d94d:d13e:f47a:29f8]) by MW3PR11MB4538.namprd11.prod.outlook.com ([fe80::d94d:d13e:f47a:29f8%3]) with mapi id 15.20.2793.018; Fri, 13 Mar 2020 17:47:55 +0000 From: "Stillwell Jr, Paul M" To: "Wang, Haiyue" , "dev@dpdk.org" , "Ye, Xiaolong" , "Zhang, Qi Z" , "Yang, Qiming" , "Xing, Beilei" CC: "Zhao1, Wei" , "Yigit, Ferruh" Thread-Topic: [dpdk-dev] [PATCH v2 0/7] add Intel DCF PMD support Thread-Index: AQHV9qljPljSSGDfcUyQXpJG1Qa66KhGuKEggAACDICAAAUIkIAABhAAgAAJOpA= Date: Fri, 13 Mar 2020 17:47:55 +0000 Message-ID: References: <20200309141437.11800-1-haiyue.wang@intel.com> <20200310065029.40966-1-haiyue.wang@intel.com> <54faf82423d94f85a83298f9238b9ac1@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: spf=none (sender IP is ) smtp.mailfrom=paul.m.stillwell.jr@intel.com; x-originating-ip: [192.55.52.218] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 74f7313c-bc4d-4105-5f39-08d7c776a924 x-ms-traffictypediagnostic: MW3PR11MB4633: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-forefront-prvs: 034119E4F6 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(396003)(39860400002)(376002)(366004)(346002)(136003)(199004)(316002)(52536014)(66946007)(76116006)(66556008)(9686003)(54906003)(966005)(4326008)(478600001)(5660300002)(107886003)(6506007)(7696005)(64756008)(55016002)(71200400001)(53546011)(81156014)(81166006)(66446008)(8936002)(26005)(86362001)(66476007)(186003)(8676002)(110136005)(2906002)(33656002)(6636002)(921003)(1121003); DIR:OUT; SFP:1102; SCL:1; SRVR:MW3PR11MB4633; H:MW3PR11MB4538.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: supkT5kBncdZlpPtwtGVXAmf6siWO8ZwGaBBv4sMD8FGD6Rhz40PDUrkleptL6gpRgtp1ynzXoZ6iFRUbHQ3rpYl+GO3htAlzO8Rkr7yS5bpUrTSyHtuS2ezr4AawwRnm944zvgWe/axEdCFTpCWpeFSnERWo8Uf93EeF5IUOCkDEW/29F0DcwAeJhiwWQiJ/pLJe27tL5AMijXO5vBLiRLgVWraG9x+LEY2P1TiTcKSMmJsw66IIm6qGYvBCgrlWXR2p1VTVTMD/OsMa+RIn4BmRB531ES/JjLK8Sv6joA1aiXPmsLBrRy3twjd3FUHMXo1wdmI2xqRRTOI8CUr1lNjYPKroqcEBJadBVHBEDw7ZdWDs8i22rLyNjzCxP42ST9HDDoNNLcngyP3YoLVk6hZCHgLYrix5MTpDBVC7e9m/0m6Ung6Fa12FSbJXLtyIcHFsgDBpgc5NQL9U65TXjIxYt76ecVjrsKmch294+JarxMSV2aYhx9N4LaujECLRXAk3or44ym3GBGA9EmvwVsscSRiy+Aen5Mx4wMti4Z/gB3mAEVJZy46aPSfrgDUTZm3YN7igHBmcK8gEHMm3A== x-ms-exchange-antispam-messagedata: 48P1fnczrMsKNlsAlnIPUAOnz1IHkFLF2UxSYJjB5lEtnMR7Zk/upR6Tlw4hXY3MVAP/RELIlPNeXD5WdCqVIF0pXs32Xgwm99DDvTtj1+ovz38QRAnyQiOCMgF8MMI/Y20P7jepj5FyKkYABkEp7Q== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 74f7313c-bc4d-4105-5f39-08d7c776a924 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Mar 2020 17:47:55.1347 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6zJVWPNdcuVW5ybVxukUxR1Mrcncf1Lq3Gksh+lRFFGozG/MvHporSIPUvJb3nHqgVY3rZTlRGPqJl3hH2U8G8Y6oYYJJ0K+nzRdkj9tKMw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4633 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 0/7] add Intel DCF PMD support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" OK, I looked at the code further and it seems like what you are doing is yo= u are using the iavf PCI device ID instead of the PF device ID when the use= r says cap=3Ddcf. This doesn't seem like the right thing to do. Why not mod= ify the iavf code to support being the DCF? Or create a new PMD? You are ca= lling iavf functions from within the ice PMD which seems wrong to me. Paul > -----Original Message----- > From: Wang, Haiyue > Sent: Friday, March 13, 2020 10:05 AM > To: Stillwell Jr, Paul M ; dev@dpdk.org; Y= e, > Xiaolong ; Zhang, Qi Z ; > Yang, Qiming ; Xing, Beilei > Cc: Zhao1, Wei > Subject: RE: [dpdk-dev] [PATCH v2 0/7] add Intel DCF PMD support >=20 > Hi Paul, >=20 > > -----Original Message----- > > From: Stillwell Jr, Paul M > > Sent: Saturday, March 14, 2020 00:50 > > To: Wang, Haiyue ; dev@dpdk.org; Ye, Xiaolong > > ; Zhang, Qi Z ; Yang, > > Qiming ; Xing, Beilei > > Cc: Zhao1, Wei > > Subject: RE: [dpdk-dev] [PATCH v2 0/7] add Intel DCF PMD support > > > > Hi Haiyue, > > > > This statement is confusing to me "But the flow setting is the ice PF > > AdminQ message, so the DCF shares most of ice PMD flow control." What > do you mean by "flow setting"? > It is DPDP rte_flow API calling. >=20 > > The way I understand DCF > > working is that there is a trusted VF (the DCF) that is setting switch > > rules for other VFs on the same PF. The mechanism for doing that is > > the DCF sends a virtchnl message to the Linux kernel driver PF to >=20 > DCF needs: 1). virtchnl message is handles by 'dpdk/drivers/common/iavf/'= , > which is the original iavf base code. >=20 > > add/delete a switch rule. None of this requires the ice PMD as far as > > I can tell. This seems like a >=20 > DCF needs: 2). add/delete a switch rule. > rte_flow API --> > 'dpdk/drivers/net/ice/ice_switch_filter.c/ice_generic_flow.c' (ice flow > framework) > | > `--> 'dpdk/drivers/net/ice/base' ... >=20 > So, put it under the ice PMD is the best way. >=20 > > driver just like the iavf driver; the iavf driver is separate from the > > ice PMD and it seems like DCF should also be separate. > > > > Paul > > > > > -----Original Message----- > > > From: Wang, Haiyue > > > Sent: Friday, March 13, 2020 9:25 AM > > > To: Stillwell Jr, Paul M ; > > > dev@dpdk.org; Ye, Xiaolong ; Zhang, Qi Z > > > ; Yang, Qiming ; Xing, > > > Beilei > > > Cc: Zhao1, Wei > > > Subject: RE: [dpdk-dev] [PATCH v2 0/7] add Intel DCF PMD support > > > > > > Hi Paul, > > > > > > Yes, it's VF (VF hardware initialization like virtchnl). But the > > > flow setting is the ice PF AdminQ message, so the DCF shares most of = ice > PMD flow control. > > > > > > BR, > > > Haiyue > > > > > > > -----Original Message----- > > > > From: Stillwell Jr, Paul M > > > > Sent: Saturday, March 14, 2020 00:19 > > > > To: Wang, Haiyue ; dev@dpdk.org; Ye, > > > > Xiaolong ; Zhang, Qi Z > > > > ; Yang, Qiming ; > > > > Xing, Beilei > > > > Cc: Zhao1, Wei ; Wang, Haiyue > > > > > > > > Subject: RE: [dpdk-dev] [PATCH v2 0/7] add Intel DCF PMD support > > > > > > > > I'm confused. Shouldn't the DCF be a separate driver since it is a > > > > VF, not part of a PF? You are starting to combine PF/VF code and > > > > I'm not sure if > > > that is the correct way to go. > > > > > > > > Paul > > > > > > > > > -----Original Message----- > > > > > From: dev On Behalf Of Haiyue Wang > > > > > Sent: Monday, March 9, 2020 11:50 PM > > > > > To: dev@dpdk.org; Ye, Xiaolong ; Zhang, > > > > > Qi Z ; Yang, Qiming > > > > > ; Xing, Beilei > > > > > Cc: Zhao1, Wei ; Wang, Haiyue > > > > > > > > > > Subject: [dpdk-dev] [PATCH v2 0/7] add Intel DCF PMD support > > > > > > > > > > A DCF (Device Config Function) based approach is proposed where > > > > > a device bound to the device's VF0 can act as a sole controlling > > > > > entity to exercise advance functionality (such as switch, ACL) > > > > > for rest of > > > the VFs. > > > > > > > > > > The DCF works as a standalone PMD to support this function, > > > > > which shares the ice PMD flow control core function and the iavf > > > > > virtchnl mailbox core module. > > > > > > > > > > This patchset is based on: > > > > > [1] https://patchwork.dpdk.org/cover/66417/ : update ice base > > > > > code [2] https://patchwork.dpdk.org/cover/66472/ : iavf share > > > > > code update > > > > > > > > > > Depends-on: series-8843 > > > > > Depends-on: series-8855 > > > > > > > > > > v2: > > > > > 1. update the iavf patchset link. > > > > > 2. split more patches for making this work be more understanda= ble > > > > > 3. fix the log function usage, devargs checking from v1. > > > > > > > > > > Haiyue Wang (7): > > > > > net/iavf: stop the PCI probe in DCF mode > > > > > net/ice: add the DCF hardware initialization > > > > > net/ice: initiate to acquire the DCF capability > > > > > net/ice: handle the AdminQ command by DCF > > > > > net/ice: export the DDP definition symbols > > > > > net/ice: handle the PF initialization by DCF > > > > > net/ice: get the VF hardware index in DCF > > > > > > > > > > doc/guides/nics/ice.rst | 47 ++ > > > > > doc/guides/nics/img/ice_dcf.png | Bin 0 -> 39168 bytes > > > > > doc/guides/rel_notes/release_20_05.rst | 5 + > > > > > drivers/common/Makefile | 1 + > > > > > drivers/net/iavf/iavf_ethdev.c | 43 ++ > > > > > drivers/net/ice/Makefile | 6 + > > > > > drivers/net/ice/ice_dcf.c | 651 > +++++++++++++++++++++++++ > > > > > drivers/net/ice/ice_dcf.h | 61 +++ > > > > > drivers/net/ice/ice_dcf_ethdev.c | 321 ++++++++++++ > > > > > drivers/net/ice/ice_dcf_ethdev.h | 33 ++ > > > > > drivers/net/ice/ice_dcf_parent.c | 344 +++++++++++++ > > > > > drivers/net/ice/ice_ethdev.c | 9 +- > > > > > drivers/net/ice/ice_ethdev.h | 8 + > > > > > drivers/net/ice/meson.build | 8 +- > > > > > mk/rte.app.mk | 1 + > > > > > 15 files changed, 1528 insertions(+), 10 deletions(-) create > > > > > mode > > > > > 100644 doc/guides/nics/img/ice_dcf.png create mode 100644 > > > > > drivers/net/ice/ice_dcf.c create mode 100644 > > > > > drivers/net/ice/ice_dcf.h create mode 100644 > > > > > drivers/net/ice/ice_dcf_ethdev.c create mode 100644 > > > > > drivers/net/ice/ice_dcf_ethdev.h create mode 100644 > > > > > drivers/net/ice/ice_dcf_parent.c > > > > > > > > > > -- > > > > > 2.25.1 > > > > > > > > > >=20