From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6DDDBA0559; Mon, 16 Mar 2020 19:54:53 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 475FD1C0B6; Mon, 16 Mar 2020 19:54:52 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id EC9B51C067 for ; Mon, 16 Mar 2020 19:54:50 +0100 (CET) IronPort-SDR: mwxDPMJ/NnKVZTSimH4KOtCPD/E32PYQj1dGxDXF2GRbavUQg3Haqy2zcVVWXj7vATGmgbNEHJ QI02GwTvHG9Q== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2020 11:54:50 -0700 IronPort-SDR: 4xOqxxIwmKQWOcGSJzqITRhyLfXG2M/GzHFaSBqfyZCvj+1qkB1h6CRrbuC/AkKFwnqDs1eGd/ DaRqLDGJukQg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,561,1574150400"; d="scan'208";a="236106100" Received: from orsmsx103.amr.corp.intel.com ([10.22.225.130]) by fmsmga007.fm.intel.com with ESMTP; 16 Mar 2020 11:54:49 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX103.amr.corp.intel.com (10.22.225.130) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 16 Mar 2020 11:54:49 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 16 Mar 2020 11:54:49 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 16 Mar 2020 11:54:49 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.171) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 16 Mar 2020 11:54:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=REi+KLyLYGHQwUUnTpKYrk2hjCxHGqwzxBaDzvBxcEjhmdCaT2LnDoLnvj6GKNQbnCqb+e6jRID4uDdhX2XGY4fJCQDyvDGPrua3MpFP+TW2mZTdFEe79ztJhxjAYz9GesKydlh3h9XxgwljpI0CQbVOlXFIxhdqswflV8utELwKzmHvjgTgBq5dHVNxAGChO4EF0YJcwupzoLEGnfAqc3xjV40Zzc8nxdPgbFpVqIu6jptNiyh0qFDTpagriJy8rqGfS4OkvVh4P65pHxcyeNxiKqaqNo+XReredcXajplc09MELQPAhIb8ihTvKG4XGhYFvvdD07RD98leCAgrtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4OWqVGgi3xxi4gvcdUNexbQRdqNSzbvq6QSiF4LnxS8=; b=NFqEvXJflC+KyszHLWLhWQSHtlunb1yfTDetJ4Q2iViCwJGj0VkZZif6OjI50vVSmOXyMrtocJmTXjUv8NKH4IK6GzfQKZCv5FRLhcydA+HDoswKQYL8Jt+Im6ieStSt1dLjb2r2XMOa0SmaRZph+ar7M+ii9FBdwwv/U8omKE/+QiXbq3aNBjnQtB4sL/Fzi76gWjkM9SGwOqKk/BhGxAdL5Qdq8KSvq5ffjtgkdq4ezbQdibsc0x+GmrNyiPbtRQnQlYL+NqTgHqjECmgDuMCPkQdeBOOFlsh4VBb7ZCJL4dSpCoOyIy7wu95Ow5EqyKgEsGjsTX77LUXRR2GrBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4OWqVGgi3xxi4gvcdUNexbQRdqNSzbvq6QSiF4LnxS8=; b=puW5eA4fYV8yQVaqKKBoCXUevzcmls9ORLC48SguGvYG9I2QUb0SOzCaHhdQ1xGeBvMiiGQYUqyXHaCsHHScN/zwdSIxTM/7M6qBDlX8hbxStxXbJwST8kNnqkhTJqVO7RqTliq7oJCH/EwL2RCmtU3x5qYJN+agv0MXS7UzPps= Received: from MW3PR11MB4538.namprd11.prod.outlook.com (2603:10b6:303:57::12) by MW3PR11MB4745.namprd11.prod.outlook.com (2603:10b6:303:5e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2814.22; Mon, 16 Mar 2020 18:54:41 +0000 Received: from MW3PR11MB4538.namprd11.prod.outlook.com ([fe80::adc6:a9cf:a486:3f59]) by MW3PR11MB4538.namprd11.prod.outlook.com ([fe80::adc6:a9cf:a486:3f59%7]) with mapi id 15.20.2814.021; Mon, 16 Mar 2020 18:54:41 +0000 From: "Stillwell Jr, Paul M" To: "Zhang, Qi Z" , "Wang, Haiyue" , "dev@dpdk.org" , "Ye, Xiaolong" , "Yang, Qiming" , "Xing, Beilei" CC: "Zhao1, Wei" , "Wang, Haiyue" , "Liang, Cunming" , "Wu, Jingjing" Thread-Topic: [dpdk-dev] [PATCH v2 0/7] add Intel DCF PMD support Thread-Index: AQHV9qljPljSSGDfcUyQXpJG1Qa66KhGuKEggAIyHACAAqlUUA== Date: Mon, 16 Mar 2020 18:54:41 +0000 Message-ID: References: <20200309141437.11800-1-haiyue.wang@intel.com> <20200310065029.40966-1-haiyue.wang@intel.com> <039ED4275CED7440929022BC67E70611547E0B06@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E70611547E0B06@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: spf=none (sender IP is ) smtp.mailfrom=paul.m.stillwell.jr@intel.com; x-originating-ip: [134.191.233.108] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 46fd0ecc-ec29-4aaf-c295-08d7c9db7c6e x-ms-traffictypediagnostic: MW3PR11MB4745: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 03449D5DD1 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(136003)(366004)(396003)(376002)(39860400002)(346002)(199004)(4326008)(107886003)(8676002)(81166006)(86362001)(81156014)(5660300002)(54906003)(55016002)(6636002)(7696005)(9686003)(8936002)(110136005)(52536014)(478600001)(966005)(186003)(66556008)(66446008)(2906002)(64756008)(26005)(6506007)(53546011)(76116006)(66946007)(71200400001)(316002)(66476007)(33656002)(921003)(1121003); DIR:OUT; SFP:1102; SCL:1; SRVR:MW3PR11MB4745; H:MW3PR11MB4538.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2nMq+QZOS6dEWt8+Z14MfnqRuq3IdDQSaAOrAQTfPKYTPzKGvyT/uQ/eRqLuVGzMdvtxVtInS6PLvPA5hlVDhmlhCG9Ao3Q5oJAmvlzchHgGXN1v/qaXFIpfWs1c1n+D7mcfAf2IBvkwzti2ewtNoVRBMsgMgtRJXpH07rkyglojlbs+tNFZICk1HJkvl5zeFqFhyXRbbvyeWbjUk/a2gg4bUBKiMpsT6MjEumohEEqIfoRc2c06/RAZ+Dn+uRq+bqxOb7l6OeF8m2tsM4acK47OW4XDmg/zjrmU9dhzEF0SpOE20s6qJK6bFYAUfXqjYa2sgFbaMGwKeKcpkgLYAn+Ty8VEDVCCCvFJHCAHKN5v8kzLqef/Xcc9ZdVNaQ4nZGDKQ7UqL/61TMHHXuoWieEjPLrfynSLC9NCEItc5OMEV9OJ6YIXvujMfDmLgeBq1ZFo55OwYO+eMJyZT80zaDpWqMKGxgpSyGZvZoFLyBH1Kn9IPl4nWUy/CBsg78km2jzGBFX8DHzVaUTm0jTyA36LUYyD08H3On7Nw72Dozr7AJnQoa2ch0TCJIevuoEwHI5D6NplV4eYGWJ1TE0E3A== x-ms-exchange-antispam-messagedata: xA9/rJWrq3eqntCtcLxxGYi5zJQAerGVan8QBMf6WfeiPvo2QPQxrvVH9XTnXruMFUqRWPbi4Z06SdytrxbwD7Dx+UXu/F3WqLMYNCBQVmYQJKYK5DJhGk2XSzyCDMRpSwKTNhUvF3e4qSOegyIUbA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 46fd0ecc-ec29-4aaf-c295-08d7c9db7c6e X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Mar 2020 18:54:41.7196 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HY3assJ/8vKADQTSGqTH0clkbSnsP5Ak2ajQx/WjX95Y22LbGVvZa2PbHtEXyIMWNSpeIq/h1V4mpbjuHgju0QPOAWc3p5TfI8HaXrGiizU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4745 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 0/7] add Intel DCF PMD support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" See my responses inline. Paul > -----Original Message----- > From: Zhang, Qi Z > Sent: Saturday, March 14, 2020 6:50 PM > To: Stillwell Jr, Paul M ; Wang, Haiyue > ; dev@dpdk.org; Ye, Xiaolong > ; Yang, Qiming ; Xing, > Beilei > Cc: Zhao1, Wei ; Wang, Haiyue > ; Liang, Cunming ; Wu, > Jingjing > Subject: RE: [dpdk-dev] [PATCH v2 0/7] add Intel DCF PMD support >=20 > Hi Paul: >=20 > > -----Original Message----- > > From: Stillwell Jr, Paul M > > Sent: Saturday, March 14, 2020 12:19 AM > > To: Wang, Haiyue ; dev@dpdk.org; Ye, Xiaolong > > ; Zhang, Qi Z ; Yang, > > Qiming ; Xing, Beilei > > Cc: Zhao1, Wei ; Wang, Haiyue > > > > Subject: RE: [dpdk-dev] [PATCH v2 0/7] add Intel DCF PMD support > > > > I'm confused. Shouldn't the DCF be a separate driver since it is a VF, > > not part of a PF? You are starting to combine PF/VF code and I'm not > > sure if that is the correct way to go. >=20 > From DPDK's view, DCF is NOT a VF driver, actually it behaves like a PF d= river > with control path only and it share most exist PF driver's API implementa= tion It *is* a VF. The only way this will work is if the VF has the trust flag s= et and then it can become the DCF. You can't set the trust flag on a PF I d= on't think. That's the only way this will work because the kernel driver co= de has checks on the admin queue messages to see if the message is from a V= F. If it's not a message from a specific VF, then the message will get reje= cted. > , That's why we combined it with exist PF driver, so when the module > driver/net/ice is compiled into a library, it can be probed as a PF drive= r or DCF > base on device ID at runtime. > And the is not special in DPDK, for example, the module in driver/net/i40= e > can be probed as i40e pf driver or i40e vf driver. > DCF take SR-IOV's mailbox as a message channel to communicate with the > backend kernel driver, so iavf virtual channel is reused here, so we also= need > to link iavf share code. >=20 > And I agree, its always better if we can separate 2 different things whil= e > decouple all the common code into a share library to avoid duplicate code > copy (just like we did on iavf share code) But in this case, a lot of cod= e > refectory is required , so far we just take the simple way, we may improv= e > this in future. >=20 > Thanks > Qi >=20 > > > > Paul > > > > > -----Original Message----- > > > From: dev On Behalf Of Haiyue Wang > > > Sent: Monday, March 9, 2020 11:50 PM > > > To: dev@dpdk.org; Ye, Xiaolong ; Zhang, Qi Z > > > ; Yang, Qiming ; Xing, > > > Beilei > > > Cc: Zhao1, Wei ; Wang, Haiyue > > > > > > Subject: [dpdk-dev] [PATCH v2 0/7] add Intel DCF PMD support > > > > > > A DCF (Device Config Function) based approach is proposed where a > > > device bound to the device's VF0 can act as a sole controlling > > > entity to exercise advance functionality (such as switch, ACL) for re= st of > the VFs. > > > > > > The DCF works as a standalone PMD to support this function, which > > > shares the ice PMD flow control core function and the iavf virtchnl > > > mailbox core module. > > > > > > This patchset is based on: > > > [1] https://patchwork.dpdk.org/cover/66417/ : update ice base code > > > [2] https://patchwork.dpdk.org/cover/66472/ : iavf share code update > > > > > > Depends-on: series-8843 > > > Depends-on: series-8855 > > > > > > v2: > > > 1. update the iavf patchset link. > > > 2. split more patches for making this work be more understandable > > > 3. fix the log function usage, devargs checking from v1. > > > > > > Haiyue Wang (7): > > > net/iavf: stop the PCI probe in DCF mode > > > net/ice: add the DCF hardware initialization > > > net/ice: initiate to acquire the DCF capability > > > net/ice: handle the AdminQ command by DCF > > > net/ice: export the DDP definition symbols > > > net/ice: handle the PF initialization by DCF > > > net/ice: get the VF hardware index in DCF > > > > > > doc/guides/nics/ice.rst | 47 ++ > > > doc/guides/nics/img/ice_dcf.png | Bin 0 -> 39168 bytes > > > doc/guides/rel_notes/release_20_05.rst | 5 + > > > drivers/common/Makefile | 1 + > > > drivers/net/iavf/iavf_ethdev.c | 43 ++ > > > drivers/net/ice/Makefile | 6 + > > > drivers/net/ice/ice_dcf.c | 651 > > +++++++++++++++++++++++++ > > > drivers/net/ice/ice_dcf.h | 61 +++ > > > drivers/net/ice/ice_dcf_ethdev.c | 321 ++++++++++++ > > > drivers/net/ice/ice_dcf_ethdev.h | 33 ++ > > > drivers/net/ice/ice_dcf_parent.c | 344 +++++++++++++ > > > drivers/net/ice/ice_ethdev.c | 9 +- > > > drivers/net/ice/ice_ethdev.h | 8 + > > > drivers/net/ice/meson.build | 8 +- > > > mk/rte.app.mk | 1 + > > > 15 files changed, 1528 insertions(+), 10 deletions(-) create mode > > > 100644 doc/guides/nics/img/ice_dcf.png create mode 100644 > > > drivers/net/ice/ice_dcf.c create mode 100644 > > > drivers/net/ice/ice_dcf.h create mode 100644 > > > drivers/net/ice/ice_dcf_ethdev.c create mode 100644 > > > drivers/net/ice/ice_dcf_ethdev.h create mode 100644 > > > drivers/net/ice/ice_dcf_parent.c > > > > > > -- > > > 2.25.1 > > >=20