From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 448F843CFB; Wed, 20 Mar 2024 07:25:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BDCFD402A2; Wed, 20 Mar 2024 07:25:44 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by mails.dpdk.org (Postfix) with ESMTP id D8D0140298; Wed, 20 Mar 2024 07:25:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1710915943; x=1742451943; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=9hovrKuP17Pj24TCyeJgErpD5hY0sRC6jFGkUNNw4u4=; b=EQb34LrmhpkvfMykBOxiX379Yk1onDtdzEZXFfTpiMKl16cSvrF3bJCv y/yI/6IR94mE8N5hwzu63d4qJ5zJNgpks+7ou13pjjcSnG4T/s/uFxOMZ zzZVUGMyRnCrcW7A1sagj9xRahPh/Kq73M1qiIhLJMq8Zzwh2+T+fsb4x PM8NahwdMbJ2OE2flVK1V8QFsHF3XB6PmtoXDYxfCArz7d5G2MvfNJ90i ZTTCRKFY/48O/NrRqjSpCghl6hCt89bHSrsMYz45Ry79uQEpDn/OYuTzd LWpOzx5es9cwCTdE0tAFvRp976uhkk2aX9CRdf43fmX4oHom4DogNsDc4 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,11018"; a="5759324" X-IronPort-AV: E=Sophos;i="6.07,139,1708416000"; d="scan'208";a="5759324" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Mar 2024 23:25:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,139,1708416000"; d="scan'208";a="14078348" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orviesa009.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 19 Mar 2024 23:25:40 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 19 Mar 2024 23:25:39 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 19 Mar 2024 23:25:39 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 19 Mar 2024 23:25:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RD1AFdUZyocj5DD8r40EWBessFfcU+o7hLO/FUwl7XtH78sUGPbJwy9nNxoPwnXGU+1230pX6zrkb79w72PK0fycC3GkH5LGr4RU84XNnXTj/TRIjQCJXFeLrgSE0wxYUym4qX6EEyfDFPdmSDiA3pvuPpYooqdH5RM5/MGNuaPaiQYh58FXt7++oLlDSPTOaKxxQQ7d6g7xnEkZceOKkCDT5M9l0wiaWwq4sIAu+7mtyiFK/e7Wg59Oc/ylwa4hq1m1l6tVKX86Wr7hYGF31NNLAlemBAguupgWuHtONPupdnT/9hdZN5d+znA1Xr5NxlGpJ9F3FTXyYSWlNdrl7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t55p4wLH0s9rDqzuESoSyxHjQSkQ+Q3d+bpODZ5qJsk=; b=QjiKLck97sn1ou9l0SNCc3stqKO2/r3P+QWcAZRPTbRO/LaZuiAu8xJaUKHiruBhYQudFS3fIxnV6RCbwE5jHm2N5Vs29Q4VvGLuECbnMDbExfSm3I2+k1i/f4p27o8EbuwD/yJC29Sue/iPBjLRoW8BU1qt/P6A93e+tFgUmcAWd3GoKzg8uuRNe2i53RyG63DRjGTYYINRDoFhgvZDsRlaKxyq+pcE7a4V2eqAT/4wwUzGt27pwywR6Ns4BqyBCTxyV4yWqiu1PL/rc8WXBdf0qnv9TqrOb1Laccn+qd7cC8aTcJ3kQvliJvpkPINny3poqGTV0agcgsPvypz/6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW3PR11MB4587.namprd11.prod.outlook.com (2603:10b6:303:58::7) by DS7PR11MB7740.namprd11.prod.outlook.com (2603:10b6:8:e0::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.12; Wed, 20 Mar 2024 06:25:32 +0000 Received: from MW3PR11MB4587.namprd11.prod.outlook.com ([fe80::a473:eb2f:6bfe:7d7f]) by MW3PR11MB4587.namprd11.prod.outlook.com ([fe80::a473:eb2f:6bfe:7d7f%6]) with mapi id 15.20.7409.010; Wed, 20 Mar 2024 06:25:26 +0000 From: "Wu, Jingjing" To: "Yan, Zhirun" , "dev@dpdk.org" CC: "jerinj@marvell.com" , "pbhagavatula@marvell.com" , "stable@dpdk.org" Subject: RE: [PATCH] graph: fix head move when graph walk in mcore dispatch Thread-Topic: [PATCH] graph: fix head move when graph walk in mcore dispatch Thread-Index: AQHaecXhFEhPkc/mYkecqf+zpMvy3bE/+x8AgAAvg/A= Date: Wed, 20 Mar 2024 06:25:26 +0000 Message-ID: References: <20240319141454.3275543-1-jingjing.wu@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW3PR11MB4587:EE_|DS7PR11MB7740:EE_ x-ms-office365-filtering-correlation-id: 6bef3928-3f4a-441e-2a07-08dc48a687fb x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nmLOnQN+I6eNB3oMUDwfszi5mZbKIMqwVHuXC23dxyvyztGGiEwbKVR4jRcMR8hfnfo022neIExhYrA4obyDSIxnr/KnSk4v6SJiu8mAR29yjiutc3COLqXL3E72Ms22Rr+t5s/tZfTCN4MCK2o6eeX+3W1sPjzmEGJkOZquC37HV6GR43xdwI7GB5ZKDbJsKYSVfBW86gLt8/89/s6SQItEoQg8sf5JOaykHZMQUdHqUvkJE5Xoy6SC5E3VbafRVB3hamwLK/ccnnLxwLfRUUfQJ7YVDX+Gc8z+rrp7UvfFSWz330iHfcYStNz/8aBWV7sx1Noe4hEAOwSA1ap021bgqqHWpnjTvXxpdNXgtlfaKpzuDGBX4gNZkCh9XhR3zna4U+dYGvZF15avw4YaYhKwruihN93uSBkwJOlYDpFPKppvQ9ZDjgtov/BVj1naOZdYEIs/N8zB1/xUgHxYchpxtGHLHDi4k+Evz58/exMJrNAyxQ/psK9HOhCDiwu3pOszYWfaexsveSICTkLXxgJDQaByXpGWGWCrveIHTLOy6G4PGGqh0HDlPbhzLspPwurM1S2TSqIX55u9d/p8F0eiKR6iAG1sU1OTYYY0yzysDm3duWPI9vLuSUOKAVoR49XvH4hMbfzuux2GkF+4rDAutT68mDH7FPFtkOPKzHailNgb4XSsEkhQOUuKkzn98G8l3BfO5xmvYdVD50lHv1uS0kMWIVRAdXKQ4KX6nz8= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW3PR11MB4587.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(366007)(376005)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YFbmtMuoiGUCWlr7w2ggQ+js6E8qQnPttl8K9IcCk8A/LxwFZEC8KeEJ08vq?= =?us-ascii?Q?OxQSvwShZz1RBZb6oJL6TZWU/5iBGteUwNojp/GPN3OuedlCOhTrevFuMR3c?= =?us-ascii?Q?QfDyxw0e155u+5Sp7p51dD7tfUxojvjEWh3zC2ymsJvah4uGiOhze0csW/OX?= =?us-ascii?Q?rEtcQ6PDUOO77KwkxICSGtFF+GvLDMEbHehUkEx31q9HPs98EOGQTYkkQe3v?= =?us-ascii?Q?NP7fjx4HN9mw9lUuvtXT0QllT+Mew84LfBQgLuOuoGrZpdmPqgx31OpLoCi6?= =?us-ascii?Q?KCubrUsbfZgwYw2FPRZQp6cHNs6BxSoMKhEYCRgcZJsUyXnLPYoyIU6wNpos?= =?us-ascii?Q?OCjH6KQ41LQwciu7bPSufSWqEEHRdABvSrv7wJ6VfEM3Ciggm2BI58qkRtU2?= =?us-ascii?Q?UkDy4iv0ITtlmKJwFeqmKDvTFVExvEangOyC2hvnZdNao0UG2RxM+XG4Iu4k?= =?us-ascii?Q?qe2sud5KglgNUpBq5uR8SVjen59ki/+pJ8BfmfuPNmU/vndlIcyigW0PYpol?= =?us-ascii?Q?4LobM6mP94MIvvqP9DOXjewciE6pfd8qoo3AwW04GkF67QUR0uGf4IwQVtPt?= =?us-ascii?Q?S0LFYeF+4RzEMkxKXATTiBYzArm2RnThb4XGwpeTPXT+hn5cH5sX0OXMW07r?= =?us-ascii?Q?c/jbDTyb9mSkPAL4ZxXCLe3xZOgBYwRp4POki9ev60OEeeU3LXESNrW2ikZm?= =?us-ascii?Q?8daSTQAV/nHITDyFNHTXjgVTaZVgP3JiuZFlE0oF2XP4yZa9c2wjPJ8DI8am?= =?us-ascii?Q?z/tBg58z3o91530TpRrtJ5C5Hacln8WHYf0yIANe5jPUtf+th+zDXH8rxJpW?= =?us-ascii?Q?fq9DlDTgNFP8n1/6B6MacttqoxDAgKZDuqun6tm2GRzQoMvqTkP47p/m3+HI?= =?us-ascii?Q?knU8S7ac3JgX8O5qa3Kvmks3tRLezy2kie3csrUCYepznovc4QYNmOqCcTR3?= =?us-ascii?Q?BFoYcl/Nez1buIM7xXxwyrJgXrW6o87pk9qLmAiQO7rTjQjz420SZoL01iXI?= =?us-ascii?Q?1RcpqrZUi6vJge9+RWzHV6FjbhqlKWZ+EuGd22HumRXz9xb2ZGPVEHZZlrSb?= =?us-ascii?Q?RODH8zmsQvQOeWEzftCqHs/9vvRV5xDDXU852ROMKZuDJcte+lWEVsKdq9FN?= =?us-ascii?Q?eTYWxZxP4josiGSg9GhjAExi2JeQPgGEl8seZg619YCSDMyLxydWbWSguQfB?= =?us-ascii?Q?fRXjmZz2R9IFQfVqFQ4jEagEfZCZ7a7oGuoGPNSMvivt2H4jZ1aY4zm0gU/k?= =?us-ascii?Q?aPQGYFMUjeeITxgYvyQ8dFdzoG+d8SArmtZ2CTWz12LlbVYSgbIdgLOUDsJm?= =?us-ascii?Q?KW2dxbsAjPAjIl6I6syPm/zdCn9mBTFelHx1FPUfca62GzDpkwVfVwUegZ/A?= =?us-ascii?Q?+Ztq7Q3tRiDGvqYapwQwcoi/PTwflKufOhgaJNLOoExE/Eabmshw6XsX0iT+?= =?us-ascii?Q?tt+y2/fmqGcgIwgB2rPRI35+t8TqAi400qmEHdBdwP9krxDsrDcmuOZo4NgX?= =?us-ascii?Q?DbcVmAMwUknyhdZtLiCSclu4Z/nlTAzVSJhhuopQMJQygY1mjMzIzovUJNgv?= =?us-ascii?Q?EXebMEirj12Cw9/Smehe3z7sZEdAmqRfZ832/jjz?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4587.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6bef3928-3f4a-441e-2a07-08dc48a687fb X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Mar 2024 06:25:26.2790 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +ONx4SS9kE5cQVkutqiMM+oXKGdGxMs24wDzwf/rio2l5AtvebPM4sJl732Paqr/8rQlT94Nvk/VVXK+m9kSgg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB7740 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > /* skip the src nodes which not bind with current worker */ > > if ((int32_t)head < 0 && node->dispatch.lcore_id !=3D graph- > > >dispatch.lcore_id) > > continue; > > - > > + head++; > If current src node not bind with current core, It will go into infinite = loop. > This line would have no chance to run. Seems reasonable, it might be OK to change "head<0" to "head <1" the condit= ion check?