From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0EB1B42DC0; Mon, 3 Jul 2023 08:53:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5CB6641143; Mon, 3 Jul 2023 08:53:36 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id BF3A240156; Mon, 3 Jul 2023 08:53:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688367214; x=1719903214; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=DzEKGl1qCIRH7SXM+5YkaT5mM2cOruCdFVqQx52sgCQ=; b=LwbgG0qa1pXCoL1jongSkMO9gJ5TJg8CZky5tbyBSo0D5gbReaEuES++ I4toQPwp9VOAYsPLkwgvAyZAFjmtd4M6z3uzo21gNNoAMvl/1e+TXWwfK BwOivalErrJaHEEErmbCj4/ESRaNOqgtAocVAJPhgXD9Q3L/irTxcu2JG wXPcYVbV4aSDG3l62YMY8lSbCuLt3bhEsmd+RKRNnaEfGItiyrPpKMjSz oR9yaCxH9AH4jmR0Vr6p8tpvdSfZEboVLk8EfnO/NOO5m98TmGgqM8CP5 wVW1ukQNPsmTNSS3o3Crlq/BPbOTLVjpE3QDmlcaVVtc1QfcIhz5J15ka Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10759"; a="342398898" X-IronPort-AV: E=Sophos;i="6.01,177,1684825200"; d="scan'208";a="342398898" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2023 23:53:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10759"; a="831701858" X-IronPort-AV: E=Sophos;i="6.01,177,1684825200"; d="scan'208";a="831701858" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga002.fm.intel.com with ESMTP; 02 Jul 2023 23:53:32 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Sun, 2 Jul 2023 23:53:31 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Sun, 2 Jul 2023 23:53:31 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.47) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Sun, 2 Jul 2023 23:53:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dFcsiubOB7YFuihuMPQQRyoWKT+3JuzOiMj4NnsbBo89Qq2wR0jqwm7o+xgcGoOGf+kDPTo2WEHYajfk0s2Q4BUs1vXkY8ZxupnpXAjvsvvFpaqva4HY+hun28XlmTjy2MiD4W2fOaISX3479JZTAt9JB/iIOzQCoIQ2220z4xiztaXmC6VnojEauXIyiXY1V4vVwaRqfWRFitCiaIA8/eniAaZABmfvut12xFyBaY9kbxoBZW9UkFvHyT1oB7E/HRd89k9tTvLAKwoIhGJo8LnYLe4NnDfMaEk72YtCMBxJ9U0Jk438KYV29K+ME88zfzrBELWxC9bXuFJkp9D29w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DzEKGl1qCIRH7SXM+5YkaT5mM2cOruCdFVqQx52sgCQ=; b=LPZBgmoKxFdUsmBSTAFZ5HprKYy2uOViivWrvqZ92bMuQNNrdwdxLUqetbHgm8xfUj0MQPxfaM2gWVzCnYhyZM5oXaZCH6AmM7RnbatisWWz7p7tpWuvsL5y5xBxHFDFnnU0Z6+c319/QSMX67kQ8AsJ48Bm7ckNAizftrf179D3i0EMgoAZyPUKHwhpYAUo8SP1lPVOZF60v2XxmALMwyDFfSvh5pBzULuocekfzzwgXAxWMROKNkP30i0YlQ6cbNufBiDA3BX6pzO5LaOG/u5vcObfsafe2+Vu/KPVyl59B1V8SPZCTnH8+J2MxOf+62EtUC66KPNczlu22DC1wQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW3PR11MB4587.namprd11.prod.outlook.com (2603:10b6:303:58::7) by DS0PR11MB6493.namprd11.prod.outlook.com (2603:10b6:8:c3::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Mon, 3 Jul 2023 06:53:28 +0000 Received: from MW3PR11MB4587.namprd11.prod.outlook.com ([fe80::65eb:f79c:dba3:873f]) by MW3PR11MB4587.namprd11.prod.outlook.com ([fe80::65eb:f79c:dba3:873f%5]) with mapi id 15.20.6544.024; Mon, 3 Jul 2023 06:53:28 +0000 From: "Wu, Jingjing" To: "Guo, Junfeng" CC: "dev@dpdk.org" , "stable@dpdk.org" , "He, Xingguang" , "Laatz, Kevin" Subject: RE: [PATCH v2] raw/ntb: add check for disabling interrupt in dev close ops Thread-Topic: [PATCH v2] raw/ntb: add check for disabling interrupt in dev close ops Thread-Index: AQHZqaCtsetpaYHn5kG6Fr/9YL/CBK+nosHg Date: Mon, 3 Jul 2023 06:53:28 +0000 Message-ID: References: <20230614051423.176572-1-junfeng.guo@intel.com> <20230628091218.32292-1-junfeng.guo@intel.com> In-Reply-To: <20230628091218.32292-1-junfeng.guo@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW3PR11MB4587:EE_|DS0PR11MB6493:EE_ x-ms-office365-filtering-correlation-id: 80f47d50-e98e-4f41-3e16-08db7b9234e1 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: XBgAeRgE5yddYLQ7Kq0xWnLzEJt4L9xlr8cm/8RY02XhNOgz5fxi0ylYnzbW81yGt/cAhmy9h3g3AhTCMS9f5Xqhgm3wCjLujgG8jg7A4cE/r3XdVTi/aSd2LmVWOBFK9Xace6PC7/QbNiqYFiGy/8M4XUiy9cbXOcjWMZWsOnrZWDBymK9mnSdqY5x28ZsCSvVkRb1KWpA7H8ox/IohoEFTTzse5cdC+qhJIiCR+Iquxcgnl/qvyC2a0ZuF8866sZ+nScUfOJySAz0PGkxI+a731A5linAmvlbWX5cyR3eKneAhXcsoClT4xo2PHTlgcte5wng8utgVDuIF0gkrdczxyprlRv0gMCglj1CTYrwdQxAmDTrTaZFJUKKKseEgc8MSY3qWIZEONH00rq3zH8FW1kH/tvyXxIdzyihp0urO2K0r8qxlOKtVV5E24mwRM25bkKT283wxOEtdeRcnrv2Dnh78Pbmjz2qA90KcKZw1Vpx4fZvSy8qGGJHevcyzqCqQP93whnFwUG7Nqm6pq/OxIP7fHW/lflUohvzGDEEmsEgK1F+QmV3ztvai8tl8xJtj+7ygcyI3vDgyECE9APg47EFmebAUbwzkwHz2PdCsqIR6WanrYn77h6DzI3jJ x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW3PR11MB4587.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(39860400002)(366004)(396003)(376002)(346002)(136003)(451199021)(38070700005)(4744005)(2906002)(41300700001)(5660300002)(52536014)(6862004)(8676002)(8936002)(33656002)(55016003)(86362001)(186003)(82960400001)(478600001)(107886003)(26005)(6506007)(9686003)(71200400001)(53546011)(7696005)(450100002)(122000001)(76116006)(316002)(6636002)(4326008)(66476007)(64756008)(66446008)(66556008)(66946007)(38100700002)(54906003)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5GcGqvBCCYPGlGcRgolA9iHAQHGLohKAN+Z/h+9EoGzexbTOWXEbuDWKH36S?= =?us-ascii?Q?Rg1iGEd1OlyaPNPckWzccCUilzPw+Ksk6bIHIVdcww860Y2ElpGHruSWXI3I?= =?us-ascii?Q?rNnrb92+ByfhTeFTULSMfyS9/V7XklA3jpVUBI1s3NhkOwM7kLrHMdB+Ly/I?= =?us-ascii?Q?PZUezqNY/yw1gBvvep/qktNMht0JTVCG6O0oeUL7/sLJQfcaer9z6G/28uX5?= =?us-ascii?Q?TrIBDq+gX7F9RZhsIkYW1/lfv2Iv5+Uurvnce/8ud0AvGUdbBbcWNs9f/bQR?= =?us-ascii?Q?JOEDVSTYnCCUas+3cwnXtKSeucQ0yc1XKi2/1/W0SZyyWxFsUXjQhXVLEjoI?= =?us-ascii?Q?upM+LmJ9OpLwVby22KpdITQEOhsFhFQDyHQ+ofTXPJc6PBT09Cba4QvC8lmj?= =?us-ascii?Q?9ez0A/ST0RoPwALXebAnubDbW6C4blblTffISkfmXZRtxhHlBdIccemvWxlO?= =?us-ascii?Q?WMUKidui1rdRNfekNBUXW7aglmHCFvjGm9neWM8E9yjpvEgNve0Sq3lM+JDK?= =?us-ascii?Q?Ascjq/r1u2yYQ3w1BvNgN/eloIlGy1iokj6QI5AagtJY9zQfXKJqNBSUsrBN?= =?us-ascii?Q?DKQXMD1jb4uGIaBaa3vP3B7beJXXVTFbCUz/XIDcXYFyN4BTwYjwHu1YObRE?= =?us-ascii?Q?TmRuVXw3acdZD1k/e+Ez8js3tR0gVtGZ3EqN8jMp/0/E15l98aVHpjF/s0ot?= =?us-ascii?Q?9bPsxJ4g/RUZpQ7E7WD4ew4fEcvjPmuDcIVOcFy3q8Qk53NMn0e+YU5/IMa6?= =?us-ascii?Q?rHqGgSH9LgNmZiZb5QZN+rHM6X4aTeRDf09FTIhynn08UQDMnGKKdev+b+yJ?= =?us-ascii?Q?raq+TyfbxgYz0XIpvcVg42jzWw7Cxr8drqQ6qkVlDQ5nfGfv998vQXRphjSv?= =?us-ascii?Q?HqRwmjkuWlLze0i9Mbw3I1ubNXSqowFDLhx/8aYZt9qBLQy3w3edStuGlUGw?= =?us-ascii?Q?PApkcJQtyG6Ts5wTbYULsEj48EBGNbtLoelVDe1RKjBcGEVJTCYsnOdp50sQ?= =?us-ascii?Q?hWOVRLBLw8kNdDqDvPmGusFYiHoi6kW935yHDTw2hdPkKEwXCIOFd2USu1w9?= =?us-ascii?Q?62U6hKTunO+Jqe2B9H/3/vtnIFFVBmTNMTp1nFzrO5QQqIqNFjGxqdTrswSv?= =?us-ascii?Q?axeqrFeGzqfWLlVhnrcCwgrdmfp4znftZ59P17nvqi8mfPthc8FasEqdPkTp?= =?us-ascii?Q?ob8geWzy5Q9DwB+Rg8GU8SKyZRz8L56adlL+XpBi2+A2iuBpSLPOYro04bVA?= =?us-ascii?Q?KZ4ggLPYIfWLnYvfuWsj+nPkn6gSgDdIy5SI3sVCBpjm5Yr9dYUpQcCoOkfh?= =?us-ascii?Q?P8lRa9hHDoFrcy2vJHAEEveR4S66vk94zEsKEaIYmp51B37l9TvMDhyWncK/?= =?us-ascii?Q?0bIQk70xo+6E2lpOyquENqkkY70YA8tZGe0speq9ppq4K2oG963cm0MPJLAd?= =?us-ascii?Q?hndD2yCzE9GKCNTNPCusPXWM4KYcTrRQ8ubRRhX7g66qXWnYCD5eS8Kpez0o?= =?us-ascii?Q?fx/gmQe2078tE3WC9pjHRBmcqUaWzfrYQEq0dt6PnE7p16kVW2zA4j6bn8Ud?= =?us-ascii?Q?RFyeRwdEixohpfO4idCUItJ1WRLs4cEU9jJDgUzA?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4587.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 80f47d50-e98e-4f41-3e16-08db7b9234e1 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jul 2023 06:53:28.5439 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wPfLxbD/GfKSX4x5GzGyK0fr4u+XpGFfX510KX/McVxylZxfoQKb2QoiiVPirINDVLIYiLhyrUw/lsBFu5CJRw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6493 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Guo, Junfeng > Sent: Wednesday, June 28, 2023 5:12 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; stable@dpdk.org; He, Xingguang = ; Laatz, Kevin > ; Guo, Junfeng > Subject: [PATCH v2] raw/ntb: add check for disabling interrupt in dev clo= se ops >=20 > During EAL cleanup stage, all bus devices are cleaned up properly. > In the meantime, the ntb example app will also do the device cleanup > process, which may call the dev ops '*dev->dev_ops->dev_close' twice. >=20 > If this dev ops for ntb was called twice, the interrupt handle for > EAL will be disabled twice and will lead to error for the seconde > time. Like this: "EAL: Error disabling MSI-X interrupts for fd xx" >=20 > Thus, this patch added the check process for disabling interrupt in > dev_close ops, to ensure that interrupt only be disabled once. >=20 > Fixes: 1cab1a40ea9b ("bus: cleanup devices on shutdown") > Cc: stable@dpdk.org >=20 > Signed-off-by: Junfeng Guo Acked-by: Jingjing Wu