From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D594E41B9B; Wed, 1 Feb 2023 09:48:54 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 903994113F; Wed, 1 Feb 2023 09:48:54 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 4C3FF4021F for ; Wed, 1 Feb 2023 09:48:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675241332; x=1706777332; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Le3/bhPIOXZxl2Y/0mqqBLAggK21lGrhbLTkX9aAJzo=; b=VduekzyZKnyxQh7Xq8Fw4aG5L09iLhNx/bJ1rzHH5+YrWekP0Ug9oL1Q 4ckp1F4q9SBbg03lDmS1c6gSPdC1TcuGjpayNRIll3qCABgE5I1CqIPJd HJRN7tMStjRO4WAWSxG4GzSQ0ndc5fPzsQ6myIsQlZ3ySl/wXnjoFsqEO /cCK2/YMf9ZCmc6DcwqaHM79GT5Nu2KrO6pWvO9XLX64VPbs6SRufkKvy 6Hc9qcmxxC4Njm9E2Dhkj7SlEW8/aHGjRcTs6d14/6OomTwPVVAyBUqJ/ GXKxQDwHrrSkGREsRuj4z49AsZ9qQNOWtqMJoC7/Ze12lDzM6KB6wtNm+ A==; X-IronPort-AV: E=McAfee;i="6500,9779,10607"; a="308432324" X-IronPort-AV: E=Sophos;i="5.97,263,1669104000"; d="scan'208";a="308432324" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2023 00:48:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10607"; a="753597365" X-IronPort-AV: E=Sophos;i="5.97,263,1669104000"; d="scan'208";a="753597365" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by FMSMGA003.fm.intel.com with ESMTP; 01 Feb 2023 00:48:50 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 1 Feb 2023 00:48:49 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 1 Feb 2023 00:48:49 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.170) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 1 Feb 2023 00:48:49 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MUMpq5f7QDktlE3MTjLEI8GUxjANQCxgPRdppAjmR35imyWCmJoR9UUxcEHWzffy4xNhmKLclU95qc8qEbB/KQnBaoCdLPksBNP8zBdq4WCHQpmUwrvEsJ791Na3mj1S5xV0eGzMIKfY8kUXK1UGDBjNXf3gbtIY1ORiaS76SnJji4CKas6ePLRPyXA92ug/dgjU2w0BezEshgWcuRUC9q2IJMym1+w4zjcCLR4dKU8lZb5obIsUEDNWe3lTlES4zODUYDj0K/ZBj7ATn9tOOAnatm+gTncT1wsGwoupxK8GKTJVepX+2LnMKX1RVHsUgnn8Yb0liiTvCItOYDAD9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4gDMUMLr0PMMvdR2yqbHQ5ErbPof0iOGzZqjIcI5EQY=; b=FEkk1u04CllQTVsPyQjkggtdFOm8fa50OxxHqE2yVrr7eLCtpDUYxVMgKHlI9H/ttCVpH3Gt+QyKxcvvuS064IsznZGLqA8M+bAVC+l3zIH+SJnlTZCxX+sLUACRWRcch82+dV5KMEOCrg6U3lFSEh7MLtXUOW5sOy+XDWRprsoTghAAz5NZpG0g5L+xmYWrFHbdXJ4WB6iI7gENhzvoUH03I/ZphS7V8X6vKpyG6QelHhUm5gZDxDP8mwtN6HSD0dUs7AilPYKVBC5JkgjlopPZVBmofWUSoGcP/Qenmm7DZS3aBH9mGJv/Gm9ouH6mEswQcJZehb5y/V19BbAGiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW3PR11MB4587.namprd11.prod.outlook.com (2603:10b6:303:58::7) by BN9PR11MB5434.namprd11.prod.outlook.com (2603:10b6:408:11f::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.24; Wed, 1 Feb 2023 08:48:47 +0000 Received: from MW3PR11MB4587.namprd11.prod.outlook.com ([fe80::8b2c:e748:6431:3cb0]) by MW3PR11MB4587.namprd11.prod.outlook.com ([fe80::8b2c:e748:6431:3cb0%4]) with mapi id 15.20.6064.025; Wed, 1 Feb 2023 08:48:47 +0000 From: "Wu, Jingjing" To: "Liu, Mingxia" , "dev@dpdk.org" CC: "Xing, Beilei" Subject: RE: [PATCH v3 1/6] common/idpf: add hw statistics Thread-Topic: [PATCH v3 1/6] common/idpf: add hw statistics Thread-Index: AQHZKxRaMCzCAIeYn0+xS4HmSP+JUq653Gig Date: Wed, 1 Feb 2023 08:48:46 +0000 Message-ID: References: <20230111071545.504706-1-mingxia.liu@intel.com> <20230118071440.902155-1-mingxia.liu@intel.com> <20230118071440.902155-2-mingxia.liu@intel.com> In-Reply-To: <20230118071440.902155-2-mingxia.liu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW3PR11MB4587:EE_|BN9PR11MB5434:EE_ x-ms-office365-filtering-correlation-id: b97e9c27-341d-4872-0403-08db043121c4 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: X+wJnsXHzeqxXq7l3nNEafXRwAfiGS9GmHsUV2Q9KNpuOXC9aDMWcDIJKN2pVxzC/KYTqcw8zouS8+zgEMzR0rbXYgE9TWtMq1gGF/GPGarIzVWjku63caSWO+wRrWzz1OUtbl8wWbLXth9PTD8fPWZUgV7alLA7RkcuQdO+Bnw3/scKgW677g+fhJ/ZGUgb31QuzlnJYIBlBuoYdb08I1Nj5YEUjuTQ+JZ11um8vfKDU6cztCH1LFQGecSA/upeckck7UbD7Z6cRCeRF3Esr8JGVBJwiGHXNNtE6z/F1hVpbE8pNugjYtgbnsxenWJ5UT/xMtFBf/JZvlSuWk4ek6d3SUAo8EEg/46RP5ZmapsD6od9CUg21NzveS7/D90QT6Ymmrfiga34kvcRM3HsiJ0+/auwi0WrmGRPixdXlpWRg1UPHXny/F0ZhPU2Lz6yrfy6IHIVGOn7tMqFddVRiFgjaSU7LDxODKlJElcbBtvIaL4lJyAEm5KohrLaj0dDbKu0iyHByYRXcGFYtQ5uRT4QEUim08wziAjzxse7wPSUhgHYz0aQSeJkETLOzpJ3NOftnj8vpHwxTU3EEwnsT5bgkggwP1GG6bsnd7OWR7rkqyiIHN1Ci3+Wnw5wmZMLE9vGA4h/FC7Tlkl/M1RPDqf2AHAGIkxlAyh+N2DCMtiT1/EY53WvbccOAWMpMmBhBz60Rc+vjzWKJQegSJhGXQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW3PR11MB4587.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(376002)(396003)(346002)(39860400002)(366004)(136003)(451199018)(186003)(9686003)(38070700005)(26005)(66446008)(4326008)(76116006)(6506007)(64756008)(66556008)(66476007)(66946007)(41300700001)(122000001)(107886003)(8676002)(8936002)(38100700002)(71200400001)(5660300002)(478600001)(52536014)(86362001)(82960400001)(316002)(2906002)(83380400001)(110136005)(7696005)(55016003)(33656002)(4744005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wrJox16NwkxNvkBmY5AMGbNrxC/Ji8LdNkZ9cgR2LeYsHdJi9Enw8SFGKyhW?= =?us-ascii?Q?B28GifDmibk93m19Lo3dVK3Mo8vmPRV8xiiF4QFI7q2jbE0eUHLoZFlT2qoa?= =?us-ascii?Q?+5JA/bDr4v2xHc3LVuGjJLbnUZhn2awnipygRShl7wBXSMO1rWK5PF1dU4y/?= =?us-ascii?Q?1NMe4p8id3kXSMs5RvAg3WMvq2ucF2paWbUvYt33txHq2aff96/QgkU/UKpa?= =?us-ascii?Q?Gd7R1JxakQRAiP2R3Zg80Ql22+fDHmFgkZt6DTPUAcxUSiXl6sQGJ/6McWru?= =?us-ascii?Q?K/Zq5Ch95YqTro6h5iIgeoA61oLTPLVKMqSStmORnReTHdm3q+RtwAblXLYk?= =?us-ascii?Q?vHAZpzMrQ6is4iT47FcvyBSt+yY+OKZnD4tnWQN+P6AlMuGi1tf4GnA0LD5F?= =?us-ascii?Q?RMNECS00pBpSUzxMsFwYRa0AlmIiRPR8dYJFdEKBzMlOFkic1pQVX3mIfB70?= =?us-ascii?Q?EUryUg4lhQAhxRMOaPvE+sT8zdwFGaed69yNKitXxOk4KaNRoh5j7yKtqJC4?= =?us-ascii?Q?NYQALBe+r3r6v9oMtsEMf7SSdo1C7+xQK6wAQLnuvM+p86lBRBEhNM1zNBI+?= =?us-ascii?Q?6QthO4qeR0EKev9bFHQOtfjExquKxwCaEw4jC9klPCFFunHi/ESKegcnSBNh?= =?us-ascii?Q?WK292OvW31BpLg6BX+BQEN01DOJPoTw+uYKG4XfwvzuWEBKqWfM9UjupMzmL?= =?us-ascii?Q?QPHSbkythh4Vht6iisGzgA+/NNxMDTs+SNZVmutv6gYRvbjcBQHF3rP3g2H6?= =?us-ascii?Q?hzZxeWMB4KmBrh3z8BtrdUpw/P7OeH6Fftfu26azZMOvr/tdnj1QynSPJC14?= =?us-ascii?Q?eB9cnIWlyNNtT0RQY4IZIu/SoIFmnb+xtR94lFhFrmaDJeBzWQCwu/oT1sOz?= =?us-ascii?Q?pz3xHNXigfRnTMexBZgrjs/v2Y6vI0PFpHN8i0LnTvw4bu93Ggh9N0Z3B9vz?= =?us-ascii?Q?mCkX51f/5lVPGKBJwLWxFGVs6cxhaDD11hflKMmVfG4eUTD4BYGbjES++Q06?= =?us-ascii?Q?lE+pWCrLxW3RA6bNlbnSQt8smQA5/EuFqlxMrda0yYRxYWNKinNJZH4TzRbk?= =?us-ascii?Q?O4x3wH1VoZRHq4POhLKwa4c0EQJ13chb6SwBNdSDvmPwmUsWik9i7qvJJIse?= =?us-ascii?Q?+DJ41MgO9yoEQeH4Ta9PaAmaBZK1c/nInmR8IMfx8EnWcfjLO0ReVWOypqdO?= =?us-ascii?Q?6z5jo4tj/JwNwS3jo4pDRWueDy+uKlxJUkVRhSQY5XAz3ePnj3am8IxFTenq?= =?us-ascii?Q?HZSjC6+Hfhmb5/1io6S1Aw2dkENu9z7CrW6SfQ9gpyrulrA33rS1vT8xJFPo?= =?us-ascii?Q?BuQC/AYafz4tcvh8kDUl5lAsdURGwWZyxp/MPCooHVTDD3p2OFd0Pu0QoDll?= =?us-ascii?Q?ClNPfDEH32RgotvZmaZcomYQyu4wE9St2SiDHchLY5V8UulqC+CD96FkKj3U?= =?us-ascii?Q?JlwfW57DhpWD/kSH27YX373ev9WOySc7ynOH30BV6jNyqzLnbB2fM/VfK/L3?= =?us-ascii?Q?whAuug3gNYN4Y3b51D4f2yIAaroGVrS63rnO1ZWBq4p92+28sVM1mNLEaEKO?= =?us-ascii?Q?EH0+FeWdpewbUZgZSwgmBiCMX2FPmNwFnY/OqlR0?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4587.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b97e9c27-341d-4872-0403-08db043121c4 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Feb 2023 08:48:46.9304 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: shT/DnYg1C3+ZGFLoXtTMCbiVmhhPEdh1aqD6lM3iWxtgBhBsuaXcJ2P/rCyM0MLXef3OXskyBeXSfQhwc9nyg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5434 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > @@ -327,6 +407,11 @@ idpf_dev_start(struct rte_eth_dev *dev) > goto err_vport; > } >=20 > + if (idpf_dev_stats_reset(dev)) { > + PMD_DRV_LOG(ERR, "Failed to reset stats"); > + goto err_vport; If stats reset fails, will block the start process and roll back? I think p= rint ERR may be enough. > + } > + > vport->stopped =3D 0; >=20 > return 0; > @@ -606,6 +691,8 @@ static const struct eth_dev_ops idpf_eth_dev_ops =3D = { > .tx_queue_release =3D idpf_dev_tx_queue_release, > .mtu_set =3D idpf_dev_mtu_set, > .dev_supported_ptypes_get =3D idpf_dev_supported_ptypes_get, > + .stats_get =3D idpf_dev_stats_get, > + .stats_reset =3D idpf_dev_stats_reset, > }; >=20 > static uint16_t > -- > 2.25.1