From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6AD73426DA; Thu, 12 Oct 2023 08:54:12 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3683A402BB; Thu, 12 Oct 2023 08:54:12 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 541754028C for ; Thu, 12 Oct 2023 08:54:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697093650; x=1728629650; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Kiw4CeTfYNm6Zb98xZlzlJ3zZprkxRyjDX/dfmpgmJo=; b=jcrK/alR47I4cUDdqv96aniQpir2G0U69TTDySNBC8PzGLycm/T3XIQt q3yUTiqzl4l8g1dBoSr59axFrgnWis+ya6qolMwr3x04s4q6GOOCCczQA 7GQ3huVscE+r9+/sC/AxOXgyXd23Dc4agXWkSYNHtjzJOYz+R6l3QI4v/ swA+sLUSxzhp1fOqwWXX+N6oe304r27KT2TiRqnGht1HPecjK6W0ifS/a WXYkAePkqZGEVHGm7m7MtOba0QLjK4sXpyaYRb7gCjzyE3/2zBYsOpUuJ 9K+jKLOih5NKFsszkn+g67xQq+aONk4PgkKnVaXTF/pdq2ELWC+tjZpsf Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10860"; a="388710515" X-IronPort-AV: E=Sophos;i="6.03,218,1694761200"; d="scan'208";a="388710515" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2023 23:54:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10860"; a="783568156" X-IronPort-AV: E=Sophos;i="6.03,218,1694761200"; d="scan'208";a="783568156" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga008.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 11 Oct 2023 23:54:09 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Wed, 11 Oct 2023 23:54:09 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Wed, 11 Oct 2023 23:54:08 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Wed, 11 Oct 2023 23:54:08 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Wed, 11 Oct 2023 23:54:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S+vQPbRTTQgWmnQdDjHJhpUC5NHzY6QMaAC/7Tc74n5NV0KAatUIGjkgODo8rz4pdRjYuRj6jRxxaNELTqo64Lx08dQ+v8lzoad0aq0TlLLgTbxy8znizX7DfE1or2Nct3GnA5zb4kDReRvN1aKyBFEF2Uj4QCkB4UJuSYAr/UBOgQJAeXgFwexHAFg2guSPThFgRQGn9qcKZB61RpT3RqZoPSCLMh6BFp+TRsAMscuSgFHv9Jt5hWcnH260rjAB+Mt6jPvWNIeX7vqAwFqlXVhTtaOp3G/t62b92Ms5C5HNUOfqTUdqJlibhbjmnw3KKIQBWQZrqWqEJQI0Q1rKpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tXgxEEkBYOQyVAbnCtBoAenLfhENmOAMUbBq3hYjixg=; b=fMuibGh+qqt24pU3dAQokmeN+eOVSKs0JDJxdgAuYcEC1zBLepX6G37xJJ5Ux05fZ5lvns3+/GM1v4CEQlyGVv/OC2/G2KBV627nKpy+owsyCtdkopFWL88nov8wKKl19Ke6K0jiDDqnLGnh221IpqjiIQJHYVKufHXAzV56SQUxqdCzaNBenuzDqJj7l0KbUlrUtPZlibd0nQZzNKWaC3CL+UUf4w5C91w33qRm2CR1u3gXS8kkTvP8Aaq8+mmTsOEZBupQxOjQ05IpbQAWWUPDF44DvCwopldy5e6VwrEEFZnF2WXrQhdU4ejaqaMOMbu0+JMzuxvsSJVrk6w7aQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW3PR11MB4587.namprd11.prod.outlook.com (2603:10b6:303:58::7) by DM4PR11MB7208.namprd11.prod.outlook.com (2603:10b6:8:110::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.42; Thu, 12 Oct 2023 06:54:06 +0000 Received: from MW3PR11MB4587.namprd11.prod.outlook.com ([fe80::9e2d:da54:94fa:f7f3]) by MW3PR11MB4587.namprd11.prod.outlook.com ([fe80::9e2d:da54:94fa:f7f3%4]) with mapi id 15.20.6863.043; Thu, 12 Oct 2023 06:54:06 +0000 From: "Wu, Jingjing" To: "Xing, Beilei" CC: "dev@dpdk.org" Subject: RE: [PATCH] net/cpfl: reset devargs during the first probe Thread-Topic: [PATCH] net/cpfl: reset devargs during the first probe Thread-Index: AQHZ/BzCYdsGBXPXhUmg+cLoyPW+77BFuB7A Date: Thu, 12 Oct 2023 06:54:06 +0000 Message-ID: References: <20231011164720.418246-1-beilei.xing@intel.com> In-Reply-To: <20231011164720.418246-1-beilei.xing@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW3PR11MB4587:EE_|DM4PR11MB7208:EE_ x-ms-office365-filtering-correlation-id: b6d56cdb-bfb0-4c0d-4f6e-08dbcaf006f8 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: usZyOOBx5+vqyI5k7AadsSw+SpNkM4y5TFz1Kkwyy0ri+F1cXdEiFpQrZfqD4b31oCrqJ5vZZtd9/V8bWAC9XbZLRC/1gz9M04fIkvnRkx7KRbtySd3co6wQaA/ud+fgDg7p+jwL9whtKyAEU9rrdc38QxV81yp11qdLaCXn2IvFY7f65u5wTv/9Gmd1vUY3jrAo+HEVXZeDBboD7s9GRiib8K7aXt8sleHSo/edRlEk+ZGgoiq6hrIsdJu/QOAwPG/XzLy2jk4fz97N4RJ1STo2sASmju0V1lcpxt+JHYkYXdKHsfqrizbj4mN1CqX2Rlj7KxQ4L6KESCTB5bzN/pPwqg/X7gKQnMXXKBzhnN4bbbKoyscUvU1NdO4dP+s8BvbPYRmxPlaVpC9wPEg2XPse/e4lAD8M7MmWLLCaxUHAL0F2qAe2uUFV3Sl/o0mvC0EMWDhb8MpXTE0tHQ2JnGMpw3hGMkVIs3Lxe4EohKZE6y6sYBKM0EPl8io7rmHIQampQXIZzbkH6CVuz/HGYe8E5gFRnppwaqBvgdRU9HzmchzmQNEeRILVHAvpPnXVCAZ65bNR25ehGDfJTQFVH5GegJRqQz4PwERSPfNoyDHm4JF9I/bXaeVRSnOnWfme x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW3PR11MB4587.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(396003)(376002)(39860400002)(366004)(346002)(230922051799003)(64100799003)(451199024)(186009)(1800799009)(4326008)(6862004)(8936002)(8676002)(38070700005)(64756008)(52536014)(5660300002)(66946007)(76116006)(66446008)(66556008)(66476007)(6636002)(316002)(41300700001)(38100700002)(82960400001)(33656002)(9686003)(26005)(86362001)(122000001)(71200400001)(53546011)(478600001)(55016003)(2906002)(83380400001)(7696005)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BMZAa3qK3/eAdY2NI+E0tsv1Mq8nOZJbwvdvpsOUjiVPTKTqL3LWF6yB/akg?= =?us-ascii?Q?/8V2zsXome39anHOQctkli0GkgTTCzLACQ8lo0KEzqKJIDb89FdzUZRQ3aSe?= =?us-ascii?Q?CIMY66FANnrR7RXhEsvO4gyb+rlSoxxgOflS50iJlQ8sHyjyfe/iReQaQTC9?= =?us-ascii?Q?2+WAJhVPS4BHQNX5U9R0MYKwjRepkoAUaloozxGvgafH7lTCfaLnd7CeIBO+?= =?us-ascii?Q?0cJVdIve0pBvi1aG6HNYXImftIpsmEju6tnnddr1vBUAhamZIDkqDJc0oCYO?= =?us-ascii?Q?V2yFHauCmznOoDBU6UTc3eCAPOmr2xvmWsbo+knew1Rw1mVlgySChW8yaVgI?= =?us-ascii?Q?a72/glm56ZYowtGKE623gdL35V4yYlOFQ1s18Ue1jnoofxc8EkhN/iJJrX6S?= =?us-ascii?Q?uUuGOjc9vpl3IpwQE4q5h3zxYdbLDM/jw8WS9HrE8TPJyy/ak4XOKcAxLC+J?= =?us-ascii?Q?xQXdcnBWzYZzSHiTBule6k6qPaCFVnoGpbE411d6ynRvZ72p+gJZmBtDRKBm?= =?us-ascii?Q?9/y+v+ZrM0dpyqDc1YtYUkklqU4JB/fOeFxFc5EjKkOMxk89mvbpaFV3v4f0?= =?us-ascii?Q?04cjDwf18O80h6lOZIAf8c1Phry+MJWdrqBwFo0F6SzWzeGSPDSptSWnX3Z9?= =?us-ascii?Q?00fbQiDxNi+TwtmQ/yJpV/CyCceW95OdYD4iV4uVzA46pqZ0XwgiAJi9cN32?= =?us-ascii?Q?RBG/7qpsYiisZPzVJYDQW+jrw70V25eQBeri0HPcm0flcMq3AH5J9PdS+pr+?= =?us-ascii?Q?ZwTAz5ksVcJf84tS4lOeGd3cjWYZXwcNqRE7ySji4z2DqOcOMTRUj2LZ0QdJ?= =?us-ascii?Q?EkvJTb+GdFzbyY9LSyAdunS1bSiTL4B832WUYv6u/72S57ChUEjsziFsOemT?= =?us-ascii?Q?22/y/ZpJx1ohJqjrdShdMpR//nNXc6MUykPPfcHaL35uo9gOPFHLavNvjG2g?= =?us-ascii?Q?n8tLe37NI3O9/MnNsudxUcXYUcraYXVSPMN21cuNvuTdgfkFrQsGORl4tH6h?= =?us-ascii?Q?yXRT3H7Wt7ceTnQctmWvwHCvVD+l1uUJPcbppLjzVHwS+vX3QyWCvQy8H9Ty?= =?us-ascii?Q?kQ6/Ty4L2KaefjtoEv9yBEvuCcc/bWVCc8jjZwlyaUcPOGOwViGAeBAFj7Ws?= =?us-ascii?Q?31IWou00/NB8fLtqPkWpQuW4nr8g7o5SwwcWt87kOK6zaHH+jaYUxEQcCr0u?= =?us-ascii?Q?1JFKt9Uzvrs2It1/dRMotX/7PfJrF72jFJ7zCffbiIlUEDsniTVxNOBqLCpS?= =?us-ascii?Q?7RCiTaCFekzuI1Tq52qw5wSW6+F78mA77YYmj8rCOxiUQVIMPwcZnc3IfpqP?= =?us-ascii?Q?PFOuPHrnSyCUnMAIsPSQDwU2GIEyyMYNnIBXEL1g5Xe1gGjE8s1/6y+l346f?= =?us-ascii?Q?amlJKJJxHh+GsLkzCV9b+ewr+SgJXWSKgv8FYkwj36yYueZbw0lA39eQtaGa?= =?us-ascii?Q?VdqunkWFFFicFSi+PUwixRfSl9++Z72y8ZBm1eP7V+U0ZHZeXdtfely0Unqd?= =?us-ascii?Q?7ygGi+pQDL+AYS3zBueUnPOEzb7Ocbp3aTemfL6Mb0qXGgf+KJm74+ZDENgU?= =?us-ascii?Q?WLWAURBYCruDljIXBLC4epxcR58DsGLV4/gOa3IJ?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4587.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b6d56cdb-bfb0-4c0d-4f6e-08dbcaf006f8 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2023 06:54:06.0712 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9fYdu7qIzE9ZF0COkuQUIdEv3VwD9W3Si1WOlMg8/ntp2Owc+FsgxAmfFaEMrEYcutVFb+okGhLjucR1S0h/Ng== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7208 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Xing, Beilei > Sent: Thursday, October 12, 2023 12:47 AM > To: Wu, Jingjing > Cc: dev@dpdk.org; Xing, Beilei > Subject: [PATCH] net/cpfl: reset devargs during the first probe >=20 > From: Beilei Xing > Reset devargs during the first probe. Otherwise, probe again will > be affected. >=20 > Fixes: a607312291b3 ("net/cpfl: support probe again") >=20 > Signed-off-by: Beilei Xing > --- > drivers/net/cpfl/cpfl_ethdev.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethde= v.c > index 762fbddfe6..890a027a1d 100644 > --- a/drivers/net/cpfl/cpfl_ethdev.c > +++ b/drivers/net/cpfl/cpfl_ethdev.c > @@ -1611,11 +1611,12 @@ cpfl_parse_devargs(struct rte_pci_device *pci_dev= , > struct cpfl_adapter_ext *adap > struct rte_kvargs *kvlist; > int ret; >=20 > - cpfl_args->req_vport_nb =3D 0; > - > if (devargs =3D=3D NULL) > return 0; >=20 > + if (first) > + memset(cpfl_args, 0, sizeof(struct cpfl_devargs)); > + adapter is allocated by rte_zmalloc. It should be zero already. If I understand correctly, memset to 0 should be happened when first probe = is done or before probe again but not at the beginning when first probe.