From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F0B5241BAA; Thu, 2 Feb 2023 09:46:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D9D0A406A2; Thu, 2 Feb 2023 09:46:51 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id B4F0A40689 for ; Thu, 2 Feb 2023 09:46:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675327609; x=1706863609; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=wTF7LlLmdStyNybeqT2NX6vUdA1JwKDypPIVZIKd4EQ=; b=hu6YWTY1CvRs8X+MLRIhLbKe9l9gsM4mA4VOxMPZKBwB6bt065UegPL7 fT1pfxS2+iK27NbVsLnrA3MC81btWLmJhSxHS75wHMb5AzFoyM6rnCJxA ugCJB7EZGnjim4KfVkPr9GMUpr8a0cJVcM/ImEjdsBtnzkHb1z62zLxIs FHWgxwLqdPQKnxVC8IP9/Bn3w5yejlhRKjw6shgZa4ua/o6YE/ap/dXSL oNtVht6TimLw4Yesa+5DHKi0+Fg/BxvGP4K9ZQo0TnWUBiQIxp3MXKJnk IGTQMFpdJYaCDDgmRrhKcRGfnQ2ENROX5pLdOgw74ojp9pztLZ5xNlfMC w==; X-IronPort-AV: E=McAfee;i="6500,9779,10608"; a="355731785" X-IronPort-AV: E=Sophos;i="5.97,266,1669104000"; d="scan'208";a="355731785" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2023 00:46:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10608"; a="910675624" X-IronPort-AV: E=Sophos;i="5.97,266,1669104000"; d="scan'208";a="910675624" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga006.fm.intel.com with ESMTP; 02 Feb 2023 00:46:48 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 2 Feb 2023 00:46:47 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Thu, 2 Feb 2023 00:46:47 -0800 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.40) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Thu, 2 Feb 2023 00:46:47 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lwEyXPDtNh1hI6J3fgWLCfJOFVg06bnVINvibqP9reJ+LIChEP+mwM8q2HORVqzA0iVnQUjWMxAji7+j9k2YaCVw8zR0YdFk/T8rJ8TrwXXg6h6wQRErjDdsT1rzsRIuDLL6EZm73iEXVqWPfoRCM8qq94e/8jk0t05qI9qchg10C6lZpQlpRIp4yucgYXJpYS6p0OF/x5cGTIDNC9Xj+f4Q4t9MHay8GyTxFPv2nTtIxa2c7gYQsdbIMxFhP4Y7/Rk9FmJvOs5abQVlIY6RkECXsRyCJYB1H0P6FO/ptNJQd2eB6sjg4IqSgN5RL27/a+mHC/OhVo9R+lXWkMShhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lS0Czd31hWMwgQoOrq2y8EWO1Q4XCh99jhddZXv8H5w=; b=ZdVzYA7W1Ihc2MjH0Zdm2YdGlK4SSkvRyTdxUJqMzpOWjXF18vXqk5gCkvUacxscG2e0xhFrAtZR9yF4rKfnKxFHQhCpnshPMdgAkTap1fmPwD53Mk2oVGvBajyMqteArT5ygItJchdFoAHQ0kygPaI0ICpksb6fysh6NLO98qLbDn8cwVOmk1fThuC0MUOOe7QswgGRFpcDIV7Sk8Hbmj8/W6WS8eACBZ+9DTUMOB4Tt5UmLqfFai/GqYA2VTpx08azz85nIOlePjXAoefhlrlqgVrbtPEHH20nhg0LUmy08pFAcqujXImJB4yvMlSgIZURUllUaHFR6N2qcW9ukQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW3PR11MB4587.namprd11.prod.outlook.com (2603:10b6:303:58::7) by CY8PR11MB7060.namprd11.prod.outlook.com (2603:10b6:930:50::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.27; Thu, 2 Feb 2023 08:46:45 +0000 Received: from MW3PR11MB4587.namprd11.prod.outlook.com ([fe80::8b2c:e748:6431:3cb0]) by MW3PR11MB4587.namprd11.prod.outlook.com ([fe80::8b2c:e748:6431:3cb0%4]) with mapi id 15.20.6064.025; Thu, 2 Feb 2023 08:46:45 +0000 From: "Wu, Jingjing" To: "Liu, Mingxia" , "dev@dpdk.org" CC: "Xing, Beilei" Subject: RE: [PATCH v3 5/6] common/idpf: add alarm to support handle vchnl message Thread-Topic: [PATCH v3 5/6] common/idpf: add alarm to support handle vchnl message Thread-Index: AQHZKxRYFwhvz1GoqUCBlXNJkqlQxq67I2YwgAA5SgCAABKP4A== Date: Thu, 2 Feb 2023 08:46:45 +0000 Message-ID: References: <20230111071545.504706-1-mingxia.liu@intel.com> <20230118071440.902155-1-mingxia.liu@intel.com> <20230118071440.902155-6-mingxia.liu@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW3PR11MB4587:EE_|CY8PR11MB7060:EE_ x-ms-office365-filtering-correlation-id: 7084a35c-0119-49c9-6579-08db04fa0386 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HtxUzil6QwU8WIdW1GiW101jMMPf9w8MJwDJxfuwdSF12dNtbDDke0hKUCs1XkMXTonbsT7Y0qXs0YsK6lxhZoRRpyiLtjxKjv/YEFntkTJhHRqLQvQ+mAacItfXLYLQM4xYj7cxgNxQ1nc43l/fOiYPqM/daQQMX75w5oMEwr+VrphCd+K6ZaP70h4fyPfCBQKnf6lFMxHsVG/n+YJ1ZCysBBe7Tt72saVbBT7QG9GaInkfHHmN+UTdIbfH2+KZmCvqwzkP8eDH51zb0br3iLA06nKdqU/8gvka35Y5PXf6+J/ZTWsKmBwiz0gg0JvwLteZUnB4cHUWW60KMhM25cZUVc2ceuTRP3s/tB6xyP0YAhyQCJ5LXmmPTcgzLXB6JsHWcuZZIXCujek6JP2BvuXNT/nJS1+8uh9Pu/vXa2YTGDVSywBHX8onhbt8G4gl6mkAAfKeooNQ2EU/BLGQb1S+CPT+YGwkI3FDpKVdgIL0F0YMf5fEEmjNXQcJSox1MRVb+105hzwLjBV8bCmdLOlnLiRzGFM9q1WjW1fxrWCBXiwqPQ367hOD4sI6vnBQTOJ0nguoAK7VaMXtFRCTzsN1rwTw600WfMr112AHw9FozSWh0K0Ko53YXzVRWZbJvYuVE3xpfMh6V+MfXqRgNJCBujSmizLdYQTtvo6cIjXt8BcDUkjNpP4PlG+MER8u5R9h0heRjSRhSjmAU+dI+R8NKKH9EC+Ypza9E9anXKI= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW3PR11MB4587.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(396003)(136003)(39860400002)(376002)(346002)(366004)(451199018)(107886003)(26005)(9686003)(38070700005)(6506007)(4744005)(316002)(7696005)(71200400001)(33656002)(110136005)(86362001)(5660300002)(52536014)(55016003)(2906002)(478600001)(66946007)(66446008)(64756008)(66556008)(66476007)(76116006)(4326008)(8676002)(8936002)(186003)(82960400001)(122000001)(41300700001)(38100700002)(21314003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pl/Jx3jJQOgrwuGtw4HQ9+qAIRDUplr+liVoqqKKd7pHP8yGkm9mBKCKUIBO?= =?us-ascii?Q?OsbBRoGPDGb1J331VnRxfb84A7TlRvG8fWS2geofx0lgX+pZKYubSee6FFNF?= =?us-ascii?Q?9PYQ6CfFBobqzKs7s5d0Q0IH/x76vxoSJO8jOfS7qAGMgiQZbV2kpv0MfgAt?= =?us-ascii?Q?/GFHwK3xIRq3Om8N6qVgBdCtWLXlHegZXHh2RBe8rSyQkU9TqX2wwhrFuLod?= =?us-ascii?Q?lIUDSORyyh90BJTKK7XU7Ae5kphs/yav3HtgaWdfG2lAjRI+mUHF2vi3LmWj?= =?us-ascii?Q?7b/1L32Fued3v4JCkMy1YYomZEejLO0QQ8oh+aCRooUrnViuL/UjozDI1V9D?= =?us-ascii?Q?n08pi/psKlULUfUCWasQ487/IbJ1s8BFmr2MqkFyAc9GOg2qLa7K1vFzJLXq?= =?us-ascii?Q?Vsn5qUciTnuKonJ+7mGuTnY4vAVdqKNBUx0B+k7s2trpwU+ddMLdxcjONbOp?= =?us-ascii?Q?77nkSzCaasvWrkJgb1AibUyd9RqF2rjZMx31NLdB4HDV3mmNw45A2fjLWfkp?= =?us-ascii?Q?WOJICJxNYJ5FIdmM7UI3VpOeMFQaxdB+GK/CBMK4rBQKHj7tsRfCeM48+M4b?= =?us-ascii?Q?dueGLNYMcRQ6jK6JEtJNdEx5Kchc4kS7AlLyP1eKHHIUUzxLxJDFCHZerqJ7?= =?us-ascii?Q?XslBOG00aT1MxKlRl2r5/pWwSzNn4JNQm34HXYZ2UqO5ralrPoHLy5+orxhe?= =?us-ascii?Q?nWg9uAZHrTdozdiuQDoVEE3dySswe1vqlCZWTYyHM7afCXYnNz9bqLatu70E?= =?us-ascii?Q?+agmcRr0sDSTRfebSwl5Q0ia3QtAT+Kc3/r5to2eW72CbDlPXKdAtugYGgqA?= =?us-ascii?Q?3wCLULnnJiRRVvDRubH36AVKDChhpj60mk6O+3KfhF53M4xO5FCtka/lJWXh?= =?us-ascii?Q?IOLQiiajG4MmiNBfgNHtJcIh8hImJAifeJS86EV845UCWZHOjZSADfWscXYK?= =?us-ascii?Q?zw3dg31k2w/WGna+0xfOpOrlwKckl4mpr+pzYb0VuWgvxda/1vLDIr/l+MWN?= =?us-ascii?Q?v+98e2AHQoHaDG+Jz8UQDvQMIQTxTOia8oTnEeKBEFtLHSURJgDblY5Rrl5i?= =?us-ascii?Q?HO6YAN37UMC0fdchnMazzO1ea+TT6EwY/CqivkguXzORnxYXto0PLt1tte4H?= =?us-ascii?Q?5U7qr8isMdWAFs9Qyi3TFM1qw+vo5yJ37T1sT6MMEt5OjNHiEBMQBxlFe+98?= =?us-ascii?Q?5HPqil2q+bdWZwTbip4LAc5FIxchqN3T7GYrzzJo7xYw+jQ6HozUgPWuxToF?= =?us-ascii?Q?nihlMHTHUfwMBGrfNw5XBEDw82zqRfPjWHrJSNBtifGsd9O4H3DUcvvMDfV0?= =?us-ascii?Q?5mlOpDVQ+/cQkINHAUorj5xb7nlgn/6X3utX1Oylg9n1GCDzw37DDlG60Ot3?= =?us-ascii?Q?uWxsflDGIVXIxKSfGRPcQxyajTTfteyVoqehwIGrYABwArf8EOH8Bw8jq1V5?= =?us-ascii?Q?dyENL7ugWCq7ck2PPsUvXdlF/7lBe/4ZYQ7fPdpF0cblQJae/+2uw7Ycr40M?= =?us-ascii?Q?1hSpvYFrM46Mm0C2pGwWzXNL1ouB8XA4l4SjJ9A18r8H+ZQ6i3PsDFK0C8iY?= =?us-ascii?Q?f2msLW5kXNg4vxq7ZYHIXxeOymg6ZaQZyNMdxqs2?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4587.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7084a35c-0119-49c9-6579-08db04fa0386 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2023 08:46:45.0376 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3NBx9oXVdUfTSTNH2RYmS8AktqWm2KvsVGYuEkE9O7a+wCefZnsBV/xtyR8zLc9PV6/ISzuQLsWZ7joXeoQhNw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7060 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > > + > > > new_link.link_duplex =3D RTE_ETH_LINK_FULL_DUPLEX; > > > + new_link.link_status =3D vport->link_up ? RTE_ETH_LINK_UP : > > > + RTE_ETH_LINK_DOWN; > > > new_link.link_autoneg =3D !(dev->data->dev_conf.link_speeds & > > > RTE_ETH_LINK_SPEED_FIXED); > > Better to use RTE_ETH_LINK_[AUTONEG/FIXED] instead. > > > [Liu, Mingxia] According to the comment description of struct rte_eth_con= f, > RTE_ETH_LINK_SPEED_FIXED is better. > struct rte_eth_conf { > uint32_t link_speeds; /**< bitmap of RTE_ETH_LINK_SPEED_XXX of speeds to = be > used. RTE_ETH_LINK_SPEED_FIXED disables link > autonegotiation, and a unique speed shall be > set. Otherwise, the bitmap defines the set of > speeds to be advertised. If the special value > RTE_ETH_LINK_SPEED_AUTONEG (0) is used, all speeds > supported are advertised. */ >=20 I am talking about link_autoneg but not link_speeds