From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 99AD4429C3; Sun, 23 Apr 2023 10:55:58 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8AC0040A80; Sun, 23 Apr 2023 10:55:58 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 5D33940156 for ; Sun, 23 Apr 2023 10:55:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682240156; x=1713776156; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=TPWtcKYUg2c/z7QKp71BQMQiu5HpYv8UT1yEO/m9eX4=; b=LdXIN3vfdeXX/pgK1z6u0NG6hD1Qb64bY2fUx7lokMiT1yPKgR8RT7Mq uTZFQo9/6LZBx8sz2RRCWofGNdMTb5lpc+Uf7t2Izu4MPkYsZCixMKk7n /S1VGhQeXz4CXPPfiR/2qzVSHYgI83MijlsCEM+y5Yu8PmQSZ5aqH2/wx HFxnM6mYe1Vo8gdoNgFPm6ROMCFDKUw4kNIMDMQxNnPRX6S08UKQxzVv9 uaMbKTZnD7Snw3rJqELAj7Znnj2uNRGWUqs8E8jwyR9V3knckUmHZ9awj Wd9pMznskMhIfb54iRO2VIjKyQ3dsod5Z3UXwvGcUI99GjonEXcDexvAX g==; X-IronPort-AV: E=McAfee;i="6600,9927,10688"; a="330471568" X-IronPort-AV: E=Sophos;i="5.99,220,1677571200"; d="scan'208";a="330471568" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2023 01:55:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10688"; a="1022359215" X-IronPort-AV: E=Sophos;i="5.99,220,1677571200"; d="scan'208";a="1022359215" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga005.fm.intel.com with ESMTP; 23 Apr 2023 01:55:55 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Sun, 23 Apr 2023 01:55:54 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Sun, 23 Apr 2023 01:55:54 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Sun, 23 Apr 2023 01:55:54 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.103) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Sun, 23 Apr 2023 01:55:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oMyWJUFK9qeWdXtlQHNSqxdW3icgJCsn3uBwKjLbIyQyfIVC05ApWvdn448UBlFbVNlEUsN1zZvjeaH4bYw3JU6DLHdHpbUTYFgxwt7ii4DdIa08Kk1Q2QhTazR/FHDzZWwk3zPRViLzmtGrWX1249iBBSg3hMLvmK/sNiJWLQ9W4pBcX9EQ3X6OGG+uYR4UoXvkN3M2aWXffiAA1f+/VzJ+a+fTOnQNEQQX6dfTln3uAevzrzuiDL1NRpKajBnhQq6+2HNwlvb06ayVbjO1Xpw01PyI7kh4egpH8wo9p7OID5caAgx9nqlKHsWj+H3KQuEQdCTWZcMLcr4z3C+qIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JIXNcp3RVg7OQG8gDwnBqF4Bp41dRBYrIkP6/ibGpxg=; b=citL57TAlIVqyirnNdFhXULtD+IffT5VMixh3+DkSbGdO0mskeGdUGQbkMqebDZemgkqDsZUEHD2Im3i5kDgish8bAzt/TNyd2mqsp04G71Qv1PfYUVZ2ySqPSYfTqQ82L7RI8TRIIrngad1S7YMFjph1Hu8F/PrJFnmZxSOR60L1qgO8TMKz7jIRAYlLy5boZN4ZZeT1XlYrFOcDGXg7yE0vUGBPHIrET2wRAabnNzABzn+REJl1uHR+5pMv6M6RFbpPZmDrHUFjr8qSJIC7DoLgz3U1lZ0OAizoZL63OFeePtT8bZ2fUySrtbOjEGAuoT3ljueXWkQs8pnI6iy4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW3PR11MB4587.namprd11.prod.outlook.com (2603:10b6:303:58::7) by PH7PR11MB8121.namprd11.prod.outlook.com (2603:10b6:510:234::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.22; Sun, 23 Apr 2023 08:55:52 +0000 Received: from MW3PR11MB4587.namprd11.prod.outlook.com ([fe80::3477:981c:fd74:9ed1]) by MW3PR11MB4587.namprd11.prod.outlook.com ([fe80::3477:981c:fd74:9ed1%6]) with mapi id 15.20.6319.032; Sun, 23 Apr 2023 08:55:52 +0000 From: "Wu, Jingjing" To: "Liu, Mingxia" , "dev@dpdk.org" CC: "Xing, Beilei" Subject: RE: [PATCH] net/idpf: refine devargs parse functions Thread-Topic: [PATCH] net/idpf: refine devargs parse functions Thread-Index: AQHZdCkvve7lrFX2Sk6QO9brerAmW684lf+Q Date: Sun, 23 Apr 2023 08:55:52 +0000 Message-ID: References: <20230421071456.297774-1-mingxia.liu@intel.com> In-Reply-To: <20230421071456.297774-1-mingxia.liu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW3PR11MB4587:EE_|PH7PR11MB8121:EE_ x-ms-office365-filtering-correlation-id: e0ffeafa-c99d-43db-2dd0-08db43d88ab7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FxoeqegtPG3MO3+GckgzetgwU1XbxYbkRsGCds5Kvn0cdO9EyAKuhd5+tFruRZ9UfL7rz/zdTT7XjPCN/Oh2cFP4WjKXYjT0Xo3p9s3D7t6A4vuGyWS89kH89SGSdUzbmGE4/4odZyVWRsHU8yiIOiL7s+7I3iKc145yah8TPRz3isi4cS8Kro2Ky+nzGDb9LM87eg4aVuw2xeOnlmUtFxv7j0m3GwtePoIRkOtM5qfiv1APQHo4NZbepBjwjFMCyi6/OTxgUr14ffZXZgNqU+VoG1fMWmFaMEvfR9EBk4l8c8mzOZie2XkqJmlnXCFodJ2LSQHaVl5pB58RO+2ercMuCuCod0Twbce47du0rkwmfbw2+g+/WqmOYxwFdYLncQggTdvqPwqvwBTbydTXNj9hojVtgIQCnf/4jq6GXaXgmdq50Q1byw9FM8qFKjAfP8VMsheRrSjZFdUwofBcAmuZEZpyaDUG64NK3hYzyur9A17F5ik6WJZGaKVdcz86O/qobeY0XRsonoF6dOcvvvLB4HmYg8cCf1estLONm88BDYJtAOtxZsvanC5fcdsYKIcTjr9nOTweqYFpnVhRcC5WeDe/t6icfs/5/HF5IYSMJASLHAsDYT+Dgw12Xq+s x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW3PR11MB4587.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(136003)(376002)(396003)(346002)(39860400002)(366004)(451199021)(2906002)(8676002)(8936002)(7696005)(38100700002)(71200400001)(33656002)(5660300002)(52536014)(110136005)(41300700001)(55016003)(122000001)(82960400001)(76116006)(64756008)(66556008)(66476007)(66946007)(66446008)(316002)(4326008)(186003)(478600001)(86362001)(38070700005)(53546011)(83380400001)(9686003)(107886003)(6506007)(26005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?fqZp0pqb9w7Pk6+lvcKSOx3huW0l00jGzpZ8Occ2FhpmYTHLfHj3g/V4X2cj?= =?us-ascii?Q?y1zMKR6p132IVsEWzCzqY80R7sbr6u9fYofVgD8/qs8hOUJfzmliddxYvgiU?= =?us-ascii?Q?P2AJvbDm/zUPmn0P1oegoqiS5+cYevpGa5uBS5aYApPz6AkmwXEDOnXYSXB9?= =?us-ascii?Q?BO8M9u2f3ulIaEQqY+R01KiwVrchtvleAlKj6uOvVjIOsSKkH93sEBFMZgqD?= =?us-ascii?Q?gLL8qGD7nH7+2wXKufbJWrahHW2HC5W6kKqhrpbaH2AZcEFYa+cTztQkdUDO?= =?us-ascii?Q?XnisiimRRyXvRRx5TL9HfRtwC27Ld978NsiVr5wWoDkWa/8Z9mwl74Y2cUQx?= =?us-ascii?Q?FsT8Nn8qZDPnjk62b3Bx+KkU+/eVB4guA2T1vL5NznwuZTl3byYH0eNkLJDC?= =?us-ascii?Q?sYYIMlZq3XWe8s64sdf+rYIBcGMibX6BYR9gQfF04z3B/6QhPk6iCqQhaySc?= =?us-ascii?Q?2wzKhZD6lmCSDFeraHFwiDnHNCp1O5Wj2Gil4QEj6ZcZRBGx48U+zOaF3mey?= =?us-ascii?Q?UazCx1T2XiAqlfF2ADTl/EleoOTJ07VX/FV1bgGrJLnID6Jd/6WhObuqt2VV?= =?us-ascii?Q?v59MKi38W/QJeSnIhjmFBbHGOOJrVmwq/NWfWnXr5M2uTBqj3uvTMOEbZmtP?= =?us-ascii?Q?YQqDTjnf3jyZiMyEuX3BdH6ACwqzxHRHCkVe7tJzKpWCkhL85nSJGxO+DjxE?= =?us-ascii?Q?oy2MwZz6nKXCnFwwxcuMFI6Yw2w3Lf9nenyM6JsKzO8lzJpY4cHRjodKkP8w?= =?us-ascii?Q?Yc1mf2KFRVVPQ1bCQsHYKoYZYEB13fRtZJx5m1UngzbZFqq80VmCnFPWYOeS?= =?us-ascii?Q?EMOCVaHDqWzDmtcymC7RE7HUiq9VZBkjNePjA5MKeEXCGgFFEK2MsDyc+L43?= =?us-ascii?Q?M1DYvG5/wVFK/AQFC5F53/XOMhJ7EhbBpQzQ1CIo4M9jF5mXWM9nAmjBqUPu?= =?us-ascii?Q?lF0j2179jDVMhWvRRpKGVL1JbAfxYKHuYIAV/CdaQGmuaP7pIg9pN4Ffk3NF?= =?us-ascii?Q?1xLhqp/+J9TBt78dZmDAT3a6y47etacs7nPOCdS/TSupqgBaIgLuYZcOIqCt?= =?us-ascii?Q?N/TJTrbOnnbxQfEgYxYLiceO3gaynZPK07UEK3lwpOhOCPOp5npuegZIEZa+?= =?us-ascii?Q?KZY/4BQ/t0oJOW5r1jNUEUHnl8zaru3gUvS6EmNgfWKM23CQSBhOBDf2XADz?= =?us-ascii?Q?rE9rfQpcD92ERzj0unlpPTGSj4hTbATSuG3Y5lD4j9Rb1M96jLg7S+WxVkPT?= =?us-ascii?Q?GQDauYlm5qI7KS8jx6zZg9O2PRN5rLKpgscZMLknecKo4XIuQFHetzGSqKsP?= =?us-ascii?Q?c+ptLJCye7JgF4tmkptf4p1gQQvO0M9l4Vlik/26lUstY58NTmH1l45PepAJ?= =?us-ascii?Q?oG+OioZCfCCCU7eInhFhJzAe1GnfTBs6a4qaYP7F8tx2M33UUPpVGflEzH++?= =?us-ascii?Q?ufDOQJER3+BJzVoB3h0d67bGvgz+hrn5dFe6d43rxhMk1tC5rCjHEqagbIh1?= =?us-ascii?Q?J7leiejrbz+Z+NYRAd/YQhzlb9syoJlHEjlY0gvanzcQ0tjJ4H2yfBW7g0xk?= =?us-ascii?Q?aPbuHhEM4E8gHJMONsXDflB6k1fFSnPrG9WN3SJ/?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4587.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e0ffeafa-c99d-43db-2dd0-08db43d88ab7 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Apr 2023 08:55:52.2135 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bzHhq1uEUYxKdNoE9Dk9Xi58cUMlW4nZzH/n/yUsqtfLks3OlRrZFMFCkZQvkBPp4FQZ5pGuo2b8kBskUCMaGw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8121 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Liu, Mingxia > Sent: Friday, April 21, 2023 3:15 PM > To: dev@dpdk.org > Cc: Wu, Jingjing ; Xing, Beilei ; Liu, Mingxia > > Subject: [PATCH] net/idpf: refine devargs parse functions >=20 > This patch refines devargs parsing functions and use valid > variable max_vport_nb to replace IDPF_MAX_VPORT_NUM. >=20 > Signed-off-by: Mingxia Liu > --- > drivers/net/idpf/idpf_ethdev.c | 61 +++++++++++++++++----------------- > 1 file changed, 30 insertions(+), 31 deletions(-) >=20 > diff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethde= v.c > index e02ec2ec5a..a8dd5a0a80 100644 > --- a/drivers/net/idpf/idpf_ethdev.c > +++ b/drivers/net/idpf/idpf_ethdev.c > @@ -857,12 +857,6 @@ insert_value(struct idpf_devargs *devargs, uint16_t = id) > return 0; > } >=20 > - if (devargs->req_vport_nb >=3D RTE_DIM(devargs->req_vports)) { > - PMD_INIT_LOG(ERR, "Total vport number can't be > %d", > - IDPF_MAX_VPORT_NUM); > - return -EINVAL; > - } > - > devargs->req_vports[devargs->req_vport_nb] =3D id; > devargs->req_vport_nb++; >=20 > @@ -879,12 +873,10 @@ parse_range(const char *value, struct idpf_devargs = *devargs) >=20 > result =3D sscanf(value, "%hu%n-%hu%n", &lo, &n, &hi, &n); > if (result =3D=3D 1) { > - if (lo >=3D IDPF_MAX_VPORT_NUM) > - return NULL; > if (insert_value(devargs, lo) !=3D 0) > return NULL; > } else if (result =3D=3D 2) { > - if (lo > hi || hi >=3D IDPF_MAX_VPORT_NUM) > + if (lo > hi) > return NULL; > for (i =3D lo; i <=3D hi; i++) { > if (insert_value(devargs, i) !=3D 0) > @@ -969,40 +961,46 @@ idpf_parse_devargs(struct rte_pci_device *pci_dev, = struct > idpf_adapter_ext *adap > return -EINVAL; > } >=20 > + ret =3D rte_kvargs_process(kvlist, IDPF_VPORT, &parse_vport, > + idpf_args); > + if (ret !=3D 0) > + goto fail; > + > + ret =3D rte_kvargs_process(kvlist, IDPF_TX_SINGLE_Q, &parse_bool, > + &adapter->base.is_tx_singleq); > + if (ret !=3D 0) > + goto fail; > + > + ret =3D rte_kvargs_process(kvlist, IDPF_RX_SINGLE_Q, &parse_bool, > + &adapter->base.is_rx_singleq); > + if (ret !=3D 0) > + goto fail; > + > /* check parsed devargs */ > if (adapter->cur_vport_nb + idpf_args->req_vport_nb > > - IDPF_MAX_VPORT_NUM) { > + adapter->max_vport_nb) { > PMD_INIT_LOG(ERR, "Total vport number can't be > %d", > - IDPF_MAX_VPORT_NUM); > + adapter->max_vport_nb); > ret =3D -EINVAL; > - goto bail; > + goto fail; > } >=20 > for (i =3D 0; i < idpf_args->req_vport_nb; i++) { > + if (idpf_args->req_vports[i] > adapter->max_vport_nb - 1) { > + PMD_INIT_LOG(ERR, "Invalid vport id %d, it should be 0 ~ %d", > + idpf_args->req_vports[i], adapter->max_vport_nb - 1); > + ret =3D -EINVAL; This verify is not necessary, because we don't limit the vport id specified= in args need to be less than the number it supports.