From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 41C634254F; Sat, 9 Sep 2023 04:08:23 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BA78C40295; Sat, 9 Sep 2023 04:08:22 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 742F44027F for ; Sat, 9 Sep 2023 04:08:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694225300; x=1725761300; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=8VQgFMsJxRrmFoMn/S8KM1sP/OHb9Avw7i2fTJa+Tcs=; b=faMbA3iQMAJKP6DAivF/VB9l+3aHaF8kXWouG10NfWvs29OXpaU+snaX sljz2S6ywf+qTmAq8kEKuMNehcjsI2luJYyARAQ4nfVX0nbu0f3S08vMY VUydt2r+Gx5QSpV0CxX4yow/ho7B9PLyZU42RFuHD484oZw+AdEwDgh7l WEDrjD4B1P3cP+VtXKsEh9fuDysnzlpTOonfb/EanK1eX6iWMhltkqcIQ //LPZgDWuz+1rVdjJztGlSN0Hb7xg4Ypru8UYse2lH+nuekhr+SH8cTcd eQOQ34T7YuUShtkaUmxVubnuCgcGOvQci+EKfWL5iXC032qGD4XMTIg5x g==; X-IronPort-AV: E=McAfee;i="6600,9927,10827"; a="375159012" X-IronPort-AV: E=Sophos;i="6.02,238,1688454000"; d="scan'208";a="375159012" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2023 19:08:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10827"; a="1073515458" X-IronPort-AV: E=Sophos;i="6.02,238,1688454000"; d="scan'208";a="1073515458" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 08 Sep 2023 19:08:13 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Fri, 8 Sep 2023 19:08:13 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Fri, 8 Sep 2023 19:08:07 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.173) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Fri, 8 Sep 2023 19:08:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N9acwZ1XwK/Z4zI4HlWQXoc25iQBsmC33FMUlbgJUbNKDHaWnxdWHq6DHwSyTXyq5qCg4LDLzvDS/Lzk4eb0H5rlp5BX8c6WSYuidwy9WO64kPVwAr9KqY7Vi5g9D7vMM75bpuTLkXI97j5+nshfQ90TsCJoXrjXcVHWyndQvlJya1/EfZ6xjTp3aiynsoGbE93Fzw68LdiIGJUfuFkLtwMkSNlsCSmkidJ7pgMNjFzxk1PgqHQEjvGakxPfK7sQCj+gDkE6xOhwv2MIk6C+4lfecfnpPcK/wP675LZRAQcN31Y1sFPu/VovXUCK4WCKupN10KwBqAQJT6JFz4obxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F9J6zRGszfza6HmuJYx8Gz3GtiKmMqkh+wk17A6rybA=; b=krvD/Q2IXMQ3Wov1BiyRXhiY6f3mNfrQAg7hA6hWy/m56tfZuwi+4jdnjuB97iAU9UfOb4kQEBju5ePelK1OLdhxeNvlz2VELt64uvPJ9G61/smWnp3JvoVY7GsDRWC5/lpehVeGpVTECeG9zkWO1NrTU+p3xRDCYY5UYid8G6fQjRb9Mh5aJiUO3tLH3lA//FSspct0PI8UUoPldCvHpmSFUwG+PG9AcBdzoHiReWJqikh3UNME0ic8F9bLowM0FMoqYSyEqIyOWmCaFw+LFnGbYjrQ+BvEzUvOBqGLp+4TE7czS37ZvYLoNkAkD1zVKQX47xPTpuOhuQRMvS7WtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW3PR11MB4587.namprd11.prod.outlook.com (2603:10b6:303:58::7) by DS7PR11MB7931.namprd11.prod.outlook.com (2603:10b6:8:e5::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6768.31; Sat, 9 Sep 2023 02:08:05 +0000 Received: from MW3PR11MB4587.namprd11.prod.outlook.com ([fe80::dd20:d0aa:651d:8789]) by MW3PR11MB4587.namprd11.prod.outlook.com ([fe80::dd20:d0aa:651d:8789%6]) with mapi id 15.20.6768.029; Sat, 9 Sep 2023 02:08:05 +0000 From: "Wu, Jingjing" To: "Xing, Beilei" CC: "dev@dpdk.org" , "Liu, Mingxia" , "Zhang, Qi Z" Subject: RE: [PATCH v4 02/10] net/cpfl: introduce interface structure Thread-Topic: [PATCH v4 02/10] net/cpfl: introduce interface structure Thread-Index: AQHZ4gBXsk72lkmsA0Gk1RRkAN7hGbARwH/A Date: Sat, 9 Sep 2023 02:08:05 +0000 Message-ID: References: <20230907151606.849612-1-beilei.xing@intel.com> <20230908111701.1022724-1-beilei.xing@intel.com> <20230908111701.1022724-3-beilei.xing@intel.com> In-Reply-To: <20230908111701.1022724-3-beilei.xing@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW3PR11MB4587:EE_|DS7PR11MB7931:EE_ x-ms-office365-filtering-correlation-id: 83bb4c0d-d5e9-4ea0-390c-08dbb0d99b0a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DqHXKHhMLDOKVt1ajqP1FSWSMK1eTV5GZCC1tbhUuMhI5s3TzzsU6XzGWWp0mLbeaDHNJmIStzK298COjmIPLb0Blsc2GesIjwYpKj716u8t8oAALMiWXk3JHPoQXoDgPlpmn+mPw7OupV27PNsBLY8MJtXcAsT1ar45534mLL2LUK7cCPzVNU0L+Czs6tbz9TYVV1D6B1aLC2V12N+8Y6upknS+owtFcCqXtOBVFSHP7KglKW8xn5jbaoTP5WxDMhNJHbC7JLfEwYaD2uoDpD5uaA1hejeK7BXpvdtYur7hRt8Wv7CwYyXGPHiITHxGfm1cqWxzIGe1V0Ik6Yurzrs4Wx8JMlGm1lygkhmxEsqA+renWPaU4grRKe/qRr5lDrTISsW3BAUbGBHofzySBCr52YCMmhUALWRwX/dz+yYpa42ngKNx2dS42gW9DaNlYqpsB8dXzqtiE5l6bAeQ9kO/Ur/wPf2Jytt2uHXW/+bMPb5J+2rRyX3nl4VjI5IHI/abNuFM7qU29xoAORKBG1Fr1JEMGZhEP9vc99NJ4fCP1jVZeEs3KaA+vQuC7oYut989q3KMjr02F6CF8No4kSu7gx2sKdHgq2dvutLvyDFJsAOCGSC6Qued29Iwrz0E x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW3PR11MB4587.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(136003)(376002)(366004)(396003)(346002)(451199024)(1800799009)(186009)(83380400001)(53546011)(9686003)(82960400001)(52536014)(2906002)(5660300002)(6636002)(8676002)(8936002)(33656002)(4326008)(6862004)(316002)(41300700001)(76116006)(64756008)(54906003)(66446008)(66946007)(66476007)(66556008)(6506007)(7696005)(478600001)(71200400001)(38100700002)(38070700005)(55016003)(122000001)(86362001)(107886003)(26005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qAEHtAC/PYNxoNsjn6OIVQs+8KvvTab+et+kqPDtdJyN9+YmJvuRyZwiRL+b?= =?us-ascii?Q?oZ2cCUvGcW/9HWxPuVMPUNQOTS+TpRXZ/21onoRo9Zz39U56mLPTbP3H0JSG?= =?us-ascii?Q?h+p6ZxLYe1JuzceFO22tjh1uBGhKPuzRS8mKR7MZVm5ScUJJKboaKzXpRAeS?= =?us-ascii?Q?H+01o+ormeo/Q/VM1SHe0VqkJyshx4gWbFT0DdJKB8WRSX+Q0SWc4M6sh1eQ?= =?us-ascii?Q?guqiXuR84GvxW57Yu6FRzR+qz8c6SGhqQb3XxU/jNjTnJcgByicN3ZyFNX2+?= =?us-ascii?Q?9cgeUaAu9L0Cs49MaTAD5WNWzJBcAN223p5rVHS1LphdDN85u2xmOe9N51o8?= =?us-ascii?Q?TERd+KfoHPbVBIaNKCesLoM7VueJ1KcVYVvbMkFSlDpltRHsrgwhFy/moi1k?= =?us-ascii?Q?bZbSGK8LAsGXqhulqPC2c45wCdLmpPM6PMD22bLlRzks766vUDHhETV7Rb0F?= =?us-ascii?Q?T4Bu67jjMHUfbxMQc5Qgd6x2BNQSAzf30T5iJtQSQZgDq9l4iBvGVNsaUfSP?= =?us-ascii?Q?RVsQ6X7xad5W030UHyikpvHGVXH1xhrwB5Mo+U4+uP0HDZuerXYOtaAdapFS?= =?us-ascii?Q?Pckx6Qrq9+gTtmdHg6D9MSzGszLYSW6J0NZp3TFKLJh/Zk9Q5iQa83hTPGrI?= =?us-ascii?Q?FcJiXKehhukjCMSHQ4jb/nDWUhuKWsZHS8F09AdWBW6Qpj462QgIsgl3/k0i?= =?us-ascii?Q?HJjQI5VKE4KW04UXaXv5fUa6uEfPskuG4I5sKOu0b59P9XpEFQEWX5LotSCx?= =?us-ascii?Q?qm74sBDNKGiNhQaTwVz0mjZZ+OGCpJKJkVX00Rl9HBaP8+hLH4npiF1C00q0?= =?us-ascii?Q?XVhil+hH6FW2jm/y7lNzItMDyZ49a2o1yAaCoMtTFHV/qB4bYP6OYz29Cr57?= =?us-ascii?Q?8b9Su4l3AKbvwXEtXNC9NksKBxB4WBrgAhCA13oVsE8xN/1C2BYJ6s4+tntY?= =?us-ascii?Q?rfOVQb75GlvFS9YnldBq1Jw5TcZ2F5YoBwnr9g748snxYRjHPsxMddQHFwWe?= =?us-ascii?Q?IicL6t/0qBGdQx2mz6ezHjwo1KA0cd9IQaU/DmkTjSYx6EpAV7C8l1Kz/zam?= =?us-ascii?Q?NaW58ff/IvFPLtBE8PAGK0EumzyeAFpC9PP+8hQo1cD7Hz/9pXmhVmQzAG6W?= =?us-ascii?Q?a+VQiyMNruSTsYJc3+NpHURCAS1AneWSWznESXOCuVlJ7K/6p0mOVx90xuF+?= =?us-ascii?Q?C9wnlzKQXIe69FHOKgNkwLlklZQ5p6vQnATLq09otZx6toAXH9fwbACxllPx?= =?us-ascii?Q?d42TgU+s/20ZKfXlZWMsiv5FmprhdprqLkLkSOclACH6AHYrcUasO2BmDZuy?= =?us-ascii?Q?1v/uzpG6ea18NJsDCGXtyZpHikfvSb+2aRp/I0n9nbs74wgNmSiHrJpcoQyn?= =?us-ascii?Q?wLAVPWpqTAlRc/SXv0m+Vnh+6mH3aFNzjUBAUSYgSKd+0yBDdY6HdPb70I+2?= =?us-ascii?Q?xSUegh2wl7tzwKW5aJKz22v/rgebskr0Db0Vxqagus+XRgeoQsWjaQHHZxid?= =?us-ascii?Q?t1mgiwzSofcamN35y2X5NQz0RD18qoygnTuqkPyZdPnPaU2Y5Sg5HOOsFscb?= =?us-ascii?Q?4V1pNh81unznwSCPX1TQ8zl1/F40tgEThoJ39tW/?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4587.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 83bb4c0d-d5e9-4ea0-390c-08dbb0d99b0a X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Sep 2023 02:08:05.8485 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: By6CCWrkL0c9LKCX58PoZJmaCRUxaOG3KkMwYipsBXnxZiH95LdhOD+OmFhznalRGwZcKtJNIQ4TJjryMcFuBg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB7931 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Xing, Beilei > Sent: Friday, September 8, 2023 7:17 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; Liu, Mingxia ; Xing, Beilei > ; Zhang, Qi Z > Subject: [PATCH v4 02/10] net/cpfl: introduce interface structure >=20 > From: Beilei Xing >=20 > Introduce cplf interface structure to distinguish vport and port > representor. >=20 > Signed-off-by: Qi Zhang > Signed-off-by: Beilei Xing > --- > drivers/net/cpfl/cpfl_ethdev.c | 3 +++ > drivers/net/cpfl/cpfl_ethdev.h | 16 ++++++++++++++++ > 2 files changed, 19 insertions(+) >=20 > diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethde= v.c > index 46b3a52e49..92fe92c00f 100644 > --- a/drivers/net/cpfl/cpfl_ethdev.c > +++ b/drivers/net/cpfl/cpfl_ethdev.c > @@ -1803,6 +1803,9 @@ cpfl_dev_vport_init(struct rte_eth_dev *dev, void > *init_params) > goto err; > } >=20 > + cpfl_vport->itf.type =3D CPFL_ITF_TYPE_VPORT; > + cpfl_vport->itf.adapter =3D adapter; > + cpfl_vport->itf.data =3D dev->data; > adapter->vports[param->idx] =3D cpfl_vport; > adapter->cur_vports |=3D RTE_BIT32(param->devarg_id); > adapter->cur_vport_nb++; > diff --git a/drivers/net/cpfl/cpfl_ethdev.h b/drivers/net/cpfl/cpfl_ethde= v.h > index b637bf2e45..53e45035e8 100644 > --- a/drivers/net/cpfl/cpfl_ethdev.h > +++ b/drivers/net/cpfl/cpfl_ethdev.h > @@ -86,7 +86,19 @@ struct p2p_queue_chunks_info { > uint32_t rx_buf_qtail_spacing; > }; >=20 > +enum cpfl_itf_type { > + CPFL_ITF_TYPE_VPORT, > + CPFL_ITF_TYPE_REPRESENTOR Defined but not used in this patch, how about move CPFL_ITF_TYPE_REPRESENTO= R to the patch that uses it? > +}; > + > +struct cpfl_itf { > + enum cpfl_itf_type type; > + struct cpfl_adapter_ext *adapter; > + void *data; > +}; > + > struct cpfl_vport { > + struct cpfl_itf itf; > struct idpf_vport base; > struct p2p_queue_chunks_info *p2p_q_chunks_info; >=20 > @@ -124,5 +136,9 @@ TAILQ_HEAD(cpfl_adapter_list, cpfl_adapter_ext); > RTE_DEV_TO_PCI((eth_dev)->device) > #define CPFL_ADAPTER_TO_EXT(p) \ > container_of((p), struct cpfl_adapter_ext, base) > +#define CPFL_DEV_TO_VPORT(dev) \ > + ((struct cpfl_vport *)((dev)->data->dev_private)) > +#define CPFL_DEV_TO_ITF(dev) \ > + ((struct cpfl_itf *)((dev)->data->dev_private)) >=20 > #endif /* _CPFL_ETHDEV_H_ */ > -- > 2.34.1