From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 95FAFA00C5; Thu, 1 Dec 2022 07:56:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8777B42D11; Thu, 1 Dec 2022 07:56:47 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 095D942D0D for ; Thu, 1 Dec 2022 07:56:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669877806; x=1701413806; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=vRF6U4URhOT9wUomlyaljWvbtn3BoH7OrCqdM4ih9Zw=; b=FkORRqPDNdNEXqucTaVpl5SqUOLH2tKAR3r5jEaXD5sWSQYsUGF8whRz dUzb1PeivO3CK+O4fGWQjHvg3+c7EqlhQNQu1A3tKg6tWFiIJCq7HLoYS H35+DplapAPqfedK/TE2zbyRdWaNj1+Cg88XQKxMmfqSLy5fvKNblAE6m pDG4XwACq4XqCoXp4cqV7hjzZ8Op3Jt70MZYx5Z76/65JdK7JeMu3UQiE +2HeDwCQdeeIGukI/z+xxCR0fiZ87QUV0DBaNv/E/AG3u9gtMQv/Q7ylq mJEa60MGmIIbiT33g8psMIfGoO32Sd6JVxcbjBVgqDUgQtws/ee+qAdr7 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10547"; a="313236425" X-IronPort-AV: E=Sophos;i="5.96,207,1665471600"; d="scan'208";a="313236425" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2022 22:56:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10547"; a="622187585" X-IronPort-AV: E=Sophos;i="5.96,207,1665471600"; d="scan'208";a="622187585" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga006.jf.intel.com with ESMTP; 30 Nov 2022 22:56:35 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 30 Nov 2022 22:56:34 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 30 Nov 2022 22:56:34 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 30 Nov 2022 22:56:34 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.177) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 30 Nov 2022 22:56:34 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RanjmlBgdDYVAHs3oo8RMqAgbBydQwvEIRgQyj/Fb6+Yr8FBmpFDHXrx5rSpVUDks+wywKnRoTZUgrq2ILpn2fThT7J2rRQsc6lU/e7/vATnF8alsWEWRRaBjUM9vcccOjCud/V5SaxcAsn5yA4u66zK7auaJjX9P5PMr2FoY2hQii+qJ+P9/XyMKuOlPnDpp2Cr3XQa7DJhb85mKKC42C5Pe1Ys4DDT9JroBkFBGzeeCH2nuZoZV1VUu8DOAqBE5rvMtbHEr1fyr3Le9UbONFe64gyBSjR5tLbBRXA4n6pvdPMz2JKz++0tZ1sVIF7RyqfVuCi9s5FQIOVbrLWoQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Go9FQqci53TH90j6s8amqrjDxkpAAleRSJZjRpHNsCI=; b=QlfAL3VDZx09d1JW/3Shd9PYO3oI+YR7NRRv3WP8HB6iM8kWHIkN3voJhbfKw2OGqeuUmioRz0/d0NMn317Iur1cUBdtYkdapT15jtUXPqbHurhLt4PjxhMog0gSVs7ue9YFEeEaIwXn995EnQq6WmJRfN2eEfQewFsABOWNHDKKk/7iG/aXmKppypPJEYgEZ1uh6VDU2MOoitmJKWhxjTcbwCGum3cMTTOJKRzlRRnsoibBHkwRSTVz3VwiO1WfXsmDZyR12QmqwIaya3O1ZEz9o7loU8fe00ErL6reUuGQ3HzZqxdHFSW42UB6vATYPZRY5oyMgrRupJU1emeB2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5911.namprd11.prod.outlook.com (2603:10b6:303:16b::16) by CO1PR11MB5075.namprd11.prod.outlook.com (2603:10b6:303:9e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Thu, 1 Dec 2022 06:56:32 +0000 Received: from MW4PR11MB5911.namprd11.prod.outlook.com ([fe80::b817:c823:b87f:486d]) by MW4PR11MB5911.namprd11.prod.outlook.com ([fe80::b817:c823:b87f:486d%4]) with mapi id 15.20.5857.023; Thu, 1 Dec 2022 06:56:32 +0000 From: "Kundapura, Ganapati" To: "Naga Harish K, S V" , "dev@dpdk.org" , "jerinj@marvell.com" , "Gujjar, Abhinandan S" CC: "Jayatheerthan, Jay" Subject: RE: [PATCH v1 2/5] eventdev/crypto: wrong crypto enqueue count stats Thread-Topic: [PATCH v1 2/5] eventdev/crypto: wrong crypto enqueue count stats Thread-Index: AQHZBN6xGlmygckBM0WgY9fhAjDDBK5YjMcAgAANXLA= Date: Thu, 1 Dec 2022 06:56:32 +0000 Message-ID: References: <20221130171014.1723899-1-ganapati.kundapura@intel.com> <20221130171014.1723899-2-ganapati.kundapura@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5911:EE_|CO1PR11MB5075:EE_ x-ms-office365-filtering-correlation-id: fc818365-abc5-4058-8808-08dad3692e39 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ToZpWG8/xE9FrF4LoxuXBTuV/4vMcDjXHEdA3Yz2oljy+JXFXnwzNYaT1OgYsw5dzNy4WqVDNa1Cp0N2hBNkIxov6xfTEx2E2+kABF5uojmFhLpU14jqgxqu7L+S6zbqVAbmhvs7EznE4NQ1XTcAo9YVgQaeodb6AmZnja5OfQp+I/oCpMWSHc711Rf6wnVL8hc3YDHOJKV8u7nUyOQXhjbNZewk/xZf6gld+TcSIhK+/etIaaKE8VOmpqHIzwKMFytTx61AV7w7KkzN9r//EZY9EDFb3PY1FmVrNSlVG1FW0MRjS1pfvrZoC0vvFJGwTSAGcxear2gO8zbgSh0oDzINdaap6SwCyO31n41PlQc9djdN+PP76sLIDRuVUAZ6S9Zb78Sl0TzMOCvENqDrUZhSc3p1Su0S0v4domiVkm7ZBe6/E/d+1Lkv3qkGjna1OOg0RxxfsirI9cJo2V239snmxWl24B4x5cbSsv2NN4z9Gl5VT3+SwYbV8un1KocKecLXlmWrMpmTGP0bgx00F9ZPk1/M7phK8yLB2T70ixLwhHb7pyrMnfzNJ9n4OxFux9NHAbaBJkiUpq7u/19+SZCRVF8Z6l4ugozdroNwy2237bFHjIJ73ZY6o4N1VELgz1vxjBSh1voXIQ1pETguQ5jOLXvwOCwFx1ewte+anR56BcUeFqrH4R//7tj1cJnUl1iiosw33JMLoCopFyo1+4EYvMUQKIi5RvC8vSsKnemYf+k2QIVGV2xzcPl7VjEmrzjJlfyWC4Bsdf0bkyig7g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW4PR11MB5911.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(346002)(39860400002)(376002)(366004)(136003)(451199015)(55236004)(316002)(53546011)(110136005)(26005)(6636002)(7696005)(6506007)(9686003)(71200400001)(107886003)(966005)(4326008)(8676002)(64756008)(66446008)(66476007)(76116006)(478600001)(66946007)(66556008)(5660300002)(52536014)(41300700001)(2906002)(8936002)(186003)(83380400001)(122000001)(38070700005)(82960400001)(38100700002)(86362001)(55016003)(33656002)(19273905006)(563064011); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?egXu4ekkCa58TZdcayIraZu940aeYmYLBddZbJ2MreoCapVZyI/gAGnWg8r2?= =?us-ascii?Q?IfEV1rAzAO3uBZS/MWk1tamseZUQecucFeIPcyX2LoALdNvWRh5Ns22QiVfD?= =?us-ascii?Q?myVZcImByvgZ7MeIGFew8Pmf6npCPZfz4XSrmH+4gkqygM+int1nZcHwCxHz?= =?us-ascii?Q?2gLdQSfV29mEXC06toZMWwaVQMpxVeplGXKLBiuzeVMMjN1G940P6urgetIk?= =?us-ascii?Q?8mn9gssUjUe0/zfuiAAIT6w5BXwJIPX31KJfBmG4yNktcbNgqFBOdZ/AoXZ+?= =?us-ascii?Q?O+JLUhbArmlFeUJFKZYffzExPCUiqh1TIPtNqdNKyPwQvB/LD0XnK71xJBKn?= =?us-ascii?Q?h17cP9q4Sy9kL3T11JVtcpGDIX2oXOcRsPb4xPU76gaeTaGuRUQ9/uwtbyrR?= =?us-ascii?Q?lnuFoZaW1dCQYJV2MUO6JWtvweUNfjAisxz4TQWiKmwG8gvXs4gPRDn/1njd?= =?us-ascii?Q?SCRx1TKdgfWfcOvqEQE+8XoVYq0OTkXa4Bw/HNW1YMWDPUs3EfR3G3U58Krg?= =?us-ascii?Q?mCTC0dcdiduYuEX9bf68ymiIvqnTo4/pVxwQPxO858v/ve+Xij+yVzen5ybe?= =?us-ascii?Q?Knkr2dc3CmyVD//ynig2ZYedFRd0tFI2jFy0Pdzzv/FOiPwkswNCctvX0dvE?= =?us-ascii?Q?YJvGCImqr4RKx/+Nh1Wk95ScEbZnxWfZk6FT/NaiJXCNhDQxb4900Wwl0uiL?= =?us-ascii?Q?/NiQkjp5bdr/tN9oLn4Fl49mCWqDvHGTJ8mb6EZ5VLzDVYoZqYSm82kF4Y2e?= =?us-ascii?Q?9F4S6SRHM8Pp7WcHqT9auk8YO23Y7ifJBHvNiNmN5nw0iyv2nT6VMj3W01Ey?= =?us-ascii?Q?/jJzHuJ+dklNR/4tSEhn99V6px6dyXJIS4v1UkqgdJei71LhVJZTbjKB0JXe?= =?us-ascii?Q?xB8I4m63CCwc51eAX+ogypAuyj8VOgbksfgrIFp31YIJfGviAJhUXyHrbkZ4?= =?us-ascii?Q?pJhU2kNHuvxybIh213Kle2rWtjGLxPxJcsRvgJQDzsPUh4dAd8Hx3kIGCBn2?= =?us-ascii?Q?Zb9RG6uKIHU4mmrJcXdIUZ7nfUwWxNm8RC6WtERPxOZCBgO+3E6sS6rtIp1u?= =?us-ascii?Q?4HAnOMglx574LomeDJIyCfYMKI3j1jsWwM2TYXkm1vfxDX2hb+0fTzjxRB2x?= =?us-ascii?Q?g0c183NF6CZjn6UL0ZQRMp3oEDS+2WddAw0NOln5HrKzgV/2UD2CqQbBrlt8?= =?us-ascii?Q?wvhRnsyYh3vUrJNl/TozoG/62mzZx0CjeRoPRcCn0OSswihd8PN2IV+N9X19?= =?us-ascii?Q?HL0FgUn4dWF0rtOuYCmoPMga8VaSucoyIg0qk20kasCH4zwT1c0cDmt2Po3t?= =?us-ascii?Q?eIzFOEFD2PecyFMdJZtz39Kqil81JVonL42gKGFcldZzr0Jjd88GkdQdDy+h?= =?us-ascii?Q?jCms8xf7cfGXC/JZt0YVtatrNcBhP3UsW8OxK8w17974N6Pxb782kbwmE05i?= =?us-ascii?Q?i691MudFYzlt5ucscOvDrxOGQ3nNs8zbGSXH+88INu1qZqUO1/K4w6EsR5Tn?= =?us-ascii?Q?qKJ+NMzB5kLmnPVYMcN+lsaMMf82c8n9gszxW7CxjL1Bh9NjGFqgYOS9lGq/?= =?us-ascii?Q?IiuKR9nk1AknwMxTHIir/w0bmxfKRzUs+ShIQsgLmfATkMHpXH2t1X7PuThE?= =?us-ascii?Q?og=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5911.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fc818365-abc5-4058-8808-08dad3692e39 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Dec 2022 06:56:32.6270 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +nbPcqJq2TSC9VW6SZW5R5Ex4H7/YUIkJcEBqJ/5bHCjPi4C0PSkK6ZzreuSlR3g6BoiJSuA8sDbTB2qsHmf6WsoI+bZ4pQbngO6oryLPSs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5075 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Harish, > -----Original Message----- > From: Naga Harish K, S V > Sent: Thursday, December 1, 2022 11:38 AM > To: Kundapura, Ganapati ; dev@dpdk.org; > jerinj@marvell.com; Gujjar, Abhinandan S > Cc: Jayatheerthan, Jay > Subject: RE: [PATCH v1 2/5] eventdev/crypto: wrong crypto enqueue count > stats >=20 > Hi Ganapti, >=20 > > -----Original Message----- > > From: Kundapura, Ganapati > > Sent: Wednesday, November 30, 2022 10:40 PM > > To: dev@dpdk.org; jerinj@marvell.com; Naga Harish K, S V > > ; Gujjar, Abhinandan S > > > > Cc: Jayatheerthan, Jay > > Subject: [PATCH v1 2/5] eventdev/crypto: wrong crypto enqueue count > > stats >=20 > As per the DPDK contribute guidelines, the subject line should use the > imperative of the verb (like instructions to the code base). > http://doc.dpdk.org/guides/contributing/patches.html > Please change the subject lines for all patches in the patch set wherever= it is > required. >=20 Updated the subject line and reposted > Also is it optimizing the stats update or fixing wrong stats update? >=20 It's fixing of wrong stats > > > > crypto_enq_count is updated on failure to enqueue ops to cryptodev. > > > > Updated crypto_enq_count on successful enqueue of ops to cryptodev. > > > > Signed-off-by: Ganapati Kundapura > > > > diff --git a/lib/eventdev/rte_event_crypto_adapter.c > > b/lib/eventdev/rte_event_crypto_adapter.c > > index 1c0a22b..ef3dbe9 100644 > > --- a/lib/eventdev/rte_event_crypto_adapter.c > > +++ b/lib/eventdev/rte_event_crypto_adapter.c > > @@ -485,6 +485,9 @@ eca_enq_to_cryptodev(struct > event_crypto_adapter > > *adapter, struct rte_event *ev, > > cdev_id, > > qp_id, > > > > &nb_enqueued); > > + stats->crypto_enq_count +=3D nb_enqueued; > > + n +=3D nb_enqueued; > > + > > /** > > * If some crypto ops failed to flush to cdev and > > * space for another batch is not available, stop @@ - > > 495,9 +498,6 @@ eca_enq_to_cryptodev(struct event_crypto_adapter > > *adapter, struct rte_event *ev, > > &qp_info->cbuf))) > > adapter->stop_enq_to_cryptodev =3D true; > > } > > - > > - stats->crypto_enq_count +=3D nb_enqueued; > > - n +=3D nb_enqueued; > > } > > > > return n; > > -- > > 2.6.4