From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EE31345843; Fri, 23 Aug 2024 09:27:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8F72F4025E; Fri, 23 Aug 2024 09:27:46 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by mails.dpdk.org (Postfix) with ESMTP id 4DC6B40150; Fri, 23 Aug 2024 09:26:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1724398019; x=1755934019; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=eg5wP/ZR3HmPkVapl0v6YCFGJf/fU+X4C8sPgHBcYJA=; b=bpEriZecMtrxJQO2VnBxstKCvYqYVHN2QDI4dYTxd31HatDMZ+5gdqk9 46Fv+O3z7bi814bj0NN2JmV2dKacBt4sZbpqz/5mDR1j7Lh7Zzm2n0a6O SU3VwtRZfvMswhS5gDC3PNsWAECMnuC6YA7WqwrYLtlmIuiS+b8U5usrk 8rpAegXIWYLA3L3xFqw4B4gAZBy0+PB8urEmC/sKOQ4QRZJ2mcvLwR4Hz LYZvwHzRcmJB388lB+zICkdvYHJRf+zs2ttqIpAfk+t+vcaHNQr1IRIjU ZJCEag3QGzyjcAtDIbGtlBi6xdE31q+0ThblUjklhYM0B3bi6w+ctqG6T g==; X-CSE-ConnectionGUID: rcAPKqEaR5CrjjYta9Jt2A== X-CSE-MsgGUID: +UUy4W/XSF+OB2cozogw8A== X-IronPort-AV: E=McAfee;i="6700,10204,11172"; a="26721592" X-IronPort-AV: E=Sophos;i="6.10,169,1719903600"; d="scan'208";a="26721592" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Aug 2024 00:26:57 -0700 X-CSE-ConnectionGUID: hSneQWtrRaS9HaVQkmxNNQ== X-CSE-MsgGUID: ydyyKD2hSn65e53j8JNefw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,169,1719903600"; d="scan'208";a="61387425" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa006.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 23 Aug 2024 00:26:57 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 23 Aug 2024 00:26:57 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 23 Aug 2024 00:26:56 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 23 Aug 2024 00:26:56 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.171) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 23 Aug 2024 00:26:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UkHitkFkwCVW3Avr+MLTdzPF0M6GxofOOh5+mpxU5LBt0l9MTSN/sJgN6c7khWvGDFETB9FroABBehBDkTMvKog7YKuXd9X8KauyDgU2ygn/vyrW2JXlZ+PlmEgesXPcPrBGF9LdQTH2IPmXb393VLZmg6WU45DuZE/ITqAYoikloXQB1idAINzJIFZ9dwR051PNfUY77yV5l6I4k5ngyWWsldUtbMjTIqAO8iURVUBU6h8Z3sqyAacnhat47pM7ZEcHy3DB/viyr5q1BILFEqs/iDOJEdiKaekDd1uIbEZJIobCdYlDeAqLSD4gLSzel4NQw2zQKijCEZ72vOepIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=599Uk8NHfNPk/mowMb5NAPOe7b7ijC19kgmGNy9ORsE=; b=C2HzAVgcKzwi+Iyqski7B9UUf/dI3UvwEf9+nU8DaAYyafQRhtk0uJikU42akeB2FiMXwXVKdcMFA/+puO0jN/pwhp/pvjfhzv1ytYB68M49xQK+Xkoj1W+3h0zOPpSzZzj9f8z5hBERnA0NuF8XqAX1cWXepKfVmRFXS0OyACliRsUSfQOgQ0s0YsNHlDFZ/E8BcAlh9PH+77s9/uqHOsARF5Z5e9M4gh5Dx2UeAku2WH5kaycv3x68Nz3Q3sxzI03VSr54kGETFXxnFwIej2B78SYdMv6Zk1B850O/oZtA8umEhEPdT/wLZDquNkTmmy5/plKk4JiHqZWYibX92A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5911.namprd11.prod.outlook.com (2603:10b6:303:16b::16) by IA0PR11MB7378.namprd11.prod.outlook.com (2603:10b6:208:432::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7875.20; Fri, 23 Aug 2024 07:26:53 +0000 Received: from MW4PR11MB5911.namprd11.prod.outlook.com ([fe80::1d00:286c:1800:c2f2]) by MW4PR11MB5911.namprd11.prod.outlook.com ([fe80::1d00:286c:1800:c2f2%6]) with mapi id 15.20.7897.014; Fri, 23 Aug 2024 07:26:53 +0000 From: "Shetty, Praveen" To: "Richardson, Bruce" CC: "dev@dpdk.org" , "stable@dpdk.org" Subject: RE: [PATCH v1] net/cpfl: fix invalid action types Thread-Topic: [PATCH v1] net/cpfl: fix invalid action types Thread-Index: AQHa4n9/FURN+R8HXEy/eLht/TzR1bIzl7uAgAD0p/A= Date: Fri, 23 Aug 2024 07:26:53 +0000 Message-ID: References: <20240730114540.1048785-1-praveen.shetty@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5911:EE_|IA0PR11MB7378:EE_ x-ms-office365-filtering-correlation-id: b328709e-8978-4bc1-d5ad-08dcc344f64b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|1800799024|366016|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?FkLH6JNBztLsByGsnIvEjVUeBkzoW/LUq0gcOC2jkHOzcHpu9TpWVAKHr9eq?= =?us-ascii?Q?1ysrbG0LPEd3q60kxdQXa8xIV8zh5WKAP8258hEiYDZ56MKJpAMQzSfb3Mq9?= =?us-ascii?Q?iAKIgwAczSz1cRAIa88s0jpDDu7zKsQ0m02tANGtJv1A8mY5efdY3G0JqyVv?= =?us-ascii?Q?3tRo73lrjSBKlpLmOpv4M6P9f+gdTzlPvkgiSOxZWruA8DIhztye+pRi7t7X?= =?us-ascii?Q?5a7Q5xEAQzWci5KA0XwXdKp+fS8XZx1sou3Rup6qKL5NWNhWRsyM9F63ii1s?= =?us-ascii?Q?AieNW9YhYgfiEIcvmjMHXUj4T8HiGlHHlFZPMLTmo3IvM/DRQOXdlCy2JnjE?= =?us-ascii?Q?vTh98gL2v2aVrJZObnwxRiMhmNePOz56tbb/bKtMN0B96D6s+3iQJFl3pKHm?= =?us-ascii?Q?udViBZBGHz1s9T4c15KV3oTWx+6nvBd+Lq6jl0CPD56uDVQFX88055G4ETMO?= =?us-ascii?Q?e21FymoOyl0lqkYiz4QEYJs7ttTNMgmm6LVIX6a2axxm0F1uDoUbDac8/7Ir?= =?us-ascii?Q?dFJdxi6vlSv4o2YvTMB5NG/+oe/2egeVtmCW3aKhDYkQ8lAJ8vbZHYy4MHmH?= =?us-ascii?Q?TSyaMGl9Gp9zv3Aaewx/IwSO2UC5zmnKiPAvLX79g4FtpGKUYxjHnHQku5xp?= =?us-ascii?Q?99FTOgbmmiwxS2Lmkd+Z0Oc6h62r0ty1edtlZ1Lrd9mutkD+iuSKe0ZREGTA?= =?us-ascii?Q?D2FkGcLM3aCo2D5w9ixjrFN4F4EyHqGbx2lexK9x2X01uDYGVXxkq0Dd0vo8?= =?us-ascii?Q?hjWequtKgpH4t6QCOiCt4qFNamWSPDfrjGPNZrQeSS2GwuSCuwnvliUgndof?= =?us-ascii?Q?nGC4AMCOcs50+YCqzIcrAAb3W7yXwo0nJp8TyTG+VJWDm61al5CWWFRYbKba?= =?us-ascii?Q?Gtiqh7x3EYErLBmrzS1DWlrajvSFzEHiOjzkGOu/80XENscaLBjmYVaNglQq?= =?us-ascii?Q?dTEGX0ItzTwtLrOOxbBdFI26kNXs8lYMS0lCzR6T/H/xbGn4AkI2rsI2HSED?= =?us-ascii?Q?2g+Z5dpq0/qRrevquh8SNtbVF2SwAoF+VZ2ijrkNRaGU9LRL1WqIqynYkNZl?= =?us-ascii?Q?GULAFv9Xf+6CMktq5JTMe+H+3SC9bjjHiURmmqXJL3lpdSl7SZunIgjgQsSN?= =?us-ascii?Q?oIWx2kAvyD0Szj/eyz27RDFSN4vMu0y30G9/3Z4Q8hIKFVQx11lSYCaDS4OJ?= =?us-ascii?Q?OTdDYR7GpQ5b3xaRkAGoy3Xs1/dwQt6cKfDE1yeiKvCFcC9nHftAuPwPplK1?= =?us-ascii?Q?CoTJxsRodvDQmq3JNmz8QpvbHc6wo6+64+Kdh6Smp5MdrEaJrd5f7jCnmhDq?= =?us-ascii?Q?xeYNBC+88JceEGYKER27H1tvyYf0DZ7olS/Ct8Xru0sNdiqKyVl8OXzmpm29?= =?us-ascii?Q?YByXnIQusB1fm/6t4CB6GAvKBUQr5XkHGAmym3QujnkZYszzjg=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW4PR11MB5911.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kf6ghYYSkg4wm2XzC+H0y047uMJJxKuw4AgZ2EoQS1Ib8EiClC4pwnnBXNvV?= =?us-ascii?Q?wY1oSiJrtJQIMFcnDcsz4IDNiS1QUvNHmrQr2lQSopyXXfA2JksOUd/Wm9Hy?= =?us-ascii?Q?dCrJXf/LLMk+4y5y5tdhqh5eRlmL11W6++a1OcxIXxwZMYDyvEs96xICoHGB?= =?us-ascii?Q?IyZf5HAk4lctnegmFlT9RFUxztvu8UZhTVBRegc4ZQjfWyQ/mg7l9Q9hHv3i?= =?us-ascii?Q?FR+R0RcyEz9o6rUEn0QaP1u4vlVCv+nuZU/ta4jvkT8APJjrhshzJFjb/r9/?= =?us-ascii?Q?ywrfys9X/mu6eWBN0DZZoV1g821785vBv/VTqRw5cgcPJTJq6BPidskI6HgT?= =?us-ascii?Q?iEoceQ1tW528+RHhoTgBX00uGjb3ZOIbRZhufB3u1YuFlF9Ujjg/MniBT2bA?= =?us-ascii?Q?uRx2iWA9Q6yIJBhSVCAkpLLpmgO/mmU2LtfS5OuKdItK4xZnqkjxRsP3t7Ua?= =?us-ascii?Q?FjbE8dHDU2PHJx3h2z5IArZZZhGYf+93mVVq9C8VBEr3Kuk2aL+y5cpDbN8B?= =?us-ascii?Q?Xt+nam4cje7sXBiggvMSwrU1ED0tmZVuMPSCfd/xauHxxzR+rne5fRwOXonq?= =?us-ascii?Q?9BJPLToMBmIQsIH8Mp8ud0ezq653eGrirvg6Mm5j6z9r2D7BeXM7FtI63l/s?= =?us-ascii?Q?4vOZWYjH+Fh5klBacR5c4RVtzVoo21ynGcZbXsrceWRwZEJr2sgK1sU5vt70?= =?us-ascii?Q?5wZHwdyd3lDIpncN7NUOv4f9BoVL7KTKtpryfeA2eaKimVhru5BdNZjnn7bV?= =?us-ascii?Q?3W7GH3y+8U5oA+5clZR50QnZgqju+bZU0SUYZiXonlD7MKtrZtq9+JNXH7Ed?= =?us-ascii?Q?gkytdlePip+s0KGdliAQqQPS5CwpLilmdZWBpWlQ+uPDR51ExCW3iF8hZEM6?= =?us-ascii?Q?M0c8pGDGCsoNfuQQC8v+t4Edk6ZloUeajyZhDsz8xRBVE6QFQmGPGa1kVK7E?= =?us-ascii?Q?yQ5ewLvXc7pzOOuz1IhL9mnHTmNWgNwQQryuhoLFuIiOqrEMPBTA6Jq51iOh?= =?us-ascii?Q?xst6ghpwfmh5xV+KjSRAs77NmiCoAplGq6m7/DjSDtghQuY/+hryrkaXqnCH?= =?us-ascii?Q?T0kHFYU7UgkUObd6GVt9K1s4Vz4uy4FaSVsVeV3Mx6c3vTx2TQTuwDww5Fvr?= =?us-ascii?Q?PuI8CJTR96EzgJufKF9PJrAtU2FvRebjhPcBZcGfkRF+uBCNeXHqae8G6kDa?= =?us-ascii?Q?VHL9YngyMckRmdsW6VVIWQ3BKyC0Ze9Jes5gRmCpHcpoLS8duTzSN3KzuRXD?= =?us-ascii?Q?1Oy3/Bc4Neg11w1KCCdqzSmF6mXSz+qHkd4fCrfENAlJotBtpuFGTw0phi57?= =?us-ascii?Q?ORu30XUjJhaQ/da93KK/J3XwahRU+xpJhU6gAOqg2KK9ENadu34OpqjVewY2?= =?us-ascii?Q?zE61vl/pXNfyqBXLRcGGmRrtdHr3YFMn4EAyUgF+zY6zHg5N8sZCwyppPoBl?= =?us-ascii?Q?O4IIaUPdpisCRK1t24yN3BG/z8pBQjj9QMi/52mzz00ngygeQ8C2PGINCUyU?= =?us-ascii?Q?5ZRtkeYbzobY/6zlvDG5R8ZVyn6qajHNF6cyd1PkZ/UWq/UMBQG6VP3aCbBq?= =?us-ascii?Q?41hwS9/31Tmy8HxX6z4yaQtVZr0C3gBQUsSrrXKq?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5911.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b328709e-8978-4bc1-d5ad-08dcc344f64b X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Aug 2024 07:26:53.6855 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hSHXnTXm4kg0FMOqIM9R3iXbWEra9u7MNuhaVInVvtjfY2W/5Jv7yT2AtPBcwl8eLkgHMhPo3TFHLgDyVewdvK2enc7PN2HtrUoNcWP9Sc0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7378 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > In case of CPFL PMD, port_representor action is used for the local=20 > vport and represented_port action is used for the remote port(remote=20 > port in this case is either the idpf pf or the vf port that is being=20 > represeted by the cpfl pmd). > Any mismatch in either of the cases PMD will throw an error. Just FYI, you don't need to wrap lines in the commit body at 60 characters. 72 is a more normal log width to use. Thanks, will incorporate this from next time. Comment inline below. Will fix on apply. /Bruce >=20 > Fixes: 441e777b85f1 ("net/cpfl: support represented port action") > Cc: stable@dpdk.org >=20 > Signed-off-by: Praveen Shetty > --- > drivers/net/cpfl/cpfl_flow_engine_fxp.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) >=20 > diff --git a/drivers/net/cpfl/cpfl_flow_engine_fxp.c=20 > b/drivers/net/cpfl/cpfl_flow_engine_fxp.c > index b9e825ef57..e760acd722 100644 > --- a/drivers/net/cpfl/cpfl_flow_engine_fxp.c > +++ b/drivers/net/cpfl/cpfl_flow_engine_fxp.c > @@ -292,6 +292,17 @@ cpfl_fxp_parse_action(struct cpfl_itf *itf, > =20 > is_vsi =3D (action_type =3D=3D RTE_FLOW_ACTION_TYPE_PORT_REPRESENTOR = || > dst_itf->type =3D=3D CPFL_ITF_TYPE_REPRESENTOR); > + /* Added checks to throw an error for the invalid action types. */ > + if (action_type =3D=3D RTE_FLOW_ACTION_TYPE_PORT_REPRESENTOR && > + dst_itf->type =3D=3D CPFL_ITF_TYPE_REPRESENTOR) { This indentation here is problematic, because by indenting by one tab, the = continuation of the condition lines up with the actual body of the if state= ment. Two formats are allowed in DPDK to resolve this - either line up using spac= es with the opening brace, or use two tabs to double-indent. The rule for w= hich to use is to follow the convention already used in the file you are ch= anging. Thanks, will take care from next time. > + PMD_DRV_LOG(ERR, "Cannot use port_representor action for the represe= nted_port"); > + goto err; > + } > + if (action_type =3D=3D RTE_FLOW_ACTION_TYPE_REPRESENTED_PORT && > + dst_itf->type =3D=3D CPFL_ITF_TYPE_VPORT) { > + PMD_DRV_LOG(ERR, "Cannot use represented_port action for the local v= port"); > + goto err; > + } > if (is_vsi) > dev_id =3D cpfl_get_vsi_id(dst_itf); > else > -- > 2.34.1 >=20