From: "Xu, HailinX" <hailinx.xu@intel.com>
To: Luca Vizzarro <luca.vizzarro@arm.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Patrick Robb <probb@iol.unh.edu>,
Paul Szczepanek <paul.szczepanek@arm.com>,
"Cui, KaixinX" <kaixinx.cui@intel.com>,
"Puttaswamy, Rajesh T" <rajesh.t.puttaswamy@intel.com>
Subject: RE: [PATCH v2 7/7] dts: update linters in doc page
Date: Tue, 17 Dec 2024 10:15:05 +0000 [thread overview]
Message-ID: <MW4PR11MB59120E5EF8F67783AC929AFC9F042@MW4PR11MB5912.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20241212140013.17548-8-luca.vizzarro@arm.com>
Hi Luca,
There is no error with this series.
The error is caused by the CI doesn't apply any changes with doc/*.
In history, Community decided to exclude doc/*, as doc/* change frequently, especially the release notes, cause a lot of conflict with main tree.
We manually merged this patch and successfully compiled it.
Regards,
Xu, Hailin
> -----Original Message-----
> From: Luca Vizzarro <luca.vizzarro@arm.com>
> Sent: Thursday, December 12, 2024 10:00 PM
> To: dev@dpdk.org
> Cc: Patrick Robb <probb@iol.unh.edu>; Luca Vizzarro
> <luca.vizzarro@arm.com>; Paul Szczepanek <paul.szczepanek@arm.com>
> Subject: [PATCH v2 7/7] dts: update linters in doc page
>
> Ruff has now superseded all the previous linters and formatters. Update DTS
> doc page accordingly.
>
> Signed-off-by: Luca Vizzarro <luca.vizzarro@arm.com>
> Reviewed-by: Paul Szczepanek <paul.szczepanek@arm.com>
> ---
> doc/guides/tools/dts.rst | 26 +++++++-------------------
> 1 file changed, 7 insertions(+), 19 deletions(-)
>
> diff --git a/doc/guides/tools/dts.rst b/doc/guides/tools/dts.rst index
> 8c972c31c4..abc389b42a 100644
> --- a/doc/guides/tools/dts.rst
> +++ b/doc/guides/tools/dts.rst
> @@ -416,32 +416,20 @@ There are four types of methods that comprise a
> test suite:
> DTS Developer Tools
> -------------------
>
> -There are three tools used in DTS to help with code checking, style and
> formatting:
> +There are two tools used in DTS to help with code checking, style and
> formatting:
>
> -* `isort <https://pycqa.github.io/isort/>`_
> +* `ruff <https://astral.sh/ruff/>`_
>
> - Alphabetically sorts python imports within blocks.
> -
> -* `black <https://github.com/psf/black>`_
> -
> - Does most of the actual formatting (whitespaces, comments, line length
> etc.)
> - and works similarly to clang-format.
> -
> -* `pylama <https://github.com/klen/pylama>`_
> -
> - Runs a collection of python linters and aggregates output.
> - It will run these tools over the repository:
> -
> - .. literalinclude:: ../../../dts/pyproject.toml
> - :language: cfg
> - :start-after: [tool.pylama]
> - :end-at: linters
> + An extremely fast all-in-one linting and formatting solution, which
> + covers most if not all the major rules such as: pylama, flake8,
> + pylint etc. Its built-in formatter is also Black-compatible and is
> + able to sort imports automatically like isort would.
>
> * `mypy <https://github.com/python/mypy>`_
>
> Enables static typing for Python, exploiting the type hints in the source code.
>
> -These three tools are all used in ``devtools/dts-check-format.sh``,
> +These two tools are all used in ``devtools/dts-check-format.sh``,
> the DTS code check and format script.
> Refer to the script for usage: ``devtools/dts-check-format.sh -h``.
>
> --
> 2.43.0
next prev parent reply other threads:[~2024-12-17 10:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-10 10:32 [PATCH 0/6] dts: add Ruff and docstring linting Luca Vizzarro
2024-12-10 10:32 ` [PATCH 1/6] dts: add Ruff as linter and formatter Luca Vizzarro
2024-12-10 10:32 ` [PATCH 2/6] dts: enable Ruff preview pydoclint rules Luca Vizzarro
2024-12-10 10:32 ` [PATCH 3/6] dts: fix docstring linter errors Luca Vizzarro
2024-12-10 10:32 ` [PATCH 4/6] dts: apply Ruff formatting Luca Vizzarro
2024-12-10 10:32 ` [PATCH 5/6] dts: update dts-check-format to use Ruff Luca Vizzarro
2024-12-10 10:32 ` [PATCH 6/6] dts: remove old linters and formatters Luca Vizzarro
2024-12-12 14:00 ` [PATCH v2 0/7] dts: add Ruff and docstring linting Luca Vizzarro
2024-12-12 14:00 ` [PATCH v2 1/7] dts: add Ruff as linter and formatter Luca Vizzarro
2024-12-12 14:00 ` [PATCH v2 2/7] dts: enable Ruff preview pydoclint rules Luca Vizzarro
2024-12-12 14:00 ` [PATCH v2 3/7] dts: resolve docstring linter errors Luca Vizzarro
2024-12-12 14:00 ` [PATCH v2 4/7] dts: apply Ruff formatting Luca Vizzarro
2024-12-12 14:00 ` [PATCH v2 5/7] dts: update dts-check-format to use Ruff Luca Vizzarro
2024-12-12 14:00 ` [PATCH v2 6/7] dts: remove old linters and formatters Luca Vizzarro
2024-12-12 14:00 ` [PATCH v2 7/7] dts: update linters in doc page Luca Vizzarro
2024-12-17 10:15 ` Xu, HailinX [this message]
2024-12-20 23:14 ` [PATCH v2 0/7] dts: add Ruff and docstring linting Patrick Robb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW4PR11MB59120E5EF8F67783AC929AFC9F042@MW4PR11MB5912.namprd11.prod.outlook.com \
--to=hailinx.xu@intel.com \
--cc=dev@dpdk.org \
--cc=kaixinx.cui@intel.com \
--cc=luca.vizzarro@arm.com \
--cc=paul.szczepanek@arm.com \
--cc=probb@iol.unh.edu \
--cc=rajesh.t.puttaswamy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).