From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2AF0AA00BE; Sun, 13 Mar 2022 14:21:26 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0072240E2D; Sun, 13 Mar 2022 14:21:25 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2089.outbound.protection.outlook.com [40.107.223.89]) by mails.dpdk.org (Postfix) with ESMTP id 1B4CC40698; Sun, 13 Mar 2022 14:21:24 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T9LMNBmjDZ/pKd5KYUP5BlOfWXGfDeQ+eoYYf5novEzaBbk4DpEhhMh4VJNYBlGCW7Db9dq34N1wvIz6lIxYVWnT2DCr0S6vLcNmLBk4uFZ6LycKke9TEKPpIZ6OjBQ74G3R/QcuDXbigEURuZS3J+3N3XJ7AgAgmsMLAfQ5pPRJQ5dqT4uXorAOpFymbAmwTq80kRXgYoDab3DAeITbzr306wEgOXWESONRdVZoxQcmSuBzKMjO5WsTZItTiz4rjSyHZKsOujECMUSp5ZgVbU1PR0nvgjFP2pmW1F11oNHV6miSqiqxy07Gde28rBHjcDEclYjko2Zd4mzPHapuEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7PKs7eiUX/UGj5+xXSWgAkoB/VblWHJeyTgGUefmuVI=; b=UfrVP1R515nqPCLSsgjScU1emTfr5FQ0CY+zbADBbkSFLWz3hL884gq/PlJMDY1suyjaOyDvxz7UBfJyPcE8BQSMvW1zqeiumwd8eFdKr3E+Dt4vMscAqhQw41LdOXYg/uTaH5SNxSDbUDcSaQErFXjkBWxOLfjGWr2WMX3ZZf+cGOr3KBk9dwmtp9rCgB2L+0BdEJGQXTXEoaVA3igt5FDqAmLMSe4qbCU4nijXK1bPlPM4Wn6xmaEs8mWLScJ9QOR9AzPGGICvB7CxtfQWUFUh9hVhXRGN8EnGAjbcGxBWFlhyOBkaqfT84HJZpM8Bc8eN0++9JS+wvrCnbDsP9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7PKs7eiUX/UGj5+xXSWgAkoB/VblWHJeyTgGUefmuVI=; b=UTSCINHfjI1aOzX8DSzG0qABUIg5ODINr8d2wm7FTAPUlsXyvLHiASeEQLMWeFIWJlMnZbCELZiS03hUdWnFrKvFnWeQdUe25qmuRKwWlnuR1chihGL6FnR49g+I621VHONj+iEC6NRL7GiKzqBsEyVFrnktNGvoye3E5/Jk9DQZD5Vz9okZvWl6SXMyocxf0O8Npc86e39ey9aVK63lRxI91OPfNMwuv/fv8Onh8ZT6UvIp9mkSSXmNgj+ipLY1Mi+OeurfFurze9/ifb/GDBsnL5IswRnz2W+hXr9kS4eUDKqNhA8Cpl+IMQ5kBp8FvkANtuKERd8T+A6mVqd4Qg== Received: from MW4PR12MB5668.namprd12.prod.outlook.com (2603:10b6:303:16b::13) by DM6PR12MB3755.namprd12.prod.outlook.com (2603:10b6:5:1c2::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5061.25; Sun, 13 Mar 2022 13:21:21 +0000 Received: from MW4PR12MB5668.namprd12.prod.outlook.com ([fe80::1145:14fd:7de7:7efc]) by MW4PR12MB5668.namprd12.prod.outlook.com ([fe80::1145:14fd:7de7:7efc%6]) with mapi id 15.20.5061.024; Sun, 13 Mar 2022 13:21:21 +0000 From: Tal Shnaiderman To: Adham Masarwah , "dev@dpdk.org" CC: "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Tamer Hleihel , Idan Hackmon , "dmitry.kozliuk@gmail.com" , "stable@dpdk.org" Subject: RE: [PATCH v3] app/testpmd: fix show RSS RETA on Windows Thread-Topic: [PATCH v3] app/testpmd: fix show RSS RETA on Windows Thread-Index: AQHYNtnq+/RueWTXvkSEoMco4dAr2qy9TLXg Date: Sun, 13 Mar 2022 13:21:21 +0000 Message-ID: References: <20220310175023.2552-1-adham@nvidia.com> <20220313125702.11884-1-adham@nvidia.com> In-Reply-To: <20220313125702.11884-1-adham@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fb3781a6-6f78-446a-11ce-08da04f45d6e x-ms-traffictypediagnostic: DM6PR12MB3755:EE_ x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HOvRxWx4yOpY+Kb7+VNDrN3f51/AnUj5rM8LqU4GzZpv3Y041GL/+fCYpUOsqqedr4JwqlCB8iAhEz92NcxRbAwLJT/webqHLnc5j/mBsZBL6oVlaXcqTivWofCBGceki/yQZhd76Ix1t+lu71YQ25jr9YQeqI6DVX4FlwaUCzJ1/CaH7qwFwjN99HA0vgj1gv71qRDjAZi8xN2A/B2WISNzGX7FlYAaQGHe9wvmjYWPU14PUy8hz5ncuMkav5rGyhzvYyLXWoU8pYnEP18Xlgg3MFXai/A6sxb6RR5ocysun2Tk5OYkdMiXgZrk/dLTBI5raa2WRECXo0iGlellYBY0WSwQmb8OFilptrS46A7UiwY4cdY09X47gjx2meGJeMstC2AaFEYkv31xHzWrjtXdqdevFbbZPlTEUvnxEQQxqgzM6+bSK/Bs7SYz5oG2aFpVb2qwqHZKjyJ03gC6UZPnOFKYbPauav0zPBHS/lwB45XO6d/wEAaAOUwVnbn2x1h1nzVQKUVX431Klm/WpG3n2a8CcDI582S5nCRWCAoeKcV0vmSxq3W7Oan7HK4suWJT18RV8tT7Jhs+5YcVy3PgZUQofMLIHdTXTXfliw5z2/R80QNSVerX/JjMLiaGlOO8NsTI5j6y0rdsZi41ATHtKQ2rjHc94VIThbKei/KsUTbrSIGAuYissaHNx9iCQ+z757sfgIzSeZG7BwgfWQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW4PR12MB5668.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(38100700002)(76116006)(66946007)(64756008)(66446008)(4326008)(66556008)(26005)(186003)(83380400001)(66476007)(38070700005)(5660300002)(508600001)(55016003)(52536014)(8676002)(9686003)(71200400001)(8936002)(54906003)(110136005)(2906002)(33656002)(7696005)(6506007)(122000001)(316002)(86362001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ahr44odha8C60nsTHl8HvHmabqPjFThHKjq5Et6HBDEm4vKoRV1ftGS38DFB?= =?us-ascii?Q?jmhIL6fjR0XYjrf7WR73XgiJKrXN8twk3HhNniCvyeKCr6tKdAYv6LIZiyRp?= =?us-ascii?Q?yjbEZO88goJGZRqQx7XKI/EMkjyAkfPkOhAZlNDOP8cU32k9xHZt3cNbuuhD?= =?us-ascii?Q?GXJahTH9QcTVln7+3QWOhxfKmnEXxoB+PJh6OqFg7E2uNqktIgokyMQo/fb8?= =?us-ascii?Q?nZPb6EL1q7dDtIif320C/11/zvRvpMIJiLtSKiZz2uCOH717AWS2H6P+rmhw?= =?us-ascii?Q?R527srNkUJCP98fiXWNv6FzJcD+oCRzJTCZSfj29p5wtCkACMJH9HtH2heI0?= =?us-ascii?Q?yNE1ElQFLLT4WIGjzOW5VXXCuh2rqQcnBy6z2ksrGJ1afbQjGzCPc91/vv+z?= =?us-ascii?Q?vzIvJGH06ewDTYp91gP1xDeC4GHxL9mc2+o6/VTU3F4ZlWX+sCAkyG3/OVbD?= =?us-ascii?Q?Ggrmv3GItuxirddKqRezRR30HF4CeantLJ4So3fMM8pVNBxkKdcSzy+7Qd1d?= =?us-ascii?Q?GN4lEgKd5f1+OLmaKnIE2QNrlRXfaguD6I6D/mBuVc0ye4dK4381o+rY48fV?= =?us-ascii?Q?0UtafRBob3sukE3RE11QmzaZ5EK8oBb53+OH1TGOdMlcD4n3yzxm67i1A53E?= =?us-ascii?Q?huXdhMkwsbwnKA2UgBb/nmdI/POiaiB80Toc1K41A2W3WVXicjCcbk2Xd9B+?= =?us-ascii?Q?MsdOvJ9n7OI+nZVzJ8XBBU3nE9nfAcikfVj9X+35iWxKnCGdjBckgvMmVLar?= =?us-ascii?Q?e9G13gFXZCE2+FU5If1echKsD9LJyCGYqSKeZXmpENb5/6pge9h6sw1Ho/kO?= =?us-ascii?Q?sk8kqSAuhH0YtALpqmzSHF812W3IxXaz8PkNlQEFnoHVCHCFeC7BjoqeDEAL?= =?us-ascii?Q?8hHhDo1ty8nwSYD3eIm2aqyxXQF2Y+uL4izHG2mZ2lWBB3HBB6xWbmeIdjFn?= =?us-ascii?Q?5/ZUGVYikjk1NUTA95ZiCCm7F9bIxYddOsgcqscRmh017+jiyKZH7pTpNzeL?= =?us-ascii?Q?uYJ+g+b5gpcTTN8fgpcYzihO9UqJnSwagSFeYugP5pRRMnwz+/QxTGGCQ8Cj?= =?us-ascii?Q?E8TFeQMWyXXIjtDrIgR7mOWYQuWurAmyrmrDKhN+1GJ27U0hFBbGhQqNNNAB?= =?us-ascii?Q?Z5pmefKeV9KtUSmUZaYmm3PIddAiwlJHa4ZPn70wc4bUGLUnA8Rczt6ZFXgt?= =?us-ascii?Q?icS4ymmfAza8QzbFjw3SR87rgn1tBlU8RZCC05WRXvZZRRrkNc8S6+yiGMyV?= =?us-ascii?Q?N+BNJLlLRlCrgO4PlnO+UDWUQSy2676jt08K3NjOXcfHqlvMwY0TwbaB0Wfg?= =?us-ascii?Q?lI14foPF3UFxaa4AxgIIO/N5GR+EOrIHLHOLQhDp6Oi2doyLGNIhX0uiQSGw?= =?us-ascii?Q?hwIyJFLWWsv259LaRd3LTTKsfyrlkZjMlUBBOutlF9dPkelNqaw4Twh5RArJ?= =?us-ascii?Q?bSoHf+5/L5066r83SzRUCSoS/saMg/uo?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB5668.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fb3781a6-6f78-446a-11ce-08da04f45d6e X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Mar 2022 13:21:21.1123 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gpNA9YUoWECJtVWPzkkSl5Ulvr3zfvZzPQWCu11FQ2e/REQHcDTn9tK+Mp7j5xffoKtolXkQURW2OIl9ajDxIg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3755 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > Subject: [PATCH v3] app/testpmd: fix show RSS RETA on Windows >=20 > Replaced using strtoul with strtoull when converting to 64-bit mask field= . > In Windows strtoul returns 32-bit values which cause an issue with show R= SS > RETA. >=20 > Fixes: 66c594904ac ("ethdev: support multiple sizes of redirection table"= ) > Cc: stable@dpdk.org >=20 > Signed-off-by: Adham Masarwah > Acked-by: Aman Singh > -- > v2: Change commit message > v3: Added Acked-by > --- > app/test-pmd/cmdline.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > b4ba8da2b0..efa02bd301 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -3127,7 +3127,7 @@ showport_parse_reta_config(struct > rte_eth_rss_reta_entry64 *conf, > return -1; > } > for (i =3D 0; i < ret; i++) > - conf[i].mask =3D (uint64_t)strtoul(str_fld[i], &end, 0); > + conf[i].mask =3D (uint64_t)strtoull(str_fld[i], &end, 0); >=20 > return 0; > } > -- > 2.16.1.windows.4 Acked-by: Tal Shnaiderman