RE: [EXTERNAL] Re: [PATCH] net/octeon_ep: add device removal event callback

[Vamsi Krishna Attunuru <vattunuru@marvell.com>]

>-----Original Message-----
>From: Jerin Jacob <jerinjacobk@gmail.com>
>Sent: Thursday, September 19, 2024 11:49 PM
>To: Vamsi Krishna Attunuru <vattunuru@marvell.com>
>Cc: dev@dpdk.org; Jerin Jacob <jerinj@marvell.com>
>Subject: [EXTERNAL] Re: [PATCH] net/octeon_ep: add device removal event
>callback
>
>On Tue, Aug 27, 2024 at 11: 03 AM Vamsi Krishna <vattunuru@ marvell. com>
>wrote: > > From: Vamsi Attunuru <vattunuru@ marvell. com> > > Patch adds
>an event callback to catch any device removal Please remove patch. > event
>
>On Tue, Aug 27, 2024 at 11:03 AM Vamsi Krishna <vattunuru@marvell.com>
>wrote:
>>
>> From: Vamsi Attunuru <vattunuru@marvell.com>
>>
>> Patch adds an event callback to catch any device removal
>
>Please remove patch.

Ack.
>
>
>> event occurred during driver probe. This callback helps in terminating
>> the execution if there is any device removal event during the driver
>> probe.
>>
>> Patch also moves global register configuration into dev_configure()
>
>Please remove patch.
>
>> routine and also validates register reads for any invalid return
>> values from hardware during driver probe.
>>
>> Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
>> ---
>> Depends-on: patch-142958 ("net/octeon_ep: extend mailbox
>> functionality")
>>
>>  drivers/net/octeon_ep/cnxk_ep_vf.c    |  2 +
>>  drivers/net/octeon_ep/otx2_ep_vf.c    |  2 +
>>  drivers/net/octeon_ep/otx_ep_ethdev.c | 58 +++++++++++++++++++-----
>---
>>  drivers/net/octeon_ep/otx_ep_mbox.c   | 11 +++++
>>  drivers/net/octeon_ep/otx_ep_vf.c     |  2 +
>
>
>Update the release notes for this new feature.

Sure.
>
>
>>  5 files changed, 59 insertions(+), 16 deletions(-)
>>
>> diff --git a/drivers/net/octeon_ep/cnxk_ep_vf.c
>> b/drivers/net/octeon_ep/cnxk_ep_vf.c
>> index 39b28de2d0..68b89fce4f 100644
>> --- a/drivers/net/octeon_ep/cnxk_ep_vf.c
>> +++ b/drivers/net/octeon_ep/cnxk_ep_vf.c
>> @@ -408,6 +408,8 @@ cnxk_ep_vf_setup_device(struct otx_ep_device
>> *otx_ep)
>>
>>         /* Get IOQs (RPVF] count */
>>         reg_val = oct_ep_read64(otx_ep->hw_addr +
>> CNXK_EP_R_IN_CONTROL(0));
>> +       if (reg_val == (uint64_t)-1)
>
>
>Use UINT64_MAX from <stdint.h> across the patch.

Ack, thanks.